Re: [vbox-dev] vgdrvIoCtl_CancelAllWaitEvents inconsistent behavior ?

2017-07-03 Thread Hans de Goede
Hi Michael, Thank you for looking into this. On 04-07-17 08:14, Michael Thayer wrote: Hello Hans, 03.07.2017 20:49, Michael Thayer wrote: [Discussion of incorrect looking wait code in VBoxGuest.cpp.]> I did not get any response when I asked around about this. Reading the code (quite a bit of

Re: [vbox-dev] vgdrvIoCtl_CancelAllWaitEvents inconsistent behavior ?

2017-07-03 Thread Michael Thayer
Hello Hans, 03.07.2017 20:49, Michael Thayer wrote: [Discussion of incorrect looking wait code in VBoxGuest.cpp.]> > I did not get any response when I asked around about this. Reading the > code (quite a bit of work, as you presumably discovered too; fortunately > the user-space part is a bit eas

Re: [vbox-dev] vgdrvIoCtl_CancelAllWaitEvents inconsistent behavior ?

2017-07-03 Thread Michael Thayer
Hello Hans, 03.07.2017 17:21, Hans de Goede wrote: > Hi, > > So while working on cleaning up the vboxguest driver for mainline > linux kernel submission (*) I noticed some inconsistent behavior > wrt vgdrvIoCtl_CancelAllWaitEvents vs vgdrvIoCtl_WaitEvent. > > If there are no waiters then vgdrvIo

[vbox-dev] vgdrvIoCtl_CancelAllWaitEvents inconsistent behavior ?

2017-07-03 Thread Hans de Goede
Hi, So while working on cleaning up the vboxguest driver for mainline linux kernel submission (*) I noticed some inconsistent behavior wrt vgdrvIoCtl_CancelAllWaitEvents vs vgdrvIoCtl_WaitEvent. If there are no waiters then vgdrvIoCtl_CancelAllWaitEvents sets pSession->fPendingCancelWaitEvents a