/ Rome / Stockholm / Vienna
Subject: Re: [vbox-dev] PATCH: Implement support for multiple custom ACPI
tables
Hi Michal,
>Do we really need three different names for one thing? SLICTable, CustomTable,
>CustomTable0 for the same thing seems like an overkill.
I agree. Ideally it woul
Hi Michal,
>Do we really need three different names for one thing? SLICTable,
CustomTable, CustomTable0 for the same thing seems like an overkill.
I agree. Ideally it would just be CustomTable0, CustomTable1,
CustomTable2.and the code currently supports that. I had kept
SLICTable/CustomTable
Hi,
Sorry for the delay.
You're absolutely right, the acpiR3SetupCust() function does a lot of
things but acpiR3PhysCopy() is the only useful bit it does.
The only objection I have then is the following: Do we really need
three different names for one thing? SLICTable, CustomTable,
Hi Michal,
Thanks for taking a look.
I agree that the behavior should not change and I don't believe it does. I
removed the call to acpiR3PrepareHeader (as well as the surrounding lines)
because it was dead code. Looking at the prior acpiR3SetupCust function:
/** Custom Description Table */
Hi,
Thanks for the patch! I quickly looked over it and it looks to me that
the behavior of existing VMs with the
VBoxInternal/Devices/acpi/0/Config/CustomTable keys set will subtly
change because the call to
acpiR3PrepareHeader(pThis, , "CUST", sizeof(cust), 1);
is no longer done and
