Re: [vbox-dev] VDCopy() fix for VHD, change progress callback percent to float?

2009-10-08 Thread Klaus Espenlaub
Huihong Luo wrote: a related issue, wonder if you like the idea of changing VDCopy callbacks to float/double percentage? right now, it's an int, the 1st 1% may takes more than 3 mins, not user friendly to update the progress bar The progress bar _is_ linear with the offset in the target image.

[vbox-dev] VDCopy() fix for VHD, change progress callback percent to float?

2009-10-07 Thread Huihong Luo
nt, the 1st 1% may takes more than 3 mins, not user friendly to update the progress bar --- On Wed, 10/7/09, Huihong Luo wrote: From: Huihong Luo Subject: Re: [vbox-dev] VDCopy() fix for VHD To: "Klaus Espenlaub" Cc: vbox-dev@virtualbox.org Date: Wednesday, October 7, 2009, 3:02 PM

Re: [vbox-dev] VDCopy() fix for VHD

2009-10-07 Thread Huihong Luo
--- On Wed, 10/7/09, Klaus Espenlaub wrote: From: Klaus Espenlaub Subject: Re: [vbox-dev] VDCopy() fix for VHD To: "Huihong Luo" Cc: vbox-dev@virtualbox.org Date: Wednesday, October 7, 2009, 2:02 PM Huihong Luo wrote: > after the fix, VHD->VMDk seems to be working fine, but VHD

Re: [vbox-dev] VDCopy() fix for VHD

2009-10-07 Thread Klaus Espenlaub
--- On *Wed, 10/7/09, Huihong Luo //* wrote: From: Huihong Luo Subject: [vbox-dev] VDCopy() fix for VHD To: vbox-dev@virtualbox.org Date: Wednesday, October 7, 2009, 12:30 AM Can you guys add the following code to function VDCopy() in VBoxHDD.cpp? right before VDCreateB

Re: [vbox-dev] VDCopy() fix for VHD

2009-10-07 Thread Huihong Luo
after the fix, VHD->VMDk seems to be working fine, but VHD->VDI still not working, the generated vdi disk throws invalid header error. --- On Wed, 10/7/09, Huihong Luo wrote: From: Huihong Luo Subject: [vbox-dev] VDCopy() fix for VHD To: vbox-dev@virtualbox.org Date: Wednesday, Oct

[vbox-dev] VDCopy() fix for VHD

2009-10-07 Thread Huihong Luo
Can you guys add the following code to function VDCopy() in VBoxHDD.cpp? right before VDCreateBase() is called.   It resets the geometry if cSectors > 63, VHD disk somehow has more than 63 sectors.     /* vmlite, fix converting error from VHD */ if (PCHSGeometryFrom.cHeads > 16 || PCHSGe