Re: [vbox-dev] Fixes for API changes in kernel 4.20

2018-11-20 Thread Aleksey Ilyushin
Hello Larry, Thanks a lot for your patch. I do have an issue with it though. I think ‘get_link_ksettings’ callback is supposed to return the link settings in the new format, so ‘vboxNetAdpEthGetSettings’ should allocate the old structure, fill it out, then call a function that does the

Re: [vbox-dev] Fixes for API changes in kernel 4.20

2018-11-20 Thread Larry Finger
On 11/20/18 6:37 AM, Michael Thayer wrote: 08.11.18 21:27, Larry Finger wrote: Hi, There are a number of changes in kernel 4.20 that affect building the VB modules. These are as follows: 1. In struct ethtool_ops, the get_settings member is renamed get_link_ksettings, and the callback method

Re: [vbox-dev] Fixes for API changes in kernel 4.20

2018-11-20 Thread Michael Thayer
08.11.18 21:27, Larry Finger wrote: > Hi, > > There are a number of changes in kernel 4.20 that affect building the VB > modules. These are as follows: > > 1. In struct ethtool_ops, the get_settings member is renamed > get_link_ksettings, and the callback method is changed. To satisfy the > new