Re: [vchkpw] remove_line() logic
Tom Collins wrote: On Apr 27, 2004, at 3:23 PM, Rick Widmer wrote: Rom: I assume you mean I should re-write the function. Yes, and I assume you mean Tom. ;-) Grrr.. Sorry, I guess the fingers were going too fast. I think I've got everything we've discussed completed in vpopmail. Is there anything else related to domains that I should do before I go back to working on qmailadmin. (Which I know I've broken by defining MAX_BUFF globally in vpopmail, but they share buffers so they should share the size definition for those buffers. Besides there is a note in the vpopmail extension to PHP noting its absence... not any more.) Rick
Re: [vchkpw] remove_line() logic
On Apr 27, 2004, at 1:56 PM, Rick Widmer wrote: So, is there a reason for keeping the logic in delete_line(), or should I re-write it from scratch based on update_file()? Yes, I think you should. Others may disagree though... I could reduce the failure window even more by moving all the rename operations from delete_line and update_file into the functions that call them. That way all the renames would be done at nearly the same time, after all the files have been created. Is this worth doing? I don't think so. Doing so makes things more complex, but could avoid problems with only some files getting updated. I'd prefer the higher level code to call a single function that does ALL of the work (as it is now). -- Tom Collins - [EMAIL PROTECTED] QmailAdmin: http://qmailadmin.sf.net/ Vpopmail: http://vpopmail.sf.net/ Info on the Sniffter hand-held Network Tester: http://sniffter.com/
Re: [vchkpw] remove_line() logic
Tom Collins wrote: On Apr 27, 2004, at 1:56 PM, Rick Widmer wrote: So, is there a reason for keeping the logic in delete_line(), or should I re-write it from scratch based on update_file()? Yes, I think you should. Others may disagree though... Rom: I assume you mean I should re-write the function. Those others have just a few hours to comment, before I start on it, and will probably be able to see the result in CVS within a day or two. Rick
Re: [vchkpw] remove_line() logic
On Apr 27, 2004, at 3:23 PM, Rick Widmer wrote: Rom: I assume you mean I should re-write the function. Yes, and I assume you mean Tom. ;-) -- Tom Collins - [EMAIL PROTECTED] QmailAdmin: http://qmailadmin.sf.net/ Vpopmail: http://vpopmail.sf.net/ Info on the Sniffter hand-held Network Tester: http://sniffter.com/
