Re: [vchkpw] Test FHS patch
I'll checkout the SVN and enable the backends compilation again. Digesting config.log I think I some found possible missing files... Thanks Matt. On Fri, Apr 3, 2009 at 11:26 AM, Matt Brookings wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > aledr wrote: >> Here it is! Do not worry about the RPM errors at the end, I need to >> fix It on my spec file. > > You will need to also package in the vusage daemon. It's basically a > requirement > for the 5.5 tree. It's just not required when building vpopmail, but that may > change. > > As a result of this log I found a few issues that still need to be resolved, > but I'll get em fixed here soon. > - -- > /* > Matt Brookings GnuPG Key D9414F70 > Software developer Systems technician > Inter7 Internet Technologies, Inc. (815)776-9465 > */ > -BEGIN PGP SIGNATURE- > Version: GnuPG v1.4.9 (GNU/Linux) > Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org > > iEYEARECAAYFAknWHIwACgkQ6QgvSNlBT3AfOQCgpLmrCEiQVIvlrhmrVM2qv/xB > /7EAoIJBONYAqgKmjUrPttrLn+adtmo7 > =f9pV > -END PGP SIGNATURE- > -- [ ]'s Aledr - Alexandre "OpenSource Solutions for SmallBusiness Problems" !DSPAM:49d61d2a32684452713626!
Re: [vchkpw] Test FHS patch
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 aledr wrote: > Here it is! Do not worry about the RPM errors at the end, I need to > fix It on my spec file. You will need to also package in the vusage daemon. It's basically a requirement for the 5.5 tree. It's just not required when building vpopmail, but that may change. As a result of this log I found a few issues that still need to be resolved, but I'll get em fixed here soon. - -- /* Matt BrookingsGnuPG Key D9414F70 Software developer Systems technician Inter7 Internet Technologies, Inc. (815)776-9465 */ -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.9 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iEYEARECAAYFAknWHIwACgkQ6QgvSNlBT3AfOQCgpLmrCEiQVIvlrhmrVM2qv/xB /7EAoIJBONYAqgKmjUrPttrLn+adtmo7 =f9pV -END PGP SIGNATURE-
Re: [vchkpw] Test FHS patch
On Thu, Apr 2, 2009 at 4:14 PM, Matt Brookings wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > aledr wrote: >> + make DESTDIR=/var/tmp/vpopmail-5.5.0-build install -C backends/mysql >> make: Entering directory >> `/usr/src/packages/BUILD/vpopmail-5.5.0/backends/mysql' >> /usr/bin/install -c vmysql.so >> /var/tmp/vpopmail-5.5.0-build/usr/lib64/vmysql.so >> rm -f /var/tmp/vpopmail-5.5.0-build/etc/vpopmail/vpopmail.authmodule >> ln -s /var/tmp/vpopmail-5.5.0-build/usr/lib64/vmysql.so >> /var/tmp/vpopmail-5.5.0-build/etc/vpopmail/vpopmail.authmodule >> if ! test -r /var/tmp/vpopmail-5.5.0-build/etc/vpopmail/vpopmail.mysql; then >> \ >> /usr/bin/install -c -o vpopmail -g vchkpw -m 0640 >> vpopmail.mysql /var/tmp/vpopmail-5.5.0-build/etc/vpopmail/vpopmail.mysql; >> \ >> fi >> /usr/bin/install: cannot change ownership of >> `/var/tmp/vpopmail-5.5.0-build/etc/vpopmail/vpopmail.mysql': Operation >> not permitted > > Woops. Missed the postgres and MySQL backends. Will fix this. > - -- > /* > Matt Brookings GnuPG Key D9414F70 > Software developer Systems technician > Inter7 Internet Technologies, Inc. (815)776-9465 > */ > -BEGIN PGP SIGNATURE- > Version: GnuPG v1.4.9 (GNU/Linux) > Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org > > iEYEARECAAYFAknVDpwACgkQ6QgvSNlBT3CLkACfa4jz5XXlanUV1KCKuZyaELhy > aXEAoIccdusGXrO7Njzqwn1WOwULleyY > =6g/v > -END PGP SIGNATURE- > Without the backends It compiled and installed successfully. I'll attach my log on a private mail to not mess the list. Thanks! -- [ ]'s Aledr - Alexandre "OpenSource Solutions for SmallBusiness Problems" !DSPAM:49d511df32681252817659!
Re: [vchkpw] Test FHS patch
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 aledr wrote: > + make DESTDIR=/var/tmp/vpopmail-5.5.0-build install -C backends/mysql > make: Entering directory > `/usr/src/packages/BUILD/vpopmail-5.5.0/backends/mysql' > /usr/bin/install -c vmysql.so > /var/tmp/vpopmail-5.5.0-build/usr/lib64/vmysql.so > rm -f /var/tmp/vpopmail-5.5.0-build/etc/vpopmail/vpopmail.authmodule > ln -s /var/tmp/vpopmail-5.5.0-build/usr/lib64/vmysql.so > /var/tmp/vpopmail-5.5.0-build/etc/vpopmail/vpopmail.authmodule > if ! test -r /var/tmp/vpopmail-5.5.0-build/etc/vpopmail/vpopmail.mysql; then \ >/usr/bin/install -c -o vpopmail -g vchkpw -m 0640 > vpopmail.mysql /var/tmp/vpopmail-5.5.0-build/etc/vpopmail/vpopmail.mysql; > \ > fi > /usr/bin/install: cannot change ownership of > `/var/tmp/vpopmail-5.5.0-build/etc/vpopmail/vpopmail.mysql': Operation > not permitted Woops. Missed the postgres and MySQL backends. Will fix this. - -- /* Matt BrookingsGnuPG Key D9414F70 Software developer Systems technician Inter7 Internet Technologies, Inc. (815)776-9465 */ -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.9 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iEYEARECAAYFAknVDpwACgkQ6QgvSNlBT3CLkACfa4jz5XXlanUV1KCKuZyaELhy aXEAoIccdusGXrO7Njzqwn1WOwULleyY =6g/v -END PGP SIGNATURE-
Re: [vchkpw] Test FHS patch
On Thu, Apr 2, 2009 at 3:53 PM, Matt Brookings wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > aledr wrote: >> Patch reject on latest on r879: >> >>> cat Makefile.in.rej >> *** >> *** 58,62 >> rm -rf config.log config.status Makefile autom4te.cache >> contrib/rc.vusaged >> >> install: $(BINS) >> - $(INSTALL) -s -m 0700 vusaged $(DESTDIR)$(VPOPMAIL_DIR_BIN) >> if test ! -r $(DESTDIR)$(VPOPMAIL_DIR_ETC)/vusaged.conf; then >> $(INSTALL) -m 0600 etc/vusaged.conf >> $(DESTDIR)$(VPOPMAIL_DIR_ETC)/vusaged.conf; fi >> --- 58,62 >> rm -rf config.log config.status Makefile autom4te.cache >> contrib/rc.vusaged >> >> install: $(BINS) >> + $(INSTALL) -s -m 0700 vusaged $(DESTDIR)$(VPOPMAIL_DIR_BIN)/vusaged >> if test ! -r $(DESTDIR)$(VPOPMAIL_DIR_ETC)/vusaged.conf; then >> $(INSTALL) -m 0600 etc/vusaged.conf >> $(DESTDIR)$(VPOPMAIL_DIR_ETC)/vusaged.conf; fi > > Eh, ignore those. They aren't that important. How did the 'make install' go? > - -- > /* > Matt Brookings GnuPG Key D9414F70 > Software developer Systems technician > Inter7 Internet Technologies, Inc. (815)776-9465 > */ > -BEGIN PGP SIGNATURE- > Version: GnuPG v1.4.9 (GNU/Linux) > Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org > > iEYEARECAAYFAknVCboACgkQ6QgvSNlBT3BKOwCcCflLnBbK6JqfHX0mnLlA2xMY > RisAnRwRlSxC4aVsfzCkAg2ESbM4d6J0 > =fiT1 > -END PGP SIGNATURE- > Stopped on MySQL backend... I'll remove the backends to test. + make DESTDIR=/var/tmp/vpopmail-5.5.0-build install -C backends/mysql make: Entering directory `/usr/src/packages/BUILD/vpopmail-5.5.0/backends/mysql' /usr/bin/install -c vmysql.so /var/tmp/vpopmail-5.5.0-build/usr/lib64/vmysql.so rm -f /var/tmp/vpopmail-5.5.0-build/etc/vpopmail/vpopmail.authmodule ln -s /var/tmp/vpopmail-5.5.0-build/usr/lib64/vmysql.so /var/tmp/vpopmail-5.5.0-build/etc/vpopmail/vpopmail.authmodule if ! test -r /var/tmp/vpopmail-5.5.0-build/etc/vpopmail/vpopmail.mysql; then \ /usr/bin/install -c -o vpopmail -g vchkpw -m 0640 vpopmail.mysql /var/tmp/vpopmail-5.5.0-build/etc/vpopmail/vpopmail.mysql; \ fi /usr/bin/install: cannot change ownership of `/var/tmp/vpopmail-5.5.0-build/etc/vpopmail/vpopmail.mysql': Operation not permitted make: *** [install] Error 1 make: Leaving directory `/usr/src/packages/BUILD/vpopmail-5.5.0/backends/mysql' error: Bad exit status from /var/tmp/rpm-tmp.17942 (%install) -- [ ]'s Aledr - Alexandre "OpenSource Solutions for SmallBusiness Problems" !DSPAM:49d50e1932685873721188!
Re: [vchkpw] Test FHS patch
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 aledr wrote: > Patch reject on latest on r879: > >> cat Makefile.in.rej > *** > *** 58,62 > rm -rf config.log config.status Makefile autom4te.cache > contrib/rc.vusaged > > install: $(BINS) > - $(INSTALL) -s -m 0700 vusaged $(DESTDIR)$(VPOPMAIL_DIR_BIN) > if test ! -r $(DESTDIR)$(VPOPMAIL_DIR_ETC)/vusaged.conf; then > $(INSTALL) -m 0600 etc/vusaged.conf > $(DESTDIR)$(VPOPMAIL_DIR_ETC)/vusaged.conf; fi > --- 58,62 > rm -rf config.log config.status Makefile autom4te.cache > contrib/rc.vusaged > > install: $(BINS) > + $(INSTALL) -s -m 0700 vusaged $(DESTDIR)$(VPOPMAIL_DIR_BIN)/vusaged > if test ! -r $(DESTDIR)$(VPOPMAIL_DIR_ETC)/vusaged.conf; then > $(INSTALL) -m 0600 etc/vusaged.conf > $(DESTDIR)$(VPOPMAIL_DIR_ETC)/vusaged.conf; fi Eh, ignore those. They aren't that important. How did the 'make install' go? - -- /* Matt BrookingsGnuPG Key D9414F70 Software developer Systems technician Inter7 Internet Technologies, Inc. (815)776-9465 */ -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.9 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iEYEARECAAYFAknVCboACgkQ6QgvSNlBT3BKOwCcCflLnBbK6JqfHX0mnLlA2xMY RisAnRwRlSxC4aVsfzCkAg2ESbM4d6J0 =fiT1 -END PGP SIGNATURE-
Re: [vchkpw] Test FHS patch
Patch reject on latest on r879: > cat Makefile.in.rej *** *** 58,62 rm -rf config.log config.status Makefile autom4te.cache contrib/rc.vusaged install: $(BINS) - $(INSTALL) -s -m 0700 vusaged $(DESTDIR)$(VPOPMAIL_DIR_BIN) if test ! -r $(DESTDIR)$(VPOPMAIL_DIR_ETC)/vusaged.conf; then $(INSTALL) -m 0600 etc/vusaged.conf $(DESTDIR)$(VPOPMAIL_DIR_ETC)/vusaged.conf; fi --- 58,62 rm -rf config.log config.status Makefile autom4te.cache contrib/rc.vusaged install: $(BINS) + $(INSTALL) -s -m 0700 vusaged $(DESTDIR)$(VPOPMAIL_DIR_BIN)/vusaged if test ! -r $(DESTDIR)$(VPOPMAIL_DIR_ETC)/vusaged.conf; then $(INSTALL) -m 0600 etc/vusaged.conf $(DESTDIR)$(VPOPMAIL_DIR_ETC)/vusaged.conf; fi On Thu, Apr 2, 2009 at 2:49 PM, aledr wrote: > Thanks Matt, I'll test it in minutes... > > On Thu, Apr 2, 2009 at 2:38 PM, Matt Brookings wrote: >> -BEGIN PGP SIGNED MESSAGE- >> Hash: SHA1 >> >> Okay, here's a patch that does the following: >> >> Only chown if root >> Only mkdir if root or DESTDIR is set >> >> I haven't committed it to the repository yet because I'm not sure if it >> addresses the issues correctly. If you're working on packaging vpopmail, >> let me know if this does the trick, or what further changes are still >> needed. >> >> Thanks! >> - -- >> /* >> Matt Brookings GnuPG Key D9414F70 >> Software developer Systems technician >> Inter7 Internet Technologies, Inc. (815)776-9465 >> */ >> -BEGIN PGP SIGNATURE- >> Version: GnuPG v1.4.9 (GNU/Linux) >> Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org >> >> iEYEARECAAYFAknU+CMACgkQ6QgvSNlBT3CU1ACfdX9NEDBFsL16TS6+WU7X90ii >> o8EAoJYW3Kw8rBCTPRY65tsX/sGzIGeW >> =FYc3 >> -END PGP SIGNATURE- >> > -- > [ ]'s > Aledr - Alexandre > "OpenSource Solutions for SmallBusiness Problems" > -- [ ]'s Aledr - Alexandre "OpenSource Solutions for SmallBusiness Problems" !DSPAM:49d508b332682022263736!
Re: [vchkpw] Test FHS patch
Thanks Matt, I'll test it in minutes... On Thu, Apr 2, 2009 at 2:38 PM, Matt Brookings wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Okay, here's a patch that does the following: > > Only chown if root > Only mkdir if root or DESTDIR is set > > I haven't committed it to the repository yet because I'm not sure if it > addresses the issues correctly. If you're working on packaging vpopmail, > let me know if this does the trick, or what further changes are still > needed. > > Thanks! > - -- > /* > Matt Brookings GnuPG Key D9414F70 > Software developer Systems technician > Inter7 Internet Technologies, Inc. (815)776-9465 > */ > -BEGIN PGP SIGNATURE- > Version: GnuPG v1.4.9 (GNU/Linux) > Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org > > iEYEARECAAYFAknU+CMACgkQ6QgvSNlBT3CU1ACfdX9NEDBFsL16TS6+WU7X90ii > o8EAoJYW3Kw8rBCTPRY65tsX/sGzIGeW > =FYc3 > -END PGP SIGNATURE- > -- [ ]'s Aledr - Alexandre "OpenSource Solutions for SmallBusiness Problems" !DSPAM:49d4faa332682854311138!
[vchkpw] Test FHS patch
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Okay, here's a patch that does the following:
Only chown if root
Only mkdir if root or DESTDIR is set
I haven't committed it to the repository yet because I'm not sure if it
addresses the issues correctly. If you're working on packaging vpopmail,
let me know if this does the trick, or what further changes are still
needed.
Thanks!
- --
/*
Matt BrookingsGnuPG Key D9414F70
Software developer Systems technician
Inter7 Internet Technologies, Inc. (815)776-9465
*/
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iEYEARECAAYFAknU+CMACgkQ6QgvSNlBT3CU1ACfdX9NEDBFsL16TS6+WU7X90ii
o8EAoJYW3Kw8rBCTPRY65tsX/sGzIGeW
=FYc3
-END PGP SIGNATURE-
Index: Makefile.in
===
--- Makefile.in (revision 878)
+++ Makefile.in (working copy)
@@ -12,6 +12,7 @@
LDFLAGS = @LDFLAGS@
DEPS = Makefile
INSTALL = @INSTALL@
+IDCOMMAND = @idcommand@
CCC = $(CC) $(CFLAGS)
PICC = $(CC) $(CFLAGS) -fPIC
LINK = $(CC) $(LDFLAGS)
@@ -235,8 +236,35 @@
install-strip: install
-install: $(BUILD_ALL)
+pre-install:
@echo
+ @echo "Checking installation pre-requisites..."
+ @echo
+
+ @if test -z "$(IDCOMMAND)"; then \
+ echo; \
+ echo "Cannot determine your uid because IDCOMMAND is not set."; \
+ echo; \
+ fi
+
+ @if test "`$(IDCOMMAND)`" != "0"; then \
+ if test -z "$${DESTDIR}"; then \
+ echo; \
+ echo "You can't install vpopmail because you aren't root"; \
+ echo "and you don't have DESTDIR set."; \
+ echo; \
+ false; \
+ fi; \
+ if test "$${DESTDIR:0:1}" != "/"; then \
+ echo; \
+ echo "DESTDIR must be an absolute path starting with /"; \
+ echo; \
+ false; \
+ fi ;\
+ fi
+
+install: pre-install $(BUILD_ALL)
+ @echo
@echo "Installing..."
@echo
@@ -244,15 +272,40 @@
@# Create directories
@#
- for i in $(INSTALL_DIRS); do if test ! -d $${i}; then mkdir -p $${i}; chown @vpopuser@:@vpopgroup@ $${i}; fi; done
- chmod 700 $(VPOPMAIL_DIR_DOMAINS)
+ for i in $(INSTALL_DIRS); do \
+ if test ! -d $${i}; then \
+ mkdir -p $${i}; \
+ if test "`$(IDCOMMAND)`" = "0"; then \
+ chown @vpopuser@:@vpopgroup@ $${i}; \
+ fi; \
+ fi; \
+done
+ if test "`$(IDCOMMAND)`" = "0" || test ! -z "$${DESTDIR}"; then \
+ chmod 700 $(DESTDIR)$(VPOPMAIL_DIR_DOMAINS); \
+fi
+
@#
@# Copy binaries, libraries and headers
@#
- for i in $(BUILD_BINS); do $(INSTALL) -s -o @vpopuser@ -g @vpopgroup@ $${i} $(DESTDIR)$(VPOPMAIL_DIR_BIN); chmod 711 $(DESTDIR)$(VPOPMAIL_DIR_BIN)/$${i}; done
- for i in $(BUILD_LIBS); do $(INSTALL) $${i} $(DESTDIR)$(VPOPMAIL_DIR_LIB); chmod 644 $(DESTDIR)$(VPOPMAIL_DIR_LIB)/$${i}; done
+ for i in $(BUILD_BINS); do \
+ $(INSTALL) -s $${i} $(DESTDIR)$(VPOPMAIL_DIR_BIN); \
+ if test "`$(IDCOMMAND)`" = "0"; then \
+ chown @vpopuser@:@vpopgroup@ $(DESTDIR)$(VPOPMAIL_DIR_BIN)/$${i}; \
+ fi; \
+ if test "`$(IDCOMMAND)`" = "0" || test ! -z "$${DESTDIR}"; then \
+ chmod 711 $(DESTDIR)$(VPOPMAIL_DIR_BIN)/$${i}; \
+ fi; \
+done
+
+ for i in $(BUILD_LIBS); do \
+ $(INSTALL) $${i} $(DESTDIR)$(VPOPMAIL_DIR_LIB); \
+ if test "`$(IDCOMMAND)`" = "0" || test ! -z "$${DESTDIR}"; then \
+ chmod 644 $(DESTDIR)$(VPOPMAIL_DIR_LIB)/$${i}; \
+ fi; \
+done
+
$(INSTALL) -m 444 config.h $(DESTDIR)$(VPOPMAIL_DIR_INCLUDE)/vpopmail_config.h
for i in $(INSTALL_HEADERS); do $(INSTALL) -m 444 $${i} $(DESTDIR)$(VPOPMAIL_DIR_INCLUDE); done
@@ -272,7 +325,10 @@
@#
if test ! -r $(DESTDIR)$(VPOPMAIL_DIR_ETC)/vusagec.conf; then \
- $(INSTALL) -o @vpopuser@ -g @vpopgroup@ -m 644 vusagec.conf $(DESTDIR)$(VPOPMAIL_DIR_ETC)/vusagec.conf; \
+ $(INSTALL) -m 644 vusagec.conf $(DESTDIR)$(VPOPMAIL_DIR_ETC)/vusagec.conf; \
+ if test "`$(IDCOMMAND)`" = "0"; then \
+ chown @vpopuser@:@vpopgroup@ $(DESTDIR)$(VPOPMAIL_DIR_ETC)/vusagec.conf; \
+ fi; \
fi
@#
Index: configure.ac
===
--- configure.ac (revision 872)
+++ configure.ac (working copy)
@@ -114,6 +114,7 @@
esac
AC_MSG_RESULT($idcommand)
+AC_SUBST(idcommand)
#
# ps command
@@ -252,13 +253,13 @@
#--
-if $idtest && test `$idcommand` != "0"
-then
- AC_MSG_WARN(=== vpopmail must be configured as root. ===)
- AC_MSG_WARN(=== please switch to the root user and ===)
- AC_MSG_WARN(=== run ./configure. ===)
- AC_MSG_ERROR(aborted.)
-fi
+#if $idtest && test `$idcommand` != "0"
+#then
+# AC_MSG_WARN(=== vpopmail must be configured as root. ===)
+# AC_MSG_WARN(=== please switch to the root user and ===)
+# AC_MSG_WARN(=== run ./configure. ===)
+# AC_MSG_ERROR(aborted.)
+#fi
#
# Locate the qmail directory
Index: configure
===
