Re: [vchkpw] vpopmail - bug or my bug

2004-01-08 Thread Tom Collins
On Jan 8, 2004, at 2:43 PM, Noe wrote:
I expected not success delivery, but defferlal delivery. Am I wrong?
Please, let me know your opinion.
This patch should correct the problem.  deliver_mail() was returning 
unexpected values, causing vdelivermail to not exit with an error.

===
RCS file: /cvsroot/vpopmail/vpopmail/vdelivermail.c,v
retrieving revision 1.8
diff -u -r1.8 vdelivermail.c
--- vdelivermail.c  3 Jan 2004 07:05:39 -   1.8
+++ vdelivermail.c  8 Jan 2004 23:28:24 -
@@ -611,7 +611,7 @@
 if ( lseek(0, 0L, SEEK_SET) < 0 ) {
 printf("lseek errno=%d\n", errno);
-return(errno);
+return(-2);
 }
 /* write the Return-Path: and Delivered-To: headers */
@@ -624,7 +624,7 @@
 return(-1);
 } else {
 printf("failed to write delivered to line 
errno=%d\n",errno);
-   return(errno);
+   return(-2);
 }
 }

@@ -639,7 +639,7 @@
  */
 if ( unlink(local_file) != 0 ) {
 printf("unlink failed %s errno = %d\n", local_file, 
errno);
-return(errno);
+return(-2);
 }

 /* Check if the user is over quota */
@@ -647,7 +647,7 @@
 return(-1);
 } else {
 printf("write failed errno = %d\n", errno);
-return(errno);
+return(-2);
 }
 }
 }
@@ -689,7 +689,7 @@
 printf("rename failed %s %s errno = %d\n",
 local_file, local_file_new, errno);
 /* shouldn't we unlink the file here? */
-return(errno);
+return(-2);
 /* rename worked, so we are okay now */
 } else {
@@ -701,7 +701,7 @@
 printf("link REALLY failed %s %s errno = %d\n",
 local_file, local_file_new, errno);
 unlink(local_file);
-return(errno);
+return(-2);
 }
 }
 }
--
Tom Collins  -  [EMAIL PROTECTED]
QmailAdmin: http://qmailadmin.sf.net/  Vpopmail: http://vpopmail.sf.net/
Info on the Sniffter hand-held Network Tester: http://sniffter.com/


[vchkpw] vpopmail - bug or my bug

2004-01-08 Thread Noe
	Hi,

I have following experience ...
When the permmisions on the ~/Maildir/new is set to , the following 
error message is written to the log file and mail message disapear
Jan  8 04:02:11 ttx02 qmail: 1073530931.162729 delivery 3254: success: 
link_REALLY_failed_/internet/mail/vpopmail/domains/ttx.sk/micho/Maildir/tmp/1073530931.9808.ttx02,S=2026_/internet/mail/vpopmail/domains/ttx.sk/micho/Maildir/new/1073530931.9808.ttx02,S=2026_errno_=_13/did_0+0+1/

I expected not success delivery, but defferlal delivery. Am I wrong?
Please, let me know your opinion.
--
Noe