[ https://issues.apache.org/jira/browse/VCL-22?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andy Kurth updated VCL-22: -------------------------- Fix Version/s: 2.4 > run_ssh_command may produce unexpected results if invalid identity key path > is specified > ---------------------------------------------------------------------------------------- > > Key: VCL-22 > URL: https://issues.apache.org/jira/browse/VCL-22 > Project: VCL > Issue Type: Bug > Components: vcld (backend) > Affects Versions: 2.0 > Reporter: Andy Kurth > Priority: Minor > Fix For: 2.4 > > > The run_ssh_command subroutine in utils.pm may produce unexpected results if > invalid identity key paths are specified. To reproduce, call the subroutine > with multiple identity paths, the first one being invalid: > run_ssh_command([node], "/etc/vcl/invalid.key /etc/vcl/good.key", "uname") > SSH first tries to use the invalid key and will output the following: > Warning: Identity file /etc/vcl/invalid.key not accessible: No such file or > directory. > SSH then tries the next identity key and succeeds. The run_ssh_command > subroutine returns an array. The first element is the exit status. In this > case it would be 0 meaning successful. The 2nd element is a reference to an > array containing the lines of output generated by SSH as it ran the command. > This array contains the warning message followed by the expected output as > the command successfully ran. > Callers of run_ssh_command see the command as being successful because of the > exit status. If the output is checked, callers may see the command as > failing because the warning messages are mixed into the output. > Fix the subroutine to not include the warning output if the intended command > is successful. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira