Re: Dojo library optimization

2012-04-05 Thread Josh Thompson
Aaron,

I've been working on this JIRA issue.  I'm having a problem with the custom 
vcldojo.* objects.  I copied the vcl/js/vcldojo directory to the dojo source 
as a sibling directory of dojo, dijit, and dojox, and listed the relative path 
to vcldojo at the end of the vcl.profile.js file the same way you did in the 
one you attached to the JIRA issue.  However, when I load any pages that have 
a widget from vcldojo, I'm getting a javascript error that dojo could not load 
the widget.  Also, it is doing a separate load of the .js file for that widget 
even though I can see that the widget was built in to the layer file.  Did you 
have any issues similar to this?  Any ideas?

Thanks,
Josh

On Friday, August 26, 2011 3:47:54 PM you wrote:
 Aaron,
 
 Thanks for creating a JIRA issue about it and adding some patches.  You're
 definitely right about the number of GETs slowing down page loads.  I was
 planning on creating one dojo include per VCL page in the next release,
 though I never created a JIRA issue about it.  I did do some work already,
 but I like how you structured it a little better.
 
 Thanks,
 Josh
 
 On Friday August 26, 2011, Aaron Coburn wrote:
  Many parts of the VCL web interface use the Dojo javascript framework,
  which has a nice facility for incrementally loading the classes needed
  for a particular page through the dojo.require(...) function. On some
  pages, however, the number of separate GET requests grows rather large.
  This makes the pages much less responsive, especially when a page is
  loaded for the first time.
  
  With dojo, it is also possible to create custom 'profiles', which are
  groups of dojo classes that are assembled into a single javascript
  library. More information about this is available here:
  
  http://dojotoolkit.org/reference-guide/quickstart/custom-builds.html
  
  I assembled about a dozen of these 'profiles' for our VCL installation,
  and with some modification to the .ht-inc/utils.php page, this change
  has resulted in a dramatic improvement in the loading and rendering of
  the vcl web pages.
  
  Is there any thought for moving in this direction for an upcoming
  release? I have created a JIRA issue for this at:
  
  https://issues.apache.org/jira/browse/VCL-505
  
  where I have included some more information as well as the code I used
  to
  implement this in our VCL setup.
  
  Best wishes,
  
  Aaron Coburn
  Systems Administrator and Programmer
  Academic Technology Services, Amherst College
  (413) 542-5451 acob...@amherst.edu
-- 
---
Josh Thompson
Systems Programmer
Advanced Computing | VCL Developer
North Carolina State University

josh_thomp...@ncsu.edu
919-515-5323

my GPG/PGP key can be found at pgp.mit.edu

All electronic mail messages in connection with State business which
are sent to or received by this account are subject to the NC Public
Records Law and may be disclosed to third parties.

signature.asc
Description: This is a digitally signed message part.


Re: Dojo library optimization

2012-04-05 Thread Aaron Peeler
Aaron,

By the way I added your jira account to the jira committers group
which gives you greater access to features under jira.

Sorry I didn't catch this earlier.

Aaron

On Thu, Apr 5, 2012 at 9:18 AM, Aaron Coburn acob...@amherst.edu wrote:
 Josh,
 I also recall having an issue with the vcldojo code. I never entirely figured 
 out how to integrate it into the custom dojo profiles, opting instead to just 
 keep it separate. As I look at the 2.2.1 code, this only seems to apply to 
 the {request | new | edit}BlockAllocation modes. In the .ht-inc/utils.php 
 file, I added a line that would explicitly load js/vcldojo/TimeTextBoxEnd.js 
 in the getDojoHTML function:

 if ($mode != 'blockAllocations'){
  $rt .= script type=\text/javascript\ 
 src=\js/vcldojo/TimeTextBoxEnd.js\/script\n;
 }

 These lines would be inserted after dojo/dojo/dojo.js and the relevant 
 dojo/dojo/dojoCustom.js scripts are loaded.

 Hope that helps!
 Aaron


 --
 Aaron Coburn
 Systems Administrator and Programmer
 Academic Technology Services, Amherst College
 acob...@amherst.edumailto:acob...@amherst.edu






 On Apr 5, 2012, at 8:50 AM, Josh Thompson wrote:

 Aaron,

 I've been working on this JIRA issue.  I'm having a problem with the custom
 vcldojo.* objects.  I copied the vcl/js/vcldojo directory to the dojo source
 as a sibling directory of dojo, dijit, and dojox, and listed the relative path
 to vcldojo at the end of the vcl.profile.js file the same way you did in the
 one you attached to the JIRA issue.  However, when I load any pages that have
 a widget from vcldojo, I'm getting a javascript error that dojo could not load
 the widget.  Also, it is doing a separate load of the .js file for that widget
 even though I can see that the widget was built in to the layer file.  Did you
 have any issues similar to this?  Any ideas?

 Thanks,
 Josh

 On Friday, August 26, 2011 3:47:54 PM you wrote:
 Aaron,

 Thanks for creating a JIRA issue about it and adding some patches.  You're
 definitely right about the number of GETs slowing down page loads.  I was
 planning on creating one dojo include per VCL page in the next release,
 though I never created a JIRA issue about it.  I did do some work already,
 but I like how you structured it a little better.

 Thanks,
 Josh

 On Friday August 26, 2011, Aaron Coburn wrote:
 Many parts of the VCL web interface use the Dojo javascript framework,
 which has a nice facility for incrementally loading the classes needed
 for a particular page through the dojo.require(...) function. On some
 pages, however, the number of separate GET requests grows rather large.
 This makes the pages much less responsive, especially when a page is
 loaded for the first time.

 With dojo, it is also possible to create custom 'profiles', which are
 groups of dojo classes that are assembled into a single javascript
 library. More information about this is available here:

 http://dojotoolkit.org/reference-guide/quickstart/custom-builds.html

 I assembled about a dozen of these 'profiles' for our VCL installation,
 and with some modification to the .ht-inc/utils.php page, this change
 has resulted in a dramatic improvement in the loading and rendering of
 the vcl web pages.

 Is there any thought for moving in this direction for an upcoming
 release? I have created a JIRA issue for this at:

 https://issues.apache.org/jira/browse/VCL-505

 where I have included some more information as well as the code I used
 to
 implement this in our VCL setup.

 Best wishes,

 Aaron Coburn
 Systems Administrator and Programmer
 Academic Technology Services, Amherst College
 (413) 542-5451 acob...@amherst.edumailto:acob...@amherst.edu
 --
 ---
 Josh Thompson
 Systems Programmer
 Advanced Computing | VCL Developer
 North Carolina State University

 josh_thomp...@ncsu.edumailto:josh_thomp...@ncsu.edu
 919-515-5323

 my GPG/PGP key can be found at pgp.mit.edu

 All electronic mail messages in connection with State business which
 are sent to or received by this account are subject to the NC Public
 Records Law and may be disclosed to third parties.




-- 
Aaron Peeler
Program Manager
Virtual Computing Lab
NC State University

All electronic mail messages in connection with State business which
are sent to or received by this account are subject to the NC Public
Records Law and may be disclosed to third parties.


Re: Dojo library optimization

2012-04-05 Thread Josh Thompson
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Success!  I finally found the problem.  I'm not sure where I picked it up, but 
for the custom files I created, I had them wrapped with an 'if' conditional 
like this:

if(! dojo._hasResource[vcldojo.HoverTooltip]) {
dojo._hasResource[vcldojo.HoverTooltip] = true;

[...code...]

}

Looking at current documentation on creating custom widgets does not mention 
this part.  When I removed the conditional, everything worked as expected.

Josh

On Thursday, April 05, 2012 1:18:01 PM Aaron Coburn wrote:
 Josh,
 I also recall having an issue with the vcldojo code. I never entirely
 figured out how to integrate it into the custom dojo profiles, opting
 instead to just keep it separate. As I look at the 2.2.1 code, this only
 seems to apply to the {request | new | edit}BlockAllocation modes. In the
 .ht-inc/utils.php file, I added a line that would explicitly load
 js/vcldojo/TimeTextBoxEnd.js in the getDojoHTML function:
 
 if ($mode != 'blockAllocations'){
   $rt .= script type=\text/javascript\
 src=\js/vcldojo/TimeTextBoxEnd.js\/script\n; }
 
 These lines would be inserted after dojo/dojo/dojo.js and the relevant
 dojo/dojo/dojoCustom.js scripts are loaded.
 
 Hope that helps!
 Aaron
 
 
 --
 Aaron Coburn
 Systems Administrator and Programmer
 Academic Technology Services, Amherst College
 acob...@amherst.edumailto:acob...@amherst.edu
 
 
 
 
 
 
 On Apr 5, 2012, at 8:50 AM, Josh Thompson wrote:
 
 Aaron,
 
 I've been working on this JIRA issue.  I'm having a problem with the custom
 vcldojo.* objects.  I copied the vcl/js/vcldojo directory to the dojo source
 as a sibling directory of dojo, dijit, and dojox, and listed the relative
 path to vcldojo at the end of the vcl.profile.js file the same way you did
 in the one you attached to the JIRA issue.  However, when I load any pages
 that have a widget from vcldojo, I'm getting a javascript error that dojo
 could not load the widget.  Also, it is doing a separate load of the .js
 file for that widget even though I can see that the widget was built in to
 the layer file.  Did you have any issues similar to this?  Any ideas?
 
 Thanks,
 Josh
 
 On Friday, August 26, 2011 3:47:54 PM you wrote:
 Aaron,
 
 Thanks for creating a JIRA issue about it and adding some patches.  You're
 definitely right about the number of GETs slowing down page loads.  I was
 planning on creating one dojo include per VCL page in the next release,
 though I never created a JIRA issue about it.  I did do some work already,
 but I like how you structured it a little better.
 
 Thanks,
 Josh
 
 On Friday August 26, 2011, Aaron Coburn wrote:
 Many parts of the VCL web interface use the Dojo javascript framework,
 which has a nice facility for incrementally loading the classes needed
 for a particular page through the dojo.require(...) function. On some
 pages, however, the number of separate GET requests grows rather large.
 This makes the pages much less responsive, especially when a page is
 loaded for the first time.
 
 With dojo, it is also possible to create custom 'profiles', which are
 groups of dojo classes that are assembled into a single javascript
 library. More information about this is available here:
 
 http://dojotoolkit.org/reference-guide/quickstart/custom-builds.html
 
 I assembled about a dozen of these 'profiles' for our VCL installation,
 and with some modification to the .ht-inc/utils.php page, this change
 has resulted in a dramatic improvement in the loading and rendering of
 the vcl web pages.
 
 Is there any thought for moving in this direction for an upcoming
 release? I have created a JIRA issue for this at:
 
 https://issues.apache.org/jira/browse/VCL-505
 
 where I have included some more information as well as the code I used
 to
 implement this in our VCL setup.
 
 Best wishes,
 
 Aaron Coburn
 Systems Administrator and Programmer
 Academic Technology Services, Amherst College
 (413) 542-5451 acob...@amherst.edumailto:acob...@amherst.edu
 --
 ---
 Josh Thompson
 Systems Programmer
 Advanced Computing | VCL Developer
 North Carolina State University
 
 josh_thomp...@ncsu.edumailto:josh_thomp...@ncsu.edu
 919-515-5323
 
 my GPG/PGP key can be found at pgp.mit.edu
 
 All electronic mail messages in connection with State business which
 are sent to or received by this account are subject to the NC Public
 Records Law and may be disclosed to third parties.
- -- 
- ---
Josh Thompson
VCL Developer
North Carolina State University

my GPG/PGP key can be found at pgp.mit.edu

All electronic mail messages in connection with State business which
are sent to or received by this account are subject to the NC Public
Records Law and may be disclosed to third parties.
-BEGIN PGP SIGNATURE-
Version: GnuPG v2.0.17 (GNU/Linux)

iEYEARECAAYFAk99tosACgkQV/LQcNdtPQM26gCdGdmAKyX+mY52TiD8N30H+aGv
1PEAn2ePr0sPzBAHZ2DXbpCi5KrI1Sd6
=tz9e
-END PGP SIGNATURE-



Re: Dojo library optimization

2011-08-26 Thread Josh Thompson
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Aaron,

Thanks for creating a JIRA issue about it and adding some patches.  You're 
definitely right about the number of GETs slowing down page loads.  I was 
planning on creating one dojo include per VCL page in the next release, though 
I never created a JIRA issue about it.  I did do some work already, but I like 
how you structured it a little better.

Thanks,
Josh

On Friday August 26, 2011, Aaron Coburn wrote:
 Many parts of the VCL web interface use the Dojo javascript framework,
 which has a nice facility for incrementally loading the classes needed for
 a particular page through the dojo.require(...) function. On some pages,
 however, the number of separate GET requests grows rather large. This
 makes the pages much less responsive, especially when a page is loaded for
 the first time.
 
 With dojo, it is also possible to create custom 'profiles', which are
 groups of dojo classes that are assembled into a single javascript
 library. More information about this is available here:
 
 http://dojotoolkit.org/reference-guide/quickstart/custom-builds.html
 
 I assembled about a dozen of these 'profiles' for our VCL installation, and
 with some modification to the .ht-inc/utils.php page, this change has
 resulted in a dramatic improvement in the loading and rendering of the vcl
 web pages.
 
 Is there any thought for moving in this direction for an upcoming release?
 I have created a JIRA issue for this at:
 
 https://issues.apache.org/jira/browse/VCL-505
 
 where I have included some more information as well as the code I used to
 implement this in our VCL setup.
 
 Best wishes,
 
 Aaron Coburn
 Systems Administrator and Programmer
 Academic Technology Services, Amherst College
 (413) 542-5451 acob...@amherst.edu
- -- 
- ---
Josh Thompson
VCL Developer
North Carolina State University

my GPG/PGP key can be found at pgp.mit.edu
-BEGIN PGP SIGNATURE-
Version: GnuPG v2.0.17 (GNU/Linux)

iEYEARECAAYFAk5X+G8ACgkQV/LQcNdtPQPZTQCcDDd3M+Frk5w74NnMG9KvHqU+
XYgAniwtKyp4dC7f7pvU5Uk1KeAChi1b
=DvzL
-END PGP SIGNATURE-