Check the result from strtoul to avoid accepting arguments like --depth=-1 and --active-branches=foo,bar,baz.
Requested-by: Ramkumar Ramachandra <artag...@gmail.com> Signed-off-by: Jonathan Nieder <jrnie...@gmail.com> --- See http://thread.gmane.org/gmane.comp.version-control.git/159117/focus=159236 for context. fast-import.c | 13 +++++++++++-- t/t9300-fast-import.sh | 8 ++++++++ 2 files changed, 19 insertions(+), 2 deletions(-) diff --git a/fast-import.c b/fast-import.c index 74f08bd..959afef 100644 --- a/fast-import.c +++ b/fast-import.c @@ -2745,16 +2745,25 @@ static void option_date_format(const char *fmt) die("unknown --date-format argument %s", fmt); } +static unsigned long ulong_arg(const char *option, const char *arg) +{ + char *endptr; + unsigned long rv = strtoul(arg, &endptr, 0); + if (strchr(arg, '-') || endptr == arg || *endptr) + die("%s: argument must be an unsigned integer", option); + return rv; +} + static void option_depth(const char *depth) { - max_depth = strtoul(depth, NULL, 0); + max_depth = ulong_arg("--depth", depth); if (max_depth > MAX_DEPTH) die("--depth cannot exceed %u", MAX_DEPTH); } static void option_active_branches(const char *branches) { - max_active_branches = strtoul(branches, NULL, 0); + max_active_branches = ulong_arg("--active-branches", branches); } static void option_export_marks(const char *marks) diff --git a/t/t9300-fast-import.sh b/t/t9300-fast-import.sh index 131f032..2c27da6 100755 --- a/t/t9300-fast-import.sh +++ b/t/t9300-fast-import.sh @@ -1528,6 +1528,14 @@ test_expect_success 'R: unknown commandline options are rejected' '\ test_must_fail git fast-import --non-existing-option < /dev/null ' +test_expect_success 'R: die on invalid option argument' ' + echo "option git active-branches=-5" | + test_must_fail git fast-import && + echo "option git depth=" | + test_must_fail git fast-import && + test_must_fail git fast-import --depth="5 elephants" </dev/null +' + cat >input <<EOF option non-existing-vcs non-existing-option EOF -- 1.7.2.3 _______________________________________________ Mailing list: https://launchpad.net/~vcs-fast-import-devs Post to : vcs-fast-import-devs@lists.launchpad.net Unsubscribe : https://launchpad.net/~vcs-fast-import-devs More help : https://help.launchpad.net/ListHelp
