Re: [Vcs-fast-import-devs] RFC: Substitution of marks to commit-ids in log messages

2009-11-07 Thread Max Bowsher
Max Bowsher wrote: > I am working on a conversion, in which I want to refer to > destination-VCS's commit ids in revision log messages - i.e. I want to > insert text into commit messages which says something like > "Cherrypick ". > > The obvious problem is that the tool writing the fastimport str

Re: [Vcs-fast-import-devs] RFC: Substitution of marks to commit-ids in log messages

2009-11-05 Thread Shawn O. Pearce
Ian Clatworthy wrote: > Shawn O. Pearce wrote: > > Ian Clatworthy wrote: > >> Would it be better to explicitly mark commit messages needing expansion? > >> By using a 'template' command in place of a 'data' command say? > > > > How does that help escaping ":8080" in a commit message that needs >

Re: [Vcs-fast-import-devs] RFC: Substitution of marks to commit-ids in log messages

2009-11-05 Thread Ian Clatworthy
Shawn O. Pearce wrote: > Ian Clatworthy wrote: >> Shawn O. Pearce wrote: >>> If we are going to start parsing the message content we probably >>> should have some sort of escape that allows the frontend to protect >>> some of it from the replacement parsing, so literal :n can be passed >>> through

Re: [Vcs-fast-import-devs] RFC: Substitution of marks to commit-ids in log messages

2009-11-05 Thread Shawn O. Pearce
Ian Clatworthy wrote: > Shawn O. Pearce wrote: > > > > If we are going to start parsing the message content we probably > > should have some sort of escape that allows the frontend to protect > > some of it from the replacement parsing, so literal :n can be passed > > through at the same time tha

Re: [Vcs-fast-import-devs] RFC: Substitution of marks to commit-ids in log messages

2009-11-05 Thread Ian Clatworthy
Shawn O. Pearce wrote: > Max Bowsher wrote: >> I would like to propose that a new importer feature be declared, >> "commit-message-mark-expansion", in which the importer is expected to >> substitute substrings of commit messages looking like <{[:12345]}> with >> the destination VCS's native revis