Re: [PATCH] Fix vcsh_trusted_checkout
On Wed, May 28, 2014 at 6:23 AM, Lorenzo Cappelletti wrote: > On Tue, May 27, 2014 at 9:45 PM, Joey Hess wrote: > >> I don't really use vcsh, so my guess is that the former syntax was >> needed by an old version and it has been simplified to the new syntax? > > I think you're right. vcsh 1.20140313 supports both syntaxes: Correct; the shorthand was introduced, and subsequently redefined as default. Off-hand, I am not sure if keeping the ability to set $MR_REPO directly gives any benefit. If not, migrating to the new style is probably more consistent. Richard ___ vcs-home mailing list vcs-home@lists.madduck.net http://lists.madduck.net/listinfo/vcs-home
Re: [PATCH] Fix vcsh_trusted_checkout
On Tue, May 27, 2014 at 9:45 PM, Joey Hess wrote: > I don't really use vcsh For the record: tsk. Richard ;) ___ vcs-home mailing list vcs-home@lists.madduck.net http://lists.madduck.net/listinfo/vcs-home
Re: [PATCH] Fix vcsh_trusted_checkout
On Tue, May 27, 2014 at 9:45 PM, Joey Hess wrote: > I don't really use vcsh, so my guess is that the former syntax was > needed by an old version and it has been simplified to the new syntax? I think you're right. vcsh 1.20140313 supports both syntaxes: run \ Use this repository ... Shortcut to run git commands directly But there was a merge of a pull request in October last year which moved documentation toward the simplified syntax: https://github.com/RichiH/vcsh/commit/43f82e0bc90d8c7b5456ba29c8a8d0f4e1004361 > This change would break mrconfig files containing the old syntax. I don't > know how common that is. It could support both syntaxes, by using > vcsh_trusted_checkout_old to give the template for the old syntax. The shorter syntax is the standard one in vcsh's documentation and, IMO, is more straightforward. I think it should be supported somehow, at least for ''vcsh_trusted_checkout' which is always used when managing vcsh repos via mr. -- Lorenzo ___ vcs-home mailing list vcs-home@lists.madduck.net http://lists.madduck.net/listinfo/vcs-home
Re: [PATCH] Fix vcsh_trusted_checkout
Lorenzo Cappelletti wrote: > Signed-off-by: Lorenzo Cappelletti > --- > mr | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mr b/mr > index ddc0738..ecd1c02 100755 > --- a/mr > +++ b/mr > @@ -2076,7 +2076,7 @@ bzr_trusted_checkout = bzr checkout|clone|branch|get > $url $repo > hg_trusted_checkout = hg clone $url $repo > darcs_trusted_checkout = darcs get $url $repo > git_bare_trusted_checkout = git clone --bare $url $repo > -vcsh_trusted_checkout = vcsh run "$MR_REPO" git clone $url $repo > +vcsh_trusted_checkout = vcsh clone $url $repo > # fossil: messy to do > veracity_trusted_checkout = vv clone $url $repo I don't really use vcsh, so my guess is that the former syntax was needed by an old version and it has been simplified to the new syntax? This change would break mrconfig files containing the old syntax. I don't know how common that is. It could support both syntaxes, by using vcsh_trusted_checkout_old to give the template for the old syntax. -- see shy jo signature.asc Description: Digital signature ___ vcs-home mailing list vcs-home@lists.madduck.net http://lists.madduck.net/listinfo/vcs-home
[PATCH] Fix vcsh_trusted_checkout
Signed-off-by: Lorenzo Cappelletti --- mr | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mr b/mr index ddc0738..ecd1c02 100755 --- a/mr +++ b/mr @@ -2076,7 +2076,7 @@ bzr_trusted_checkout = bzr checkout|clone|branch|get $url $repo hg_trusted_checkout = hg clone $url $repo darcs_trusted_checkout = darcs get $url $repo git_bare_trusted_checkout = git clone --bare $url $repo -vcsh_trusted_checkout = vcsh run "$MR_REPO" git clone $url $repo +vcsh_trusted_checkout = vcsh clone $url $repo # fossil: messy to do veracity_trusted_checkout = vv clone $url $repo -- 1.9.2 ___ vcs-home mailing list vcs-home@lists.madduck.net http://lists.madduck.net/listinfo/vcs-home
