On Mon, Dec 5, 2011 at 10:00 PM, Joey Hess wrote:
> Joey Hess wrote:
>> Moving the git_test etc into perl code would be one way to speed it up
>> for the common case. Adding a special case optimisation to avoid the shell
>> for "true" and "false" brings mr list down from 8.50 to 1.81 seconds.
>> T
Joey Hess wrote:
> Moving the git_test etc into perl code would be one way to speed it up
> for the common case. Adding a special case optimisation to avoid the shell
> for "true" and "false" brings mr list down from 8.50 to 1.81 seconds.
> The remaining time is here spent running skip tests, I hav
Joey Hess wrote:
> It could well not be. mr list -j 10 runs in the same time as mr list -j 1,
> suggesting the overhead is in something else than actually running the
> shell.
Whoops, bad benchmark, -j comes before action.
Anyway, yes, without any calls to system(), mr list takes just 0.35 second
Adam Spiers wrote:
> Skipper functions like hours_since could (and probably should) decide
> not to skip if MR_ACTION is set to a read-only action such "list" -
> arguably "diff" and "status" too, although that's a matter of personal
> taste.
It could, but skip = lazy is a harder case.
> But mayb
On Mon, Dec 5, 2011 at 5:38 PM, Joey Hess wrote:
> Adam Spiers wrote:
>> > 9c87f2352214175de307efedb8fd93889a26afbc
>> > Can you give an example of when this is needed?
>>
>> I can't remember but I definitely saw it happen at least once :-/
>
> My worry is that, since that really shouldn't
Adam Spiers wrote:
> > 9c87f2352214175de307efedb8fd93889a26afbc
> > Can you give an example of when this is needed?
>
> I can't remember but I definitely saw it happen at least once :-/
My worry is that, since that really shouldn't happen AFIACS, you
were actually seeing a bug. Either that
On Sun, Dec 4, 2011 at 9:11 PM, Joey Hess wrote:
> 37617a63ec993b128f77a945a2020ec894c58eb1
> loadconfig already uses %loaded to avoid reloading the same
> config twice, so this extra check is not necessary, I think.
Ah yes, I missed that. Still, for the cost of an extra line of co
Adam Spiers wrote:
> OK, as discussed, here's a new 'for-joey' branch based off
> current upstream master:
>
> https://github.com/aspiers/kitenet-mr/commits/for-joey
>
> All commits are self-contained, and hopefully non-contentious. They
> are mostly minor bugfixes, but there are a few enhance
