Re: [vdr] vdr-1.4.3-1.diff epg problems

2006-10-11 Thread VDR User 
I can confirm this as well. Tried the new patch, didn't solve the problem. EIT -1, Klaus - 0 ;)On 10/10/06, V Live 
[EMAIL PROTECTED] wrote:Thank you for your effort. But the attached patch still did not fix the  no title in the epg guide or yaepg plugin. But like I said before  removing the 
eit.c patch from your vdr-1.4.3-1.diff and it works fine.Klaus Schmidinger 
[EMAIL PROTECTED] wrote:  V Live wrote:
 I patched your vdr-1.4.3-1.diff against my vdr-1.4.3 version and since  the epg guide and vdr-yaepg plugin show no title in th epg. Seems that  there is an error there. However if I remove the patches to 
eit.c and eit.h but keep the rest of  the patch the epg guide works like it should.Well, meanwhile I guess I found it.The problem only occurs if there is external EPG data (withtable id 0x00). The attached patch should fix that.
Klaus--- eit.c 2006/10/07 12:32:24 1.121+++ eit.c
 2006/10/09 16:14:36@@ -234,7 +234,7 @@ pEvent-SetTitle(ShortEventDescriptor-name.getText(buffer, sizeof(buffer))); pEvent-SetShortText(ShortEventDescriptor-text.getText
(buffer, sizeof(buffer))); }- else {+ else if (!HasExternalData) { pEvent-SetTitle(NULL); pEvent-SetShortText(NULL); }@@ -242,7 +242,7 @@
 char buffer[ExtendedEventDescriptors-getMaximumTextLength(: ) + 1]; pEvent-SetDescription(ExtendedEventDescriptors-getText(buffer, sizeof(buffer), : ));
 }- else+ else if (!HasExternalData) pEvent-SetDescription(NULL);  }   delete ExtendedEventDescriptors;@@ -250,7 +250,8 @@pEvent-SetComponents(Components);
 -  pEvent-FixEpgBugs();+  if
 (!HasExternalData)+ pEvent-FixEpgBugs();   if (LinkChannels)  channel-SetLinkChannels(LinkChannels);   Modified = true;___
vdr mailing listvdr@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr 
	

	
		Get your own web address for just $1.99/1st yr. We'll help. 
Yahoo! Small Business.

___vdr mailing listvdr@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr
___
vdr mailing list
vdr@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr

Re: [vdr] vdr-1.4.3-1.diff epg problems

2006-10-09 Thread Klaus Schmidinger 

V Live wrote:
I patched your vdr-1.4.3-1.diff against my vdr-1.4.3 version and since 
the epg guide and vdr-yaepg plugin show no title in th epg. Seems that 
there is an error there.
However if I remove the patches to eit.c and eit.h but keep the rest of 
the patch the epg guide works like it should.


Please see the attached diff the patch that gave the problem.

http://www.geocities.com/vlivecd/vdr-1.4.3-1-eit.diff.zip


This change just clears any existing contents in the Title,
ShortText or Description if the current version of the event
data doesn't contain a ShortEventDescriptor or ExtendedEventDescriptor.

The reason for this is that there are cases where an event e.g. doesn't
have an ExtendedEventDescriptor, but has a lengthy text in the
ShortText. cEvent::FixEpgBugs() then moves the ShortText into
the Description and clears the ShortText. If later a new version
of the event data is encountered, the ShortText would be set to the
lengthy text again, and the Description wouldn't be overwritten,
since there is no ExtendedEventDescriptor. cEvent::FixEpgBugs()
would then do nothing and the result is an event with (almost) the
same text in both ShortText and Description.

So if in your case there are suddenly events with no data at
all, this can only mean that the current version of the event
data doesn't have a ShortEventDescriptor or ExtendedEventDescriptor.
But then I wonder where that data came from before...

I'm afraid I can't further debug this here, because this problem
doesn't occur with the data I'm receiving. So I guess you'll
have to debug this yourself.

Klaus

___
vdr mailing list
vdr@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr

Re: [vdr] vdr-1.4.3-1.diff epg problems

2006-10-09 Thread Klaus Schmidinger 

V Live wrote:
I patched your vdr-1.4.3-1.diff against my vdr-1.4.3 version and since 
the epg guide and vdr-yaepg plugin show no title in th epg. Seems that 
there is an error there.
However if I remove the patches to eit.c and eit.h but keep the rest of 
the patch the epg guide works like it should.


Well, meanwhile I guess I found it.
The problem only occurs if there is external EPG data (with
table id 0x00). The attached patch should fix that.

Klaus

--- eit.c	2006/10/07 12:32:24	1.121
+++ eit.c	2006/10/09 16:14:36
@@ -234,7 +234,7 @@
 pEvent-SetTitle(ShortEventDescriptor-name.getText(buffer, sizeof(buffer)));
 pEvent-SetShortText(ShortEventDescriptor-text.getText(buffer, sizeof(buffer)));
 }
- else {
+ else if (!HasExternalData) {
 pEvent-SetTitle(NULL);
 pEvent-SetShortText(NULL);
 }
@@ -242,7 +242,7 @@
 char buffer[ExtendedEventDescriptors-getMaximumTextLength(: ) + 1];
 pEvent-SetDescription(ExtendedEventDescriptors-getText(buffer, sizeof(buffer), : ));
 }
- else
+ else if (!HasExternalData)
 pEvent-SetDescription(NULL);
  }
   delete ExtendedEventDescriptors;
@@ -250,7 +250,8 @@
 
   pEvent-SetComponents(Components);
 
-  pEvent-FixEpgBugs();
+  if (!HasExternalData)
+ pEvent-FixEpgBugs();
   if (LinkChannels)
  channel-SetLinkChannels(LinkChannels);
   Modified = true;
___
vdr mailing list
vdr@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr

[vdr] vdr-1.4.3-1.diff epg problems

2006-10-08 Thread V Live 
I patched your vdr-1.4.3-1.diff against my vdr-1.4.3 version and since  the epg guide and vdr-yaepg plugin show "no title" in th epg. Seems  that there is an error there.  However if I remove the patches to eit.c and eit.h but keep the rest of the patch the epg guide works like it should.Please see the attached diff the patch that gave the problem.http://www.geocities.com/vlivecd/vdr-1.4.3-1-eit.diff.zipThanks  Viking1   
		How low will we go? Check out Yahoo! Messenger’s low  PC-to-Phone call rates.___
vdr mailing list
vdr@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr