[vdr] [Patch] crashes with old recordings without info file

2011-04-03 Thread Mika Laitio
I have some old recordings made on 2005 which does not have info file. This caused vdr 1.7.17 to crash because in tools.c line 1194 there is no check whether the file parameter passed is NULL or not. Real cause for the crash is in the vdrrip plugins which should handle the case where the info

Re: [vdr] [Patch] Make RGYB buttons customizeable

2011-04-03 Thread Klaus Schmidinger
On 31.03.2011 15:40, Rainer Blickle wrote: 2011/3/30 Steffen Barszussteffenbpu...@googlemail.com: 2011/3/30 Oliver Schinagloli...@schinagl.nl: I belive that is exactly only what this patch does, it changes the positions on the screen for the ST-NG theme I think (it's been a while I admit). So

Re: [vdr] [Patch] Make RGYB buttons customizeable

2011-04-03 Thread Klaus Schmidinger
On 01.04.2011 15:26, Oliver Schinagl wrote: I have a iMon remote control, which also doesn't use this 'standard' order ;) Additionally on my previous mail (I hit send by accident actually :p) I checked the wikipage, and i couldn't find any mention of color or colour in relation to the order of

Re: [vdr] [Patch] crashes with old recordings without info file

2011-04-03 Thread Klaus Schmidinger
On 03.04.2011 12:23, Mika Laitio wrote: I have some old recordings made on 2005 which does not have info file. This caused vdr 1.7.17 to crash because in tools.c line 1194 there is no check whether the file parameter passed is NULL or not. Real cause for the crash is in the vdrrip plugins

Re: [vdr] [Patch] crashes with old recordings without info file

2011-04-03 Thread Mika Laitio
I wonder who is actually calling cRecordingInfo::Read(FILE *f) with a NULL pointer? In VDR's own code all calls to that function are made sure to get a non-NULL pointer: Yes, the real reason is in the vdrrip plugin that I cloned from http://projects.vdr-developer.org/git/ It has this kind of

Re: [vdr] [ANNOUNCE] VDR developer version 1.7.17

2011-04-03 Thread Udo Richter
Am 27.03.2011 16:45, schrieb Klaus Schmidinger: Can you please rewrite your patch so that it keeps the original 'd' variable? I liked the fact that the 'nextUpdate' variable was incremented in *one* place, and not in several places. Made the whole thing more transparent to me. Besides, I could

Re: [vdr] [Patch] Make RGYB buttons customizeable

2011-04-03 Thread fnu
Well, not only the German one's, there was also a Screenshot from Norway, I guess a kind of advanced teletext: http://upload.wikimedia.org/wikipedia/en/d/d0/Digital_teletext_%28NRK%29.jpg Regards fnu -Urspr√ľngliche Nachricht- Von: vdr-boun...@linuxtv.org [mailto:vdr-boun...@linuxtv.org]

[vdr] [PATCH] PLUGINS/src/osddemo/osddemo.c: fix possible null pointer dereference

2011-04-03 Thread Paul Menzel
Date: Sun, 3 Apr 2011 22:53:33 +0200 Cppcheck reports the following. $ cppcheck --version Cppcheck 1.47 $ cppcheck . […] Checking ./PLUGINS/src/osddemo/osddemo.c... [./PLUGINS/src/osddemo/osddemo.c:8]: (debug) Include file: vdr/osd.h not found.

[vdr] [PATCH] PLUGINS/src/dvbsddevice/dvbsdffosd.c: remove superflous variable `Bitmap`

2011-04-03 Thread Paul Menzel
Date: Fri, 4 Feb 2011 14:58:23 +0100 Cppcheck reports the following. cppcheck: (style) Variable 'Bitmap' is assigned a value that is never used Therefore remove the variable `Bitmap` for stylistic reasons since the compiler probably optimized that out anyway. Signed-off-by: Paul