Re: [vdr] [PATCH v2] Gather necessary options for build in Make.global and include it.

2010-01-29 Thread Paul Menzel
Dear Frank, Am Freitag, den 29.01.2010, 10:04 +0100 schrieb Frank Schmirler: […] > 1) from VDR's Makefile, remove the line > DEFINES += -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE > It is already included from Make.global > > 2) in all plugin Makefiles, remove -fPIC from t

Re: [vdr] [PATCH v2] Gather necessary options for build in Make.global and include it.

2010-01-29 Thread Frank Schmirler
Hi Paul, thanks for the patch - looks good. Some suggestions from me: 1) from VDR's Makefile, remove the line DEFINES += -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE It is already included from Make.global 2) in all plugin Makefiles, remove -fPIC from the line CXXFLAGS ?= -fP

[vdr] [PATCH v2] Gather necessary options for build in Make.global and include it.

2010-01-28 Thread Paul Menzel
Without this patch, if some options in `Makefile` were set outside `Makefile` and no `Make.config` existed with the necessary options, builds could fail. [1][2][3] Therefore include strictly necessary options in `Make.global` and include this in all the Makefiles before `Make.config`. This pat