Re: [vdr] [Patch] Allow to limit SVDRP port to given IP

2010-01-09 Thread Olaf Titz
How about this: if svdrphosts.conf contains only one single IP number, then open the port for only that IP number. Otherwise i needs to be opened generally, This only works if the single line in svdrphosts.conf is 127.0.0.1. But how about this much simpler solution: if svdrphosts.conf is

Re: [vdr] [Patch] Allow to limit SVDRP port to given IP

2010-01-09 Thread Klaus Schmidinger
On 09.01.2010 11:25, Olaf Titz wrote: How about this: if svdrphosts.conf contains only one single IP number, then open the port for only that IP number. Otherwise i needs to be opened generally, This only works if the single line in svdrphosts.conf is 127.0.0.1. But how about this much

Re: [vdr] [Patch] Allow to limit SVDRP port to given IP

2010-01-09 Thread Manuel Reimer
Original-Nachricht Datum: Sat, 09 Jan 2010 11:25:29 +0100 Von: Olaf Titz o...@bigred.inka.de An: vdr@linuxtv.org Betreff: Re: [vdr] [Patch] Allow to limit SVDRP port to given IP But how about this much simpler solution: if svdrphosts.conf is missing or empty, bind

Re: [vdr] [Patch] Allow to limit SVDRP port to given IP

2010-01-09 Thread Theunis Potgieter
2010/1/9 Manuel Reimer manuel.rei...@gmx.de: Original-Nachricht Datum: Sat, 09 Jan 2010 11:25:29 +0100 Von: Olaf Titz o...@bigred.inka.de An: vdr@linuxtv.org Betreff: Re: [vdr] [Patch] Allow to limit SVDRP port to given IP But how about this much simpler solution

Re: [vdr] [Patch] Allow to limit SVDRP port to given IP

2010-01-09 Thread Manuel Reimer
Hello, I've attached a second patch. This patch changes VDR's svdrp port handling in the following way: If only the localhost item is found in svdrphosts.conf, then the port is attached to INADDR_LOOPBACK, which makes it impossible to reach the port from outside. As soon as even one additional

Re: [vdr] [Patch] Allow to limit SVDRP port to given IP

2010-01-09 Thread Theunis Potgieter
Sorry to make things complicated, but would it not satisfy everybody needs if you could bind to an ip address, which could be any one you specify? For example, I would prefer mine to be bind to my eth0's ip for internal lan clients to connect, but not accessible via ppp0 for example. So I guess

Re: [vdr] [Patch] Allow to limit SVDRP port to given IP

2010-01-09 Thread Olaf Titz
I've attached a second patch. This patch changes VDR's svdrp port handling in the following way: If only the localhost item is found in svdrphosts.conf, then the port is attached to INADDR_LOOPBACK, which makes it impossible to reach the port from outside. As soon as even one additional item

[vdr] [Patch] Allow to limit SVDRP port to given IP

2010-01-08 Thread Manuel Reimer
Hello, the INSTALL file in the VDR source code says: WARNING: DUE TO THE OPEN SVDRP PORT THIS PROGRAM MAY CONSTITUTE A === POTENTIAL SECURITY HAZARD! IF YOU ARE NOT RUNNING VDR IN A CONTROLLED ENVIRONMENT, YOU MAY WANT TO DISABLE SVDRP BY USING '--port=0'! This is a

Re: [vdr] [Patch] Allow to limit SVDRP port to given IP

2010-01-08 Thread Klaus Schmidinger
On 08.01.2010 13:27, Manuel Reimer wrote: Hello, the INSTALL file in the VDR source code says: WARNING: DUE TO THE OPEN SVDRP PORT THIS PROGRAM MAY CONSTITUTE A === POTENTIAL SECURITY HAZARD! IF YOU ARE NOT RUNNING VDR IN A CONTROLLED ENVIRONMENT, YOU MAY WANT TO DISABLE

Re: [vdr] [Patch] Allow to limit SVDRP port to given IP

2010-01-08 Thread Klaus Schmidinger
On 08.01.2010 16:56, Manuel Reimer wrote: Original-Nachricht Datum: Fri, 08 Jan 2010 14:57:12 +0100 Von: Klaus Schmidinger klaus.schmidin...@tvdr.de An: VDR Mailing List vdr@linuxtv.org Betreff: Re: [vdr] [Patch] Allow to limit SVDRP port to given IP What about

Re: [vdr] [Patch] Allow to limit SVDRP port to given IP

2010-01-08 Thread Martin Emrich
Hi! Klaus Schmidinger schrieb: How about this: if svdrphosts.conf contains only one single IP number, then open the port for only that IP number. Otherwise i needs to be opened generally, anyway. AFAIK one can only bind an IP socket to a local address (usually corresponding to a network

Re: [vdr] [Patch] Allow to limit SVDRP port to given IP

2010-01-08 Thread Manuel Reimer
Hello, How about this: if svdrphosts.conf contains only one single IP number, then open the port for only that IP number. Otherwise i needs to be opened generally, anyway. You are absolutely right! So if svdrphosts.conf only contains 127.0.0.1 (which is the default), then the port would