Re: [vdr] Removing newline characters from EPG entries.

2007-01-02 Thread Klaus Schmidinger 
Carsten Koch wrote:
> Hi,
> 
> I found the following code in epg.c lines 633-636:
> 
>   // VDR can't usefully handle newline characters in the title and shortText 
> of EPG
>   // data, so let's always convert them to blanks (independent of the setting 
> of EPGBugfixLevel):
>   strreplace(title, '\n', ' ');
>   strreplace(shortText, '\n', ' ');
> 
> AFAIK, VDR _can_ handle newlines in the title and shortText,
> as long as they are represented as '|'.
> So I wonder if it would not be an improvement to change
> the above code into
> 
>   // Change newline characters into '|', which will be displayed as newline.
>   strreplace(title, '\n', '|');
>   strreplace(shortText, '\n', '|');

By "VDR can't usefully handle newline characters in the title and shortText" I 
meant
that the title and short text are always used in a "single line" context.
There's no point in having newlines in there.

Klaus

___
vdr mailing list
vdr@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr

[vdr] Removing newline characters from EPG entries.

2007-01-01 Thread Carsten Koch 
Hi,

I found the following code in epg.c lines 633-636:

  // VDR can't usefully handle newline characters in the title and shortText of 
EPG
  // data, so let's always convert them to blanks (independent of the setting 
of EPGBugfixLevel):
  strreplace(title, '\n', ' ');
  strreplace(shortText, '\n', ' ');

AFAIK, VDR _can_ handle newlines in the title and shortText,
as long as they are represented as '|'.
So I wonder if it would not be an improvement to change
the above code into

  // Change newline characters into '|', which will be displayed as newline.
  strreplace(title, '\n', '|');
  strreplace(shortText, '\n', '|');

Carsten.

___
vdr mailing list
vdr@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr