Re: [vdr] [ANNOUNCE] VDR developer version 1.7.27
On Sat, Apr 07, 2012 at 11:39:38AM +0200, Klaus Schmidinger wrote:
> On 06.04.2012 22:13, Juergen Lock wrote:
> > In article<4f6f0570.7050...@tvdr.de> you write:
> >> VDR developer version 1.7.27 is now available at
> >>
> >>ftp://ftp.tvdr.de/vdr/Developer/vdr-1.7.27.tar.bz2
> >>
> >> A 'diff' against the previous version is available at
> >>
> >>ftp://ftp.tvdr.de/vdr/Developer/vdr-1.7.26-1.7.27.diff
> >>
> >> [...]
> >
> > Hi!
> >
> > While upgrading from 1.7.22 to 1.7.27 I noticed epg scans on a
> > single tuner (with xineliboutput in this case) no longer seem to
> > happen while that tuner is in live view mode, even trying to force
> > a scan via the osd or via "svdrpsend scan" no longer does anything.
> >
> > Am I right this is because eitscan.c cEITScanner::Process does
> >
> > ...
> > if (!Device->Receiving()) {
> > ...
> >
> > and device.c cDevice::Receiving's bool arg no longer does anything
> > i.e. it no longer checks the attached receiver's priorities and thus
> > returns true even for devices only in live view mode?
> >
> > And if yes, what would be the proper fix? :)
>
> Please try changing
>
> if (!Device->Receiving()) {
>
> to
>
> if (Device->Priority() < 0) {
>
>
Yep, that fixes it, now "svdrpsend scan" works again.
Thanx! :)
Juergen
___
vdr mailing list
vdr@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr
Re: [vdr] [ANNOUNCE] VDR developer version 1.7.27
On 06.04.2012 22:13, Juergen Lock wrote:
In article<4f6f0570.7050...@tvdr.de> you write:
VDR developer version 1.7.27 is now available at
ftp://ftp.tvdr.de/vdr/Developer/vdr-1.7.27.tar.bz2
A 'diff' against the previous version is available at
ftp://ftp.tvdr.de/vdr/Developer/vdr-1.7.26-1.7.27.diff
[...]
Hi!
While upgrading from 1.7.22 to 1.7.27 I noticed epg scans on a
single tuner (with xineliboutput in this case) no longer seem to
happen while that tuner is in live view mode, even trying to force
a scan via the osd or via "svdrpsend scan" no longer does anything.
Am I right this is because eitscan.c cEITScanner::Process does
...
if (!Device->Receiving()) {
...
and device.c cDevice::Receiving's bool arg no longer does anything
i.e. it no longer checks the attached receiver's priorities and thus
returns true even for devices only in live view mode?
And if yes, what would be the proper fix? :)
Please try changing
if (!Device->Receiving()) {
to
if (Device->Priority() < 0) {
Klaus
___
vdr mailing list
vdr@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr
Re: [vdr] [ANNOUNCE] VDR developer version 1.7.27
In article <4f6f0570.7050...@tvdr.de> you write:
>VDR developer version 1.7.27 is now available at
>
> ftp://ftp.tvdr.de/vdr/Developer/vdr-1.7.27.tar.bz2
>
>A 'diff' against the previous version is available at
>
> ftp://ftp.tvdr.de/vdr/Developer/vdr-1.7.26-1.7.27.diff
>
>[...]
Hi!
While upgrading from 1.7.22 to 1.7.27 I noticed epg scans on a
single tuner (with xineliboutput in this case) no longer seem to
happen while that tuner is in live view mode, even trying to force
a scan via the osd or via "svdrpsend scan" no longer does anything.
Am I right this is because eitscan.c cEITScanner::Process does
...
if (!Device->Receiving()) {
...
and device.c cDevice::Receiving's bool arg no longer does anything
i.e. it no longer checks the attached receiver's priorities and thus
returns true even for devices only in live view mode?
And if yes, what would be the proper fix? :)
Thanx!
Juergen
___
vdr mailing list
vdr@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr
Re: [vdr] [ANNOUNCE] VDR developer version 1.7.27
On 5 Apr 2012, at 16:26, Dominic Evans wrote: > Hi Klaus, > > On 4 April 2012 22:53, Klaus Schmidinger wrote: >> On 04.04.2012 23:08, Dominic Evans wrote: >>> I can re-test with vanilla VDR sources if you think its possible they >>> are causing the issue? >> >> It would be a start, jut to make sure. >> After all, it appears to work fine here. > > As suspected, it looks like it was the wareagleicon patch causing the > issue. After removing that the Now+Next page is looking good! :-) > > Apologies for the confusion. I'll investigate what needs fixing in the > icon patch. Was an easy fix in the end. Will send it to yavdr guys. ___ vdr mailing list vdr@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr
Re: [vdr] [ANNOUNCE] VDR developer version 1.7.27
Hi Klaus, On 4 April 2012 22:53, Klaus Schmidinger wrote: > On 04.04.2012 23:08, Dominic Evans wrote: >> I can re-test with vanilla VDR sources if you think its possible they >> are causing the issue? > > It would be a start, jut to make sure. > After all, it appears to work fine here. As suspected, it looks like it was the wareagleicon patch causing the issue. After removing that the Now+Next page is looking good! :-) Apologies for the confusion. I'll investigate what needs fixing in the icon patch. ___ vdr mailing list vdr@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr
Re: [vdr] [ANNOUNCE] VDR developer version 1.7.27
On 04.04.2012 23:08, Dominic Evans wrote:
On 4 April 2012 21:48, Klaus Schmidinger wrote:
On 04.04.2012 20:36, Dominic Evans wrote:
With the additional patch to fix the bug with getting a single column
width (that I previously mentioned), this still isn't quite working
correctly.
See this screenshot – http://sadpanda.us/images/901762-Z1591G2.jpg
The column has been widened, but the displayed channel names are
seemingly cropped to the old width?
BBC ON rather than BBC ONE
BBC TW rather than BBC TWO
Channe rather than Channel 4
etc.
Are you sure you're using the right version of menu.c?
The macro CHNAMWIDTH must be used 3 times there:
#> grep -n CHNAMWIDTH menu.c
52:#define CHNAMWIDTH (Channels.MaxShortChannelNameLength() + 1)
1390::cOsdMenu(Now ? tr("What's on now?") : tr("What's on next?"),
CHNUMWIDTH, CHNAMWIDTH, 6, 4)
1614: SetCols(CHNUMWIDTH, CHNAMWIDTH, 7, 6, 4);
1633: SetCols(CHNUMWIDTH, CHNAMWIDTH, 7, 6, 4);
Yep. Before applying my quilt series, my menu.c matches yours:
$ grep -n CHNAMWIDTH menu.c
52:#define CHNAMWIDTH (Channels.MaxShortChannelNameLength() + 1)
1390::cOsdMenu(Now ? tr("What's on now?") : tr("What's on next?"),
CHNUMWIDTH, CHNAMWIDTH, 6, 4)
1614: SetCols(CHNUMWIDTH, CHNAMWIDTH, 7, 6, 4);
1633: SetCols(CHNUMWIDTH, CHNAMWIDTH, 7, 6, 4);
After applying a few patches, the line numbers have shifted, but the
code remains the same:
$ grep -n CHNAMWIDTH menu.c
56:#define CHNAMWIDTH (Channels.MaxShortChannelNameLength() + 1)
1550::cOsdMenu(Now ? tr("What's on now?") : tr("What's on next?"),
CHNUMWIDTH, CHNAMWIDTH, 6, 4)
1800: SetCols(CHNUMWIDTH, CHNAMWIDTH, 7, 6, 4);
1819: SetCols(CHNUMWIDTH, CHNAMWIDTH, 7, 6, 4);
I can re-test with vanilla VDR sources if you think its possible they
are causing the issue?
It would be a start, jut to make sure.
After all, it appears to work fine here.
Klaus
___
vdr mailing list
vdr@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr
Re: [vdr] [ANNOUNCE] VDR developer version 1.7.27
On 4 April 2012 21:48, Klaus Schmidinger wrote:
> On 04.04.2012 20:36, Dominic Evans wrote:
>> With the additional patch to fix the bug with getting a single column
>> width (that I previously mentioned), this still isn't quite working
>> correctly.
>>
>> See this screenshot – http://sadpanda.us/images/901762-Z1591G2.jpg
>>
>> The column has been widened, but the displayed channel names are
>> seemingly cropped to the old width?
>>
>> BBC ON rather than BBC ONE
>> BBC TW rather than BBC TWO
>> Channe rather than Channel 4
>> etc.
>
> Are you sure you're using the right version of menu.c?
> The macro CHNAMWIDTH must be used 3 times there:
>
> #> grep -n CHNAMWIDTH menu.c
>
> 52:#define CHNAMWIDTH (Channels.MaxShortChannelNameLength() + 1)
> 1390::cOsdMenu(Now ? tr("What's on now?") : tr("What's on next?"),
> CHNUMWIDTH, CHNAMWIDTH, 6, 4)
> 1614: SetCols(CHNUMWIDTH, CHNAMWIDTH, 7, 6, 4);
> 1633: SetCols(CHNUMWIDTH, CHNAMWIDTH, 7, 6, 4);
Yep. Before applying my quilt series, my menu.c matches yours:
$ grep -n CHNAMWIDTH menu.c
52:#define CHNAMWIDTH (Channels.MaxShortChannelNameLength() + 1)
1390::cOsdMenu(Now ? tr("What's on now?") : tr("What's on next?"),
CHNUMWIDTH, CHNAMWIDTH, 6, 4)
1614: SetCols(CHNUMWIDTH, CHNAMWIDTH, 7, 6, 4);
1633: SetCols(CHNUMWIDTH, CHNAMWIDTH, 7, 6, 4);
After applying a few patches, the line numbers have shifted, but the
code remains the same:
$ grep -n CHNAMWIDTH menu.c
56:#define CHNAMWIDTH (Channels.MaxShortChannelNameLength() + 1)
1550::cOsdMenu(Now ? tr("What's on now?") : tr("What's on next?"),
CHNUMWIDTH, CHNAMWIDTH, 6, 4)
1800: SetCols(CHNUMWIDTH, CHNAMWIDTH, 7, 6, 4);
1819: SetCols(CHNUMWIDTH, CHNAMWIDTH, 7, 6, 4);
I can re-test with vanilla VDR sources if you think its possible they
are causing the issue?
___
vdr mailing list
vdr@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr
Re: [vdr] [ANNOUNCE] VDR developer version 1.7.27
On 04.04.2012 20:36, Dominic Evans wrote:
Hi Klaus,
On 25 March 2012 12:45, Klaus Schmidinger wrote:
- The channel name column in the "What's on now/next" menu now adjusts its
width
to display the full short name of each channel (suggested by Dominic
Evans).
With the additional patch to fix the bug with getting a single column
width (that I previously mentioned), this still isn't quite working
correctly.
See this screenshot – http://sadpanda.us/images/901762-Z1591G2.jpg
The column has been widened, but the displayed channel names are
seemingly cropped to the old width?
BBC ON rather than BBC ONE
BBC TW rather than BBC TWO
Channe rather than Channel 4
etc.
Are you sure you're using the right version of menu.c?
The macro CHNAMWIDTH must be used 3 times there:
#> grep -n CHNAMWIDTH menu.c
52:#define CHNAMWIDTH (Channels.MaxShortChannelNameLength() + 1)
1390::cOsdMenu(Now ? tr("What's on now?") : tr("What's on next?"), CHNUMWIDTH,
CHNAMWIDTH, 6, 4)
1614: SetCols(CHNUMWIDTH, CHNAMWIDTH, 7, 6, 4);
1633: SetCols(CHNUMWIDTH, CHNAMWIDTH, 7, 6, 4);
Klaus
___
vdr mailing list
vdr@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr
Re: [vdr] [ANNOUNCE] VDR developer version 1.7.27
Hi Klaus, On 25 March 2012 12:45, Klaus Schmidinger wrote: > - The channel name column in the "What's on now/next" menu now adjusts its > width > to display the full short name of each channel (suggested by Dominic > Evans). With the additional patch to fix the bug with getting a single column width (that I previously mentioned), this still isn't quite working correctly. See this screenshot – http://sadpanda.us/images/901762-Z1591G2.jpg The column has been widened, but the displayed channel names are seemingly cropped to the old width? BBC ON rather than BBC ONE BBC TW rather than BBC TWO Channe rather than Channel 4 etc. ___ vdr mailing list vdr@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr
Re: [vdr] [ANNOUNCE] VDR developer version 1.7.27
On 1 April 2012 00:54, VDR User wrote: >> Unfortunately, this doesn't seem to be working. I just upgraded to vdr >> 1.7.27 and the channel name is now only a single character for every >> channel. > > I had the same problem here as well. Klaus has fixed it, try the patch Thanks. Have submitted this to the yaVDR guys on github to add to their debian/patches. ___ vdr mailing list vdr@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr
Re: [vdr] [ANNOUNCE] VDR developer version 1.7.27
On Sat, Mar 31, 2012 at 4:10 PM, Dominic Evans wrote:
>>> - The channel name column in the "What's on now/next" menu now adjusts its
>>> width to display the full short name of each channel (suggested by Dominic
>>> Evans).
>
> Unfortunately, this doesn't seem to be working. I just upgraded to vdr
> 1.7.27 and the channel name is now only a single character for every
> channel.
I had the same problem here as well. Klaus has fixed it, try the patch below:
diff -pruN vdr-1.7.27-orig/channels.c vdr-1.7.27/channels.c
--- vdr-1.7.27-orig/channels.c 2012-03-25 22:46:14.294920001 -0700
+++ vdr-1.7.27/channels.c 2012-03-28 09:29:23.734920001 -0700
@@ -955,7 +955,7 @@ int cChannels::MaxShortChannelNameLength
if (!maxShortChannelNameLength) {
for (cChannel *channel = First(); channel; channel = Next(channel)) {
if (!channel->GroupSep())
-maxShortChannelNameLength =
max(Utf8StrLen(channel->ShortName()), maxShortChannelNameLength);
+maxShortChannelNameLength =
max(Utf8StrLen(channel->ShortName(true)), maxShortChannelNameLength);
}
}
return maxShortChannelNameLength;
___
vdr mailing list
vdr@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr
Re: [vdr] [ANNOUNCE] VDR developer version 1.7.27
On 26 March 2012 10:25, Dominic Evans wrote: > On 25 March 2012 12:45, Klaus Schmidinger wrote: >> - The channel name column in the "What's on now/next" menu now adjusts its >> width to display the full short name of each channel (suggested by Dominic >> Evans). > > Superb! Many thanks! Unfortunately, this doesn't seem to be working. I just upgraded to vdr 1.7.27 and the channel name is now only a single character for every channel. I tried to grab a screenshot, but xine seems to be refusing to with '[xine..put] cXinelibServer::Grab: Grab failed (0)' ___ vdr mailing list vdr@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr
Re: [vdr] [ANNOUNCE] VDR developer version 1.7.27
On 25 March 2012 12:45, Klaus Schmidinger wrote: > - The channel name column in the "What's on now/next" menu now adjusts its > width to display the full short name of each channel (suggested by Dominic > Evans). Superb! Many thanks! ___ vdr mailing list vdr@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr
