Re: [vdr] [ANNOUNCE] VDR developer version 2.1.7

2015-01-18 Thread Lars Hanisch
Hi,

Am 18.01.2015 um 15:40 schrieb Joerg Bornkessel:
> Am 18.01.2015 15:11, schrieb Manuel Reimer:
>> On 01/18/2015 02:43 PM, Joerg Bornkessel wrote:
 - VDR now reads command line options from *.conf files in 
 /etc/vdr/conf.d (thanks to Lars Hanisch). See vdr.1 and vdr.5
 for details.
>>>
>>> Is there an example what exactly can we do with this? The
>>> Manpage's give there very small information :( Lars?

 Yes, I should have documented that feature a bit... My fault, will try to do 
in the next days.

> 
>> Have a look at the vdr4arch repository: 
>> https://github.com/VDR4Arch/vdr4arch
> 
>> We already used this feature using the patch created by Lars.
> 
>> This new feature is especially useful when using systemd or other
>> event driven init systems. It now no longer is required to
>> "somehow" construct a command line. Just start VDR
> 
> 
> Oh Oh, systemd crap...

 It's not only systemd. In fact, it hasn't anything to do with systemd. But it 
helps to strip down the various init
scripts, regardless if systemd, Upstart or SysV.

 And of course everything works with the old scripts. :)

>> vdr4arch places the plugin config files to /etc/vdr/conf.available 
>> first. It's the user's job to create a symlink to /etc/vdr/conf.d
>> to enable the plugin or delete the symlink to disable a plugin.
> 
> this looks like, as has the user a lot of activity to do
> in my opinion, prevent the end user from a lot of editing some files
> or symlinking etc.
> anyway, systemd is not my working place and i will see what ideas
> comes from Lucian M. He is the manager of the systemd crap part in the
> gentoo-vdr-scripts

 It helps distributors for preconfiguring the vdr and its plugins, but also you 
can created multiple conf.d directories
and symlink the one or the other to /etc/vdr/conf.d to test different 
configuration without messing with the old and
working config.

 Just play a bit with it, you may find it helpful. "vdr --showargs[=DIR]" will 
output all options from /etc/vdr/conf.d
or the given directory. You might even use this to generate lines for "old 
style" init scripts with all options on the
commandline.

Lars.

> 
> Thx for your reply
> 
> 
> ___
> vdr mailing list
> vdr@linuxtv.org
> http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr
> 


___
vdr mailing list
vdr@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr


Re: [vdr] [ANNOUNCE] VDR developer version 2.1.7

2015-01-18 Thread Joerg Bornkessel
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Am 18.01.2015 13:58, schrieb Joerg Bornkessel:
> Am 18.01.2015 11:38, schrieb Klaus Schmidinger:
>> VDR developer version 2.1.7 is now available at
> 
>> ftp://ftp.tvdr.de/vdr/Developer/vdr-2.1.7.tar.bz2
> 
> 
> 
> Attached patch will fix some issues with gcc-4.8 and CXXFLAGS
> -std=C++11 warning: invalid suffix on literal; C++11 requires a
> space between literal and identifier [-Wliteral-suffix]
> 
> in dvbsubtitle.c recording.c remote.c
> 
> Tested also with gcc-4.8 without extended -std-=C++11
> 
passed also the test with gcc-4.9.2 on x86_64 without any problems


-BEGIN PGP SIGNATURE-
Version: GnuPG v2
Comment: added by hd_bru...@gentoo.org
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iD8DBQFUu8aVdn07HTTCgIoRAsvAAKC6Oq+f7pbgNhz2h0nNM4Vk7ELUpACePBVP
McvxTnXlpBazL5g5rprSnxU=
=+cxv
-END PGP SIGNATURE-

___
vdr mailing list
vdr@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr


Re: [vdr] [ANNOUNCE] VDR developer version 2.1.7

2015-01-18 Thread Joerg Bornkessel
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Am 18.01.2015 15:11, schrieb Manuel Reimer:
> On 01/18/2015 02:43 PM, Joerg Bornkessel wrote:
>>> - VDR now reads command line options from *.conf files in 
>>> /etc/vdr/conf.d (thanks to Lars Hanisch). See vdr.1 and vdr.5
>>> for details.
>> 
>> Is there an example what exactly can we do with this? The
>> Manpage's give there very small information :( Lars?
> 
> Have a look at the vdr4arch repository: 
> https://github.com/VDR4Arch/vdr4arch
> 
> We already used this feature using the patch created by Lars.
> 
> This new feature is especially useful when using systemd or other
> event driven init systems. It now no longer is required to
> "somehow" construct a command line. Just start VDR
> 

Oh Oh, systemd crap...


> vdr4arch places the plugin config files to /etc/vdr/conf.available 
> first. It's the user's job to create a symlink to /etc/vdr/conf.d
> to enable the plugin or delete the symlink to disable a plugin.
> 
this looks like, as has the user a lot of activity to do
in my opinion, prevent the end user from a lot of editing some files
or symlinking etc.
anyway, systemd is not my working place and i will see what ideas
comes from Lucian M. He is the manager of the systemd crap part in the
gentoo-vdr-scripts

Thx for your reply

-BEGIN PGP SIGNATURE-
Version: GnuPG v2
Comment: added by hd_bru...@gentoo.org
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iD8DBQFUu8XIdn07HTTCgIoRAqvGAJ9LJ6/eCSBFaCJjMPhRb8mGUoMlYgCfQFT7
tTuBUsT9a+9ZhJ8XvMqqjpY=
=M2St
-END PGP SIGNATURE-

___
vdr mailing list
vdr@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr


Re: [vdr] [ANNOUNCE] VDR developer version 2.1.7

2015-01-18 Thread Manuel Reimer

On 01/18/2015 02:43 PM, Joerg Bornkessel wrote:

- VDR now reads command line options from *.conf files in
/etc/vdr/conf.d (thanks to Lars Hanisch). See vdr.1 and vdr.5 for
details.


Is there an example what exactly can we do with this?
The Manpage's give there very small information :(
Lars?


Have a look at the vdr4arch repository:
https://github.com/VDR4Arch/vdr4arch

We already used this feature using the patch created by Lars.

This new feature is especially useful when using systemd or other event 
driven init systems. It now no longer is required to "somehow" construct 
a command line. Just start VDR


https://github.com/VDR4Arch/vdr4arch/blob/master/vdr/vdr.service

The VDR settings can be configured in a file like this one:
https://github.com/VDR4Arch/vdr4arch/blob/master/vdr/10-vdr.conf

And to load/configure a plugin the config file has to look like this:

https://github.com/VDR4Arch/vdr4arch/blob/master/plugins/vdr-softhddevice/50-softhddevice.conf

vdr4arch places the plugin config files to /etc/vdr/conf.available 
first. It's the user's job to create a symlink to /etc/vdr/conf.d to 
enable the plugin or delete the symlink to disable a plugin.


Manuel

___
vdr mailing list
vdr@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr


Re: [vdr] [ANNOUNCE] VDR developer version 2.1.7

2015-01-18 Thread Joerg Bornkessel
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Am 18.01.2015 11:38, schrieb Klaus Schmidinger:
> VDR developer version 2.1.7 is now available at
> 

> - VDR now reads command line options from *.conf files in 
> /etc/vdr/conf.d (thanks to Lars Hanisch). See vdr.1 and vdr.5 for
> details.

Is there an example what exactly can we do with this?
The Manpage's give there very small information :(
Lars?

-BEGIN PGP SIGNATURE-
Version: GnuPG v2
Comment: added by hd_bru...@gentoo.org
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iD8DBQFUu7htdn07HTTCgIoRAgUQAJ0cNfeqNnkhb7VuVWsnZhSh9rYLggCglquL
yys+Kinebh4CvBWL5BL6+RA=
=oqVV
-END PGP SIGNATURE-

___
vdr mailing list
vdr@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr


Re: [vdr] [ANNOUNCE] VDR developer version 2.1.7

2015-01-18 Thread Klaus Schmidinger

On 18.01.2015 13:58, Joerg Bornkessel wrote:

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Am 18.01.2015 11:38, schrieb Klaus Schmidinger:

VDR developer version 2.1.7 is now available at

ftp://ftp.tvdr.de/vdr/Developer/vdr-2.1.7.tar.bz2




Attached patch will fix some issues with gcc-4.8 and CXXFLAGS -std=C++11
warning: invalid suffix on literal; C++11 requires a space between
literal and identifier [-Wliteral-suffix]

in dvbsubtitle.c recording.c remote.c


I hated that "PRId64" rubbish when it was introduced, now I hate it even more...

(This is not against you, Joerg - just a general rant ;-).

Klaus

___
vdr mailing list
vdr@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr


Re: [vdr] [ANNOUNCE] VDR developer version 2.1.7

2015-01-18 Thread Joerg Bornkessel
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Am 18.01.2015 11:38, schrieb Klaus Schmidinger:
> VDR developer version 2.1.7 is now available at
> 
> ftp://ftp.tvdr.de/vdr/Developer/vdr-2.1.7.tar.bz2



Attached patch will fix some issues with gcc-4.8 and CXXFLAGS -std=C++11
warning: invalid suffix on literal; C++11 requires a space between
literal and identifier [-Wliteral-suffix]

in dvbsubtitle.c recording.c remote.c

Tested also with gcc-4.8 without extended -std-=C++11

Thanks for the new version :)

/dev/joerg

-BEGIN PGP SIGNATURE-
Version: GnuPG v2
Comment: added by hd_bru...@gentoo.org
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iD8DBQFUu63qdn07HTTCgIoRAgJUAKCW9F9Ogk6Y2ONn6h6Qecw0F6j7mQCeLbBq
/Qwnw6kXcrtnLWvIADQHdgY=
=TO2y
-END PGP SIGNATURE-
Invalid suffix on Literal with GCC 4.8 and C++11
warning: invalid suffix on literal; C++11 requires a space between literal and identifier [-Wliteral-suffix]

Signed-of-by: Joerg Bornkessel  Jan/18/2015

diff -Naur vdr-2.1.7.orig/dvbsubtitle.c vdr-2.1.7/dvbsubtitle.c
--- vdr-2.1.7.orig/dvbsubtitle.c	2015-01-18 12:52:48.949414301 +0100
+++ vdr-2.1.7/dvbsubtitle.c	2015-01-18 13:04:01.889448784 +0100
@@ -1042,7 +1042,7 @@
 default: dbgpages("unknown page state: %d\n", pageState);
 }
   bs.SkipBits(2); // reserved
-  dbgpages("\npage id %d version %d pts %"PRId64" timeout %d state %d\n", pageId, pageVersionNumber, pts, pageTimeout, pageState);
+  dbgpages("\npage id %d version %d pts %" PRId64 " timeout %d state %d\n", pageId, pageVersionNumber, pts, pageTimeout, pageState);
   regionRefs.Clear();
   while (!bs.IsEOF())
 regionRefs.Add(new cSubtitleRegionRef(bs));
@@ -1073,7 +1073,7 @@
 default: dbgpages("unknown page state: %d\n", pageState);
 }
   bs.SkipBits(6);
-  dbgpages("\npage id %d version %d pts %"PRId64" timeout %d state %d\n", pageId, pageVersionNumber, pts, pageTimeout, pageState);
+  dbgpages("\npage id %d version %d pts %" PRId64 " timeout %d state %d\n", pageId, pageVersionNumber, pts, pageTimeout, pageState);
   regionRefs.Clear();
   pending = true;
 }
@@ -1384,7 +1384,7 @@
  if (Length > PayloadOffset + SubstreamHeaderLength) {
 int64_t pts = PesHasPts(Data) ? PesGetPts(Data) : -1;
 if (pts >= 0)
-   dbgconverter("converter PTS: %"PRId64"\n", pts);
+   dbgconverter("converter PTS: %" PRId64 "\n", pts);
 const uchar *data = Data + PayloadOffset + SubstreamHeaderLength; // skip substream header
 int length = Length - PayloadOffset - SubstreamHeaderLength; // skip substream header
 if (ResetSubtitleAssembler)
@@ -1420,7 +1420,7 @@
  if (Length > PayloadOffset) {
 int64_t pts = PesHasPts(Data) ? PesGetPts(Data) : -1;
 if (pts >= 0)
-   dbgconverter("converter PTS: %"PRId64"\n", pts);
+   dbgconverter("converter PTS: %" PRId64 "\n", pts);
 const uchar *data = Data + PayloadOffset;
 int length = Length - PayloadOffset;
 if (length > 0) {
@@ -1488,7 +1488,7 @@
 dbgoutput("showing bitmap #%d of %d\n", sb->Index() + 1, bitmaps->Count());
 sb->Draw(osd);
 Timeout.Set(sb->Timeout() * 1000);
-dbgconverter("PTS: %"PRId64"  STC: %"PRId64" (%"PRId64") timeout: %d\n", sb->Pts(), STC, Delta, sb->Timeout());
+dbgconverter("PTS: %" PRId64 "  STC: %" PRId64 " (%" PRId64 ") timeout: %d\n", sb->Pts(), STC, Delta, sb->Timeout());
 }
  }
   else
diff -Naur vdr-2.1.7.orig/recording.c vdr-2.1.7/recording.c
--- vdr-2.1.7.orig/recording.c	2015-01-18 12:52:48.956080968 +0100
+++ vdr-2.1.7/recording.c	2015-01-18 13:05:42.346120598 +0100
@@ -1749,7 +1749,7 @@
 off_t FileSizeSrc = FileSize(FileNameSrc);
 off_t FileSizeDst = FileSize(FileNameDst);
 if (FileSizeSrc != FileSizeDst) {
-   esyslog("ERROR: file size discrepancy: %"PRId64" != %"PRId64, FileSizeSrc, FileSizeDst);
+   esyslog("ERROR: file size discrepancy: %" PRId64 " != %" PRId64, FileSizeSrc, FileSizeDst);
break;
}
 }
@@ -2476,7 +2476,7 @@
delta = int(buf.st_size % sizeof(tIndexTs));
if (delta) {
   delta = sizeof(tIndexTs) - delta;
-  esyslog("ERROR: invalid file size (%"PRId64") in '%s'", buf.st_size, *fileName);
+  esyslog("ERROR: invalid file size (%" PRId64 ") in '%s'", buf.st_size, *fileName);
   }
last = int((buf.st_size + delta) / sizeof(tIndexTs) - 1);
if ((!Record || Update) && last >= 0) {
diff -Naur vdr-2.1.7.orig/remote.c vdr-2.1.7/remote.c
--- vdr-2.1.7.orig/remote.c	2015-01-18 12:52:48.949414301 +0100
+++ vdr-2.1.7/remote.c	2015-01-18 13:06:40.752790258 +0100
@@ -124,7 +124,7 @@
 bool cR