Re: [vdr] [ANNOUNCE] vdr-sudoku-0.2.0

[Ville Skyttä]

On Saturday 22 March 2008, Thomas Günther wrote:
> Ville Skyttä wrote:
>
> > - no-exit: Remove the "Exit" choice from the commands menu; exiting the
> > plugin using this menu entry exits the plugin fine but next time any VDR
> > OSD should appear after doing this, VDR crashes (VDR 1.4.7, Fedora Core
> > 8).  This is obviously just a stopgap patch, it'd be better if this could
> > be fixed properly.
>
> Sorry, this was a last minute change, without testing the exit
> function. :-( Please try the attached patch. It solves the problem for
> me.

Seems to work for me too, thanks.

___
vdr mailing list
vdr@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr

Re: [vdr] [ANNOUNCE] vdr-sudoku-0.2.0

[Ville Skyttä]

On Saturday 22 March 2008, Thomas Günther wrote:
> Hi!
>
> There is a new version of the Sudoku plug-in.
>
> Download: http://toms-cafe.de/vdr/sudoku/vdr-sudoku-0.2.0.tgz

Here's a bunch of patches:

- finnish: Add missing Finnish translations.

- no-pattern-default: Turn of "show numbers as pattern" by default; I find the 
feature quite unexpected and it causes a mess (bleeding colors) with my DXR3 
OSD.

- no-exit: Remove the "Exit" choice from the commands menu; exiting the plugin 
using this menu entry exits the plugin fine but next time any VDR OSD should 
appear after doing this, VDR crashes (VDR 1.4.7, Fedora Core 8).  This is 
obviously just a stopgap patch, it'd be better if this could be fixed 
properly.
Remove "Exit" from commands menu, it causes crashes when opening the
OSD next time after exiting the plugin.

diff -up sudoku-0.2.0/commands.cpp~ sudoku-0.2.0/commands.cpp
--- sudoku-0.2.0/commands.cpp~	2008-03-22 04:00:00.0 +0200
+++ sudoku-0.2.0/commands.cpp	2008-03-22 14:11:15.0 +0200
@@ -43,7 +43,6 @@ CommandMenu::CommandMenu() :
   Add(new Command(hk(tr("Save the puzzle")),   &Menu::save));
   Add(new Command(hk(tr("Reset the puzzle")),  &Menu::reset));
   Add(new Command(hk(tr("Open setup menu")),   &Menu::open_setup));
-  Add(new Command(hk(tr("Exit")),  &Menu::exit));
   command = NULL;
 }
 
Don't show possible numbers as a pattern by default, it's an unexpected
feature and doesn't work properly with all OSD's.

diff -up sudoku-0.2.0/setup.cpp~ sudoku-0.2.0/setup.cpp
--- sudoku-0.2.0/setup.cpp~	2008-03-22 04:00:00.0 +0200
+++ sudoku-0.2.0/setup.cpp	2008-03-22 13:43:53.0 +0200
@@ -39,7 +39,7 @@ SetupData::SetupData()
   symmetric = 1;
   mark_errors = 1;
   mark_ambiguous = 1;
-  show_possibles_pattern = 1;
+  show_possibles_pattern = 0;
   show_possibles_digits = 1;
   clear_marks = 0;
   transparency = 50;


vdr-sudoku-0.2.0-finnish.patch.gz
Description: GNU Zip compressed data
___
vdr mailing list
vdr@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr