Re: [vdr] [PATCH v2] Gather necessary options for build in Make.global and include it.

2010-01-29 Thread Paul Menzel 
Dear Frank,


Am Freitag, den 29.01.2010, 10:04 +0100 schrieb Frank Schmirler:

[…]

> 1) from VDR's Makefile, remove the line
> DEFINES += -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE
> It is already included from Make.global
> 
> 2) in all plugin Makefiles, remove -fPIC from the line
> CXXFLAGS ?= -fPIC -g -O2 -Wall -Woverloaded-virtual -Wno-parentheses
> It will be added by Make.global anyway

My reasoning was that someone reading the Makefile would have it easier
to see what options are needed. I will change it now.

I will also remove the line `DEFINES += -D_FILE …` in there too because
it should be added by `Make.global` too.

> 3) in Make.config.template, remove only the line
> DEFINES += -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE
> The lines with "+= -fPIC" are still necessary, as Make.config resets
> CFLAGS/CXXFLAGS.

Correct.

> 4) Script newplugin needs to be modified, too.

I did not know about `newplugin`.


Thanks for the review. I will send a new version of the patch,

Paul


signature.asc
Description: Dies ist ein digital signierter Nachrichtenteil
___
vdr mailing list
vdr@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr

Re: [vdr] [PATCH v2] Gather necessary options for build in Make.global and include it.

2010-01-29 Thread Frank Schmirler 
Hi Paul,

thanks for the patch - looks good. Some suggestions from me:

1) from VDR's Makefile, remove the line
DEFINES += -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE
It is already included from Make.global

2) in all plugin Makefiles, remove -fPIC from the line
CXXFLAGS ?= -fPIC -g -O2 -Wall -Woverloaded-virtual -Wno-parentheses
It will be added by Make.global anyway

3) in Make.config.template, remove only the line
DEFINES += -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE
The lines with "+= -fPIC" are still necessary, as Make.config resets
CFLAGS/CXXFLAGS.

4) Script newplugin needs to be modified, too.

Best regards,
Frank

___
vdr mailing list
vdr@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr