Re: [vdr] VDR 1.5.17 - pre 1.3.19 compatibility mode problems

2008-04-13 Thread Stefan Lucke 
On Sunday 13 April 2008, Reinhard Nissl wrote:
> Hi,
> 
> Stefan Lucke schrieb:
> 
> > Apr 13 09:48:11 jarada vdr: [7765] unknown PS1 packet, substream id = 62 
> > (counter is at 8)
> > Apr 13 09:48:11 jarada vdr: [7765] unknown PS1 packet, substream id = DA 
> > (counter is at 9)
> > Apr 13 09:48:11 jarada vdr: [7765] switching to pre 1.3.19 Dolby Digital 
> > compatibility mode - substream id = DA
> > Apr 13 09:48:11 jarada vdr: [7765] unknown PS1 packet, substream id = DA 
> > (counter is at 0)
> > Apr 13 09:48:11 jarada vdr: [7765] unknown PS1 packet, substream id = 41 
> > (counter is at 0)
> > Apr 13 09:48:11 jarada vdr: [7765] unknown PS1 packet, substream id = 0B 
> > (counter is at 1)
> > Apr 13 09:48:11 jarada vdr: [7765] unknown PS1 packet, substream id = D6 
> > (counter is at 2)
> > Apr 13 09:48:11 jarada vdr: [7765] unknown PS1 packet, substream id = C6 
> > (counter is at 2)
> > Apr 13 09:48:11 jarada vdr: [7765] unknown PS1 packet, substream id = 5A 
> > (counter is at 3)
> > Apr 13 09:48:11 jarada vdr: [7765] unknown PS1 packet, substream id = 0B 
> > (counter is at 4)
> > Apr 13 09:48:11 jarada vdr: [7765] unknown PS1 packet, substream id = 6C 
> > (counter is at 4)
> > 
> > Wondering why the are different substream ids are reported with the same 
> > counter value ;-).
> > 
> >> This additional check was suggested by Marco Schlüßler, so maybe he can 
> >> comment
> >> on this and maybe find out why this is interfering with the pre 1.3.19 
> >> Dolby Digital
> >> detection?
> 
> Maybe I should have posted this patch to the list earlier too. 

Ack.
Maybe I should have tested my old recordings a bit earlier ;-) .

> Without the patch, the counter will restart from 0 and prevent 

Bingo.
With patch, vdr-1.6.0 could replay these old recodings with sound,
at least normal stereo.
Thanks.

> VDR to run in compatibility mode just after VDR was going to 
> activate compatibility mode.
> 

 
Stefan Lucke

___
vdr mailing list
vdr@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr

Re: [vdr] VDR 1.5.17 - pre 1.3.19 compatibility mode problems

2008-04-13 Thread Klaus Schmidinger 
On 04/13/08 10:54, Reinhard Nissl wrote:
> Hi,
> 
> Stefan Lucke schrieb:
> 
>> Apr 13 09:48:11 jarada vdr: [7765] unknown PS1 packet, substream id = 
>> 62 (counter is at 8)
>> Apr 13 09:48:11 jarada vdr: [7765] unknown PS1 packet, substream id = 
>> DA (counter is at 9)
>> Apr 13 09:48:11 jarada vdr: [7765] switching to pre 1.3.19 Dolby 
>> Digital compatibility mode - substream id = DA
>> Apr 13 09:48:11 jarada vdr: [7765] unknown PS1 packet, substream id = 
>> DA (counter is at 0)
>> Apr 13 09:48:11 jarada vdr: [7765] unknown PS1 packet, substream id = 
>> 41 (counter is at 0)
>> Apr 13 09:48:11 jarada vdr: [7765] unknown PS1 packet, substream id = 
>> 0B (counter is at 1)
>> Apr 13 09:48:11 jarada vdr: [7765] unknown PS1 packet, substream id = 
>> D6 (counter is at 2)
>> Apr 13 09:48:11 jarada vdr: [7765] unknown PS1 packet, substream id = 
>> C6 (counter is at 2)
>> Apr 13 09:48:11 jarada vdr: [7765] unknown PS1 packet, substream id = 
>> 5A (counter is at 3)
>> Apr 13 09:48:11 jarada vdr: [7765] unknown PS1 packet, substream id = 
>> 0B (counter is at 4)
>> Apr 13 09:48:11 jarada vdr: [7765] unknown PS1 packet, substream id = 
>> 6C (counter is at 4)
>>
>> Wondering why the are different substream ids are reported with the 
>> same counter value ;-).
>>
>>> This additional check was suggested by Marco Schlüßler, so maybe he 
>>> can comment
>>> on this and maybe find out why this is interfering with the pre 
>>> 1.3.19 Dolby Digital
>>> detection?
> 
> Maybe I should have posted this patch to the list earlier too. Without 
> the patch, the counter will restart from 0 and prevent VDR to run in 
> compatibility mode just after VDR was going to activate compatibility mode.

You've beat me by just a few seconds - I was just about to post the patch
you sent me privately, too ;-)

Klaus

___
vdr mailing list
vdr@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr

Re: [vdr] VDR 1.5.17 - pre 1.3.19 compatibility mode problems

2008-04-13 Thread Reinhard Nissl 

Hi,

Stefan Lucke schrieb:


Apr 13 09:48:11 jarada vdr: [7765] unknown PS1 packet, substream id = 62 
(counter is at 8)
Apr 13 09:48:11 jarada vdr: [7765] unknown PS1 packet, substream id = DA 
(counter is at 9)
Apr 13 09:48:11 jarada vdr: [7765] switching to pre 1.3.19 Dolby Digital 
compatibility mode - substream id = DA
Apr 13 09:48:11 jarada vdr: [7765] unknown PS1 packet, substream id = DA 
(counter is at 0)
Apr 13 09:48:11 jarada vdr: [7765] unknown PS1 packet, substream id = 41 
(counter is at 0)
Apr 13 09:48:11 jarada vdr: [7765] unknown PS1 packet, substream id = 0B 
(counter is at 1)
Apr 13 09:48:11 jarada vdr: [7765] unknown PS1 packet, substream id = D6 
(counter is at 2)
Apr 13 09:48:11 jarada vdr: [7765] unknown PS1 packet, substream id = C6 
(counter is at 2)
Apr 13 09:48:11 jarada vdr: [7765] unknown PS1 packet, substream id = 5A 
(counter is at 3)
Apr 13 09:48:11 jarada vdr: [7765] unknown PS1 packet, substream id = 0B 
(counter is at 4)
Apr 13 09:48:11 jarada vdr: [7765] unknown PS1 packet, substream id = 6C 
(counter is at 4)

Wondering why the are different substream ids are reported with the same 
counter value ;-).


This additional check was suggested by Marco Schlüßler, so maybe he can comment
on this and maybe find out why this is interfering with the pre 1.3.19 Dolby 
Digital
detection?


Maybe I should have posted this patch to the list earlier too. 
Without the patch, the counter will restart from 0 and prevent 
VDR to run in compatibility mode just after VDR was going to 
activate compatibility mode.


Bye.
--
Dipl.-Inform. (FH) Reinhard Nissl
mailto:[EMAIL PROTECTED]
--- ../vdr-1.5.18-dvbs2-other/device.c	2008-03-19 22:33:06.0 +0100
+++ device.c	2008-04-06 18:53:53.0 +0200
@@ -1335,6 +1346,7 @@ pre_1_3_19_PrivateStreamDeteced:
  if (pre_1_3_19_PrivateStream > MIN_PRE_1_3_19_PRIVATESTREAM) {
 dsyslog("switching to pre 1.3.19 Dolby Digital compatibility mode - substream id = %02X", SubStreamId);
 ClrAvailableTracks();
+pre_1_3_19_PrivateStream = MIN_PRE_1_3_19_PRIVATESTREAM + 1;
 goto pre_1_3_19_PrivateStreamDeteced;
 }
  }
___
vdr mailing list
vdr@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr

Re: [vdr] VDR 1.5.17 - pre 1.3.19 compatibility mode problems

2008-04-13 Thread Stefan Lucke 
On Saturday 12 April 2008, Klaus Schmidinger wrote:
> On 04/09/08 08:54, Stefan Lucke wrote:
> > On Wednesday 05 March 2008, Klaus Schmidinger wrote:
> >> On 03/04/08 10:58, Tero Siironen wrote:
> >>> Hi,
> >>>
> >>> I upgraded from VDR 1.4.7 to 1.5.17 and noticed that some of my old  
> >>> recordings won't play decently with this new version. Here's a syslog  
> >>> entry and example clip can be found from 
> >>> http://kotisivu.suomi.net/izero/vdr-darwin/ddmode_example.zip 
> >>>   (9MB)
> >>>
> >>> Those problematic recordings were done with some 1.3.x series VDR with  
> >>> ttxtsubs plugin in fall 2004. Plays fine with VDR 1.4.7, but playback  
> >>> stutters when playing with VDR 1.5.17. My system has DVB-C FF 2.1 and  
> >>> DVB-C budget cards. Running on Fedora 5.
> >> My guess would be that the offending data comes from the ttxtsubs plugin.
> >> Maybe you need to patch VDR to become aware of this.
> > 
> > My guess is that this is introduced by vdr-1.5.11
> > 
> > Original vdr-1.6.0:
> > Apr  9 08:29:38 jarada vdr: [7997] replay 
> > /net_data/video/Extra/Enterprise_1/%1-01_Aufbruch_ins_Unbekannte_-_Teil_1/2004-01-31.19:05.99.99.rec
> > Apr  9 08:29:38 jarada vdr: [7997] playing 
> > '/net_data/video/Extra/Enterprise_1/%1-01_Aufbruch_ins_Unbekannte_-_Teil_1/2004-01-31.19:05.99.99.rec/001.vdr'
> > Apr  9 08:29:38 jarada vdr: [7997] loading 
> > /net_data/video/Extra/Enterprise_1/%1-01_Aufbruch_ins_Unbekannte_-_Teil_1/2004-01-31.19:05.99.99.rec//marks.vdr
> > Apr  9 08:29:38 jarada vdr: [8019] dvbplayer thread started (pid=7997, 
> > tid=8019)
> > Apr  9 08:29:38 jarada vdr: [8020] non blocking file reader thread started 
> > (pid=7997, tid=8020)
> > Apr  9 08:29:38 jarada vdr: [8019] unknown PS1 packet, substream id = EB 
> > (counter is at 0)
> > Apr  9 08:29:38 jarada vdr: [8019] unknown PS1 packet, substream id = 0B 
> > (counter is at 1)


> > Attached pach fixes this problem for me.
> 
> Your patch changed two things: the MIN_PRE_1_3_19_PRIVATESTREAM stuff, which 
> merely
> made detection of pre 1.3.19 Dolby Digital data more reliable, and the 
> (Data[7] & 0x01)
> check in "// Compatibility mode for old subtitles plugin:". I assume that the 
> latter one
> is what's causing your problems.
> 
> Can you please reinstate the MIN_PRE_1_3_19_PRIVATESTREAM stuff and check 
> whether just
> leaving out the (Data[7] & 0x01) check is enough to fix this?

I guess you meant the following change only:

--- device.c.orig   2008-03-09 11:03:34.0 +0100
+++ device.c2008-04-12 17:30:45.0 +0200
@@ -1265,7 +1265,7 @@
int PayloadOffset = Data[8] + 9;

// Compatibility mode for old subtitles plugin:
-   if ((Data[7] & 0x01) && (Data[PayloadOffset - 3] & 0x81) == 
0x01 && Data[PayloadOffset - 2] == 0x81)
+   if ((Data[PayloadOffset - 3] & 0x81) == 1 && Data[PayloadOffset 
- 2] == 0x81)
   PayloadOffset--;

uchar SubStreamId = Data[PayloadOffset];

With this change it is still the same issue: no sound at all.

Apr 13 09:48:11 jarada vdr: [7765] unknown PS1 packet, substream id = 62 
(counter is at 8)
Apr 13 09:48:11 jarada vdr: [7765] unknown PS1 packet, substream id = DA 
(counter is at 9)
Apr 13 09:48:11 jarada vdr: [7765] switching to pre 1.3.19 Dolby Digital 
compatibility mode - substream id = DA
Apr 13 09:48:11 jarada vdr: [7765] unknown PS1 packet, substream id = DA 
(counter is at 0)
Apr 13 09:48:11 jarada vdr: [7765] unknown PS1 packet, substream id = 41 
(counter is at 0)
Apr 13 09:48:11 jarada vdr: [7765] unknown PS1 packet, substream id = 0B 
(counter is at 1)
Apr 13 09:48:11 jarada vdr: [7765] unknown PS1 packet, substream id = D6 
(counter is at 2)
Apr 13 09:48:11 jarada vdr: [7765] unknown PS1 packet, substream id = C6 
(counter is at 2)
Apr 13 09:48:11 jarada vdr: [7765] unknown PS1 packet, substream id = 5A 
(counter is at 3)
Apr 13 09:48:11 jarada vdr: [7765] unknown PS1 packet, substream id = 0B 
(counter is at 4)
Apr 13 09:48:11 jarada vdr: [7765] unknown PS1 packet, substream id = 6C 
(counter is at 4)

Wondering why the are different substream ids are reported with the same 
counter value ;-).

> 
> This additional check was suggested by Marco Schlüßler, so maybe he can 
> comment
> on this and maybe find out why this is interfering with the pre 1.3.19 Dolby 
> Digital
> detection?
> 

Stefan Lucke

___
vdr mailing list
vdr@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr

Re: [vdr] VDR 1.5.17 - pre 1.3.19 compatibility mode problems

2008-04-12 Thread Klaus Schmidinger 
On 04/09/08 08:54, Stefan Lucke wrote:
> On Wednesday 05 March 2008, Klaus Schmidinger wrote:
>> On 03/04/08 10:58, Tero Siironen wrote:
>>> Hi,
>>>
>>> I upgraded from VDR 1.4.7 to 1.5.17 and noticed that some of my old  
>>> recordings won't play decently with this new version. Here's a syslog  
>>> entry and example clip can be found from 
>>> http://kotisivu.suomi.net/izero/vdr-darwin/ddmode_example.zip 
>>>   (9MB)
>>>
>>> Those problematic recordings were done with some 1.3.x series VDR with  
>>> ttxtsubs plugin in fall 2004. Plays fine with VDR 1.4.7, but playback  
>>> stutters when playing with VDR 1.5.17. My system has DVB-C FF 2.1 and  
>>> DVB-C budget cards. Running on Fedora 5.
>> My guess would be that the offending data comes from the ttxtsubs plugin.
>> Maybe you need to patch VDR to become aware of this.
> 
> My guess is that this is introduced by vdr-1.5.11
> 
> Original vdr-1.6.0:
> Apr  9 08:29:38 jarada vdr: [7997] replay 
> /net_data/video/Extra/Enterprise_1/%1-01_Aufbruch_ins_Unbekannte_-_Teil_1/2004-01-31.19:05.99.99.rec
> Apr  9 08:29:38 jarada vdr: [7997] playing 
> '/net_data/video/Extra/Enterprise_1/%1-01_Aufbruch_ins_Unbekannte_-_Teil_1/2004-01-31.19:05.99.99.rec/001.vdr'
> Apr  9 08:29:38 jarada vdr: [7997] loading 
> /net_data/video/Extra/Enterprise_1/%1-01_Aufbruch_ins_Unbekannte_-_Teil_1/2004-01-31.19:05.99.99.rec//marks.vdr
> Apr  9 08:29:38 jarada vdr: [8019] dvbplayer thread started (pid=7997, 
> tid=8019)
> Apr  9 08:29:38 jarada vdr: [8020] non blocking file reader thread started 
> (pid=7997, tid=8020)
> Apr  9 08:29:38 jarada vdr: [8019] unknown PS1 packet, substream id = EB 
> (counter is at 0)
> Apr  9 08:29:38 jarada vdr: [8019] unknown PS1 packet, substream id = 0B 
> (counter is at 1)
> Apr  9 08:29:38 jarada vdr: [8019] unknown PS1 packet, substream id = D1 
> (counter is at 2)
> Apr  9 08:29:38 jarada vdr: [8019] unknown PS1 packet, substream id = 5D 
> (counter is at 3)
> Apr  9 08:29:38 jarada vdr: [8019] unknown PS1 packet, substream id = F0 
> (counter is at 4)
> Apr  9 08:29:38 jarada vdr: [8019] unknown PS1 packet, substream id = 7E 
> (counter is at 5)
> 
> In this case there is no sound at all :-(.
> Recording was done with vdr-1.2.1.
> 
> Plain vdr 1.6.0 with pre_1_3_19 change (from vdr-1.5.11) reverted:
> Apr  9 08:25:50 jarada vdr: [7837] replay 
> /net_data/video/Extra/Enterprise_1/%1-01_Aufbruch_ins_Unbekannte_-_Teil_1/2004-01-31.19:05.99.99.rec
> Apr  9 08:25:50 jarada vdr: [7837] playing 
> '/net_data/video/Extra/Enterprise_1/%1-01_Aufbruch_ins_Unbekannte_-_Teil_1/2004-01-31.19:05.99.99.rec/001.vdr'
> Apr  9 08:25:50 jarada vdr: [7837] loading 
> /net_data/video/Extra/Enterprise_1/%1-01_Aufbruch_ins_Unbekannte_-_Teil_1/2004-01-31.19:05.99.99.rec//marks.vdr
> Apr  9 08:25:50 jarada vdr: [7859] dvbplayer thread started (pid=7837, 
> tid=7859)
> Apr  9 08:25:50 jarada vdr: [7859] resuming replay at index 69 (0:00:02.20)
> Apr  9 08:25:50 jarada vdr: [7860] non blocking file reader thread started 
> (pid=7837, tid=7860)
> Apr  9 08:25:50 jarada vdr: [7859] SetBrokenLink: no GOP header found in 
> video packet
> Apr  9 08:25:50 jarada vdr: [7859] switching to pre 1.3.19 Dolby Digital 
> compatibility mode
> 
> Attached pach fixes this problem for me.

Your patch changed two things: the MIN_PRE_1_3_19_PRIVATESTREAM stuff, which 
merely
made detection of pre 1.3.19 Dolby Digital data more reliable, and the (Data[7] 
& 0x01)
check in "// Compatibility mode for old subtitles plugin:". I assume that the 
latter one
is what's causing your problems.

Can you please reinstate the MIN_PRE_1_3_19_PRIVATESTREAM stuff and check 
whether just
leaving out the (Data[7] & 0x01) check is enough to fix this?

This additional check was suggested by Marco Schlüßler, so maybe he can comment
on this and maybe find out why this is interfering with the pre 1.3.19 Dolby 
Digital
detection?

Klaus

___
vdr mailing list
vdr@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr

Re: [vdr] VDR 1.5.17 - pre 1.3.19 compatibility mode problems

2008-04-08 Thread Stefan Lucke 
On Wednesday 05 March 2008, Klaus Schmidinger wrote:
> On 03/04/08 10:58, Tero Siironen wrote:
> > Hi,
> > 
> > I upgraded from VDR 1.4.7 to 1.5.17 and noticed that some of my old  
> > recordings won't play decently with this new version. Here's a syslog  
> > entry and example clip can be found from 
> > http://kotisivu.suomi.net/izero/vdr-darwin/ddmode_example.zip 
> >   (9MB)
> > 
> > Those problematic recordings were done with some 1.3.x series VDR with  
> > ttxtsubs plugin in fall 2004. Plays fine with VDR 1.4.7, but playback  
> > stutters when playing with VDR 1.5.17. My system has DVB-C FF 2.1 and  
> > DVB-C budget cards. Running on Fedora 5.
> 
> My guess would be that the offending data comes from the ttxtsubs plugin.
> Maybe you need to patch VDR to become aware of this.

My guess is that this is introduced by vdr-1.5.11

Original vdr-1.6.0:
Apr  9 08:29:38 jarada vdr: [7997] replay 
/net_data/video/Extra/Enterprise_1/%1-01_Aufbruch_ins_Unbekannte_-_Teil_1/2004-01-31.19:05.99.99.rec
Apr  9 08:29:38 jarada vdr: [7997] playing 
'/net_data/video/Extra/Enterprise_1/%1-01_Aufbruch_ins_Unbekannte_-_Teil_1/2004-01-31.19:05.99.99.rec/001.vdr'
Apr  9 08:29:38 jarada vdr: [7997] loading 
/net_data/video/Extra/Enterprise_1/%1-01_Aufbruch_ins_Unbekannte_-_Teil_1/2004-01-31.19:05.99.99.rec//marks.vdr
Apr  9 08:29:38 jarada vdr: [8019] dvbplayer thread started (pid=7997, tid=8019)
Apr  9 08:29:38 jarada vdr: [8020] non blocking file reader thread started 
(pid=7997, tid=8020)
Apr  9 08:29:38 jarada vdr: [8019] unknown PS1 packet, substream id = EB 
(counter is at 0)
Apr  9 08:29:38 jarada vdr: [8019] unknown PS1 packet, substream id = 0B 
(counter is at 1)
Apr  9 08:29:38 jarada vdr: [8019] unknown PS1 packet, substream id = D1 
(counter is at 2)
Apr  9 08:29:38 jarada vdr: [8019] unknown PS1 packet, substream id = 5D 
(counter is at 3)
Apr  9 08:29:38 jarada vdr: [8019] unknown PS1 packet, substream id = F0 
(counter is at 4)
Apr  9 08:29:38 jarada vdr: [8019] unknown PS1 packet, substream id = 7E 
(counter is at 5)

In this case there is no sound at all :-(.
Recording was done with vdr-1.2.1.

Plain vdr 1.6.0 with pre_1_3_19 change (from vdr-1.5.11) reverted:
Apr  9 08:25:50 jarada vdr: [7837] replay 
/net_data/video/Extra/Enterprise_1/%1-01_Aufbruch_ins_Unbekannte_-_Teil_1/2004-01-31.19:05.99.99.rec
Apr  9 08:25:50 jarada vdr: [7837] playing 
'/net_data/video/Extra/Enterprise_1/%1-01_Aufbruch_ins_Unbekannte_-_Teil_1/2004-01-31.19:05.99.99.rec/001.vdr'
Apr  9 08:25:50 jarada vdr: [7837] loading 
/net_data/video/Extra/Enterprise_1/%1-01_Aufbruch_ins_Unbekannte_-_Teil_1/2004-01-31.19:05.99.99.rec//marks.vdr
Apr  9 08:25:50 jarada vdr: [7859] dvbplayer thread started (pid=7837, tid=7859)
Apr  9 08:25:50 jarada vdr: [7859] resuming replay at index 69 (0:00:02.20)
Apr  9 08:25:50 jarada vdr: [7860] non blocking file reader thread started 
(pid=7837, tid=7860)
Apr  9 08:25:50 jarada vdr: [7859] SetBrokenLink: no GOP header found in video 
packet
Apr  9 08:25:50 jarada vdr: [7859] switching to pre 1.3.19 Dolby Digital 
compatibility mode

Attached pach fixes this problem for me.

Just found Klaus message from 2007-10-21:
"[vdr] VDR 1.5.10, Subtitles gets out of sync":
http://www.linuxtv.org/pipermail/vdr/2007-October/014316.html

-- 
Stefan Lucke
--- device.c.orig   2007-11-03 14:30:09.0 +0100
+++ device.c2008-04-08 15:06:51.0 +0200
@@ -209,9 +209,6 @@
 // The default priority for non-primary devices:
 #define DEFAULTPRIORITY  -1
 
-// The minimum number of unknown PS1 packets to consider this a "pre 1.3.19 
private stream":
-#define MIN_PRE_1_3_19_PRIVATESTREAM 10
-
 int cDevice::numDevices = 0;
 int cDevice::useDevice = 0;
 int cDevice::nextCardIndex = 0;
@@ -934,7 +931,7 @@
 }
  else
 memset(availableTracks, 0, sizeof(availableTracks));
- pre_1_3_19_PrivateStream = 0;
+ pre_1_3_19_PrivateStream = false;
  SetAudioChannel(0); // fall back to stereo
  currentAudioTrackMissingCount = 0;
  currentAudioTrack = ttNone;
@@ -1239,7 +1236,7 @@
int PayloadOffset = Data[8] + 9;
 
// Compatibility mode for old subtitles plugin:
-   if ((Data[7] & 0x01) && (Data[PayloadOffset - 3] & 0x81) == 
0x01 && Data[PayloadOffset - 2] == 0x81)
+   if ((Data[PayloadOffset - 3] & 0x81) == 1 && Data[PayloadOffset 
- 2] == 0x81)
   PayloadOffset--;
 
uchar SubStreamId = Data[PayloadOffset];
@@ -1248,13 +1245,11 @@
 
// Compatibility mode for old VDR recordings, where 0xBD was 
only AC3:
 pre_1_3_19_PrivateStreamDeteced:
-   if (pre_1_3_19_PrivateStream > MIN_PRE_1_3_19_PRIVATESTREAM) {
+   if (pre_1_3_19_PrivateStream) {
   SubStreamId = c;
   SubStreamType = 0x80;
   SubStreamIndex = 0;
   }
-   else if (pre_1_3_19_PrivateStream)
-  pre_1_3_19_Priv

Re: [vdr] VDR 1.5.17 - pre 1.3.19 compatibility mode problems

2008-03-07 Thread Tero Siironen 

Rolf Ahrenberg kirjoitti 6.3.2008 kello 13.49:

> On Thu, 6 Mar 2008, Tero Siironen wrote:
>
>> Maybe I need to make another test run with plain versions of both VDR
>> versions when I get back to home. But anyway I have patched VDR  
>> 1.5.17
>> with vdr-1.5.17-ttxtsubs-0.0.5.diff and ttxtsubs 0.0.5 plugin is
>> patched with raastinrautaedition from 22-Jan so I think patches  
>> should
>> be ok, or is there still some more patches for ttxtsubs? 1.4.7  
>> version
>> of VDR is patched with similar patches (from that timeframe) and as I
>> said it plays the recordings (and the sample) fine.
>
> Those patches should be enough and fine, so just recheck that the
> vdr-1.5.17 patch is really integrated succesfully. If everything still
> looks ok, I'd say there's a bug in the patch. You could debug what's
> happening in the additional StripExtendedPackets function found in
> dvbplayer.c.

I installed plain versions of VDR and then ttxtsubs patched versions  
and run the tests with interesting results.

plain vdr-1.4.7 plays fine
plain vdr-1.5.17stutters
vdr-1.4.7 with ttxtsubs patches plays fine
vdr-1.5.17 with ttxtsubsstutters

So it seems that something has changed in the VDR playback so that it  
cannot play those old recordings with or without ttxtsubs patching.

I'm using TechnoTrend DVB-C FF 2.1 card with dvb-ttpci-01.fw-22623  
firmware.


-- 
Tero

___
vdr mailing list
vdr@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr

Re: [vdr] VDR 1.5.17 - pre 1.3.19 compatibility mode problems

2008-03-06 Thread Rolf Ahrenberg 
On Thu, 6 Mar 2008, Tero Siironen wrote:

> Maybe I need to make another test run with plain versions of both VDR
> versions when I get back to home. But anyway I have patched VDR 1.5.17
> with vdr-1.5.17-ttxtsubs-0.0.5.diff and ttxtsubs 0.0.5 plugin is
> patched with raastinrautaedition from 22-Jan so I think patches should
> be ok, or is there still some more patches for ttxtsubs? 1.4.7 version
> of VDR is patched with similar patches (from that timeframe) and as I
> said it plays the recordings (and the sample) fine.

Those patches should be enough and fine, so just recheck that the 
vdr-1.5.17 patch is really integrated succesfully. If everything still 
looks ok, I'd say there's a bug in the patch. You could debug what's 
happening in the additional StripExtendedPackets function found in 
dvbplayer.c.

BR,
--
rofa

___
vdr mailing list
vdr@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr

Re: [vdr] VDR 1.5.17 - pre 1.3.19 compatibility mode problems

2008-03-05 Thread Tero Siironen 

Rolf Ahrenberg kirjoitti 5.3.2008 kello 23.11:

> On Wed, 5 Mar 2008, Klaus Schmidinger wrote:
>
>> On 03/04/08 10:58, Tero Siironen wrote:
>>>
>>> Those problematic recordings were done with some 1.3.x series VDR  
>>> with
>>> ttxtsubs plugin in fall 2004. Plays fine with VDR 1.4.7, but  
>>> playback
>>> stutters when playing with VDR 1.5.17. My system has DVB-C FF 2.1  
>>> and
>>> DVB-C budget cards. Running on Fedora 5.
>>
>> My guess would be that the offending data comes from the ttxtsubs  
>> plugin.
>> Maybe you need to patch VDR to become aware of this.
>
> The ttxtsubs patch should strip off all EBU teletext data packets, so
> that they won't mess up the normal PES playback. Maybe Tero's setup is
> missing this one...

Maybe I need to make another test run with plain versions of both VDR  
versions when I get back to home. But anyway I have patched VDR 1.5.17  
with vdr-1.5.17-ttxtsubs-0.0.5.diff and ttxtsubs 0.0.5 plugin is  
patched with raastinrautaedition from 22-Jan so I think patches should  
be ok, or is there still some more patches for ttxtsubs? 1.4.7 version  
of VDR is patched with similar patches (from that timeframe) and as I  
said it plays the recordings (and the sample) fine.


-- 
Tero

___
vdr mailing list
vdr@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr

Re: [vdr] VDR 1.5.17 - pre 1.3.19 compatibility mode problems

2008-03-05 Thread Rolf Ahrenberg 
On Wed, 5 Mar 2008, Klaus Schmidinger wrote:

> On 03/04/08 10:58, Tero Siironen wrote:
>>
>> Those problematic recordings were done with some 1.3.x series VDR with
>> ttxtsubs plugin in fall 2004. Plays fine with VDR 1.4.7, but playback
>> stutters when playing with VDR 1.5.17. My system has DVB-C FF 2.1 and
>> DVB-C budget cards. Running on Fedora 5.
>
> My guess would be that the offending data comes from the ttxtsubs plugin.
> Maybe you need to patch VDR to become aware of this.

The ttxtsubs patch should strip off all EBU teletext data packets, so 
that they won't mess up the normal PES playback. Maybe Tero's setup is 
missing this one...

BR,
--
rofa

___
vdr mailing list
vdr@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr

Re: [vdr] VDR 1.5.17 - pre 1.3.19 compatibility mode problems

2008-03-05 Thread Klaus Schmidinger 
On 03/04/08 10:58, Tero Siironen wrote:
> Hi,
> 
> I upgraded from VDR 1.4.7 to 1.5.17 and noticed that some of my old  
> recordings won't play decently with this new version. Here's a syslog  
> entry and example clip can be found from 
> http://kotisivu.suomi.net/izero/vdr-darwin/ddmode_example.zip 
>   (9MB)
> 
> Those problematic recordings were done with some 1.3.x series VDR with  
> ttxtsubs plugin in fall 2004. Plays fine with VDR 1.4.7, but playback  
> stutters when playing with VDR 1.5.17. My system has DVB-C FF 2.1 and  
> DVB-C budget cards. Running on Fedora 5.

My guess would be that the offending data comes from the ttxtsubs plugin.
Maybe you need to patch VDR to become aware of this.

Klaus

___
vdr mailing list
vdr@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr