On Thu, Oct 18, 2012 at 02:12:58AM -0400, lvro...@linux.vnet.ibm.com wrote: > Royce Lv has posted comments on this change. > > Change subject: schema: New type VmParameters > ...................................................................... > > > Patch Set 4: > > Adam, > I saw 3 kinds of vm related description spread in the code: > > (1)vm.conf: query via vm.status()(vm.py), used as return value when changed > vm's conf(changeCD, hotplugDisk) > > (2)vm.stats: query via vm.getStats()(vm.py), which is VM's live stats and > used when calling getVmStats.(also used by MOM) > > (3)vm.parameter: parameter passed to vm.create().(API.py) > > You are trying to split is (3) from (1); But the live info should be (2) from > (1) according to me.
To me, VmDefinition contains the hardware properties of the VM (things like devices, amount of memory, number of cpus). It also contains things that can only be known at runtime (VNC display port, device bus information (if not specified in advance), current cdrom disk, etc). VmStatistics are different because they are measured (network activity, cpu usage, etc). VmParameters is like a streamlined VmDefinition where we remove items that cannot be specified at create time. > -- > To view, visit http://gerrit.ovirt.org/7839 > To unsubscribe, visit http://gerrit.ovirt.org/settings > > Gerrit-MessageType: comment > Gerrit-Change-Id: I00d1b9aed55cbfc2210c1a4091bce17d45b90e67 > Gerrit-PatchSet: 4 > Gerrit-Project: vdsm > Gerrit-Branch: master > Gerrit-Owner: Adam Litke <a...@us.ibm.com> > Gerrit-Reviewer: Adam Litke <a...@us.ibm.com> > Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> > Gerrit-Reviewer: Royce Lv <lvro...@linux.vnet.ibm.com> > Gerrit-Reviewer: Saggi Mizrahi <smizr...@redhat.com> > -- Adam Litke <a...@us.ibm.com> IBM Linux Technology Center _______________________________________________ vdsm-devel mailing list vdsm-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-devel
