Re: [vdsm] SSLError with vdsm
On 2012-06-07 13:51, Zhou Zheng Sheng wrote: Hi, It is because normal user do not have the privilege to access the keys in /etc/pki/vdsm/keys/ and certificates in /etc/pki/vdsm/certs/. You can su to root or sudo vdsClient to use SSL connection. 于 2012年06月07日 13:03, Wenyi Gao 写道: Hi guys, When I ran the cmmand vdsClient -s 0 getVdsCaps, I got the following error: $ vdsClient -s 0 getVdsCaps Traceback (most recent call last): File /usr/share/vdsm/vdsClient.py, line 2275, in module code, message = commands[command][0](commandArgs) File /usr/share/vdsm/vdsClient.py, line 403, in do_getCap return self.ExecAndExit(self.s.getVdsCapabilities()) File /usr/lib64/python2.7/xmlrpclib.py, line 1224, in __call__ return self.__send(self.__name, args) File /usr/lib64/python2.7/xmlrpclib.py, line 1578, in __request verbose=self.__verbose File /usr/lib64/python2.7/xmlrpclib.py, line 1264, in request return self.single_request(host, handler, request_body, verbose) File /usr/lib64/python2.7/xmlrpclib.py, line 1292, in single_request self.send_content(h, request_body) File /usr/lib64/python2.7/xmlrpclib.py, line 1439, in send_content connection.endheaders(request_body) File /usr/lib64/python2.7/httplib.py, line 954, in endheaders self._send_output(message_body) File /usr/lib64/python2.7/httplib.py, line 814, in _send_output self.send(msg) File /usr/lib64/python2.7/httplib.py, line 776, in send self.connect() File /usr/lib/python2.7/site-packages/vdsm/SecureXMLRPCServer.py, line 98, in connect cert_reqs=self.cert_reqs) File /usr/lib64/python2.7/ssl.py, line 381, in wrap_socket ciphers=ciphers) File /usr/lib64/python2.7/ssl.py, line 141, in __init__ ciphers) SSLError: [Errno 185090050] _ssl.c:340: error:0B084002:x509 certificate routines:X509_load_cert_crl_file:system lib But if I set ssl = false in /etc/vdsm/vdsm.conf, then run vdsClient 0 getVdsCaps, the problem goes away. Does anyone know what causes the problem above? Thanks. Wenyi Gao ___ vdsm-devel mailing list vdsm-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-devel -- Thanks and best regards! Zhou Zheng Sheng / 周征晟 E-mail:zhshz...@linux.vnet.ibm.com Telephone: 86-10-82454397 ___ vdsm-devel mailing list vdsm-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-devel Yes, it works. Thanks. Wenyi Gao ___ vdsm-devel mailing list vdsm-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-devel
[vdsm] Request for code review
Hi guys: My patch Move vdsmd.init to vdsm-tool is ready for review. http://gerrit.ovirt.org/#/c/4738/ I am looking forward to your comments. Thanks. Wenyi Gao ___ vdsm-devel mailing list vdsm-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-devel
Re: [vdsm] A Tool for PEP 8 Patches to Find Code Logic Changes
I haven't used the tool yet, but saw your mail with the examples. I think its a very nice tool and very helpful. Why don't you submit this tool to python project itself ? It think it deserves it. ___ vdsm-devel mailing list vdsm-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-devel
Re: [vdsm] A Tool for PEP 8 Patches to Find Code Logic Changes
On Thu, Jun 07, 2012 at 12:03:30PM +0800, Zhou Zheng Sheng wrote:
Hi,
Since there is no coverage report on tests in vdsm, if a PEP 8 patch
passes the tests, we still not sure if there is no mistake in it.
Viewing the diff reports on all the changes consumes a lot of time, and
some small but fatal mistakes(like misspelling variable name) can easily
be ignored by human eyes.
So I have a try on the compiler module of Python. I write a tool named
'pydiff'. pydiff parses two Python scripts into Abstract Syntax Trees.
These data structures can reflect the logic of the code, and pydiff
performs a recursive compare on the trees. Then pydiff reports
differences and the corresponding line numbers. In this way, pydiff
ignores code style changes, and reports only logical changes of the code.
I think this tool can save us a lot of time. After a PEP 8 patch passes
vdsm tests and pydiff, I will get some confidence on the patch and it
probably does not break anything in vdsm.
This is a very nice tool. Thanks for sharing it. I would like to see all
authors of PEP8 patches use this to check their patches for semantic
correctness. This should greatly improve our ability to complete the PEP8
cleanup quickly.
Here is a usage example:
test_o.py
def foo(a, b):
pass
if __name__ == '__main__':
A = [1, 2, 3]
print (4, 5, 6), \
over
foo(1, 2)
print 'Hello World'
test_n.py
def foo(a, b):
pass
if __name__ == '__main__':
A = [1,
2, 3]
print (4, 5, 6), over
fooo(
1, 2)
print ('Hello '
'World')
Some differences of the files are just a matter of style. The only
significant difference is the function call foo() is misspelled in
test_n.py.
Run pydiff.py, it will report:
$ python pydiff.py test_*.py
1 difference(s)
first file: test_n.py
second file: test_o.py
((8, 'fooo'), (8, 'foo'))
This report tells us that 'fooo' in line 8 of test_n.py is different
from 'foo' in line 8 of test_o.py.
It can also find insertions or deletions. Here is another simple example:
old.py
print 'Hello 1'
print 'Hello 2'
print 'Hello 3'
print 'Hello 4'
print 'Hello 5'
new.py
print 'Hello 1'
print 'Hello 3'
print 'Hello 4'
print 'Hello 5'
print 'Hello 5'
Run pydiff:
$ pydiff old.py new.py
2 difference(s)
first file: old.py
second file: new.py
((2, Printnl([Const('Hello 2')], None)), (2, None))
((5, None), (5, Printnl([Const('Hello 5')], None)))
Here ((2, Printnl([Const('Hello 2')], None)), (2, None)) means there
is a print statement in line 2 of old.py, but no corresponding statement
in new.py, so we can know the statement is deleted in new.py.
((5, None), (5, Printnl([Const('Hello 5')], None))) means there is a
print statement in line 5 of new.py, but no corresponding statement in
old.py, so we can know the statement is inserted in new.py.
Sometimes the change in code logic is acceptable, for example, change
aDict.has_key(Key) into Key in aDict. pydiff can report a difference
in this case, but it is up to the user to judge whether it's acceptable.
pydiff is just a tool to help you finding these changes.
I hope it can be helpful for PEP 8 patch reviewers. If you find any
bugs, please let me know. The script is in the attachment.
--
Thanks and best regards!
Zhou Zheng Sheng / 周征晟
E-mail: zhshz...@linux.vnet.ibm.com
Telephone: 86-10-82454397
___
vdsm-devel mailing list
vdsm-devel@lists.fedorahosted.org
https://fedorahosted.org/mailman/listinfo/vdsm-devel
--
Adam Litke a...@us.ibm.com
IBM Linux Technology Center
___
vdsm-devel mailing list
vdsm-devel@lists.fedorahosted.org
https://fedorahosted.org/mailman/listinfo/vdsm-devel
[vdsm] Help please! -- [postmas...@us.ibm.com: Delivery Status Notification (Failure)]
Hi. Recently my mails to vdsm-devel have started bouncing. I think this was caused by a temporary misconfiguration of my local mail setup that resulted in my email appearing as 'agli...@us.ibm.com'. Could someone please verify that my list membership is still configured with the proper email address 'a...@us.ibm.com'? Thanks a lot and sorry for causing trouble! :) - Forwarded message from e33.co.us.ibm.com PostMaster postmas...@us.ibm.com - Date: Wed, 6 Jun 2012 15:33:12 -0600 From: e33.co.us.ibm.com PostMaster postmas...@us.ibm.com To: a...@us.ibm.com Subject: Delivery Status Notification (Failure) X-MailerServer: XMail 1.27mod32-ISS X-MailerError: Message = [1339018392162.92bffba0.49b4.2825d.e33] Server = [e33.co.us.ibm.com] [00] XMail bounce: Rcpt=[vdsm-devel@lists.fedorahosted.org];Error=[550 5.1.1 vdsm-devel@lists.fedorahosted.org: Recipient address rejected: User unknown in local recipient table] [01] Error sending message [1339018392162.92bffba0.49b4.2825d.e33] from [e33.co.us.ibm.com]. ID:12060621-2398---0746823F Mail From: a...@us.ibm.com Rcpt To: vdsm-devel@lists.fedorahosted.org Server:[hosted03.fedoraproject.org.] [02] The reason of the delivery failure was: 550 5.1.1 vdsm-devel@lists.fedorahosted.org: Recipient address rejected: User unknown in local recipient table [05] Here is listed the initial part of the message: Received: from /spool/local by e33.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for vdsm-devel@lists.fedorahosted.org from a...@us.ibm.com; Wed, 6 Jun 2012 15:33:12 -0600 Received: from d03dlp02.boulder.ibm.com (9.17.202.178) by e33.co.us.ibm.com (192.168.1.133) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Wed, 6 Jun 2012 15:33:10 -0600 Received: from d03relay03.boulder.ibm.com (d03relay03.boulder.ibm.com [9.17.195.228]) by d03dlp02.boulder.ibm.com (Postfix) with ESMTP id E4C9F3E4004C for vdsm-devel@lists.fedorahosted.org; Wed, 6 Jun 2012 21:33:08 + (WET) Received: from d03av05.boulder.ibm.com (d03av05.boulder.ibm.com [9.17.195.85]) by d03relay03.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q56LX2Fe134162 for vdsm-devel@lists.fedorahosted.org; Wed, 6 Jun 2012 15:33:05 -0600 Received: from d03av05.boulder.ibm.com (loopback [127.0.0.1]) by d03av05.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q56LX0DP010799 for vdsm-devel@lists.fedorahosted.org; Wed, 6 Jun 2012 15:33:01 -0600 Received: from us.ibm.com (sig-9-76-23-222.mts.ibm.com [9.76.23.222]) by d03av05.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with SMTP id q56LWviG010656; Wed, 6 Jun 2012 15:32:58 -0600 Received: by us.ibm.com (sSMTP sendmail emulation); Wed, 6 Jun 2012 16:32:57 -0500 From: Adam Litke a...@us.ibm.com Date: Wed, 6 Jun 2012 16:32:57 -0500 To: Rodrigo Trujillo rodrigo.truji...@linux.vnet.ibm.com Cc: vdsm-devel@lists.fedorahosted.org Subject: Re: [vdsm] About xmlrpc an rest api Message-ID: 20120606213257.GU2671@localhost.localdomain References: 4fcfab74.8030...@linux.vnet.ibm.com MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: 4fcfab74.8030...@linux.vnet.ibm.com User-Agent: Mutt/1.5.21 (2010-09-15) X-Content-Scanned: Fidelis XPS MAILER x-cbid: 12060621-2398---0746823F On Wed, Jun 06, 2012 at 04:11:48PM -0300, Rodrigo Trujillo wrote: Hi, I have researched about the VDSM APIs, but was not clear to me how to use them. Where can I find documentation about them and how to use with python ? I wrote this python script (with help from this list) to create a VM using the xmlrpc interface. It is not trivial (as you will see). I am certain that you will need to modify this to get it working in your environment. In the future, we hope to make this far easier to do. We want to save you from needing to do the storage manipulations. Also, a REST API should organize the API much better than the xmlrpc (which was never meant to be friendly to end users). #!/usr/bin/python import sys import uuid import time - End forwarded message - -- Adam Litke a...@us.ibm.com IBM Linux Technology Center ___ vdsm-devel mailing list vdsm-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-devel
Re: [vdsm] Help please! -- [postmas...@us.ibm.com: Delivery Status Notification (Failure)]
On 06/07/2012 05:07 PM, Adam Litke wrote: Hi. Recently my mails to vdsm-devel have started bouncing. I think this was caused by a temporary misconfiguration of my local mail setup that resulted in my email appearing as 'agli...@us.ibm.com'. Could someone please verify that my list membership is still configured with the proper email address 'a...@us.ibm.com'? Thanks a lot and sorry for causing trouble! :) I think you just got this like other people who replied to that email. i.e., it's from your mail server, not from the mailing list - Forwarded message from e33.co.us.ibm.com PostMasterpostmas...@us.ibm.com - Date: Wed, 6 Jun 2012 15:33:12 -0600 From: e33.co.us.ibm.com PostMasterpostmas...@us.ibm.com To: a...@us.ibm.com Subject: Delivery Status Notification (Failure) X-MailerServer: XMail 1.27mod32-ISS X-MailerError: Message = [1339018392162.92bffba0.49b4.2825d.e33] Server = [e33.co.us.ibm.com] [00] XMail bounce: Rcpt=[vdsm-devel@lists.fedorahosted.org];Error=[550 5.1.1vdsm-devel@lists.fedorahosted.org: Recipient address rejected: User unknown in local recipient table] [01] Error sending message [1339018392162.92bffba0.49b4.2825d.e33] from [e33.co.us.ibm.com]. ID:12060621-2398---0746823F Mail From:a...@us.ibm.com Rcpt To:vdsm-devel@lists.fedorahosted.org Server:[hosted03.fedoraproject.org.] [02] The reason of the delivery failure was: 550 5.1.1vdsm-devel@lists.fedorahosted.org: Recipient address rejected: User unknown in local recipient table [05] Here is listed the initial part of the message: Received: from /spool/local by e33.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted forvdsm-devel@lists.fedorahosted.org froma...@us.ibm.com; Wed, 6 Jun 2012 15:33:12 -0600 Received: from d03dlp02.boulder.ibm.com (9.17.202.178) by e33.co.us.ibm.com (192.168.1.133) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Wed, 6 Jun 2012 15:33:10 -0600 Received: from d03relay03.boulder.ibm.com (d03relay03.boulder.ibm.com [9.17.195.228]) by d03dlp02.boulder.ibm.com (Postfix) with ESMTP id E4C9F3E4004C forvdsm-devel@lists.fedorahosted.org; Wed, 6 Jun 2012 21:33:08 + (WET) Received: from d03av05.boulder.ibm.com (d03av05.boulder.ibm.com [9.17.195.85]) by d03relay03.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q56LX2Fe134162 forvdsm-devel@lists.fedorahosted.org; Wed, 6 Jun 2012 15:33:05 -0600 Received: from d03av05.boulder.ibm.com (loopback [127.0.0.1]) by d03av05.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q56LX0DP010799 forvdsm-devel@lists.fedorahosted.org; Wed, 6 Jun 2012 15:33:01 -0600 Received: from us.ibm.com (sig-9-76-23-222.mts.ibm.com [9.76.23.222]) by d03av05.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with SMTP id q56LWviG010656; Wed, 6 Jun 2012 15:32:58 -0600 Received: by us.ibm.com (sSMTP sendmail emulation); Wed, 6 Jun 2012 16:32:57 -0500 From: Adam Litkea...@us.ibm.com Date: Wed, 6 Jun 2012 16:32:57 -0500 To: Rodrigo Trujillorodrigo.truji...@linux.vnet.ibm.com Cc: vdsm-devel@lists.fedorahosted.org Subject: Re: [vdsm] About xmlrpc an rest api Message-ID:20120606213257.GU2671@localhost.localdomain References:4fcfab74.8030...@linux.vnet.ibm.com MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To:4fcfab74.8030...@linux.vnet.ibm.com User-Agent: Mutt/1.5.21 (2010-09-15) X-Content-Scanned: Fidelis XPS MAILER x-cbid: 12060621-2398---0746823F On Wed, Jun 06, 2012 at 04:11:48PM -0300, Rodrigo Trujillo wrote: Hi, I have researched about the VDSM APIs, but was not clear to me how to use them. Where can I find documentation about them and how to use with python ? I wrote this python script (with help from this list) to create a VM using the xmlrpc interface. It is not trivial (as you will see). I am certain that you will need to modify this to get it working in your environment. In the future, we hope to make this far easier to do. We want to save you from needing to do the storage manipulations. Also, a REST API should organize the API much better than the xmlrpc (which was never meant to be friendly to end users). #!/usr/bin/python import sys import uuid import time - End forwarded message - ___ vdsm-devel mailing list vdsm-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-devel
Re: [vdsm] Help please! -- [postmas...@us.ibm.com: Delivery Status Notification (Failure)]
On Thu, Jun 07, 2012 at 05:33:04PM +0300, Itamar Heim wrote: On 06/07/2012 05:07 PM, Adam Litke wrote: Hi. Recently my mails to vdsm-devel have started bouncing. I think this was caused by a temporary misconfiguration of my local mail setup that resulted in my email appearing as 'agli...@us.ibm.com'. Could someone please verify that my list membership is still configured with the proper email address 'a...@us.ibm.com'? Thanks a lot and sorry for causing trouble! :) I think you just got this like other people who replied to that email. i.e., it's from your mail server, not from the mailing list Hmm, ok. It seems that the mail is flowing now and is arriving at the list. Also this reply has worked. Hope all is okay now then. - Forwarded message from e33.co.us.ibm.com PostMasterpostmas...@us.ibm.com - Date: Wed, 6 Jun 2012 15:33:12 -0600 From: e33.co.us.ibm.com PostMasterpostmas...@us.ibm.com To: a...@us.ibm.com Subject: Delivery Status Notification (Failure) X-MailerServer: XMail 1.27mod32-ISS X-MailerError: Message = [1339018392162.92bffba0.49b4.2825d.e33] Server = [e33.co.us.ibm.com] [00] XMail bounce: Rcpt=[vdsm-devel@lists.fedorahosted.org];Error=[550 5.1.1vdsm-devel@lists.fedorahosted.org: Recipient address rejected: User unknown in local recipient table] [01] Error sending message [1339018392162.92bffba0.49b4.2825d.e33] from [e33.co.us.ibm.com]. ID:12060621-2398---0746823F Mail From:a...@us.ibm.com Rcpt To:vdsm-devel@lists.fedorahosted.org Server:[hosted03.fedoraproject.org.] [02] The reason of the delivery failure was: 550 5.1.1vdsm-devel@lists.fedorahosted.org: Recipient address rejected: User unknown in local recipient table [05] Here is listed the initial part of the message: Received: from /spool/local by e33.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted forvdsm-devel@lists.fedorahosted.org froma...@us.ibm.com; Wed, 6 Jun 2012 15:33:12 -0600 Received: from d03dlp02.boulder.ibm.com (9.17.202.178) by e33.co.us.ibm.com (192.168.1.133) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Wed, 6 Jun 2012 15:33:10 -0600 Received: from d03relay03.boulder.ibm.com (d03relay03.boulder.ibm.com [9.17.195.228]) by d03dlp02.boulder.ibm.com (Postfix) with ESMTP id E4C9F3E4004C forvdsm-devel@lists.fedorahosted.org; Wed, 6 Jun 2012 21:33:08 + (WET) Received: from d03av05.boulder.ibm.com (d03av05.boulder.ibm.com [9.17.195.85]) by d03relay03.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q56LX2Fe134162 forvdsm-devel@lists.fedorahosted.org; Wed, 6 Jun 2012 15:33:05 -0600 Received: from d03av05.boulder.ibm.com (loopback [127.0.0.1]) by d03av05.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q56LX0DP010799 forvdsm-devel@lists.fedorahosted.org; Wed, 6 Jun 2012 15:33:01 -0600 Received: from us.ibm.com (sig-9-76-23-222.mts.ibm.com [9.76.23.222]) by d03av05.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with SMTP id q56LWviG010656; Wed, 6 Jun 2012 15:32:58 -0600 Received: by us.ibm.com (sSMTP sendmail emulation); Wed, 6 Jun 2012 16:32:57 -0500 From: Adam Litkea...@us.ibm.com Date: Wed, 6 Jun 2012 16:32:57 -0500 To: Rodrigo Trujillorodrigo.truji...@linux.vnet.ibm.com Cc: vdsm-devel@lists.fedorahosted.org Subject: Re: [vdsm] About xmlrpc an rest api Message-ID:20120606213257.GU2671@localhost.localdomain References:4fcfab74.8030...@linux.vnet.ibm.com MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To:4fcfab74.8030...@linux.vnet.ibm.com User-Agent: Mutt/1.5.21 (2010-09-15) X-Content-Scanned: Fidelis XPS MAILER x-cbid: 12060621-2398---0746823F On Wed, Jun 06, 2012 at 04:11:48PM -0300, Rodrigo Trujillo wrote: Hi, I have researched about the VDSM APIs, but was not clear to me how to use them. Where can I find documentation about them and how to use with python ? I wrote this python script (with help from this list) to create a VM using the xmlrpc interface. It is not trivial (as you will see). I am certain that you will need to modify this to get it working in your environment. In the future, we hope to make this far easier to do. We want to save you from needing to do the storage manipulations. Also, a REST API should organize the API much better than the xmlrpc (which was never meant to be friendly to end users). #!/usr/bin/python import sys import uuid import time - End forwarded message - -- Adam Litke a...@us.ibm.com IBM Linux Technology Center ___ vdsm-devel mailing list vdsm-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-devel
Re: [vdsm] SSLError with vdsm
On Thu, Jun 07, 2012 at 05:35:54PM +0300, Itamar Heim wrote: On 06/07/2012 09:58 AM, Wenyi Gao wrote: On 2012-06-07 13:51, Zhou Zheng Sheng wrote: Hi, It is because normal user do not have the privilege to access the keys in /etc/pki/vdsm/keys/ and certificates in /etc/pki/vdsm/certs/. You can su to root or sudo vdsClient to use SSL connection. 于 2012年06月07日 13:03, Wenyi Gao 写道: Hi guys, When I ran the cmmand vdsClient -s 0 getVdsCaps, I got the following error: $ vdsClient -s 0 getVdsCaps Traceback (most recent call last): File /usr/share/vdsm/vdsClient.py, line 2275, in module code, message = commands[command][0](commandArgs) File /usr/share/vdsm/vdsClient.py, line 403, in do_getCap return self.ExecAndExit(self.s.getVdsCapabilities()) File /usr/lib64/python2.7/xmlrpclib.py, line 1224, in __call__ return self.__send(self.__name, args) File /usr/lib64/python2.7/xmlrpclib.py, line 1578, in __request verbose=self.__verbose File /usr/lib64/python2.7/xmlrpclib.py, line 1264, in request return self.single_request(host, handler, request_body, verbose) File /usr/lib64/python2.7/xmlrpclib.py, line 1292, in single_request self.send_content(h, request_body) File /usr/lib64/python2.7/xmlrpclib.py, line 1439, in send_content connection.endheaders(request_body) File /usr/lib64/python2.7/httplib.py, line 954, in endheaders self._send_output(message_body) File /usr/lib64/python2.7/httplib.py, line 814, in _send_output self.send(msg) File /usr/lib64/python2.7/httplib.py, line 776, in send self.connect() File /usr/lib/python2.7/site-packages/vdsm/SecureXMLRPCServer.py, line 98, in connect cert_reqs=self.cert_reqs) File /usr/lib64/python2.7/ssl.py, line 381, in wrap_socket ciphers=ciphers) File /usr/lib64/python2.7/ssl.py, line 141, in __init__ ciphers) SSLError: [Errno 185090050] _ssl.c:340: error:0B084002:x509 certificate routines:X509_load_cert_crl_file:system lib But if I set ssl = false in /etc/vdsm/vdsm.conf, then run vdsClient 0 getVdsCaps, the problem goes away. Does anyone know what causes the problem above? Thanks. Wenyi Gao ___ vdsm-devel mailing list vdsm-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-devel -- Thanks and best regards! Zhou Zheng Sheng / 周征晟 E-mail:zhshz...@linux.vnet.ibm.com Telephone: 86-10-82454397 ___ vdsm-devel mailing list vdsm-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-devel Yes, it works. Thanks. maybe send a patch to check the permissions and give a proper error message for the next user failing on this? +1. Great suggestion! -- Adam Litke a...@us.ibm.com IBM Linux Technology Center ___ vdsm-devel mailing list vdsm-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-devel
Re: [vdsm] A Tool for PEP 8 Patches to Find Code Logic Changes
On 2012-6-7 21:26, Adam Litke wrote:
On Thu, Jun 07, 2012 at 12:03:30PM +0800, Zhou Zheng Sheng wrote:
Hi,
Since there is no coverage report on tests in vdsm, if a PEP 8 patch
passes the tests, we still not sure if there is no mistake in it.
Viewing the diff reports on all the changes consumes a lot of time, and
some small but fatal mistakes(like misspelling variable name) can easily
be ignored by human eyes.
So I have a try on the compiler module of Python. I write a tool named
'pydiff'. pydiff parses two Python scripts into Abstract Syntax Trees.
These data structures can reflect the logic of the code, and pydiff
performs a recursive compare on the trees. Then pydiff reports
differences and the corresponding line numbers. In this way, pydiff
ignores code style changes, and reports only logical changes of the code.
I think this tool can save us a lot of time. After a PEP 8 patch passes
vdsm tests and pydiff, I will get some confidence on the patch and it
probably does not break anything in vdsm.
This is a very nice tool. Thanks for sharing it. I would like to see all
authors of PEP8 patches use this to check their patches for semantic
correctness. This should greatly improve our ability to complete the PEP8
cleanup quickly.
Yes, I agree with you. Also, we should merge this tool into vdsm as a
helper for PEP8 clean work.
Here is a usage example:
test_o.py
def foo(a, b):
pass
if __name__ == '__main__':
A = [1, 2, 3]
print (4, 5, 6), \
over
foo(1, 2)
print 'Hello World'
test_n.py
def foo(a, b):
pass
if __name__ == '__main__':
A = [1,
2, 3]
print (4, 5, 6), over
fooo(
1, 2)
print ('Hello '
'World')
Some differences of the files are just a matter of style. The only
significant difference is the function call foo() is misspelled in
test_n.py.
Run pydiff.py, it will report:
$ python pydiff.py test_*.py
1 difference(s)
first file: test_n.py
second file: test_o.py
((8, 'fooo'), (8, 'foo'))
This report tells us that 'fooo' in line 8 of test_n.py is different
from 'foo' in line 8 of test_o.py.
It can also find insertions or deletions. Here is another simple example:
old.py
print 'Hello 1'
print 'Hello 2'
print 'Hello 3'
print 'Hello 4'
print 'Hello 5'
new.py
print 'Hello 1'
print 'Hello 3'
print 'Hello 4'
print 'Hello 5'
print 'Hello 5'
Run pydiff:
$ pydiff old.py new.py
2 difference(s)
first file: old.py
second file: new.py
((2, Printnl([Const('Hello 2')], None)), (2, None))
((5, None), (5, Printnl([Const('Hello 5')], None)))
Here ((2, Printnl([Const('Hello 2')], None)), (2, None)) means there
is a print statement in line 2 of old.py, but no corresponding statement
in new.py, so we can know the statement is deleted in new.py.
((5, None), (5, Printnl([Const('Hello 5')], None))) means there is a
print statement in line 5 of new.py, but no corresponding statement in
old.py, so we can know the statement is inserted in new.py.
Sometimes the change in code logic is acceptable, for example, change
aDict.has_key(Key) into Key in aDict. pydiff can report a difference
in this case, but it is up to the user to judge whether it's acceptable.
pydiff is just a tool to help you finding these changes.
I hope it can be helpful for PEP 8 patch reviewers. If you find any
bugs, please let me know. The script is in the attachment.
--
Thanks and best regards!
Zhou Zheng Sheng / 周征晟
E-mail: zhshz...@linux.vnet.ibm.com
Telephone: 86-10-82454397
___
vdsm-devel mailing list
vdsm-devel@lists.fedorahosted.org
https://fedorahosted.org/mailman/listinfo/vdsm-devel
--
Shu Mingshum...@linux.vnet.ibm.com
IBM China Systems and Technology Laboratory
___
vdsm-devel mailing list
vdsm-devel@lists.fedorahosted.org
https://fedorahosted.org/mailman/listinfo/vdsm-devel
Re: [vdsm] vdsm event loop issue
Done
2012/6/7 Anthony Liguori anth...@codemonkey.ws
On 06/07/2012 10:53 AM, Royce Lv wrote:
Thread eventloop:
poll.poll(timeout)
vdsm mainThread:
os.setgroups/os.setuid/os.**setgid,etc
eventloop will receive EINTR and stops, events callback can't be
reacted from then on.Libvirt/vdsm connection's keepalive message also
count
on this event loop, setuid/setgroups/etc will cause libvirt will close
connection to vdsm because of loosing keepalive message.
This make libvirt/vdsm connection vulnerable to some system calls
like(setgroups,setuids,etc)
While Libvirt's default eventloop API handled EINTR without causing
this problem.
retry:
ret = poll(fds, nfds, timeout);
if (ret 0) {
EVENT_DEBUG(Poll got error event %d, errno);
if (errno == EINTR) {
goto retry;
}
Based on this please see
change:http://gerrit.ovirt.**org/#/c/5113/http://gerrit.ovirt.org/#/c/5113/
I don't think your change is correct. You catch the exception around
run_once() but run once sets self.runningPoll = true at the beginning and
self.runningPoll = false at the end. If self.poll.poll() throws an
exception, you'll leave self.runningPoll = true when you probably need to
clear it to false.
I'd suggest moving the exception handling to the run_once() function so
you can explicitly clean up the state before returning.
Regards,
Anthony Liguori
__**_
vdsm-devel mailing list
vdsm-devel@lists.fedorahosted.**org vdsm-devel@lists.fedorahosted.org
https://fedorahosted.org/**mailman/listinfo/vdsm-develhttps://fedorahosted.org/mailman/listinfo/vdsm-devel
___
vdsm-devel mailing list
vdsm-devel@lists.fedorahosted.org
https://fedorahosted.org/mailman/listinfo/vdsm-devel
[vdsm] About the pep8cleaning topic branch
Hi, I am working on pep8cleaning topic branch and include twelve different files in the first batch of topic branch merging into the upstream. And I found the most challenging job was to keep the topic branch synced with the latest master head, especially PEP8 clean can change a file across all the lines of the file. So I am really hoping to narrow the time window of merging the topic branch into master. So I really appreciate that more people can help to review these patches and approve the patches. -- Shu Mingshum...@linux.vnet.ibm.com IBM China Systems and Technology Laboratory ___ vdsm-devel mailing list vdsm-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-devel
