Re: [vdsm] Patch review process
- Original Message - From: Ryan Harper ry...@us.ibm.com To: Alon Bar-Lev alo...@redhat.com Cc: Ryan Harper ry...@us.ibm.com, Ryan Harper ry...@linux.vnet.ibm.com, Anthony Liguori aligu...@linux.vnet.ibm.com, vdsm-devel@lists.fedorahosted.org, Adam Litke a...@us.ibm.com Sent: Monday, September 10, 2012 9:41:14 PM Subject: Re: [vdsm] Patch review process * Alon Bar-Lev alo...@redhat.com [2012-09-10 12:44]: - Original Message - From: Ryan Harper ry...@us.ibm.com To: Alon Bar-Lev alo...@redhat.com Cc: Ryan Harper ry...@us.ibm.com, Ryan Harper ry...@linux.vnet.ibm.com, Anthony Liguori aligu...@linux.vnet.ibm.com, vdsm-devel@lists.fedorahosted.org, Adam Litke a...@us.ibm.com Sent: Monday, September 10, 2012 8:33:53 PM Subject: Re: [vdsm] Patch review process * Alon Bar-Lev alo...@redhat.com [2012-09-10 12:22]: - Original Message - From: Ryan Harper ry...@us.ibm.com To: Adam Litke a...@us.ibm.com Cc: Ryan Harper ry...@linux.vnet.ibm.com, Anthony Liguori aligu...@linux.vnet.ibm.com, vdsm-devel@lists.fedorahosted.org Sent: Monday, September 10, 2012 7:07:56 PM Subject: Re: [vdsm] Patch review process * Adam Litke a...@us.ibm.com [2012-09-09 12:29]: snip I'm certainly willing to review any patches that show up on the mailing list directly, so if folks want to submit patches first for review before pushing into gerrit; I'm quite happy with reviewing those. Why won't you subscribe to vdsm-patches[1] and comment within gerrit? I am subscribed. Commenting within gerrit is much slower for myself. I'm always in my email client, so sending an email back involves far less work for myself and I don't have to write lots of words in a small text box without a proper text editor. Gerrit comment workflow: 1) follow link from vdsm-patches email to gerrit patch in browser 2) sign-in via openid 3) find which patch file I want to comment upon 4) select the line I want to comment upon to bring up text widget 5) write up comment in a browswer gui box without any support from text editor 6) repeat (3-5) if there are multiple files touched 7) go back to top 8) hit publish Email comment workflow after we know have inline patches. 1) Reply to email 2) find lines in email for comments 3) write up responses in editor 4) close file and mail. This method is superior as the past/present/future comments and review I disagree here. process is managed within productivity application, from birth to merge or death. Much like an email thread with inline patches that's archived for everyone to read and review. Each comment within gerrit is going to the list as if sent directly to the mailing list, so you can track the activity. What's the point of going to the list if not to be able to respond to email? You see the benefit of you as a reviewer, while there are other reviewers (past and future, members and guests) and there is the patch owner. While it may indeed be easier for you to just send a message, for the other people who are involved in the process it may not be as productive as managing the discussion within productivity application which supports the process quite well. Sure; There is a fixed set of folks who already have been working with gerrit for some time and I'm sure are quite comfortable with the process. Part of opening the community up is figuring out how best to attract and maintain additional developers. When growing a community, reducing the barrier for entry is a must. I'll posit that if contributions to gerrit-based communities require the additional openid, web-based commented/editing, some-what undocumented process for obtain review and approval then we're not going to see tremendous growth given the additional overhead of working with gerrit as a contributor. Only recently did we get gerrit to push the code out after submission, meaning that if someone wanted to lurk and read the code, it was always through the web-based viewing; some comments showup on the page of the changeset, the other in-line comments are only available if you know which file the comment was made against. All comments go to the vdsm-patches, but this is a one-way avenue; you don't see discussion happening in response; and if you want to reply, you have to sign-in to gerrit and hunt down the right file. None of this is *bad*; it's just different. Any one of these extra steps could be the excuse that keeps developers from participating. It is not that gerrit is perfect, it is far from being perfect, however has advantages over plain list. I'd really like to hear what advantage
Re: [vdsm] [Engine-devel] is gerrit.ovirt.org down? eom
It seems gerrit has downed for several times recently. Is there any special reason? 于 2012-9-12 22:45, Alon Bar-Lev: yes. - Original Message - From: Shireesh Anjal san...@redhat.com To: engine-de...@ovirt.org Sent: Wednesday, September 12, 2012 5:43:35 PM Subject: [Engine-devel] is gerrit.ovirt.org down? eom ___ Engine-devel mailing list engine-de...@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ Engine-devel mailing list engine-de...@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel -- --- 舒明 Shu Ming Open Virtualization Engineerning; CSTL, IBM Corp. Tel: 86-10-82451626 Tieline: 9051626 E-mail: shum...@cn.ibm.com or shum...@linux.vnet.ibm.com Address: 3/F Ring Building, ZhongGuanCun Software Park, Haidian District, Beijing 100193, PRC ___ vdsm-devel mailing list vdsm-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-devel
Re: [vdsm] [Engine-devel] is gerrit.ovirt.org down? eom
Yes, I am experiencing this too... Itamar? - Original Message - From: Shu Ming shum...@linux.vnet.ibm.com To: Alon Bar-Lev alo...@redhat.com Cc: Shireesh Anjal san...@redhat.com, engine-de...@ovirt.org, VDSM Project Development vdsm-devel@lists.fedorahosted.org Sent: Wednesday, September 12, 2012 5:50:14 PM Subject: Re: [Engine-devel] is gerrit.ovirt.org down? eom It seems gerrit has downed for several times recently. Is there any special reason? 于 2012-9-12 22:45, Alon Bar-Lev: yes. - Original Message - From: Shireesh Anjal san...@redhat.com To: engine-de...@ovirt.org Sent: Wednesday, September 12, 2012 5:43:35 PM Subject: [Engine-devel] is gerrit.ovirt.org down? eom ___ Engine-devel mailing list engine-de...@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ Engine-devel mailing list engine-de...@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel -- --- 舒明 Shu Ming Open Virtualization Engineerning; CSTL, IBM Corp. Tel: 86-10-82451626 Tieline: 9051626 E-mail: shum...@cn.ibm.com or shum...@linux.vnet.ibm.com Address: 3/F Ring Building, ZhongGuanCun Software Park, Haidian District, Beijing 100193, PRC ___ vdsm-devel mailing list vdsm-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-devel
Re: [vdsm] [Engine-devel] is gerrit.ovirt.org down? eom
In cases like these it's best to mail infra as well, or poke on #ovirt. On Wed, Sep 12, 2012 at 10:52:39AM -0400, Alon Bar-Lev wrote: Yes, I am experiencing this too... Itamar? - Original Message - From: Shu Ming shum...@linux.vnet.ibm.com To: Alon Bar-Lev alo...@redhat.com Cc: Shireesh Anjal san...@redhat.com, engine-de...@ovirt.org, VDSM Project Development vdsm-devel@lists.fedorahosted.org Sent: Wednesday, September 12, 2012 5:50:14 PM Subject: Re: [Engine-devel] is gerrit.ovirt.org down? eom It seems gerrit has downed for several times recently. Is there any special reason? 于 2012-9-12 22:45, Alon Bar-Lev: yes. - Original Message - From: Shireesh Anjal san...@redhat.com To: engine-de...@ovirt.org Sent: Wednesday, September 12, 2012 5:43:35 PM Subject: [Engine-devel] is gerrit.ovirt.org down? eom ___ vdsm-devel mailing list vdsm-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-devel
Re: [vdsm] [Engine-devel] is gerrit.ovirt.org down? eom
- Original Message - From: Itamar Heim ih...@redhat.com To: Asaf Shakarchi ashak...@redhat.com Cc: Alon Bar-Lev alo...@redhat.com, Shireesh Anjal san...@redhat.com, engine-de...@ovirt.org, VDSM Project Development vdsm-devel@lists.fedorahosted.org, Shu Ming shum...@linux.vnet.ibm.com, Eyal Edri ee...@redhat.com Sent: Wednesday, September 12, 2012 6:34:56 PM Subject: Re: [Engine-devel] is gerrit.ovirt.org down? eom On 09/12/2012 06:23 PM, Asaf Shakarchi wrote: It happens from time to time, restart is required, Itamar only. restarted. eyal - can we make progress on the jenkins job with permission to more people to restart gerrit? the job is ready http://jenkins.ovirt.org/view/system-monitoring/job/restart_gerrit_service but i need to have jenkins user access to gerrit server + sudo access to run 'service' restart... it has access to www.ovirt.org but not to gerrit.ovirt.org. others - please email infra on gerrit issues (well, me personally always help as well) - Original Message - Yes, I am experiencing this too... Itamar? - Original Message - From: Shu Ming shum...@linux.vnet.ibm.com To: Alon Bar-Lev alo...@redhat.com Cc: Shireesh Anjal san...@redhat.com, engine-de...@ovirt.org, VDSM Project Development vdsm-devel@lists.fedorahosted.org Sent: Wednesday, September 12, 2012 5:50:14 PM Subject: Re: [Engine-devel] is gerrit.ovirt.org down? eom It seems gerrit has downed for several times recently. Is there any special reason? 于 2012-9-12 22:45, Alon Bar-Lev: yes. - Original Message - From: Shireesh Anjal san...@redhat.com To: engine-de...@ovirt.org Sent: Wednesday, September 12, 2012 5:43:35 PM Subject: [Engine-devel] is gerrit.ovirt.org down? eom ___ Engine-devel mailing list engine-de...@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ Engine-devel mailing list engine-de...@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel -- --- 舒明 Shu Ming Open Virtualization Engineerning; CSTL, IBM Corp. Tel: 86-10-82451626 Tieline: 9051626 E-mail: shum...@cn.ibm.com or shum...@linux.vnet.ibm.com Address: 3/F Ring Building, ZhongGuanCun Software Park, Haidian District, Beijing 100193, PRC ___ Engine-devel mailing list engine-de...@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ vdsm-devel mailing list vdsm-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-devel
Re: [vdsm] [Engine-devel] is gerrit.ovirt.org down? eom
So the fix is to just regularly restart gerrit? Do we have any idea about the real, underlying problem? On Wed, Sep 12, 2012 at 11:56:44AM -0400, Eyal Edri wrote: - Original Message - From: Itamar Heim ih...@redhat.com To: Asaf Shakarchi ashak...@redhat.com Cc: Alon Bar-Lev alo...@redhat.com, Shireesh Anjal san...@redhat.com, engine-de...@ovirt.org, VDSM Project Development vdsm-devel@lists.fedorahosted.org, Shu Ming shum...@linux.vnet.ibm.com, Eyal Edri ee...@redhat.com Sent: Wednesday, September 12, 2012 6:34:56 PM Subject: Re: [Engine-devel] is gerrit.ovirt.org down? eom On 09/12/2012 06:23 PM, Asaf Shakarchi wrote: It happens from time to time, restart is required, Itamar only. restarted. eyal - can we make progress on the jenkins job with permission to more people to restart gerrit? the job is ready http://jenkins.ovirt.org/view/system-monitoring/job/restart_gerrit_service but i need to have jenkins user access to gerrit server + sudo access to run 'service' restart... it has access to www.ovirt.org but not to gerrit.ovirt.org. others - please email infra on gerrit issues (well, me personally always help as well) - Original Message - Yes, I am experiencing this too... Itamar? - Original Message - From: Shu Ming shum...@linux.vnet.ibm.com To: Alon Bar-Lev alo...@redhat.com Cc: Shireesh Anjal san...@redhat.com, engine-de...@ovirt.org, VDSM Project Development vdsm-devel@lists.fedorahosted.org Sent: Wednesday, September 12, 2012 5:50:14 PM Subject: Re: [Engine-devel] is gerrit.ovirt.org down? eom It seems gerrit has downed for several times recently. Is there any special reason? 于 2012-9-12 22:45, Alon Bar-Lev: yes. - Original Message - From: Shireesh Anjal san...@redhat.com To: engine-de...@ovirt.org Sent: Wednesday, September 12, 2012 5:43:35 PM Subject: [Engine-devel] is gerrit.ovirt.org down? eom ___ Engine-devel mailing list engine-de...@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ Engine-devel mailing list engine-de...@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel -- --- 舒明 Shu Ming Open Virtualization Engineerning; CSTL, IBM Corp. Tel: 86-10-82451626 Tieline: 9051626 E-mail: shum...@cn.ibm.com or shum...@linux.vnet.ibm.com Address: 3/F Ring Building, ZhongGuanCun Software Park, Haidian District, Beijing 100193, PRC ___ Engine-devel mailing list engine-de...@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ vdsm-devel mailing list vdsm-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-devel -- Adam Litke a...@us.ibm.com IBM Linux Technology Center ___ vdsm-devel mailing list vdsm-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-devel
Re: [vdsm] [Engine-devel] is gerrit.ovirt.org down? eom
On 09/12/2012 05:50 PM, Shu Ming wrote: It seems gerrit has downed for several times recently. Is there any special reason? I assume the jenkins/gerrit integration is overloading it a bit. 于 2012-9-12 22:45, Alon Bar-Lev: yes. - Original Message - From: Shireesh Anjal san...@redhat.com To: engine-de...@ovirt.org Sent: Wednesday, September 12, 2012 5:43:35 PM Subject: [Engine-devel] is gerrit.ovirt.org down? eom ___ Engine-devel mailing list engine-de...@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ Engine-devel mailing list engine-de...@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ vdsm-devel mailing list vdsm-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-devel
Re: [vdsm] [fedora-virt] libvirt 0.10.0 dependency issue
On 09/09/2012 02:21 PM, Dan Kenigsberg wrote: On Sun, Sep 09, 2012 at 12:35:00PM +0300, Dan Kenigsberg wrote: On Thu, Sep 06, 2012 at 10:10:17PM +0800, Royce Lv wrote: Guys, Because vdsm is depend on a patch in libvirt 0.10.0, But libvirt 0.10.0 is not available for fc17. You can download the rpm here:http://libvirt.org/sources/ Other packages can be found with yum. Sorry for the inconvenience I've brought. Yeah, this unfortunate consequece was not foreseen by your reviewer. Shame on him. On the mean while, I've built libvirt-0.10.1-2 for my F16 (yes, I'm backward) and put it in http://danken.fedorapeople.org/f16/ I've moved it around under http://danken.fedorapeople.org/my-virt-preview, and added f17, but then realised, that we should better request whomever responsible on fedora-virt-preview to update libvirt under http://fedorapeople.org/groups/virt/virt-preview/ Would the owner be kind to do this? Whoops, my script was dead for a bit. Latest libvirt should be available there for now. - Cole ___ vdsm-devel mailing list vdsm-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-devel
Re: [vdsm] [Engine-devel] is gerrit.ovirt.org down? eom
It happens from time to time, restart is required, Itamar only. - Original Message - Yes, I am experiencing this too... Itamar? - Original Message - From: Shu Ming shum...@linux.vnet.ibm.com To: Alon Bar-Lev alo...@redhat.com Cc: Shireesh Anjal san...@redhat.com, engine-de...@ovirt.org, VDSM Project Development vdsm-devel@lists.fedorahosted.org Sent: Wednesday, September 12, 2012 5:50:14 PM Subject: Re: [Engine-devel] is gerrit.ovirt.org down? eom It seems gerrit has downed for several times recently. Is there any special reason? 于 2012-9-12 22:45, Alon Bar-Lev: yes. - Original Message - From: Shireesh Anjal san...@redhat.com To: engine-de...@ovirt.org Sent: Wednesday, September 12, 2012 5:43:35 PM Subject: [Engine-devel] is gerrit.ovirt.org down? eom ___ Engine-devel mailing list engine-de...@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ Engine-devel mailing list engine-de...@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel -- --- 舒明 Shu Ming Open Virtualization Engineerning; CSTL, IBM Corp. Tel: 86-10-82451626 Tieline: 9051626 E-mail: shum...@cn.ibm.com or shum...@linux.vnet.ibm.com Address: 3/F Ring Building, ZhongGuanCun Software Park, Haidian District, Beijing 100193, PRC ___ Engine-devel mailing list engine-de...@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ vdsm-devel mailing list vdsm-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-devel
Re: [vdsm] [Engine-devel] is gerrit.ovirt.org down? eom
On 09/12/2012 08:15 PM, Adam Litke wrote: So the fix is to just regularly restart gerrit? Do we have any idea about the real, underlying problem? the error is in jetty, i didn't look at fixing the core issue in jetty. moving to another container is possible, but makes managing it for upgrades much less trivial. so far most threads around this on google mention a cron to detect this and restart. I actually expect moving to a hosted physical server will make this less of an issue based on the previous experience of extending the EC2 instance. if it won't help, we may need to tackle the core jetty issue ourselves. On Wed, Sep 12, 2012 at 11:56:44AM -0400, Eyal Edri wrote: - Original Message - From: Itamar Heim ih...@redhat.com To: Asaf Shakarchi ashak...@redhat.com Cc: Alon Bar-Lev alo...@redhat.com, Shireesh Anjal san...@redhat.com, engine-de...@ovirt.org, VDSM Project Development vdsm-devel@lists.fedorahosted.org, Shu Ming shum...@linux.vnet.ibm.com, Eyal Edri ee...@redhat.com Sent: Wednesday, September 12, 2012 6:34:56 PM Subject: Re: [Engine-devel] is gerrit.ovirt.org down? eom On 09/12/2012 06:23 PM, Asaf Shakarchi wrote: It happens from time to time, restart is required, Itamar only. restarted. eyal - can we make progress on the jenkins job with permission to more people to restart gerrit? the job is ready http://jenkins.ovirt.org/view/system-monitoring/job/restart_gerrit_service but i need to have jenkins user access to gerrit server + sudo access to run 'service' restart... it has access to www.ovirt.org but not to gerrit.ovirt.org. others - please email infra on gerrit issues (well, me personally always help as well) - Original Message - Yes, I am experiencing this too... Itamar? - Original Message - From: Shu Ming shum...@linux.vnet.ibm.com To: Alon Bar-Lev alo...@redhat.com Cc: Shireesh Anjal san...@redhat.com, engine-de...@ovirt.org, VDSM Project Development vdsm-devel@lists.fedorahosted.org Sent: Wednesday, September 12, 2012 5:50:14 PM Subject: Re: [Engine-devel] is gerrit.ovirt.org down? eom It seems gerrit has downed for several times recently. Is there any special reason? 于 2012-9-12 22:45, Alon Bar-Lev: yes. - Original Message - From: Shireesh Anjal san...@redhat.com To: engine-de...@ovirt.org Sent: Wednesday, September 12, 2012 5:43:35 PM Subject: [Engine-devel] is gerrit.ovirt.org down? eom ___ Engine-devel mailing list engine-de...@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ Engine-devel mailing list engine-de...@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel -- --- 舒明 Shu Ming Open Virtualization Engineerning; CSTL, IBM Corp. Tel: 86-10-82451626 Tieline: 9051626 E-mail: shum...@cn.ibm.com or shum...@linux.vnet.ibm.com Address: 3/F Ring Building, ZhongGuanCun Software Park, Haidian District, Beijing 100193, PRC ___ Engine-devel mailing list engine-de...@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel ___ vdsm-devel mailing list vdsm-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-devel ___ vdsm-devel mailing list vdsm-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-devel
