On 10/31/2012 11:17 AM, Sheldon wrote:
On 10/30/2012 03:45 PM, Itamar Heim wrote:
On 10/30/2012 07:00 AM, Sheldon wrote:
Looking for some review on this patch.

http://gerrit.ovirt.org/#/c/7535/

Hi Sheldon,

just wondering - are you planning to close this feature end-to-end
(with ovirt engine)?

a feature page would be nice (i think your commit message is almost
good enough to explain.
just need to cover how it fits with the engine side.


IMO, It is nice for engine to add UI to let user to decide to add this
watchdog device.
Like virt-manager, it has a UI option to add watchdog device.
And engine just need to add the watchdog device configuration in the
parameter when call  VM create API, if watchdog device is chosen.

i'd say it's not only nice, but mandatory, if the feature is to be supported in ovirt and not only vdsm. my question was just if there was a plan to close the loop on this (feature page, patches to engine, etc.)

thanks,
   Itamar
_______________________________________________
vdsm-devel mailing list
vdsm-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-devel

Reply via email to