Re: [vdsm] [Users] Failed to Start VM (Run Once) due to internal spice channel error
David Jaša píše v Út 19. 03. 2013 v 10:50 +0100: Omer Frenkel píše v Út 19. 03. 2013 v 04:58 -0400: Od: Omer Frenkel ofren...@redhat.com Komu: Tom Rogers trogers1...@gmail.com Kopie: us...@ovirt.org Předmět: Re: [Users] Failed to Start VM (Run Once) due to internal spice channel error Datum: 19.3.2013 09:58:23 - Original Message - From: Tom Rogers trogers1...@gmail.com To: us...@ovirt.org Sent: Monday, March 18, 2013 10:22:52 PM Subject: [Users] Failed to Start VM (Run Once) due to internal spice channel error When trying to run a first time (Run Once) VM install, the vm session fails to start. When we look into the libvirtd.log on the host, we find the following error: virDomainGraphicsDefParseXML:6566 : internal error unknown spice channel name ain in the lines right above message, contained in the xmlDESC we find the following snippet: channel type=spicevmc target name=com.redhat.spice.0 type=virtio/ /channel graphics autoport=yes keymap=en-us listen=0 passwd=* passwdValidTo=1970-01-01T00:00:01 port=-1 tlsPort=-1 type=spice channel mode=secure name=ain/ channel mode=secure name=nputs/ channel mode=secure name=ursor/ channel mode=secure name=layback/ channel mode=secure name=ecord/ channel mode=secure name=isplay/ channel mode=secure name=sbredir/ channel mode=secure name=martcard/ /graphics It looks to us that the xml may be malformed due to the seemingly first character missing in the channel names. Does this make any sense to anyone? On master: Ovirt-engine 3.3.0-0.2.master.20130313215708 On node: qemu-kvm 1.2.2-7.fc18 vdsm-xmlrpc 4.10.3-10.fc18 libvirt-daemon 0.10.2.3-1.fc18 -- Tom Rogers ___ Users mailing list us...@ovirt.org http://lists.ovirt.org/mailman/listinfo/users indeed looks like first letter is missing, this is what the engine sends: engine=# select * from vdc_options where option_name = 'SpiceSecureChannels'; option_id | option_name | option_value | version ---+-+---+- 345 | SpiceSecureChannels | smain,sinputs | 3.0 346 | SpiceSecureChannels | main,inputs,cursor,playback,record,display,usbredir,smartcard | 3.1 347 | SpiceSecureChannels | main,inputs,cursor,playback,record,display,usbredir,smartcard | 3.2 348 | SpiceSecureChannels | main,inputs,cursor,playback,record,display,usbredir,smartcard | 3.3 can you please attach relevant vdsm log for this run? Thanks sounds like vdsm didn't get right schannel - channel name change [1]. It should either implement magic like spice-xpi: http://cgit.freedesktop.org/spice/spice-xpi/tree/SpiceXPI/src/plugin/plugin.cpp#n320 or stop any channel name mangling altogether for recent enough clusters. [1] https://bugzilla.redhat.com/show_bug.cgi?id=803666 David -- David Jaša, RHCE SPICE QE based in Brno GPG Key: 22C33E24 Fingerprint: 513A 060B D1B4 2A72 7F0D 0278 B125 CD00 22C3 3E24 ___ vdsm-devel mailing list vdsm-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-devel
Re: [vdsm] [Users] Failed to Start VM (Run Once) due to internal spice channel error
Omer Frenkel píše v Út 19. 03. 2013 v 04:58 -0400: Od: Omer Frenkel ofren...@redhat.com Komu: Tom Rogers trogers1...@gmail.com Kopie: us...@ovirt.org Předmět: Re: [Users] Failed to Start VM (Run Once) due to internal spice channel error Datum: 19.3.2013 09:58:23 - Original Message - From: Tom Rogers trogers1...@gmail.com To: us...@ovirt.org Sent: Monday, March 18, 2013 10:22:52 PM Subject: [Users] Failed to Start VM (Run Once) due to internal spice channel error When trying to run a first time (Run Once) VM install, the vm session fails to start. When we look into the libvirtd.log on the host, we find the following error: virDomainGraphicsDefParseXML:6566 : internal error unknown spice channel name ain in the lines right above message, contained in the xmlDESC we find the following snippet: channel type=spicevmc target name=com.redhat.spice.0 type=virtio/ /channel graphics autoport=yes keymap=en-us listen=0 passwd=* passwdValidTo=1970-01-01T00:00:01 port=-1 tlsPort=-1 type=spice channel mode=secure name=ain/ channel mode=secure name=nputs/ channel mode=secure name=ursor/ channel mode=secure name=layback/ channel mode=secure name=ecord/ channel mode=secure name=isplay/ channel mode=secure name=sbredir/ channel mode=secure name=martcard/ /graphics It looks to us that the xml may be malformed due to the seemingly first character missing in the channel names. Does this make any sense to anyone? On master: Ovirt-engine 3.3.0-0.2.master.20130313215708 On node: qemu-kvm 1.2.2-7.fc18 vdsm-xmlrpc 4.10.3-10.fc18 libvirt-daemon 0.10.2.3-1.fc18 -- Tom Rogers ___ Users mailing list us...@ovirt.org http://lists.ovirt.org/mailman/listinfo/users indeed looks like first letter is missing, this is what the engine sends: engine=# select * from vdc_options where option_name = 'SpiceSecureChannels'; option_id | option_name | option_value | version ---+-+---+- 345 | SpiceSecureChannels | smain,sinputs | 3.0 346 | SpiceSecureChannels | main,inputs,cursor,playback,record,display,usbredir,smartcard | 3.1 347 | SpiceSecureChannels | main,inputs,cursor,playback,record,display,usbredir,smartcard | 3.2 348 | SpiceSecureChannels | main,inputs,cursor,playback,record,display,usbredir,smartcard | 3.3 can you please attach relevant vdsm log for this run? Thanks sounds like vdsm didn't get right schannel - channel name change [1]. It should either implement magic like spice-xpi: http://cgit.freedesktop.org/spice/spice-xpi/tree/SpiceXPI/src/plugin/plugin.cpp#n320 or stop any channel name mangling altogether for recent enough clusters. David -- David Jaša, RHCE SPICE QE based in Brno GPG Key: 22C33E24 Fingerprint: 513A 060B D1B4 2A72 7F0D 0278 B125 CD00 22C3 3E24 ___ vdsm-devel mailing list vdsm-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-devel
Re: [vdsm] [Users] Failed to Start VM (Run Once) due to internal spice channel error
On Tue, Mar 19, 2013 at 10:54:48AM +0100, David Jaša wrote: David Jaša píše v Út 19. 03. 2013 v 10:50 +0100: Omer Frenkel píše v Út 19. 03. 2013 v 04:58 -0400: Od: Omer Frenkel ofren...@redhat.com Komu: Tom Rogers trogers1...@gmail.com Kopie: us...@ovirt.org Předmět: Re: [Users] Failed to Start VM (Run Once) due to internal spice channel error Datum: 19.3.2013 09:58:23 - Original Message - From: Tom Rogers trogers1...@gmail.com To: us...@ovirt.org Sent: Monday, March 18, 2013 10:22:52 PM Subject: [Users] Failed to Start VM (Run Once) due to internal spice channel error When trying to run a first time (Run Once) VM install, the vm session fails to start. When we look into the libvirtd.log on the host, we find the following error: virDomainGraphicsDefParseXML:6566 : internal error unknown spice channel name ain in the lines right above message, contained in the xmlDESC we find the following snippet: channel type=spicevmc target name=com.redhat.spice.0 type=virtio/ /channel graphics autoport=yes keymap=en-us listen=0 passwd=* passwdValidTo=1970-01-01T00:00:01 port=-1 tlsPort=-1 type=spice channel mode=secure name=ain/ channel mode=secure name=nputs/ channel mode=secure name=ursor/ channel mode=secure name=layback/ channel mode=secure name=ecord/ channel mode=secure name=isplay/ channel mode=secure name=sbredir/ channel mode=secure name=martcard/ /graphics It looks to us that the xml may be malformed due to the seemingly first character missing in the channel names. Does this make any sense to anyone? On master: Ovirt-engine 3.3.0-0.2.master.20130313215708 On node: qemu-kvm 1.2.2-7.fc18 vdsm-xmlrpc 4.10.3-10.fc18 libvirt-daemon 0.10.2.3-1.fc18 -- Tom Rogers ___ Users mailing list us...@ovirt.org http://lists.ovirt.org/mailman/listinfo/users indeed looks like first letter is missing, this is what the engine sends: engine=# select * from vdc_options where option_name = 'SpiceSecureChannels'; option_id | option_name | option_value | version ---+-+---+- 345 | SpiceSecureChannels | smain,sinputs | 3.0 346 | SpiceSecureChannels | main,inputs,cursor,playback,record,display,usbredir,smartcard | 3.1 347 | SpiceSecureChannels | main,inputs,cursor,playback,record,display,usbredir,smartcard | 3.2 348 | SpiceSecureChannels | main,inputs,cursor,playback,record,display,usbredir,smartcard | 3.3 can you please attach relevant vdsm log for this run? Thanks sounds like vdsm didn't get right schannel - channel name change [1]. It should either implement magic like spice-xpi: http://cgit.freedesktop.org/spice/spice-xpi/tree/SpiceXPI/src/plugin/plugin.cpp#n320 or stop any channel name mangling altogether for recent enough clusters. [1] https://bugzilla.redhat.com/show_bug.cgi?id=803666 For some reason, that's a private bug. It reminds me of https://lists.fedorahosted.org/pipermail/vdsm-patches/2012-May/007785.html that has never came through, due to the compatibilty issues with older cluster levels, or something like that. Dan. ___ vdsm-devel mailing list vdsm-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-devel
Re: [vdsm] Per device custom properties
adding arch@ovirt, as this feature is cross sub-project On Sun, Mar 17, 2013 at 09:50:20AM -0400, Assaf Muller wrote: Hi all, Right now we have the ability to define VM-wide properties that may be used by hooks. It is time we have the same functionality on a device basis: http://www.ovirt.org/Features/Device_Custom_Properties This feature page needs some love and attention. * I received a private communication about the suggested GUI: there should not be an independent vNIC action called custom Properties - the dialog for editing per-vNIC custom properties should be part of defining a new vNIC or editting an existing one. I believe Eldan (our GUI designer) concurs. * http://www.ovirt.org/Features/Device_Custom_Properties#Engine is rather lacking concrete details. Yair, could you improve it, as well as the completely empty REST section? For example: If the VM has 2 disks called disk1 and disk2, and two NICs called nic1 and nic2, and the admin (From the engine) added a custom property qos: 0.5 for nic1 and a custom property defrag: None for disk2. When the VM is started we'll run a hook for nic1 with its XML and qos: 0.5 added as an environment variable, and a hook for disk2 with its XML and defrag: None. When a device is hot plugged and it has custom properties we'll run that hook as well. Implementation-wise, hot plug/unplug for disks and NICs is dead simple - vmCreate is more problematic: If the user set a custom property called 'qos: 0.8' for nic3, I'd want it exposed as an environment variable called 'qos' for hot plug nic hooks, but for vmCreate I'd like to prefix the nic's alias. However, when vmCreate is called we don't have the aliases for NICs and disks. The proposed solution is to create a new hook point called something like: 'before_device_creation' that will be called before vmCreate. We'll then call that hook specifically for devices that contains custom properties, as described in the second paragraph of this mail. I would love to hear smarter ideas before I move forward. Thanks! I find it quite intuitive, but I'd rather hear if it feats Izik's use case. Dan. ___ vdsm-devel mailing list vdsm-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-devel
Re: [vdsm] Per device custom properties
Hello, I accept Dan's proposition, an updated mock up has been uploaded to the wiki. E. - Original Message - From: Dan Kenigsberg dan...@redhat.com To: Assaf Muller amul...@redhat.com, Yair Zaslavsky yzasl...@redhat.com, Eldan Hildesheim ehild...@redhat.com, iz...@mellanox.com Cc: vdsm-devel@lists.fedorahosted.org, a...@ovirt.org Sent: Tuesday, March 19, 2013 5:06:44 PM Subject: Re: [vdsm] Per device custom properties adding arch@ovirt, as this feature is cross sub-project On Sun, Mar 17, 2013 at 09:50:20AM -0400, Assaf Muller wrote: Hi all, Right now we have the ability to define VM-wide properties that may be used by hooks. It is time we have the same functionality on a device basis: http://www.ovirt.org/Features/Device_Custom_Properties This feature page needs some love and attention. * I received a private communication about the suggested GUI: there should not be an independent vNIC action called custom Properties - the dialog for editing per-vNIC custom properties should be part of defining a new vNIC or editting an existing one. I believe Eldan (our GUI designer) concurs. * http://www.ovirt.org/Features/Device_Custom_Properties#Engine is rather lacking concrete details. Yair, could you improve it, as well as the completely empty REST section? For example: If the VM has 2 disks called disk1 and disk2, and two NICs called nic1 and nic2, and the admin (From the engine) added a custom property qos: 0.5 for nic1 and a custom property defrag: None for disk2. When the VM is started we'll run a hook for nic1 with its XML and qos: 0.5 added as an environment variable, and a hook for disk2 with its XML and defrag: None. When a device is hot plugged and it has custom properties we'll run that hook as well. Implementation-wise, hot plug/unplug for disks and NICs is dead simple - vmCreate is more problematic: If the user set a custom property called 'qos: 0.8' for nic3, I'd want it exposed as an environment variable called 'qos' for hot plug nic hooks, but for vmCreate I'd like to prefix the nic's alias. However, when vmCreate is called we don't have the aliases for NICs and disks. The proposed solution is to create a new hook point called something like: 'before_device_creation' that will be called before vmCreate. We'll then call that hook specifically for devices that contains custom properties, as described in the second paragraph of this mail. I would love to hear smarter ideas before I move forward. Thanks! I find it quite intuitive, but I'd rather hear if it feats Izik's use case. Dan. ___ vdsm-devel mailing list vdsm-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-devel
