Re: [vdsm] [Engine-devel] Copy reviewer scores on trivial rebase/commit msg changes
On 18/01/14 01:48 +0200, Itamar Heim wrote: I'd like to enable these - comments welcome: 1. label.Label-Name.copyAllScoresOnTrivialRebase If true, all scores for the label are copied forward when a new patch set is uploaded that is a trivial rebase. A new patch set is considered as trivial rebase if the commit message is the same as in the previous patch set and if it has the same code delta as the previous patch set. This is the case if the change was rebased onto a different parent. This can be used to enable sticky approvals, reducing turn-around for trivial rebases prior to submitting a change. Defaults to false. 2. label.Label-Name.copyAllScoresIfNoCodeChange If true, all scores for the label are copied forward when a new patch set is uploaded that has the same parent commit as the previous patch set and the same code delta as the previous patch set. This means only the commit message is different. This can be used to enable sticky approvals on labels that only depend on the code, reducing turn-around if only the commit message is changed prior to submitting a change. Defaults to false. I am a bit late to the party but +1 from me for trying both. I guess it will be quite rare that something bad happens here. So unlikely, that the time saved on all the previous patches will far offset the lost time for fixing the corner cases. ___ vdsm-devel mailing list vdsm-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-devel
[vdsm] ovirt-guest-agent on debian
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi, here are my results so far. I did: install debian 7 x64 into a vm as root: mkdir code cd code git clone git://gerrit.ovirt.org/ovirt-guest-agent cd ovirt-guest-agent ./autogen.sh ./autogen.sh: 3: ./autogen.sh: autoreconf: not found apt-get install dh-autoreconf ./autogen.sh ./configure configure: error: no suitable Python interpreter found apt-get install python ./configure ./configure: line 15790: --variable=systemdsystemunitdir: command not found checking for pep8... no configure: WARNING: python-pep8 not found ./configure: line 15868: syntax error near unexpected token 'GDM_PLUGIN, ' ./configure: line 15868: ' PKG_CHECK_MODULES(GDM_PLUGIN; ' apt-get install pep8 I found this: http://lists.ovirt.org/pipermail/users/2013-August/015773.html so I tried: ./configure --with-gdm=no --with-sso=no but I get the same errors again. Doing less configure shows however that this options should be recognized and supported? Any help will be appreciated. I will try to maintain some manual and get patches in so we can get a stable build for Debian. Thanks for your time. Sven -BEGIN PGP SIGNATURE- Version: GnuPG v2.0.22 (MingW32) iQGcBAEBAgAGBQJS3ttmAAoJEAq0kGAWDrqlezAMAJwi4ZPMdWCCANUdWn7fPUDm 6QsAamcaNm5pcSwUHYKMLjhfn+UO2NoVb/f46UVOSadJ1Yfr7CbVutnRy+W0MMjR PehaoZw5o2bJ09Is8nLN505iriiw4Xvwk1MvmYCIj8XcHC0Uj3q+VU7erV0fE4Js XHUMuHto8S/4op9MDAfjAAJfu0l/9ADSIcp4HRo75NCqt0r3wccT8tSI/t+ABYc1 7luDA0RqRAbnYgqZPgfv7P3l0wHy5SBCEbFP8md5CH0VHJw1w8x40Mx4X9K1UI2g 9nkyI+ObNlTI7ori6OP0ZHjQpddzQlO8r965rANW4Zlj4YHwRL6Z0YlgVNzIlFLJ ps5qAKc2xxXfC3cqk/EGalGaLGwQNV1rI1s/Ah/jsET0sNAc55tBFvsYOQxkoVit lFbzXm9J17kUBb+EcIxMihkU2abQMx+j4KVaxA430uwggQL1mmTLgGfgBtFhOB8t laWExv4FAoy4UQLHkOptmscPiRfKPAzRvXNd9q5oMg== =b9/7 -END PGP SIGNATURE- ___ vdsm-devel mailing list vdsm-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-devel
