Re: [vdsm] Review Request: Add an option to create a watchdog device.
On 10/30/2012 01:00 PM, Sheldon wrote: Looking for some review on this patch. http://gerrit.ovirt.org/#/c/7535/ Thanks. Add a feature page on wiki. http://wiki.ovirt.org/wiki/Add_an_option_to_create_a_watchdog_device -- Sheldon Feng(冯少合)shao...@linux.vnet.ibm.com IBM Linux Technology Center ___ vdsm-devel mailing list vdsm-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-devel -- Sheldon Feng(冯少合)shao...@linux.vnet.ibm.com IBM Linux Technology Center ___ vdsm-devel mailing list vdsm-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-devel
Re: [vdsm] Review Request: Add an option to create a watchdog device.
On 10/31/2012 06:30 PM, Itamar Heim wrote: On 10/31/2012 11:17 AM, Sheldon wrote: On 10/30/2012 03:45 PM, Itamar Heim wrote: On 10/30/2012 07:00 AM, Sheldon wrote: Looking for some review on this patch. http://gerrit.ovirt.org/#/c/7535/ Hi Sheldon, just wondering - are you planning to close this feature end-to-end (with ovirt engine)? a feature page would be nice (i think your commit message is almost good enough to explain. just need to cover how it fits with the engine side. IMO, It is nice for engine to add UI to let user to decide to add this watchdog device. Like virt-manager, it has a UI option to add watchdog device. And engine just need to add the watchdog device configuration in the parameter when call VM create API, if watchdog device is chosen. i'd say it's not only nice, but mandatory, if the feature is to be supported in ovirt and not only vdsm. my question was just if there was a plan to close the loop on this (feature page, patches to engine, etc.) Hi Itamar. Currently, we do not have any plans to implement the engine side of the feature. But I will add a watchdog feature page to describe how engine enable this feature. It's definitely great if any engine guy would like to take the engine part. I will be glad to provide help if needed. thanks, Itamar -- Sheldon Feng(冯少合)shao...@linux.vnet.ibm.com IBM Linux Technology Center ___ vdsm-devel mailing list vdsm-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-devel
Re: [vdsm] Review Request: Add an option to create a watchdog device.
On 10/31/2012 11:17 AM, Sheldon wrote: On 10/30/2012 03:45 PM, Itamar Heim wrote: On 10/30/2012 07:00 AM, Sheldon wrote: Looking for some review on this patch. http://gerrit.ovirt.org/#/c/7535/ Hi Sheldon, just wondering - are you planning to close this feature end-to-end (with ovirt engine)? a feature page would be nice (i think your commit message is almost good enough to explain. just need to cover how it fits with the engine side. IMO, It is nice for engine to add UI to let user to decide to add this watchdog device. Like virt-manager, it has a UI option to add watchdog device. And engine just need to add the watchdog device configuration in the parameter when call VM create API, if watchdog device is chosen. i'd say it's not only nice, but mandatory, if the feature is to be supported in ovirt and not only vdsm. my question was just if there was a plan to close the loop on this (feature page, patches to engine, etc.) thanks, Itamar ___ vdsm-devel mailing list vdsm-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-devel
[vdsm] Review Request: Add an option to create a watchdog device.
Looking for some review on this patch. http://gerrit.ovirt.org/#/c/7535/ Thanks. -- Sheldon Feng(???)shao...@linux.vnet.ibm.com IBM Linux Technology Center ___ vdsm-devel mailing list vdsm-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-devel
