[vdsm] pep8 questions

2012-06-05 Thread Deepak C Shetty 

Hi,
I was looking at resolving pep8 issues in 
vdsm/storage/blockVolume.py. Haven't been able to resolve the below.. 
Pointers appreciated.


vdsm/storage/blockVolume.py:99:55: E225 missing whitespace around operator
vdsm/storage/blockVolume.py:148:28: E201 whitespace after '{'
vdsm/storage/blockVolume.py:207:28: E701 multiple statements on one line 
(colon)



line 99:  cls.log.warn(Could not get size for vol %s/%s using optimized
googling i found some links indicating this pep8 warning is incorrect.

line 148: cls.__putMetadata({ NONE: # * (sd.METASIZE-10) }, metaid)
It gives some other error if i remove the whitespace after {

line 206  207:
raise se.VolumeCannotGetParent(blockVolume can't get 
parent %s for

  volume %s: %s % (srcVolUUID, volUUID, str(e)))
I split this line to overcome the  80 error, but unable to decipher 
what this error means ?


thanx,
deepak

___
vdsm-devel mailing list
vdsm-devel@lists.fedorahosted.org
https://fedorahosted.org/mailman/listinfo/vdsm-devel

Re: [vdsm] pep8 questions

2012-06-05 Thread Saggi Mizrahi 
I thins this is the correct formatting:

self.__putMetadata({NONE: # * (sd.METASIZE - 10)}, metaid)

cls.log.warn(Could not get size for vol %s/%s
 using optimized methods,
 sdobj.sdUUID, volUUID, exc_info=True)

- Original Message -
 From: Deepak C Shetty deepa...@linux.vnet.ibm.com
 To: VDSM Project Development vdsm-devel@lists.fedorahosted.org
 Sent: Tuesday, June 5, 2012 2:19:04 PM
 Subject: [vdsm] pep8 questions
 
 Hi,
  I was looking at resolving pep8 issues in
 vdsm/storage/blockVolume.py. Haven't been able to resolve the below..
 Pointers appreciated.
 
 vdsm/storage/blockVolume.py:99:55: E225 missing whitespace around
 operator
 vdsm/storage/blockVolume.py:148:28: E201 whitespace after '{'
 vdsm/storage/blockVolume.py:207:28: E701 multiple statements on one
 line
 (colon)
 
 
 line 99:  cls.log.warn(Could not get size for vol %s/%s using
 optimized
 googling i found some links indicating this pep8 warning is
 incorrect.
 
 line 148: cls.__putMetadata({ NONE: # * (sd.METASIZE-10) },
 metaid)
 It gives some other error if i remove the whitespace after {
 
 line 206  207:
  raise se.VolumeCannotGetParent(blockVolume can't get
 parent %s for
volume %s: %s % (srcVolUUID, volUUID, str(e)))
 I split this line to overcome the  80 error, but unable to decipher
 what this error means ?
 
 thanx,
 deepak
 
 ___
 vdsm-devel mailing list
 vdsm-devel@lists.fedorahosted.org
 https://fedorahosted.org/mailman/listinfo/vdsm-devel
 
___
vdsm-devel mailing list
vdsm-devel@lists.fedorahosted.org
https://fedorahosted.org/mailman/listinfo/vdsm-devel

Re: [vdsm] pep8 questions

2012-06-05 Thread Zhou Zheng Sheng 

Hi, I think a space is needed after %s/%s, just like follow:

cls.log.warn(Could not get size for vol %s/%s 
 using optimized methods,
 sdobj.sdUUID, volUUID, exc_info=True)


于 2012年06月06日 04:11, Saggi Mizrahi 写道:

 cls.log.warn(Could not get size for vol %s/%s
  using optimized methods,
  sdobj.sdUUID, volUUID, exc_info=True)


--
Thanks and best regards!

Zhou Zheng Sheng / 周征晟
E-mail: zhshz...@linux.vnet.ibm.com
Telephone: 86-10-82454397

___
vdsm-devel mailing list
vdsm-devel@lists.fedorahosted.org
https://fedorahosted.org/mailman/listinfo/vdsm-devel