[vdsm] VDSM sync meeting minutes June 10th, 2014
VDSM sync meeting June 10th 2014 We mainly discussed the status of features for 3.5. Storage: * live merge: pending on reviews and minor revisions Network: * 3.5 features are all merged * one open issue about activating networks at boot (to be resolved in two different ways 3.5/master) Infra: * json-rpc: pending on merge * ioprocess: pending on final review * configure-libvirt: pending on verification and final reviews -- Federico ___ vdsm-devel mailing list vdsm-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-devel
Re: [vdsm] vdsm sync meeting minutes April 1st, 2014
On Wed, Apr 02, 2014 at 09:29:09AM +0100, dan...@redhat.com wrote: - We had a very (too) heated debate about ignoring failures of setDomainRegularRole() in http://gerrit.ovirt.org/24495/ and http://gerrit.ovirt.org/25424. The pain point is that relying on domain role (master/regular) is faulty by design. We cannot avoid the cases where a pool has more than one domain with a master role written in its metadata. One side argued that oVirt should be fixed to handle this unescapable truth, or at least enumerate the places where Vdsm and Engine, both current and old, depend on master role uniqueness. The other side argued that this is not a priority task, and that we should try to garbage-collect known-bad master roles as a courtesy to people digging into domain metadata, and as a means to lessen the problem until we kill the pool concept in the upcoming version. I hope that I present the debate fairly enough. In order to move these two patches forward, how about: - Limit the usage of the catching-all except Exception and replace it with swalling only the expected IO error - Add a comment about setDomainRegularRole() being called only as a courtesy garbage-collection attempt. - Conduct a survey on whether migrateMaster is used by anyone. No supported Engine has it, but I there was a suggestion that it was still expected via the command line. What do you think? ___ vdsm-devel mailing list vdsm-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-devel
Re: [vdsm] vdsm sync meeting minutes April 1st, 2014
- Original Message - From: Dan Kenigsberg dan...@redhat.com To: VDSM Project Development vdsm-devel@lists.fedorahosted.org, de...@ovirt.org, lara...@redhat.com, nsof...@redhat.com, fsimo...@redhat.com Cc: lyarw...@redhat.com Sent: Wednesday, April 9, 2014 3:01:31 PM Subject: Re: [vdsm] vdsm sync meeting minutes April 1st, 2014 On Wed, Apr 02, 2014 at 09:29:09AM +0100, dan...@redhat.com wrote: - We had a very (too) heated debate about ignoring failures of setDomainRegularRole() in http://gerrit.ovirt.org/24495/ and http://gerrit.ovirt.org/25424. The pain point is that relying on domain role (master/regular) is faulty by design. We cannot avoid the cases where a pool has more than one domain with a master role written in its metadata. One side argued that oVirt should be fixed to handle this unescapable truth, or at least enumerate the places where Vdsm and Engine, both current and old, depend on master role uniqueness. The other side argued that this is not a priority task, and that we should try to garbage-collect known-bad master roles as a courtesy to people digging into domain metadata, and as a means to lessen the problem until we kill the pool concept in the upcoming version. I hope that I present the debate fairly enough. In order to move these two patches forward, how about: - Limit the usage of the catching-all except Exception and replace it with swalling only the expected IO error - Add a comment about setDomainRegularRole() being called only as a courtesy garbage-collection attempt. - Conduct a survey on whether migrateMaster is used by anyone. No supported Engine has it, but I there was a suggestion that it was still expected via the command line. You don't call masterMigrate directly. It's triggered when you deactivate the master domain. -- Federico ___ vdsm-devel mailing list vdsm-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-devel
[vdsm] vdsm sync meeting minutes April 1st, 2014
Vdsm sync call April 1st 2014 = - cpopen: - Toni: there's a versioning mismatch: the version in pypi is higher than the one on https://github.com/ficoos/cpopen - Saggi: there shouldn't be any code difference - Yaniv should sync the two. - We use two options that are missing from Python3's Popen: umask and deathSignal. - Toni to re-send his Python3 port for cpopen, with tests running on Python3, too. - Saggi to accept it. - Infra team to suggest missing features to Python. - fromani described his attempts of consolidating the two migration-monitoring threads into one. The motivation is a finer way of contolling the migration down time based on progress. Reducing thread numbers per se is not the main motivation. - pep8 has changed. Again. Version 1.5.1 has even more draconic requirements. We can comply with them, or, include our version of pep8/pyflakes/pylint in our git repo. danken shudders at the thought of copying the code, but having a git sub-module is a reasonable compromise. - Infra team to take this task (unless someone else is faster) - Until that happens, one need to use pep8-1.4.6 or --ignore offending errors. - We've been asked to kill the separate vdsm-devel mailing list, and join it into de...@ovirt.org. There's some resistence in the audience, so we'd do it softly. Next week, I'll have vdsm-devel members mass-subscribed to devel@ovirt. If you do NOT want to be subscribed, please send me a private request. Then, for several months, we'd see how it goes, and whether we drown in unrelated Engine chatter. - We had a very (too) heated debate about ignoring failures of setDomainRegularRole() in http://gerrit.ovirt.org/24495/ and http://gerrit.ovirt.org/25424. The pain point is that relying on domain role (master/regular) is faulty by design. We cannot avoid the cases where a pool has more than one domain with a master role written in its metadata. One side argued that oVirt should be fixed to handle this unescapable truth, or at least enumerate the places where Vdsm and Engine, both current and old, depend on master role uniqueness. The other side argued that this is not a priority task, and that we should try to garbage-collect known-bad master roles as a courtesy to people digging into domain metadata, and as a means to lessen the problem until we kill the pool concept in the upcoming version. I hope that I present the debate fairly enough. Dan. ___ vdsm-devel mailing list vdsm-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-devel
Re: [vdsm] vdsm sync meeting minutes April 1st, 2014
- Original Message - From: dan...@redhat.com To: VDSM Project Development vdsm-devel@lists.fedorahosted.org, de...@ovirt.org Sent: Wednesday, April 2, 2014 10:29:09 AM Subject: [vdsm] vdsm sync meeting minutes April 1st, 2014 Vdsm sync call April 1st 2014 = - cpopen: - Toni: there's a versioning mismatch: the version in pypi is higher than the one on https://github.com/ficoos/cpopen - Saggi: there shouldn't be any code difference - Yaniv should sync the two. - We use two options that are missing from Python3's Popen: umask and deathSignal. - Toni to re-send his Python3 port for cpopen, with tests running on Python3, too. https://github.com/celebdor/cpopen/commit/6db0429de06020c2c62007f6d1a3b41906e85742 I did it last night. There's still the noclosefds test failing for unknown reasons. I'll investigate it. - Saggi to accept it. - Infra team to suggest missing features to Python. - fromani described his attempts of consolidating the two migration-monitoring threads into one. The motivation is a finer way of contolling the migration down time based on progress. Reducing thread numbers per se is not the main motivation. - pep8 has changed. Again. Version 1.5.1 has even more draconic requirements. We can comply with them, or, include our version of pep8/pyflakes/pylint in our git repo. danken shudders at the thought of copying the code, but having a git sub-module is a reasonable compromise. - Infra team to take this task (unless someone else is faster) - Until that happens, one need to use pep8-1.4.6 or --ignore offending errors. - We've been asked to kill the separate vdsm-devel mailing list, and join it into de...@ovirt.org. There's some resistence in the audience, so we'd do it softly. Next week, I'll have vdsm-devel members mass-subscribed to devel@ovirt. If you do NOT want to be subscribed, please send me a private request. Then, for several months, we'd see how it goes, and whether we drown in unrelated Engine chatter. - We had a very (too) heated debate about ignoring failures of setDomainRegularRole() in http://gerrit.ovirt.org/24495/ and http://gerrit.ovirt.org/25424. The pain point is that relying on domain role (master/regular) is faulty by design. We cannot avoid the cases where a pool has more than one domain with a master role written in its metadata. One side argued that oVirt should be fixed to handle this unescapable truth, or at least enumerate the places where Vdsm and Engine, both current and old, depend on master role uniqueness. The other side argued that this is not a priority task, and that we should try to garbage-collect known-bad master roles as a courtesy to people digging into domain metadata, and as a means to lessen the problem until we kill the pool concept in the upcoming version. I hope that I present the debate fairly enough. Dan. ___ vdsm-devel mailing list vdsm-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-devel ___ vdsm-devel mailing list vdsm-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-devel
[vdsm] vdsm sync meeting minutes Feb 24th, 2014
vdsm sync call Feb 24th 2014 = - Toni to add Douglas to the linkPool patch so it can go into the build. - Try and give karma to iscsiadm bug https://bugzilla.redhat.com/1057761 https://admin.fedoraproject.org/updates/selinux-policy-3.12.1-74.19.fc19 Needs to be backported as well. Douglas offers to help with the testing for karma giving. - TLV meeting: - Design and architecture discussion: Nir proposes to go over the general design. Dispatcher, tasks. Adam agrees with the design request and warns about Python constructs for the possibility of hidden pitfalls. - Style guide discussion: Documentation, idioms, etc. Nir, Adam and Toni subscribe that. Adam proposes pushing for smaller patches. Toni pushes for topic branches of smaller patches that are considered in the context of the branch and not as self-standing patches. - JSON rpc discussion: Revive? plan etc. Adam wants to talk about the needs to make the engine start using JSON and get rid of the hacks. AMQP plans. Find ways to deprecate XMLRPC and get the API consistent in its representations. - Task creation: Nir proposes to discuss the way in which tasks are handled between engine and vdsm, so that the task uuid is pushed from the engine. - Get some presentation about SLA side of thinks. Adam asks if maybe Martin or Doron could do that? ___ vdsm-devel mailing list vdsm-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-devel
Re: [vdsm] vdsm sync meeting minutes Feb 24th, 2014
- Original Message - From: ybronhei ybron...@redhat.com To: Antoni Segura Puimedon asegu...@redhat.com, VDSM Project Development vdsm-devel@lists.fedorahosted.org, Piotr Kliczewski piotr.kliczew...@gmail.com, Doron Fediuck dfedi...@redhat.com Sent: Monday, February 24, 2014 6:33:56 PM Subject: Re: [vdsm] vdsm sync meeting minutes Feb 24th, 2014 On 02/24/2014 05:06 PM, Antoni Segura Puimedon wrote: vdsm sync call Feb 24th 2014 = - Toni to add Douglas to the linkPool patch so it can go into the build. - Try and give karma to iscsiadm bug https://bugzilla.redhat.com/1057761 https://admin.fedoraproject.org/updates/selinux-policy-3.12.1-74.19.fc19 Needs to be backported as well. Douglas offers to help with the testing for karma giving. - TLV meeting: - Design and architecture discussion: Nir proposes to go over the general design. Dispatcher, tasks. Adam agrees with the design request and warns about Python constructs for the possibility of hidden pitfalls. - Style guide discussion: Documentation, idioms, etc. Nir, Adam and Toni subscribe that. Adam proposes pushing for smaller patches. Toni pushes for topic branches of smaller patches that are considered in the context of the branch and not as self-standing patches. - JSON rpc discussion: Revive? plan etc. Adam wants to talk about the needs to make the engine start using JSON and get rid of the hacks. AMQP plans. Find ways to deprecate XMLRPC and get the API consistent in its representations. - Task creation: Nir proposes to discuss the way in which tasks are handled between engine and vdsm, so that the task uuid is pushed from the engine. - Get some presentation about SLA side of thinks. Adam asks if maybe Martin or Doron could do that? ___ vdsm-devel mailing list vdsm-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-devel Hey, sorry to miss the call today, I was at first but dropped after we started the discussion and failed to join back the json rpc part is merged to vdsm, pushed by saggi and Piotr, maybe Piotr can add more plan's details about that part? about the design and architecture discussion, i also think we should talk how we can improve\refactor mainly the tasks infrastructure, i know that some groups have stable roadmap plans (not only SLA) that can be shared for discussion and review (mostly storage parts - e.g. removing the pool concept), and we'll discuss about more suggestions for improvement that will be raised. -- Yaniv Bronhaim. Hi guys, Martin is joining you to help where possible. Please let me know what are you aiming for and we'll make sure you have the SLA view for it. In general I can tell you we have a few things planned for the next 2++ versions, so we need to focus on the relevant parts of your meetup. ___ vdsm-devel mailing list vdsm-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-devel
Re: [vdsm] vdsm sync meeting minutes Feb 24th, 2014
On 02/24/2014 10:06 AM, Antoni Segura Puimedon wrote: vdsm sync call Feb 24th 2014 = - Toni to add Douglas to the linkPool patch so it can go into the build. Hey Toni, please get it approved/backported for the ovirt-3.4 branch. - Try and give karma to iscsiadm bug https://bugzilla.redhat.com/1057761 https://admin.fedoraproject.org/updates/selinux-policy-3.12.1-74.19.fc19 Needs to be backported as well. Douglas offers to help with the testing for karma giving. Added karma/updated bug since during my tests the selinux permission error is gone. https://admin.fedoraproject.org/updates/selinux-policy-3.12.1-74.19.fc19 https://bugzilla.redhat.com/show_bug.cgi?id=1057761#c4 - TLV meeting: - Design and architecture discussion: Nir proposes to go over the general design. Dispatcher, tasks. Adam agrees with the design request and warns about Python constructs for the possibility of hidden pitfalls. - Style guide discussion: Documentation, idioms, etc. Nir, Adam and Toni subscribe that. Adam proposes pushing for smaller patches. Toni pushes for topic branches of smaller patches that are considered in the context of the branch and not as self-standing patches. - JSON rpc discussion: Revive? plan etc. Adam wants to talk about the needs to make the engine start using JSON and get rid of the hacks. AMQP plans. Find ways to deprecate XMLRPC and get the API consistent in its representations. - Task creation: Nir proposes to discuss the way in which tasks are handled between engine and vdsm, so that the task uuid is pushed from the engine. - Get some presentation about SLA side of thinks. Adam asks if maybe Martin or Doron could do that? ___ vdsm-devel mailing list vdsm-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-devel -- Cheers Douglas ___ vdsm-devel mailing list vdsm-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-devel
Re: [vdsm] vdsm sync meeting minutes - Nov 18
On Nov 18, 2013, at 20:59 , Dan Kenigsberg dan...@redhat.com wrote: Things we've discussed - pending iscsi dependency (fixed master branch since meeting) http://gerrit.ovirt.org/21385 - We should strive to keep master usable by el6 (and other supported platforms). We forgot to discuss the issue blocking our spec-checking jenkins job: cpopen collision. Yaniv, are there any updates on that? - function storage/virt tests needs a parent and extension. Ayal says that A storage developer was assigned to that task, expect improvement within weeks. - Vdsm is asked to report information about various VM-related long processes: VM migration, live storage migration, live merge. There was a universal agreement that getAllVmStats is a reasonable place to add those. Michal, Saggi, would it be fine? yes, this is what i originally had in mind, perfect! - failing `make distcheck`: Toni to try monkey-patching the constants module when the schema is built. - Nir's mock module needs review, and later - a decision. There was a disagreement regarding its necessity/helpfulness. See ya! ___ vdsm-devel mailing list vdsm-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-devel ___ vdsm-devel mailing list vdsm-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-devel
Re: [vdsm] vdsm sync meeting minutes - Nov 18
- Original Message - From: Dan Kenigsberg dan...@redhat.com To: VDSM Project Development vdsm-devel@lists.fedorahosted.org Cc: ybron...@redhat.com, smizr...@redhat.com, mskri...@redhat.com, nsof...@redhat.com Sent: Monday, November 18, 2013 9:59:53 PM Subject: vdsm sync meeting minutes - Nov 18 Things we've discussed - pending iscsi dependency (fixed master branch since meeting) http://gerrit.ovirt.org/21385 - We should strive to keep master usable by el6 (and other supported platforms). We forgot to discuss the issue blocking our spec-checking jenkins job: cpopen collision. Yaniv, are there any updates on that? After releasing 1.2.3-4 and merging http://gerrit.ovirt.org/20489 I don't face any collisions . any specific issue? I'll verify on clean environment, I might miss it might be that the jobs still use cpopen 1.2.3-2 without the Obsoletes fix? - function storage/virt tests needs a parent and extension. Ayal says that A storage developer was assigned to that task, expect improvement within weeks. - Vdsm is asked to report information about various VM-related long processes: VM migration, live storage migration, live merge. There was a universal agreement that getAllVmStats is a reasonable place to add those. Michal, Saggi, would it be fine? - failing `make distcheck`: Toni to try monkey-patching the constants module when the schema is built. - Nir's mock module needs review, and later - a decision. There was a disagreement regarding its necessity/helpfulness. fyi, the mocking issue: http://gerrit.ovirt.org/#/c/21155/ and usage example in http://gerrit.ovirt.org/#/c/20720/17/tests/toolLvmDeactivateLvsTests.py See ya! ___ vdsm-devel mailing list vdsm-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-devel
[vdsm] vdsm sync meeting minutes - Nov 18
Things we've discussed - pending iscsi dependency (fixed master branch since meeting) http://gerrit.ovirt.org/21385 - We should strive to keep master usable by el6 (and other supported platforms). We forgot to discuss the issue blocking our spec-checking jenkins job: cpopen collision. Yaniv, are there any updates on that? - function storage/virt tests needs a parent and extension. Ayal says that A storage developer was assigned to that task, expect improvement within weeks. - Vdsm is asked to report information about various VM-related long processes: VM migration, live storage migration, live merge. There was a universal agreement that getAllVmStats is a reasonable place to add those. Michal, Saggi, would it be fine? - failing `make distcheck`: Toni to try monkey-patching the constants module when the schema is built. - Nir's mock module needs review, and later - a decision. There was a disagreement regarding its necessity/helpfulness. See ya! ___ vdsm-devel mailing list vdsm-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-devel
Re: [vdsm] vdsm sync meeting minutes - Nov 18
- Original Message - From: Dan Kenigsberg dan...@redhat.com To: VDSM Project Development vdsm-devel@lists.fedorahosted.org Cc: mskri...@redhat.com Sent: Monday, November 18, 2013 8:59:53 PM Subject: [vdsm] vdsm sync meeting minutes - Nov 18 Things we've discussed - pending iscsi dependency (fixed master branch since meeting) http://gerrit.ovirt.org/21385 - We should strive to keep master usable by el6 (and other supported platforms). We forgot to discuss the issue blocking our spec-checking jenkins job: cpopen collision. Yaniv, are there any updates on that? - function storage/virt tests needs a parent and extension. Ayal says that A storage developer was assigned to that task, expect improvement within weeks. - Vdsm is asked to report information about various VM-related long processes: VM migration, live storage migration, live merge. There was a universal agreement that getAllVmStats is a reasonable place to add those. Michal, Saggi, would it be fine? - failing `make distcheck`: Toni to try monkey-patching the constants module when the schema is built. And also the tests in the testrunner due to the check part of distcheck. Another point that was not raised but should be addessed: - Reduce the excessive cpopen calling from _nic_devices. - Nir's mock module needs review, and later - a decision. There was a disagreement regarding its necessity/helpfulness. See ya! ___ vdsm-devel mailing list vdsm-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-devel ___ vdsm-devel mailing list vdsm-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-devel
