Re: [vdsm] new API verb: getVersionInfo()

2012-10-21 Thread Peter V. Saveliev
21.10.2012 09:23, Dan Kenigsberg kirjoitti: skip / We should decide NOW on the format of the capabilities «bag», and never change it. Testing for a capability is much more reliable than checking a version, and remembering which version had which capability. Dan. Ok, so what will we decide?

Re: [vdsm] new API verb: getVersionInfo()

2012-10-21 Thread Dan Kenigsberg
On Sun, Oct 21, 2012 at 02:26:44PM +0200, Peter V. Saveliev wrote: 21.10.2012 09:23, Dan Kenigsberg kirjoitti: skip / We should decide NOW on the format of the capabilities «bag», and never change it. Testing for a capability is much more reliable than checking a version, and remembering

Re: [vdsm] new API verb: getVersionInfo()

2012-10-19 Thread Vinzenz Feenstra
- From: Vinzenz Feenstra vfeen...@redhat.com To: Itamar Heim ih...@redhat.com Cc: Saggi Mizrahi smizr...@redhat.com, Michal Skrivanek mskri...@redhat.com, vdsm-devel@lists.fedorahosted.org Sent: Thursday, October 18, 2012 3:15:47 PM Subject: Re: [vdsm] new API verb: getVersionInfo() On 10/18/2012 08

Re: [vdsm] new API verb: getVersionInfo()

2012-10-18 Thread Dan Kenigsberg
On Wed, Oct 17, 2012 at 10:07:43AM -0500, Adam Litke wrote: Thanks for posting your idea on the list here. I like the idea of a more fine-grained version query API. getVdsCapabilities has become too much of a catch-all and I agree that something lighter is useful. I do think vdsm will want

Re: [vdsm] new API verb: getVersionInfo()

2012-10-18 Thread Saggi Mizrahi
dan...@redhat.com To: Adam Litke a...@us.ibm.com Cc: vdsm-devel@lists.fedorahosted.org, Michal Skrivanek mskri...@redhat.com Sent: Thursday, October 18, 2012 4:38:16 AM Subject: Re: [vdsm] new API verb: getVersionInfo() On Wed, Oct 17, 2012 at 10:07:43AM -0500, Adam Litke wrote: Thanks

Re: [vdsm] new API verb: getVersionInfo()

2012-10-18 Thread Itamar Heim
On 10/18/2012 06:03 PM, Saggi Mizrahi wrote: currently getVdsCaps() does a lot of unrelated things most of them have no relation to capabilites. This was done because of HTTP overhead. Instead of calling multiple commands we will call one that does everything. I agree with the suggestion that

Re: [vdsm] new API verb: getVersionInfo()

2012-10-18 Thread Vinzenz Feenstra
On 10/18/2012 08:34 PM, Itamar Heim wrote: On 10/18/2012 06:03 PM, Saggi Mizrahi wrote: currently getVdsCaps() does a lot of unrelated things most of them have no relation to capabilites. This was done because of HTTP overhead. Instead of calling multiple commands we will call one that does

Re: [vdsm] new API verb: getVersionInfo()

2012-10-18 Thread Saggi Mizrahi
mskri...@redhat.com, vdsm-devel@lists.fedorahosted.org Sent: Thursday, October 18, 2012 3:15:47 PM Subject: Re: [vdsm] new API verb: getVersionInfo() On 10/18/2012 08:34 PM, Itamar Heim wrote: On 10/18/2012 06:03 PM, Saggi Mizrahi wrote: currently getVdsCaps() does a lot of unrelated things

Re: [vdsm] new API verb: getVersionInfo()

2012-10-18 Thread Peter V. Saveliev
18.10.2012 18:03, Saggi Mizrahi kirjoitti: currently getVdsCaps() does a lot of unrelated things most of them have no relation to capabilites. This was done because of HTTP overhead. Instead of calling multiple commands we will call one that does everything. skip / Can I please make a small

Re: [vdsm] new API verb: getVersionInfo()

2012-10-18 Thread Peter V. Saveliev
… Just to be clear: yes, I think, that getVdsCapabilities() can and should be optimized, but as well it has quite different meaning for different purposes. And what about capabilities «bag» — its format also can be a subject of a change (e.g. long int bitmask ⇒ list of literals), but the version