Change in vdsm[master]: make compression type configurable, support gzip and xz

2012-05-14 Thread shaohef
ShaoHe Feng has posted comments on this change. Change subject: make compression type configurable, support gzip and xz .. Patch Set 2: xz is Higher compression efficiency than gzip. vdsm-4.9.6.tar.gz is 455924 bytes

Change in vdsm[master]: make compression type configurable, support gzip and xz

2012-05-14 Thread shaohef
ShaoHe Feng has posted comments on this change. Change subject: make compression type configurable, support gzip and xz .. Patch Set 2: sorry. a mistake. xz is Higher compression efficiency than gzip. vdsm-4.9.6.tar.xz is

Change in vdsm[master]: MOM Integration

2012-05-14 Thread wudxw
Mark Wu has posted comments on this change. Change subject: MOM Integration .. Patch Set 7: Hi Dan, Thanks a lot for the review. I am going to revise the patch as per your comments. And the unittest will be included in next

Change in vdsm[master]: libvirtvm.py: Extend controller support to allow configuring...

2012-05-14 Thread hdegoede
Hans De Goede has posted comments on this change. Change subject: libvirtvm.py: Extend controller support to allow configuring USB controllers .. Patch Set 3: (2 inline comments)

Change in vdsm[master]: BZ#788640 - Add [block|file]SD.getAllVolumes

2012-05-14 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: BZ#788640 - Add [block|file]SD.getAllVolumes .. Patch Set 11: (2 inline comments) File

Change in vdsm[master]: introducing test package to vdsm

2012-05-14 Thread smizrahi
Saggi Mizrahi has posted comments on this change. Change subject: introducing test package to vdsm .. Patch Set 4: (7 inline comments) This patch does too many things and is a bit confusing, please have every change in it's

Change in vdsm[master]: introducing test package to vdsm

2012-05-14 Thread smizrahi
Saggi Mizrahi has posted comments on this change. Change subject: introducing test package to vdsm .. Patch Set 4: I would prefer that you didn't submit this -- To view, visit http://gerrit.ovirt.org/3923 To unsubscribe, visit

Change in vdsm[master]: remove stale libvirtNet before creating a new net with same ...

2012-05-14 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: remove stale libvirtNet before creating a new net with same name .. Patch Set 1: (2 inline comments) File

Change in vdsm[master]: remove stale libvirtNet before creating a new net with same ...

2012-05-14 Thread Avi Tal
Avi Tal has posted comments on this change. Change subject: remove stale libvirtNet before creating a new net with same name .. Patch Set 2: Verified -- To view, visit http://gerrit.ovirt.org/4370 To unsubscribe, visit

Change in vdsm[master]: Add the async kwarg to acquireHostId

2012-05-14 Thread smizrahi
Saggi Mizrahi has posted comments on this change. Change subject: Add the async kwarg to acquireHostId .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/4392 To

Change in vdsm[master]: Make domainMonitor compliant to PEP8

2012-05-14 Thread smizrahi
Saggi Mizrahi has posted comments on this change. Change subject: Make domainMonitor compliant to PEP8 .. Patch Set 3: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/3928 To

Change in vdsm[master]: make compression type configurable, support gzip and xz

2012-05-14 Thread shaohef
ShaoHe Feng has posted comments on this change. Change subject: make compression type configurable, support gzip and xz .. Patch Set 2: (1 inline comment) File configure.ac

Change in vdsm[master]: [WIP] List storage domains using monitoredDomains

2012-05-14 Thread fsimonce
Federico Simoncelli has uploaded a new change for review. Change subject: [WIP] List storage domains using monitoredDomains .. [WIP] List storage domains using monitoredDomains To get the list of the storage domains that vdsm

Change in vdsm[master]: remove stale libvirtNet before creating a new net with same ...

2012-05-14 Thread ilvovsky
Igor Lvovsky has posted comments on this change. Change subject: remove stale libvirtNet before creating a new net with same name .. Patch Set 2: Looks good to me, but someone else must approve -- To view, visit

Change in vdsm[master]: remove stale libvirtNet before creating a new net with same ...

2012-05-14 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: remove stale libvirtNet before creating a new net with same name .. Patch Set 2: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4370 To

Change in vdsm[master]: remove stale libvirtNet before creating a new net with same ...

2012-05-14 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: remove stale libvirtNet before creating a new net with same name .. remove stale libvirtNet before creating a new net with same name Vdsm is the owner

Change in vdsm[master]: rest-api: Add the basic server infrastructure

2012-05-14 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: rest-api: Add the basic server infrastructure .. rest-api: Add the basic server infrastructure Add a new API binding for a REST API based on CherryPy

Change in vdsm[master]: rest-api: Add the basic server infrastructure

2012-05-14 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: rest-api: Add the basic server infrastructure .. Patch Set 8: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/2021 To

Change in vdsm[master]: Tunnel errors from child to parent in betterPopen

2012-05-14 Thread smizrahi
Saggi Mizrahi has uploaded a new change for review. Change subject: Tunnel errors from child to parent in betterPopen .. Tunnel errors from child to parent in betterPopen Change-Id: I05d89d92728ffd34e2eff9fd8d63b1bce72d3f9d

Change in vdsm[master]: Tunnel errors from child to parent in betterPopen

2012-05-14 Thread smizrahi
Saggi Mizrahi has uploaded a new change for review. Change subject: Tunnel errors from child to parent in betterPopen .. Tunnel errors from child to parent in betterPopen Change-Id: I2d4a132317e9cf0843671460a0876f615760731d

Change in vdsm[master]: Tunnel errors from child to parent in betterPopen

2012-05-14 Thread smizrahi
Saggi Mizrahi has abandoned this change. Change subject: Tunnel errors from child to parent in betterPopen .. Patch Set 1: Abandoned -- To view, visit http://gerrit.ovirt.org/4410 To unsubscribe, visit

Change in vdsm[master]: make compression type configurable, support gzip and xz

2012-05-14 Thread smizrahi
Saggi Mizrahi has posted comments on this change. Change subject: make compression type configurable, support gzip and xz .. Patch Set 2: I would prefer that you didn't submit this Why do it at build time rather then runtime?

Change in vdsm[master]: make compression type configurable, support gzip and xz

2012-05-14 Thread shaohef
ShaoHe Feng has posted comments on this change. Change subject: make compression type configurable, support gzip and xz .. Patch Set 2: it is better that do it at runtime. but how to do it at runtime? i.e. if user using rpm

Change in vdsm[master]: Add a function wrapper to vdsm-tool for /etc/inid.d/function...

2012-05-14 Thread wenyi
Wenyi Gao has uploaded a new change for review. Change subject: Add a function wrapper to vdsm-tool for /etc/inid.d/functions .. Add a function wrapper to vdsm-tool for /etc/inid.d/functions Change-Id:

Change in vdsm[master]: rest-api: Model volumes

2012-05-14 Thread wudxw
Mark Wu has posted comments on this change. Change subject: rest-api: Model volumes .. Patch Set 6: I would prefer that you didn't submit this (1 inline comment) Sorry for not raising this problem earlier. I just notice this

Change in vdsm[master]: Reraise errors from underlying c code in betterPopen

2012-05-14 Thread xiawenc
Wenchao Xia has posted comments on this change. Change subject: Reraise errors from underlying c code in betterPopen .. Patch Set 1: if the error is not raised, what would happen? -- To view, visit

Change in vdsm[master]: dsaversion: renamed to dsaversion.in

2012-05-14 Thread dougsland
Douglas Schilling Landgraf has posted comments on this change. Change subject: dsaversion: renamed to dsaversion.in .. Patch Set 2: Verified -- To view, visit http://gerrit.ovirt.org/4284 To unsubscribe, visit

Change in vdsm[master]: Support unicode args in betterPopen

2012-05-14 Thread xiawenc
Wenchao Xia has posted comments on this change. Change subject: Support unicode args in betterPopen .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/4414 To unsubscribe,

Change in vdsm[master]: Tunnel errors from child to parent in betterPopen

2012-05-14 Thread xiawenc
Wenchao Xia has posted comments on this change. Change subject: Tunnel errors from child to parent in betterPopen .. Patch Set 1: (1 inline comment) reviewed, and have some technic questions that I did not catch up with the

Change in vdsm[master]: Reraise errors from underlying c code in betterPopen

2012-05-14 Thread xiawenc
Wenchao Xia has posted comments on this change. Change subject: Reraise errors from underlying c code in betterPopen .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/4412 To unsubscribe, visit

Change in vdsm[master]: configure.ac: add python-devel requirement

2012-05-14 Thread dougsland
Douglas Schilling Landgraf has uploaded a new change for review. Change subject: configure.ac: add python-devel requirement .. configure.ac: add python-devel requirement vdsm/betterPopen: requires python-devel package.

Change in vdsm[master]: configure.ac: add python-devel requirement

2012-05-14 Thread dougsland
Douglas Schilling Landgraf has posted comments on this change. Change subject: configure.ac: add python-devel requirement .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/4420 To unsubscribe, visit

Change in vdsm[master]: configNetwork: remove skipLibvirt flag

2012-05-14 Thread dougsland
Douglas Schilling Landgraf has posted comments on this change. Change subject: configNetwork: remove skipLibvirt flag .. Patch Set 2: Verified -- To view, visit http://gerrit.ovirt.org/4342 To unsubscribe, visit

Change in vdsm[master]: Get network address to showNetwork

2012-05-14 Thread lilei
Lei Li has posted comments on this change. Change subject: Get network address to showNetwork .. Patch Set 2: (1 inline comment) File vdsm/configNetwork.py Line 708:

Change in vdsm[master]: Reraise errors from underlying c code in betterPopen

2012-05-14 Thread xiawenc
Wenchao Xia has posted comments on this change. Change subject: Reraise errors from underlying c code in betterPopen .. Patch Set 1: No score; Looks good to me, but someone else must approve -- To view, visit