Shahar Havivi has posted comments on this change.
Change subject: promisc: bug fixes, change name to port-mirroring
..
Patch Set 7: (1 inline comment)
File vdsm/libvirtvm.py
Dan Kenigsberg has posted comments on this change.
Change subject: Added Gluster file system management support.
..
Patch Set 16: I would prefer that you didn't submit this
I do not see that you've followed Federico's advice. W
Dan Kenigsberg has posted comments on this change.
Change subject: Added gluster cli support in supervdsm.
..
Patch Set 19: I would prefer that you didn't submit this
(1 inline comment)
I'm fine if you promise to fix this in a
Dan Kenigsberg has posted comments on this change.
Change subject: promisc: bug fixes, change name to port-mirroring
..
Patch Set 7: I would prefer that you didn't submit this
(1 inline comment)
...
Dan Kenigsberg has posted comments on this change.
Change subject: Modify scripts in vdsm_cli/ for PEP8 compliance
..
Patch Set 5: Fails; I would prefer that you didn't submit this
(1 inline comment)
Luckily, submission has fa
Dan Kenigsberg has posted comments on this change.
Change subject: Modify scripts in vdsm_cli/ for PEP8 compliance
..
Patch Set 5: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4106
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: clean PEP 8 problems in caps.py clientIF.py guestIF.py
..
Patch Set 1: Looks good to me, but someone else must approve
Please have someone else review it, too,
Dan Kenigsberg has submitted this change and it was merged.
Change subject: tests: Clean up sample text in fileUtilTests.py
..
tests: Clean up sample text in fileUtilTests.py
I understand the value of humor and I am certain no
ShaoHe Feng has uploaded a new change for review.
Change subject: change the code style of persistentDict.py for PEP8 compliance
..
change the code style of persistentDict.py for PEP8 compliance
Change-Id: I8b531d70a72be9bd1b08f
ShaoHe Feng has uploaded a new change for review.
Change subject: change the code style of before_vm_start.py for PEP8 compliance
..
change the code style of before_vm_start.py for PEP8 compliance
Change-Id: I15551c9a756b3c1e3f1
ShaoHe Feng has uploaded a new change for review.
Change subject: change the code style of resourceFactories.py for PEP8
compliance
..
change the code style of resourceFactories.py for PEP8 compliance
Change-Id: I55935f921f8466
ShaoHe Feng has uploaded a new change for review.
Change subject: change the code style of BindingXMLRPC.py for PEP8 compliance
..
change the code style of BindingXMLRPC.py for PEP8 compliance
Change-Id: Ibb8c8c57d4eb2628a6e49a2
ShaoHe Feng has uploaded a new change for review.
Change subject: change the code style of before_vm_start.py for PEP8 compliance
..
change the code style of before_vm_start.py for PEP8 compliance
Change-Id: Ie2c1602db5457ee1751
Douglas Schilling Landgraf has posted comments on this change.
Change subject: Report that Engine 3.1 is supported by this Vdsm.
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ov
Dan Kenigsberg has uploaded a new change for review.
Change subject: Report that Engine 3.1 is supported by this Vdsm.
..
Report that Engine 3.1 is supported by this Vdsm.
Change-Id: I407202bad56a0cf865c6c58def5a334594913296
Sig
Wenyi Gao has abandoned this change.
Change subject: Fix pep8 problems
..
Patch Set 2: Abandoned
Cut it into small patches for easy review
--
To view, visit http://gerrit.ovirt.org/4453
To unsubscribe, visit http://gerrit.ovir
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Change to use WatchedFileHandler instead of FileHandler in
logger.conf
..
Change to use WatchedFileHandler instead of FileHandler in logger.conf
We fi
Dan Kenigsberg has posted comments on this change.
Change subject: Change to use WatchedFileHandler instead of FileHandler in
logger.conf
..
Patch Set 2:
I happy either way, as long as no logger message is left behind.
--
To
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: tests: Add functional tests
..
Patch Set 4: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/4452
To unsubs
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: tests: Package up tests
..
Patch Set 4: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/4451
To unsubscrib
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: tests: Package up tests
..
Patch Set 3:
I don't know autotools well enough to comment on this. It's needed which is
good enough for me now.
--
To
Adam Litke has posted comments on this change.
Change subject: tests: Add functional tests
..
Patch Set 4: Verified
--
To view, visit http://gerrit.ovirt.org/4452
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-M
Adam Litke has posted comments on this change.
Change subject: tests: Package up tests
..
Patch Set 4: Verified
--
To view, visit http://gerrit.ovirt.org/4451
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-Messa
Adam Litke has posted comments on this change.
Change subject: tests: Package up tests
..
Patch Set 3: (1 inline comment)
File tests/run_tests.sh.in
Line 2: prefix="@prefix@"
Adam Litke has posted comments on this change.
Change subject: tests: Add functional tests
..
Patch Set 3: No score
Ewoud, you're absolutely right. I have too many open patches floating around
and somehow I lost that particul
Shahar Havivi has posted comments on this change.
Change subject: promisc: bug fixes, change name to port-mirroring
..
Patch Set 7: Verified
--
To view, visit http://gerrit.ovirt.org/4359
To unsubscribe, visit http://gerrit.ovi
Shahar Havivi has posted comments on this change.
Change subject: promisc: bug fixes, change name to port-mirroring
..
Patch Set 6: (2 inline comments)
File vdsm/tc.py
Line 5
Bala.FA has posted comments on this change.
Change subject: Added Gluster file system management support.
..
Patch Set 15: (1 inline comment)
File vdsm_cli/vdsm_cli_gluster_e
Bala.FA has posted comments on this change.
Change subject: Added gluster cli support in supervdsm.
..
Patch Set 18: (2 inline comments)
File vdsm/gluster/cli.py
Line 27: fro
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: tests: Package up tests
..
Patch Set 3: Looks good to me, but someone else must approve
(1 inline comment)
Looks good, minor comment inline.
.
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: tests: Add functional tests
..
Patch Set 3:
I don't see the lambda modification. Now I think the patch could be submitted
without it but when I see
Royce Lv has posted comments on this change.
Change subject: remove /rhel/data-center after vdsm uninstalled
..
Patch Set 6:
I really like the data restored in the users machine rather than erase it:
1.It maybe better for us to
Mark Wu has posted comments on this change.
Change subject: Change to use WatchedFileHandler instead of FileHandler in
logger.conf
..
Patch Set 2:
Dan,
Let me clarify it. Changming means that the new log file is not created
i
Federico Simoncelli has posted comments on this change.
Change subject: Remove unnecesary preparePaths.
..
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
Federico Simoncelli has posted comments on this change.
Change subject: Added Gluster file system management support.
..
Patch Set 15: (1 inline comment)
File vdsm_cli/vdsm_c
Federico Simoncelli has posted comments on this change.
Change subject: Added gluster cli support in supervdsm.
..
Patch Set 18: I would prefer that you didn't submit this
(2 inline comments)
Feel free to override the -1 if in
Dan Kenigsberg has posted comments on this change.
Change subject: Change to use WatchedFileHandler instead of FileHandler in
logger.conf
..
Patch Set 2:
Chambing, I do not understand. After logrotate, does Vdsm starts filling
Royce Lv has posted comments on this change.
Change subject: tests: Package up tests
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/4451
To unsubscribe, visit http://ge
Dan Kenigsberg has posted comments on this change.
Change subject: BZ#822782 - use mkstemp() on older systems
..
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
the code seems right, but it's better
Changming Bai has posted comments on this change.
Change subject: Change to use WatchedFileHandler instead of FileHandler in
logger.conf
..
Patch Set 2: Verified
Write some log message into the vdsm.log file(the file size more
Royce Lv has posted comments on this change.
Change subject: Modify pthread.py comply to pep8
..
Patch Set 2: (1 inline comment)
File Makefile.am
Line 48: vdsm/pthread.py
Nigel Jones has uploaded a new change for review.
Change subject: BZ#822782 - use mkstemp() on older systems
..
BZ#822782 - use mkstemp() on older systems
Registering RHEL5 systems will fail as NamedTemporaryFile() in
python 2.4
42 matches
Mail list logo
