Change in vdsm[master]: BZ#784931 - Restore SD.validate() semantics.

Eduardo has posted comments on this change. Change subject: BZ#784931 - Restore SD.validate() semantics. .. Patch Set 2: (1 inline comment) File vdsm/storage/blockSD.py Line

Change in vdsm[master]: Change oop to be a new process instead of a fork

Saggi Mizrahi has posted comments on this change. Change subject: Change oop to be a new process instead of a fork .. Patch Set 3: (4 inline comments) File

Change in vdsm[master]: Change oop to be a new process instead of a fork

Dan Kenigsberg has posted comments on this change. Change subject: Change oop to be a new process instead of a fork .. Patch Set 3: (2 inline comments) File

Change in vdsm[master]: Automatic reconnection to the Storage Pool

Eduardo has posted comments on this change. Change subject: Automatic reconnection to the Storage Pool .. Patch Set 2: I would prefer that you didn't submit this (2 inline comments)

Change in vdsm[master]: BZ#826022 Disable the sanlock volume leases

Eduardo has posted comments on this change. Change subject: BZ#826022 Disable the sanlock volume leases .. Patch Set 1: I would prefer that you didn't submit this (1 inline comment)

Change in vdsm[master]: BZ#826022 Disable the sanlock volume leases

Allon Mureinik has posted comments on this change. Change subject: BZ#826022 Disable the sanlock volume leases .. Patch Set 1: (1 inline comment) File vdsm/libvirtvm.py Line

Change in vdsm[master]: Fix attachSD and masterMigrate for domain version 3

Eduardo has posted comments on this change. Change subject: Fix attachSD and masterMigrate for domain version 3 .. Patch Set 9: I would prefer that you didn't submit this (2 inline comments)

Change in vdsm[master]: Change oop to be a new process instead of a fork

Ayal Baron has posted comments on this change. Change subject: Change oop to be a new process instead of a fork .. Patch Set 3: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/4318 To

Change in vdsm[master]: configNetworks: reject bridge names starting w/ dash

Dan Kenigsberg has uploaded a new change for review. Change subject: configNetworks: reject bridge names starting w/ dash .. configNetworks: reject bridge names starting w/ dash Evil users may attempt to create bridges with

Change in vdsm[master]: configuNetworks: no need to create set repeatedly

Dan Kenigsberg has uploaded a new change for review. Change subject: configuNetworks: no need to create set repeatedly .. configuNetworks: no need to create set repeatedly Yes, this is a very minor performance improvement, but

Change in vdsm[master]: configNetworks: reject bridge names starting w/ dash

Igor Lvovsky has posted comments on this change. Change subject: configNetworks: reject bridge names starting w/ dash .. Patch Set 1: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5004 To unsubscribe,

Change in vdsm[master]: configuNetworks: no need to create set repeatedly

Igor Lvovsky has posted comments on this change. Change subject: configuNetworks: no need to create set repeatedly .. Patch Set 1: Looks good to me, approved What about squashing these two? -- To view, visit

Change in vdsm[master]: configNetworks: reject bridge names starting w/ dash

Dan Kenigsberg has posted comments on this change. Change subject: configNetworks: reject bridge names starting w/ dash .. Patch Set 1: Verified verified with bridge names like '-foo'. btw, a patch sent to upstream

Change in vdsm[master]: [WIP] report another unique identity

Dan Kenigsberg has posted comments on this change. Change subject: [WIP] report another unique identity .. Patch Set 1: I would prefer that you didn't submit this (1 inline comment)

Change in vdsm[master]: Reuse the stored pool host id on reconstructMaster

Ayal Baron has posted comments on this change. Change subject: Reuse the stored pool host id on reconstructMaster .. Patch Set 1: I would prefer that you didn't submit this (2 inline comments)

Change in vdsm[master]: remove '/var/log/core' from fedora

Xu He Jie has posted comments on this change. Change subject: remove '/var/log/core' from fedora .. Patch Set 3: (4 inline comments) Hi, Dan, I found this patch too complex, I will separate it. I guess submit a topic branch

Change in vdsm[master]: add VdsmConfig.py for support writing comment to config file

Xu He Jie has posted comments on this change. Change subject: add VdsmConfig.py for support writing comment to config file .. Patch Set 1: (1 inline comment) Sorry for I didn't reply your comment. I agree your comment, so I

Change in vdsm[master]: pep8 clean vdsm/storage/hba.py

Zhou Zheng Sheng has posted comments on this change. Change subject: pep8 clean vdsm/storage/hba.py .. Patch Set 1: Verified The patch passes tests in vdsm. And I compare the old file and new file with a tool named pydiff.py.

Change in vdsm[master]: use default libvirt event handler impl

Royce Lv has posted comments on this change. Change subject: use default libvirt event handler impl .. Patch Set 1: Verified Verified:1.vdsm to libvirt connection,2.vm event got callback from libvirt -- To view, visit