Change in vdsm[master]: Make vdsm/clientIF.py PEP8 clean

Shu Ming has abandoned this change. Change subject: Make vdsm/clientIF.py PEP8 clean .. Patch Set 3: Abandoned This file will be covered in the next round of pep8 patches by Zhou Zheng Sheng. And new change ID will be used

Change in vdsm[master]: Make vdsm/caps.py PEP8 clean

Shu Ming has abandoned this change. Change subject: Make vdsm/caps.py PEP8 clean .. Patch Set 3: Abandoned This file will be covered in the next round of pep8 patches by Zhou Zheng Sheng. And new change ID will be used for

Change in vdsm[master]: Sort PEP 8 white list in Makefile.am

Zhou Zheng Sheng has uploaded a new change for review. Change subject: Sort PEP 8 white list in Makefile.am .. Sort PEP 8 white list in Makefile.am Change-Id: Ia28da6ff2280cc5b643642c563174c307201f0c8 Signed-off-by: Zhou Zheng

Change in vdsm[master]: Make vdsm/caps.py PEP8 clean

Zhou Zheng Sheng has uploaded a new change for review. Change subject: Make vdsm/caps.py PEP8 clean .. Make vdsm/caps.py PEP8 clean Change-Id: Ie6be4a2c9cdf58bcf36f861649303afdc87fd4d7 Signed-off-by: Zhou Zheng Sheng

Change in vdsm[master]: Make vdsm/clientIF.py PEP8 clean

Zhou Zheng Sheng has uploaded a new change for review. Change subject: Make vdsm/clientIF.py PEP8 clean .. Make vdsm/clientIF.py PEP8 clean Change-Id: I56949c0016348b5b19f03e8c82b33a1dfe016fb8 Signed-off-by: Zhou Zheng Sheng

Change in vdsm[master]: Make storage/sd.py PEP8 clean

Hello Royce Lv, I'd like you to do a code review. Please visit http://gerrit.ovirt.org/5415 to review the following change. Change subject: Make storage/sd.py PEP8 clean .. Make storage/sd.py PEP8 clean Change-Id:

Change in vdsm[master]: make vdsm_reg/createDaemon.py PEP8 clean

Hello Bing Bu Cao, I'd like you to do a code review. Please visit http://gerrit.ovirt.org/5417 to review the following change. Change subject: make vdsm_reg/createDaemon.py PEP8 clean .. make vdsm_reg/createDaemon.py

Change in vdsm[master]: make storage/iscsiadm.py PEP8 clean

Hello Bing Bu Cao, I'd like you to do a code review. Please visit http://gerrit.ovirt.org/5418 to review the following change. Change subject: make storage/iscsiadm.py PEP8 clean .. make storage/iscsiadm.py PEP8 clean

Change in vdsm[master]: Make pthread.py PEP8 clean

Hello Royce Lv, I'd like you to do a code review. Please visit http://gerrit.ovirt.org/5413 to review the following change. Change subject: Make pthread.py PEP8 clean .. Make pthread.py PEP8 clean Change-Id:

Change in vdsm[master]: make storage/securable.py PEP8 clean

Hello Wenchao Xia, I'd like you to do a code review. Please visit http://gerrit.ovirt.org/5416 to review the following change. Change subject: make storage/securable.py PEP8 clean .. make storage/securable.py PEP8 clean

Change in vdsm[master]: make libvirtev.py PEP8 clean

Hello ShaoHe Feng, I'd like you to do a code review. Please visit http://gerrit.ovirt.org/5420 to review the following change. Change subject: make libvirtev.py PEP8 clean .. make libvirtev.py PEP8 clean Change-Id:

Change in vdsm[master]: make libvirtev.py PEP8 clean

Bing Bu Cao has posted comments on this change. Change subject: make libvirtev.py PEP8 clean .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/5420 To unsubscribe, visit

Change in vdsm[master]: Make vdsm/caps.py PEP8 clean

Shu Ming has posted comments on this change. Change subject: Make vdsm/caps.py PEP8 clean .. Patch Set 3: See: http://gerrit.ovirt.org/#/c/5411/ -- To view, visit http://gerrit.ovirt.org/4801 To unsubscribe, visit

Change in vdsm[master]: Make vdsm/clientIF.py PEP8 clean

Shu Ming has posted comments on this change. Change subject: Make vdsm/clientIF.py PEP8 clean .. Patch Set 3: See: http://gerrit.ovirt.org/#/c/5412/ -- To view, visit http://gerrit.ovirt.org/4802 To unsubscribe, visit

Change in vdsm[master]: make storage/fuser.py PEP8 clean

Bing Bu Cao has posted comments on this change. Change subject: make storage/fuser.py PEP8 clean .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/5414 To unsubscribe,

Change in vdsm[master]: Make pthread.py PEP8 clean

Bing Bu Cao has posted comments on this change. Change subject: Make pthread.py PEP8 clean .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/5413 To unsubscribe, visit

Change in vdsm[master]: Make vdsm/caps.py PEP8 clean

Bing Bu Cao has posted comments on this change. Change subject: Make vdsm/caps.py PEP8 clean .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/5411 To unsubscribe, visit

Change in vdsm[master]: make storage/securable.py PEP8 clean

Bing Bu Cao has posted comments on this change. Change subject: make storage/securable.py PEP8 clean .. Patch Set 1: (1 inline comment) File vdsm/storage/securable.py Line

Change in vdsm[master]: Make vdsm/clientIF.py PEP8 clean

Bing Bu Cao has posted comments on this change. Change subject: Make vdsm/clientIF.py PEP8 clean .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/5412 To unsubscribe,

Change in vdsm[master]: Internal volumes must be RW in domain version 3

Ayal Baron has posted comments on this change. Change subject: Internal volumes must be RW in domain version 3 .. Patch Set 13: I would prefer that you didn't submit this (1 inline comment)

Change in vdsm[master]: make libvirtev.py PEP8 clean

ShaoHe Feng has posted comments on this change. Change subject: make libvirtev.py PEP8 clean .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/5420 To unsubscribe, visit

Change in vdsm[master]: Modify pthread.py comply to pep8

Royce Lv has abandoned this change. Change subject: Modify pthread.py comply to pep8 .. Patch Set 5: Abandoned submiitted a new one -- To view, visit http://gerrit.ovirt.org/4531 To unsubscribe, visit

Change in vdsm[master]: adding handling EINTR to poll to make it more robust

Dan Kenigsberg has posted comments on this change. Change subject: adding handling EINTR to poll to make it more robust .. Patch Set 5: I would prefer that you didn't submit this (1 inline comment) thanks for posting to

Change in vdsm[master]: Make vdsm/clientIF.py PEP8 clean

Ewoud Kohl van Wijngaarden has posted comments on this change. Change subject: Make vdsm/clientIF.py PEP8 clean .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/5412 To

Change in vdsm[master]: add arguments parser to testrunner

Wenchao Xia has posted comments on this change. Change subject: add arguments parser to testrunner .. Patch Set 6: (3 inline comments) File tests/testrunner.py Line 149:

Change in vdsm[master]: BZ#808874 Skip master validation on repoStat

Dan Kenigsberg has posted comments on this change. Change subject: BZ#808874 Skip master validation on repoStat .. Patch Set 1: Do not submit please abandon and re-post to the rhev-3.1 branch. -- To view, visit

Change in vdsm[master]: Sort PEP 8 white list in Makefile.am

Zhou Zheng Sheng has posted comments on this change. Change subject: Sort PEP 8 white list in Makefile.am .. Patch Set 1: Verified; Looks good to me, but someone else must approve Keeping the list sorted would help solving

Change in vdsm[master]: Internal volumes must be RW in domain version 3

Federico Simoncelli has posted comments on this change. Change subject: Internal volumes must be RW in domain version 3 .. Patch Set 13: (2 inline comments) File

Change in vdsm[master]: Fix typo (change socekt to socket) in libvirtvm.py and vm.py

Bing Bu Cao has uploaded a new change for review. Change subject: Fix typo (change socekt to socket) in libvirtvm.py and vm.py .. Fix typo (change socekt to socket) in libvirtvm.py and vm.py Change-Id:

Change in vdsm[master]: Make vdsm/caps.py PEP8 clean

Zhou Zheng Sheng has posted comments on this change. Change subject: Make vdsm/caps.py PEP8 clean .. Patch Set 1: Verified Passes by tests in vdsm. pydiff reports no changes on code logic. -- To view, visit

Change in vdsm[master]: Make vdsm/clientIF.py PEP8 clean

Zhou Zheng Sheng has posted comments on this change. Change subject: Make vdsm/clientIF.py PEP8 clean .. Patch Set 1: Verified Passes the tests in vdsm. pydiff reports 5 changes but all of them are like changing

Change in vdsm[master]: Internal volumes must be RW in domain version 3

Federico Simoncelli has posted comments on this change. Change subject: Internal volumes must be RW in domain version 3 .. Patch Set 13: (1 inline comment) File

Change in vdsm[master]: Make pthread.py PEP8 clean

Zhou Zheng Sheng has posted comments on this change. Change subject: Make pthread.py PEP8 clean .. Patch Set 1: Verified Passes the tests in vdsm. pydiff reports no change in code logic. -- To view, visit

Change in vdsm[master]: make storage/fuser.py PEP8 clean

Zhou Zheng Sheng has posted comments on this change. Change subject: make storage/fuser.py PEP8 clean .. Patch Set 1: Verified Passes tests in vdsm. pydiff reports no change in code logic. -- To view, visit

Change in vdsm[master]: Properly parse configurations in function do_create in vds...

Zhou Zheng Sheng has posted comments on this change. Change subject: Properly parse configurations in function do_create in vdsClient .. Patch Set 4: Add unit test for function do_create to verify config file is parsed the

Change in vdsm[master]: Internal volumes must be RW in domain version 3

Ayal Baron has posted comments on this change. Change subject: Internal volumes must be RW in domain version 3 .. Patch Set 13: (1 inline comment) File

Change in vdsm[master]: Internal volumes must be RW in domain version 3

Federico Simoncelli has posted comments on this change. Change subject: Internal volumes must be RW in domain version 3 .. Patch Set 13: (1 inline comment) File

Change in vdsm[master]: BZ#830486 - Allow to change network according the diffs from...

Igor Lvovsky has posted comments on this change. Change subject: BZ#830486 - Allow to change network according the diffs from previous state .. Patch Set 7: (1 inline comment)

Change in vdsm[master]: BZ#808874 Skip master validation on repoStat

Federico Simoncelli has abandoned this change. Change subject: BZ#808874 Skip master validation on repoStat .. Patch Set 1: Abandoned -- To view, visit http://gerrit.usersys.redhat.com/1318 To unsubscribe, visit

[ABANDONED PATCH] BZ#808874 Skip master validation on repoStat (via gerrit-bot)

Patch was abandoned by Federico Simoncelli (fsimo...@redhat.com) because: You can review this change at: http://gerrit.usersys.redhat.com/1318 ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: BZ#808874 Skip master validation on repoStat

Dan Kenigsberg has submitted this change and it was merged. Change subject: BZ#808874 Skip master validation on repoStat .. BZ#808874 Skip master validation on repoStat The current master validation code is affected by two

Change in vdsm[master]: Sort PEP 8 white list in Makefile.am

Dan Kenigsberg has posted comments on this change. Change subject: Sort PEP 8 white list in Makefile.am .. Patch Set 1: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5410 To unsubscribe, visit

Change in vdsm[master]: Sort PEP 8 white list in Makefile.am

Dan Kenigsberg has submitted this change and it was merged. Change subject: Sort PEP 8 white list in Makefile.am .. Sort PEP 8 white list in Makefile.am Change-Id: Ia28da6ff2280cc5b643642c563174c307201f0c8 Signed-off-by: Zhou

Change in vdsm[master]: Fix return value of shutdown() on failure

Mark Wu has uploaded a new change for review. Change subject: Fix return value of shutdown() on failure .. Fix return value of shutdown() on failure Change-Id: Ice01a8db664c8c1a3ca32c15de4865f362e7210e Signed-off-by: Mark Wu

Change in vdsm[master]: Properly parse configurations in function do_create in vds...

Ewoud Kohl van Wijngaarden has posted comments on this change. Change subject: Properly parse configurations in function do_create in vdsClient .. Patch Set 4: I would prefer that you didn't submit this (3 inline comments)

Change in vdsm[master]: Fix return value of shutdown() on failure

Ewoud Kohl van Wijngaarden has posted comments on this change. Change subject: Fix return value of shutdown() on failure .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit

Change in vdsm[master]: Fix typo (change socekt to socket) in libvirtvm.py and vm.py

Ewoud Kohl van Wijngaarden has posted comments on this change. Change subject: Fix typo (change socekt to socket) in libvirtvm.py and vm.py .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit

Change in vdsm[master]: Better documentation for cpuPinning

Laszlo Hornyak has posted comments on this change. Change subject: Better documentation for cpuPinning .. Patch Set 2: Verified; Looks good to me, but someone else must approve broken dopwn to multiple rows so that it fits 80

Change in vdsm[master]: Avoid racing condition of vmContainer's lenth

Shu Ming has posted comments on this change. Change subject: Avoid racing condition of vmContainer's lenth .. Patch Set 1: Is it time to merge this patch? -- To view, visit http://gerrit.ovirt.org/5202 To unsubscribe, visit

Change in vdsm[master]: Avoid racing condition of vmContainer's lenth

Dan Kenigsberg has posted comments on this change. Change subject: Avoid racing condition of vmContainer's lenth .. Patch Set 1: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5202 To unsubscribe, visit

Change in vdsm[master]: Avoid racing condition of vmContainer's lenth

Dan Kenigsberg has submitted this change and it was merged. Change subject: Avoid racing condition of vmContainer's lenth .. Avoid racing condition of vmContainer's lenth Change-Id: I8ca434d75180637721c8cb105e84b337094b632f

Change in vdsm[master]: Better documentation for cpuPinning

Dan Kenigsberg has posted comments on this change. Change subject: Better documentation for cpuPinning .. Patch Set 2: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5071 To unsubscribe, visit

Change in vdsm[master]: Better documentation for cpuPinning

Dan Kenigsberg has submitted this change and it was merged. Change subject: Better documentation for cpuPinning .. Better documentation for cpuPinning Replaces the documentation text with something more helpful with a link to

Change in vdsm[master]: VM.create: Normalize propagateErrors semantics

Adam Litke has posted comments on this change. Change subject: VM.create: Normalize propagateErrors semantics .. Patch Set 2: Verified -- To view, visit http://gerrit.ovirt.org/5299 To unsubscribe, visit

Change in vdsm[master]: rest-api: Handle resource links

Adam Litke has posted comments on this change. Change subject: rest-api: Handle resource links .. Patch Set 2: Verified -- To view, visit http://gerrit.ovirt.org/5047 To unsubscribe, visit http://gerrit.ovirt.org/settings

Change in vdsm[master]: VM.create: Make readonly optional for disk devices

Adam Litke has posted comments on this change. Change subject: VM.create: Make readonly optional for disk devices .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/5298 To unsubscribe, visit

Change in vdsm[master]: rest-api: Add basic create and delete support

Adam Litke has posted comments on this change. Change subject: rest-api: Add basic create and delete support .. Patch Set 2: Verified -- To view, visit http://gerrit.ovirt.org/5048 To unsubscribe, visit

Change in vdsm[master]: rest-api: Allow optional data in DELETE request bodies

Adam Litke has posted comments on this change. Change subject: rest-api: Allow optional data in DELETE request bodies .. Patch Set 2: Verified -- To view, visit http://gerrit.ovirt.org/5049 To unsubscribe, visit

Change in vdsm[master]: rest-api: Model storage connection references

Adam Litke has posted comments on this change. Change subject: rest-api: Model storage connection references .. Patch Set 8: Verified -- To view, visit http://gerrit.ovirt.org/3750 To unsubscribe, visit

Change in vdsm[master]: rest-api: Model StorageDomains

Adam Litke has posted comments on this change. Change subject: rest-api: Model StorageDomains .. Patch Set 8: Verified -- To view, visit http://gerrit.ovirt.org/3751 To unsubscribe, visit http://gerrit.ovirt.org/settings

Change in vdsm[master]: rest-api: Model images

Adam Litke has posted comments on this change. Change subject: rest-api: Model images .. Patch Set 8: Verified -- To view, visit http://gerrit.ovirt.org/3752 To unsubscribe, visit http://gerrit.ovirt.org/settings

Change in vdsm[master]: rest-api: Model volumes

Adam Litke has posted comments on this change. Change subject: rest-api: Model volumes .. Patch Set 8: Verified -- To view, visit http://gerrit.ovirt.org/3753 To unsubscribe, visit http://gerrit.ovirt.org/settings

Change in vdsm[master]: rest-api: Model Tasks

Adam Litke has posted comments on this change. Change subject: rest-api: Model Tasks .. Patch Set 8: Verified -- To view, visit http://gerrit.ovirt.org/3754 To unsubscribe, visit http://gerrit.ovirt.org/settings

Change in vdsm[master]: rest-api: Model StoragePools

Adam Litke has posted comments on this change. Change subject: rest-api: Model StoragePools .. Patch Set 8: Verified -- To view, visit http://gerrit.ovirt.org/3755 To unsubscribe, visit http://gerrit.ovirt.org/settings

Change in vdsm[master]: API: Provide a working getAllTasks API

Adam Litke has posted comments on this change. Change subject: API: Provide a working getAllTasks API .. Patch Set 2: Verified -- To view, visit http://gerrit.ovirt.org/3613 To unsubscribe, visit

Change in vdsm[master]: rest-api: Compact sub-resource link handling

Adam Litke has abandoned this change. Change subject: rest-api: Compact sub-resource link handling .. Patch Set 2: Abandoned -- To view, visit http://gerrit.ovirt.org/4344 To unsubscribe, visit http://gerrit.ovirt.org/settings

Change in vdsm[master]: VM.create: Normalize propagateErrors semantics

Dan Kenigsberg has submitted this change and it was merged. Change subject: VM.create: Normalize propagateErrors semantics .. VM.create: Normalize propagateErrors semantics Changes since V1: - Use utils.tobool() as suggested

Change in vdsm[master]: rest-api: Handle resource links

Dan Kenigsberg has submitted this change and it was merged. Change subject: rest-api: Handle resource links .. rest-api: Handle resource links Change the method for resolving links in a REST Resource. Instead of each class

Change in vdsm[master]: Make vdsm/caps.py PEP8 clean

Dan Kenigsberg has submitted this change and it was merged. Change subject: Make vdsm/caps.py PEP8 clean .. Make vdsm/caps.py PEP8 clean Change-Id: Ie6be4a2c9cdf58bcf36f861649303afdc87fd4d7 Signed-off-by: Zhou Zheng Sheng

Change in vdsm[master]: Make vdsm/caps.py PEP8 clean

Dan Kenigsberg has posted comments on this change. Change subject: Make vdsm/caps.py PEP8 clean .. Patch Set 1: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5411 To unsubscribe, visit

Change in vdsm[master]: Make vdsm/clientIF.py PEP8 clean

Dan Kenigsberg has posted comments on this change. Change subject: Make vdsm/clientIF.py PEP8 clean .. Patch Set 1: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5412 To unsubscribe, visit

Change in vdsm[master]: Make vdsm/clientIF.py PEP8 clean

Dan Kenigsberg has submitted this change and it was merged. Change subject: Make vdsm/clientIF.py PEP8 clean .. Make vdsm/clientIF.py PEP8 clean Change-Id: I56949c0016348b5b19f03e8c82b33a1dfe016fb8 Signed-off-by: Zhou Zheng

Change in vdsm[master]: Make pthread.py PEP8 clean

Dan Kenigsberg has posted comments on this change. Change subject: Make pthread.py PEP8 clean .. Patch Set 1: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5413 To unsubscribe, visit

Change in vdsm[master]: Make pthread.py PEP8 clean

Dan Kenigsberg has submitted this change and it was merged. Change subject: Make pthread.py PEP8 clean .. Make pthread.py PEP8 clean Change-Id: I1aa3726da56ac920dd5b204a9b0dcd0f477042ce Signed-off-by: Royce

Change in vdsm[master]: make storage/fuser.py PEP8 clean

Dan Kenigsberg has posted comments on this change. Change subject: make storage/fuser.py PEP8 clean .. Patch Set 1: Looks good to me, approved Thanks for your pep8 cleanup work! -- To view, visit http://gerrit.ovirt.org/5414

Change in vdsm[master]: make storage/fuser.py PEP8 clean

Dan Kenigsberg has submitted this change and it was merged. Change subject: make storage/fuser.py PEP8 clean .. make storage/fuser.py PEP8 clean Change-Id: Ice578703afd97b7f0749c429ad43b4bdbbb1ea52 Signed-off-by: Royce

Change in vdsm[master]: Fix typo (change socekt to socket) in libvirtvm.py and vm.py

Dan Kenigsberg has posted comments on this change. Change subject: Fix typo (change socekt to socket) in libvirtvm.py and vm.py .. Patch Set 1: Looks good to me, approved doh! -- To view, visit http://gerrit.ovirt.org/5427 To

Change in vdsm[master]: Fix return value of shutdown() on failure

Dan Kenigsberg has posted comments on this change. Change subject: Fix return value of shutdown() on failure .. Patch Set 1: Looks good to me, but someone else must approve I suppose you are right here - but I would like

Change in vdsm[master]: BZ#833119 - Allow to create VLANed network on top of existin...

Igor Lvovsky has uploaded a new change for review. Change subject: BZ#833119 - Allow to create VLANed network on top of existing bond .. BZ#833119 - Allow to create VLANed network on top of existing bond Change-Id:

Change in vdsm[master]: BZ#831528 - Allow multiple VLANed network together with only...

Igor Lvovsky has posted comments on this change. Change subject: BZ#831528 - Allow multiple VLANed network together with only one non-VLANed on top of NIC/Bond .. Patch Set 4: I would prefer that you didn't submit this This

Change in vdsm[master]: BZ#831528 - Allow multiple VLANed network together with only...

Dan Kenigsberg has posted comments on this change. Change subject: BZ#831528 - Allow multiple VLANed network together with only one non-VLANed on top of NIC/Bond .. Patch Set 4: I would prefer that you didn't submit this so

Change in vdsm[master]: BZ#831528 - Allow multiple VLANed network together with only...

Igor Lvovsky has posted comments on this change. Change subject: BZ#831528 - Allow multiple VLANed network together with only one non-VLANed on top of NIC/Bond .. Patch Set 4: Because, i did it first and anyway it's

Change in vdsm[master]: BZ#826873 - Allow to change bond without network attached to...

Dan Kenigsberg has posted comments on this change. Change subject: BZ#826873 - Allow to change bond without network attached to it .. Patch Set 4: I would prefer that you didn't submit this (3 inline comments)

Change in vdsm[master]: BZ#830486 - Allow to change network according the diffs from...

Dan Kenigsberg has posted comments on this change. Change subject: BZ#830486 - Allow to change network according the diffs from previous state .. Patch Set 8: Looks good to me, but someone else must approve -- To view, visit

Change in vdsm[master]: BZ#826467 - Allow to remove bond and attach network to NIC

Dan Kenigsberg has posted comments on this change. Change subject: BZ#826467 - Allow to remove bond and attach network to NIC .. Patch Set 3: I would prefer that you didn't submit this (1 inline comment) yikes, but I do not

Change in vdsm[master]: BZ#833119 - Allow to create VLANed network on top of existin...

Dan Kenigsberg has posted comments on this change. Change subject: BZ#833119 - Allow to create VLANed network on top of existing bond .. Patch Set 1: I would prefer that you didn't submit this (1 inline comment) I completely

Change in vdsm[master]: Remove the traceback from the getVSize warning

Dan Kenigsberg has posted comments on this change. Change subject: Remove the traceback from the getVSize warning .. Patch Set 6: I would prefer that you didn't submit this (2 inline comments)

Change in vdsm[master]: BZ#833119 - Allow to create VLANed network on top of existin...

Igor Lvovsky has posted comments on this change. Change subject: BZ#833119 - Allow to create VLANed network on top of existing bond .. Patch Set 1: (1 inline comment) File

Change in vdsm[master]: Add VolumeType storage exception to clarify createVolume err...

Ryan Harper has posted comments on this change. Change subject: Add VolumeType storage exception to clarify createVolume error .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/5378 To unsubscribe, visit

Change in vdsm[master]: Make storage/sd.py PEP8 clean

Zhou Zheng Sheng has posted comments on this change. Change subject: Make storage/sd.py PEP8 clean .. Patch Set 1: Verified Passes tests in vdsm, and pydiff reports no change in code logic. -- To view, visit

Change in vdsm[master]: make storage/securable.py PEP8 clean

Zhou Zheng Sheng has posted comments on this change. Change subject: make storage/securable.py PEP8 clean .. Patch Set 1: Verified (1 inline comment) Passes tests in vdsm, pydiff reports no change in code logic.

Change in vdsm[master]: Make storage/sd.py PEP8 clean

Royce Lv has posted comments on this change. Change subject: Make storage/sd.py PEP8 clean .. Patch Set 1: Looks good to me, but someone else must approve Zheng Sheng, Thanks a lot for your patient for checking and verifying

Change in vdsm[master]: make vdsm_reg/createDaemon.py PEP8 clean

Zhou Zheng Sheng has posted comments on this change. Change subject: make vdsm_reg/createDaemon.py PEP8 clean .. Patch Set 1: Verified Passes tests in vdsm. pydiff reports 4 changes, but all of them are changing raise

Change in vdsm[master]: make storage/iscsiadm.py PEP8 clean

Zhou Zheng Sheng has posted comments on this change. Change subject: make storage/iscsiadm.py PEP8 clean .. Patch Set 1: Verified Passes tests in vdsm. pydiff reports no change in code logic. -- To view, visit

Change in vdsm[master]: BZ#830486 - Allow to change network according the diffs from...

Lei Li has posted comments on this change. Change subject: BZ#830486 - Allow to change network according the diffs from previous state .. Patch Set 8: Looks good to me, but someone else must approve -- To view, visit

Change in vdsm[master]: make storage/fileVolume.py PEP8 clean

Zhou Zheng Sheng has posted comments on this change. Change subject: make storage/fileVolume.py PEP8 clean .. Patch Set 1: Verified Passes tests in vdsm. pydiff reports no changes in code logic. -- To view, visit

Change in vdsm[master]: BZ#833201: get dynamically VDSM_MIN_VER

Douglas Schilling Landgraf has uploaded a new change for review. Change subject: BZ#833201: get dynamically VDSM_MIN_VER .. BZ#833201: get dynamically VDSM_MIN_VER To avoid deploy error when vdsm package version is increased,

Change in vdsm[master]: make libvirtev.py PEP8 clean

Zhou Zheng Sheng has posted comments on this change. Change subject: make libvirtev.py PEP8 clean .. Patch Set 1: Verified Passes tests in vdsm. pydiff find some changes, but all of them are deleting useless ; after a