Change in vdsm[master]: [WIP] rest-api: Model Networks

Lei Li has posted comments on this change. Change subject: [WIP] rest-api: Model Networks .. Patch Set 1: I know it's far far away from perfect. Suggestions and comments are very appreciated! -- To view, visit http://gerrit.ov

Change in vdsm[master]: [WIP] rest-api: Model Networks

Lei Li has uploaded a new change for review. Change subject: [WIP] rest-api: Model Networks .. [WIP] rest-api: Model Networks API Implemented: /api/networks * list, create, confirm and edit configuration for net

Change in vdsm[master]: BZ#832199: selinux - move selinux from init to spec

Mark Wu has posted comments on this change. Change subject: BZ#832199: selinux - move selinux from init to spec .. Patch Set 2: I suggest using "semanage boolean -l" to check if the booleans are already set in policy and only

Change in vdsm[master]: Add local storage xmlrpc functional test

Royce Lv has posted comments on this change. Change subject: Add local storage xmlrpc functional test .. Patch Set 1: Need to rebase on Dan's patch when it is merged -- To view, visit http://gerrit.ovirt.org/5860 To unsubscrib

Change in vdsm[master]: Add local storage xmlrpc functional test

Hello Adam Litke, I'd like you to do a code review. Please visit http://gerrit.ovirt.org/5860 to review the following change. Change subject: Add local storage xmlrpc functional test .. Add local storage xmlrpc functional

Change in vdsm[master]: getDeviceList - passing includePartitioned to HSM

Daniel Erez has abandoned this change. Change subject: getDeviceList - passing includePartitioned to HSM .. Patch Set 4: Abandoned 'includePartitioned' flag is not needed any more. Instead, a status field has been added to 'get

Change in vdsm[master]: faqemu: add a bit of documentation

Dan Kenigsberg has submitted this change and it was merged. Change subject: faqemu: add a bit of documentation .. faqemu: add a bit of documentation Change-Id: Icbe32a22aa67e2a5fd06ed718fa50387b5ac1941 Signed-off-by: Dan Kenigs

Change in vdsm[master]: faqemu: add a bit of documentation

Dan Kenigsberg has posted comments on this change. Change subject: faqemu: add a bit of documentation .. Patch Set 1: Verified; Looks good to me, approved harmless docs, one ack is fine. -- To view, visit http://gerrit.ovirt.o

Change in vdsm[master]: faqemu: add a bit of documentation

Douglas Schilling Landgraf has posted comments on this change. Change subject: faqemu: add a bit of documentation .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/5813 To

Change in vdsm[master]: BZ#836954 - Allow to break bond and create a new network on ...

Dan Kenigsberg has posted comments on this change. Change subject: BZ#836954 - Allow to break bond and create a new network on its interface in single action. .. Patch Set 2: Looks good to me, approved -- To view, visit http:/

Change in vdsm[master]: BZ#836954 - Allow to break bond and create a new network on ...

Dan Kenigsberg has submitted this change and it was merged. Change subject: BZ#836954 - Allow to break bond and create a new network on its interface in single action. .. BZ#836954 - Allow to break bond and create a new network

Change in vdsm[master]: Remove redundant 'explicitBonding' parameter from setupNetwo...

Dan Kenigsberg has posted comments on this change. Change subject: Remove redundant 'explicitBonding' parameter from setupNetworks .. Patch Set 3: Verified; Looks good to me, approved pushing, with a fix of tabs to spaces. --

Change in vdsm[master]: Remove redundant 'explicitBonding' parameter from setupNetwo...

Dan Kenigsberg has submitted this change and it was merged. Change subject: Remove redundant 'explicitBonding' parameter from setupNetworks .. Remove redundant 'explicitBonding' parameter from setupNetworks Change-Id: Id8cd8781

Change in vdsm[master]: Add a basic xmlrpc functional test

Dan Kenigsberg has posted comments on this change. Change subject: Add a basic xmlrpc functional test .. Patch Set 2: I would prefer that you didn't submit this (1 inline comment) Trying to reproduce Royce's issue, I've found

Change in vdsm[master]: BZ#836954 - Allow to break bond and create a new network on ...

Igor Lvovsky has posted comments on this change. Change subject: BZ#836954 - Allow to break bond and create a new network on its interface in single action. .. Patch Set 2: Verified -- To view, visit http://gerrit.ovirt.org/58

Change in vdsm[master]: Remove redundant 'explicitBonding' parameter from setupNetwo...

Igor Lvovsky has posted comments on this change. Change subject: Remove redundant 'explicitBonding' parameter from setupNetworks .. Patch Set 2: Verified -- To view, visit http://gerrit.ovirt.org/5840 To unsubscribe, visit http

Change in vdsm[master]: Degrade sanlock-python to 1.8 in the BuildRequires

Jarod.w has posted comments on this change. Change subject: Degrade sanlock-python to 1.8 in the BuildRequires .. Patch Set 1: Verified I have verified the patch on CentOS 6.2 and Fedora 17. All passes. -- To view, visit http

Change in vdsm[master]: Degrade sanlock-python to 1.8 in the BuildRequires

Jarod.w has abandoned this change. Change subject: Degrade sanlock-python to 1.8 in the BuildRequires .. Patch Set 1: Abandoned Sure.Thanks for your suggestion. -- To view, visit http://gerrit.ovirt.org/5705 To unsubscribe, vi

Change in vdsm[master]: Degrade sanlock-python to 1.8 in the BuildRequires

Jarod.w has uploaded a new change for review. Change subject: Degrade sanlock-python to 1.8 in the BuildRequires .. Degrade sanlock-python to 1.8 in the BuildRequires Some OSes are still using sanlock-python 1.8 such as centos 6

Change in vdsm[master]: Degrade sanlock-python to 1.8 in the BuildRequires

Jarod.w has abandoned this change. Change subject: Degrade sanlock-python to 1.8 in the BuildRequires .. Patch Set 1: Abandoned -- To view, visit http://gerrit.ovirt.org/5703 To unsubscribe, visit http://gerrit.ovirt.org/settin

Change in vdsm[master]: Fix broken pyflakes check

Jarod.w has posted comments on this change. Change subject: Fix broken pyflakes check .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/5690 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-Messag

Change in vdsm[master]: Degrade sanlock-python to 1.8 in the BuildRequires

Jarod.w has uploaded a new change for review. Change subject: Degrade sanlock-python to 1.8 in the BuildRequires .. Degrade sanlock-python to 1.8 in the BuildRequires Some OSes are still using sanlock 1.8 such as centos 6.2. Aft

Change in vdsm[master]: Fix broken pyflakes check

Jarod.w has uploaded a new change for review. Change subject: Fix broken pyflakes check .. Fix broken pyflakes check Change-Id: I79afa156061268018606d9ef445755da47a8bef8 Signed-off-by: jarod.w --- M tests/configNetworkTests.py

Change in vdsm[master]: Remove redundant 'explicitBonding' parameter from setupNetwo...

Dan Kenigsberg has posted comments on this change. Change subject: Remove redundant 'explicitBonding' parameter from setupNetworks .. Patch Set 1: I would prefer that you didn't submit this (1 inline comment) yay. anything tha

Change in vdsm[master]: BZ#836954 - Allow to break bond and create a new network on ...

Igor Lvovsky has posted comments on this change. Change subject: BZ#836954 - Allow to break bond and create a new network on its interface in single action. .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/58

Change in vdsm[master]: Remove redundant 'explicitBonding' parameter from setupNetwo...

Igor Lvovsky has posted comments on this change. Change subject: Remove redundant 'explicitBonding' parameter from setupNetworks .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/5840 To unsubscribe, visit http

Change in vdsm[master]: Remove redundant 'explicitBonding' parameter from setupNetwo...

Igor Lvovsky has uploaded a new change for review. Change subject: Remove redundant 'explicitBonding' parameter from setupNetworks .. Remove redundant 'explicitBonding' parameter from setupNetworks Change-Id: Id8cd878109ab5fe9d0

Change in vdsm[master]: BZ#836954 - Allow to break bond and create a new network on ...

Igor Lvovsky has uploaded a new change for review. Change subject: BZ#836954 - Allow to break bond and create a new network on its interface in single action. .. BZ#836954 - Allow to break bond and create a new network on its in

Change in vdsm[ovirt-3.1]: BZ#832199: selinux - move selinux from init to spec

Dan Kenigsberg has posted comments on this change. Change subject: BZ#832199: selinux - move selinux from init to spec .. Patch Set 1: No score -- To view, visit http://gerrit.ovirt.org/5614 To unsubscribe, visit http://gerrit.

Change in vdsm[master]: BZ#832199: selinux - move selinux from init to spec

Dan Kenigsberg has posted comments on this change. Change subject: BZ#832199: selinux - move selinux from init to spec .. Patch Set 2: I would prefer that you didn't submit this I have to take my words back. I wanted to verify

Change in vdsm[ovirt-3.1]: BZ#832199: selinux - move selinux from init to spec

Dan Kenigsberg has posted comments on this change. Change subject: BZ#832199: selinux - move selinux from init to spec .. Patch Set 1: Looks good to me, approved (1 inline comment) .

Change in vdsm[ovirt-3.1]: BZ#832199: selinux - move selinux from init to spec

Mark Wu has posted comments on this change. Change subject: BZ#832199: selinux - move selinux from init to spec .. Patch Set 1: I would prefer that you didn't submit this (1 inline comment) Douglas, The problem is not introduc

Change in vdsm[master]: Add a basic xmlrpc functional test

Royce Lv has posted comments on this change. Change subject: Add a basic xmlrpc functional test .. Patch Set 2: I would prefer that you didn't submit this I got a libvirt(libvirt-0.9.11.4-3.fc17.x86_64) error when verifying thi

Change in vdsm[master]: bootstrap: m2crypto is no longer used

Dan Kenigsberg has posted comments on this change. Change subject: bootstrap: m2crypto is no longer used .. Patch Set 1: Yaniv, the original intention of explicitly listing these dependencies, was that if they are missing, a c

Change in vdsm[master]: bootstrap: m2crypto is no longer used

Yaniv Kaul has posted comments on this change. Change subject: bootstrap: m2crypto is no longer used .. Patch Set 1: It's not directly related to this patch, but we should not require pixman and mesa - let Spice handle its dep

Change in vdsm[master]: Do not set max_cstate on host with constant_tsc

Mark Wu has posted comments on this change. Change subject: Do not set max_cstate on host with constant_tsc .. Patch Set 3: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/5658 To unsub

Change in vdsm[master]: Add a test case for _handleMessage()

Dan Kenigsberg has submitted this change and it was merged. Change subject: Add a test case for _handleMessage() .. Add a test case for _handleMessage() Change-Id: Iec467cdef122999a28b3e47cd24e25192df10c21 Signed-off-by: Mark W

Change in vdsm[master]: Add a test case for _handleMessage()

Dan Kenigsberg has posted comments on this change. Change subject: Add a test case for _handleMessage() .. Patch Set 2: Verified ... and runs fine, too. Thanks! -- To view, visit http://gerrit.ovirt.org/5819 To unsubscribe, v

Change in vdsm[master]: Adding the status field to getDeviceList info.

Dan Kenigsberg has posted comments on this change. Change subject: Adding the status field to getDeviceList info. .. Patch Set 8: Verified; Looks good to me, approved rebase seems sane. copying scores. -- To view, visit http:/

Change in vdsm[master]: Adding the status field to getDeviceList info.

Dan Kenigsberg has submitted this change and it was merged. Change subject: Adding the status field to getDeviceList info. .. Adding the status field to getDeviceList info. This status tries to predict the result of pvcreate on

Change in vdsm[master]: Do not set max_cstate on host with constant_tsc

Dan Kenigsberg has posted comments on this change. Change subject: Do not set max_cstate on host with constant_tsc .. Patch Set 3: I now feel holier ;-) -- To view, visit http://gerrit.ovirt.org/5658 To unsubscribe, visit http

Change in vdsm[master]: Do not set max_cstate on host with constant_tsc

Dan Kenigsberg has posted comments on this change. Change subject: Do not set max_cstate on host with constant_tsc .. Patch Set 3: I no -- To view, visit http://gerrit.ovirt.org/5658 To unsubscribe, visit http://gerrit.ovirt.o

Change in vdsm[master]: Do not set max_cstate on host with constant_tsc

Mark Wu has posted comments on this change. Change subject: Do not set max_cstate on host with constant_tsc .. Patch Set 2: I would prefer that you didn't submit this Minor suggestion inline. -- To view, visit http://gerrit.ov

Change in vdsm[master]: Do not set max_cstate on host with constant_tsc

Mark Wu has posted comments on this change. Change subject: Do not set max_cstate on host with constant_tsc .. Patch Set 2: (1 inline comment) Do you think it's safe to apply this change to rhel6 based host too? ..

Change in vdsm[master]: Add a test case for _handleMessage()

Dan Kenigsberg has posted comments on this change. Change subject: Add a test case for _handleMessage() .. Patch Set 2: Looks good to me, approved ah, much more legible. -- To view, visit http://gerrit.ovirt.org/5819 To unsubs

Change in vdsm[master]: Collect more guest memory stats

Dan Kenigsberg has posted comments on this change. Change subject: Collect more guest memory stats .. Patch Set 3: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/3917 To unsubscribe, visit http://gerrit.ov

Change in vdsm[master]: Collect more guest memory stats

Dan Kenigsberg has submitted this change and it was merged. Change subject: Collect more guest memory stats .. Collect more guest memory stats More detailed guest memory stats has been to ovirt-guest-agent in http://gerrit.ovir

Change in vdsm[master]: pep8: make gpl boiler plate narrower

Dan Kenigsberg has submitted this change and it was merged. Change subject: pep8: make gpl boiler plate narrower .. pep8: make gpl boiler plate narrower Better do it in one sed blow. Change-Id: I47ea008d067216a4327c70b76d3583c

Change in vdsm[master]: pep8: make gpl boiler plate narrower

Dan Kenigsberg has posted comments on this change. Change subject: pep8: make gpl boiler plate narrower .. Patch Set 1: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5796 To unsubscribe, visit http://gerr

Change in vdsm[master]: pep8: make gpl boiler plate narrower

Zhou Zheng Sheng has posted comments on this change. Change subject: pep8: make gpl boiler plate narrower .. Patch Set 1: Verified; Looks good to me, but someone else must approve Run through ./autobuild.sh. And use pydiff chec

Change in vdsm[master]: Adding the status field to getDeviceList info.

Dan Kenigsberg has posted comments on this change. Change subject: Adding the status field to getDeviceList info. .. Patch Set 7: Verified Verified by Derez -- To view, visit http://gerrit.ovirt.org/5515 To unsubscribe, visit

Change in vdsm[master]: Add shutdown based on qemu-ga(qemu guest agent) in vdsm

Mark Wu has posted comments on this change. Change subject: Add shutdown based on qemu-ga(qemu guest agent) in vdsm .. Patch Set 3: I would prefer that you didn't submit this (1 inline comment) Bingbu, I think you misunderstoo

Change in vdsm[master]: Adding the status field to getDeviceList info.

Ayal Baron has posted comments on this change. Change subject: Adding the status field to getDeviceList info. .. Patch Set 7: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5515 To unsubscribe, visit http:

Change in vdsm[master]: Add a test case for _handleMessage()

Dan Kenigsberg has posted comments on this change. Change subject: Add a test case for _handleMessage() .. Patch Set 1: I would prefer that you didn't submit this (3 inline comments) ...

Change in vdsm[master]: BZ#770153 Do not set max_cstate on Fedora hosts

Mark Wu has posted comments on this change. Change subject: BZ#770153 Do not set max_cstate on Fedora hosts .. Patch Set 1: I would prefer that you didn't submit this Does it mean people always run Fedora on modern hardware? :)

Change in vdsm[master]: Add shutdown based on qemu-ga(qemu guest agent) in vdsm

Bing Bu Cao has posted comments on this change. Change subject: Add shutdown based on qemu-ga(qemu guest agent) in vdsm .. Patch Set 3: (2 inline comments) File vdsm/libvirtv

Change in vdsm[master]: Collect more guest memory stats

Mark Wu has posted comments on this change. Change subject: Collect more guest memory stats .. Patch Set 3: Verified Test case is submit in http://gerrit.ovirt.org/#/c/5819/ -- To view, visit http://gerrit.ovirt.org/3917 To un

Change in vdsm[master]: Add a test case for _handleMessage()

Mark Wu has uploaded a new change for review. Change subject: Add a test case for _handleMessage() .. Add a test case for _handleMessage() Change-Id: Iec467cdef122999a28b3e47cd24e25192df10c21 Signed-off-by: Mark Wu --- M tests/

Change in vdsm[master]: Add shutdown based on qemu-ga(qemu guest agent) in vdsm

Dan Kenigsberg has posted comments on this change. Change subject: Add shutdown based on qemu-ga(qemu guest agent) in vdsm .. Patch Set 3: I would prefer that you didn't submit this (3 inline comments)