ShaoHe Feng has uploaded a new change for review.
Change subject: fix test error, NET_CONF_BACK_DIR is not in configNetwork module
..
fix test error, NET_CONF_BACK_DIR is not in configNetwork module
NET_CONF_BACK_DIR is not in
Igor Lvovsky has posted comments on this change.
Change subject: configNetTests: fix another netinfo-rebase issue
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6121
To unsubscribe, visit
Maor Lipchuk has posted comments on this change.
Change subject: Orthogonal storage repository conversion
..
Patch Set 32: (1 inline comment)
Commit Message
Line 10: not
Igor Lvovsky has posted comments on this change.
Change subject: Use only one NETPREFIX constant
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/6115
To unsubscribe,
Maor Lipchuk has posted comments on this change.
Change subject: Use domain proxies instead of actual domain references
..
Patch Set 32: Looks good to me, but someone else must approve
--
To view, visit
Maor Lipchuk has posted comments on this change.
Change subject: Use domain proxies instead of actual domain references
..
Patch Set 32: No score
--
To view, visit http://gerrit.ovirt.org/3044
To unsubscribe, visit
Igor Lvovsky has posted comments on this change.
Change subject: fix test error, NET_CONF_BACK_DIR is not in configNetwork module
..
Patch Set 1: I would prefer that you didn't submit this
--
To view, visit
Ayal Baron has posted comments on this change.
Change subject: Related to BZ#833099 - Removing unused exceptions.
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6085
To unsubscribe, visit
Ayal Baron has posted comments on this change.
Change subject: Related to BZ#833099 - spmRole is a StoragePool attribute.
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6084
To
Federico Simoncelli has posted comments on this change.
Change subject: Add the hostId parameter to reconstructMaster
..
Patch Set 12: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5068
To
Federico Simoncelli has posted comments on this change.
Change subject: Remove the unused nocache option
..
Patch Set 17: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3747
To unsubscribe,
Federico Simoncelli has posted comments on this change.
Change subject: Uniform the block and file volume methods
..
Patch Set 21: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3683
To
Federico Simoncelli has posted comments on this change.
Change subject: Unify the volume creation code in volume.create
..
Patch Set 22: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3627
To
Federico Simoncelli has posted comments on this change.
Change subject: Use domain proxies instead of actual domain references
..
Patch Set 33: Verified; Looks good to me, approved
--
To view, visit
Federico Simoncelli has posted comments on this change.
Change subject: Orthogonal storage repository conversion
..
Patch Set 33: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3045
To
Federico Simoncelli has posted comments on this change.
Change subject: Add the formatConverter for Storage Domain V3
..
Patch Set 17: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3841
To
Royce Lv has uploaded a new change for review.
Change subject: bz#831938 raise exception when error occurs in
connectStorageServer
..
bz#831938 raise exception when error occurs in connectStorageServer
connectStorageServer
Alon Bar-Lev has uploaded a new change for review.
Change subject: cleanup: use iproute instead of vconfig for vlan management
..
cleanup: use iproute instead of vconfig for vlan management
**EXPERIMENTAL**
iproute utility is
Laszlo Hornyak has posted comments on this change.
Change subject: send POSIXFS instead of SHAREDFS
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/6103
To unsubscribe, visit http://gerrit.ovirt.org/settings
Dan Kenigsberg has posted comments on this change.
Change subject: Use domain proxies instead of actual domain references
..
Patch Set 33: I would prefer that you didn't submit this
Ayal, Federico,
Is this one so urgent?
Igor Lvovsky has posted comments on this change.
Change subject: configNetTests: fix another netinfo-rebase issue
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/6121
To unsubscribe, visit
Igor Lvovsky has submitted this change and it was merged.
Change subject: configNetTests: fix another netinfo-rebase issue
..
configNetTests: fix another netinfo-rebase issue
configNetTests have been stubbing the variable
Igor Lvovsky has posted comments on this change.
Change subject: configNetTests: do not call a non-existing TestCaseBase.__del__
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6104
To
Igor Lvovsky has submitted this change and it was merged.
Change subject: configNetTests: do not call a non-existing TestCaseBase.__del__
..
configNetTests: do not call a non-existing TestCaseBase.__del__
This gives an ominous
Dan Kenigsberg has posted comments on this change.
Change subject: vdsmd: Don't keep the temporary file generated by configuring
libvirt
..
Patch Set 1:
I do not think it is highly important, but I won't nack a bump (fedora
Royce Lv has uploaded a new change for review.
Change subject: remove symlink when connect local storage failed
..
remove symlink when connect local storage failed
if connectStorageServer failed for some reason,
symlink remains
Zhou Zheng Sheng has posted comments on this change.
Change subject: clean .pyc files generated in unit tests
..
Patch Set 3:
@He Jie: Thanks very much! If we do not generate .pyc files at all during unit
test, we will not
Mark Wu has uploaded a new change for review.
Change subject: Update error code of migrateToURI2() on abortJob()
..
Update error code of migrateToURI2() on abortJob()
Before migrateToURI2() just returned a generl error
Alon Bar-Lev has posted comments on this change.
Change subject: pthread.py: avoid stdout noise on process shutdown
..
Patch Set 2: Verified; Looks good to me, but someone else must approve
Reproduced and solved by this patch.
Igor Lvovsky has uploaded a new change for review.
Change subject: Handle bridgeless networks too in getNetworksAndVlansForBonding
..
Handle bridgeless networks too in getNetworksAndVlansForBonding
Change-Id:
Igor Lvovsky has uploaded a new change for review.
Change subject: Fix bridgeless networks report
..
Fix bridgeless networks report
Change-Id: I2523c10bf1692bac7429c7be056297a9b857541b
Signed-off-by: Igor Lvovsky
Mark Wu has posted comments on this change.
Change subject: MOM Integration
..
Patch Set 12:
Other questions except the file name(MOM.py) has been answered.
--
To view, visit http://gerrit.ovirt.org/2367
To unsubscribe, visit
Igor Lvovsky has posted comments on this change.
Change subject: Fix bridgeless networks report
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/6147
To unsubscribe, visit http://gerrit.ovirt.org/settings
Igor Lvovsky has posted comments on this change.
Change subject: Handle bridgeless networks too in getNetworksAndVlansForBonding
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/6143
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: Fix bridgeless networks report
..
Patch Set 1: Looks good to me, approved
oops, sorry...
--
To view, visit http://gerrit.ovirt.org/6147
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Fix bridgeless networks report
..
Fix bridgeless networks report
Change-Id: I2523c10bf1692bac7429c7be056297a9b857541b
Signed-off-by: Igor Lvovsky
Dan Kenigsberg has posted comments on this change.
Change subject: pthread.py: avoid stdout noise on process shutdown
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5659
To unsubscribe,
Dan Kenigsberg has submitted this change and it was merged.
Change subject: pthread.py: avoid stdout noise on process shutdown
..
pthread.py: avoid stdout noise on process shutdown
For some reason, on process shutdown,
Ayal Baron has posted comments on this change.
Change subject: BZ#833099 - Induce MSD reconstruct when getSpmStatus fail.
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6083
To
Ayal Baron has posted comments on this change.
Change subject: Related to BZ#833099 - Removing unused exceptions.
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6085
To unsubscribe, visit
Ayal Baron has posted comments on this change.
Change subject: Related to BZ#833099 - spmRole is a StoragePool attribute.
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6084
To
Ayal Baron has posted comments on this change.
Change subject: BZ#784931 - Fixing race condition in deactivateSD().
..
Patch Set 4: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5677
To unsubscribe,
Ayal Baron has posted comments on this change.
Change subject: Fix 2nd order exception msg in lvm._initpvs().
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5319
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: bootstrap: m2crypto is no longer used
..
Patch Set 2:
Kaul: upstream Vdsm does not really try to support prehistoric vdsm that used
m2crypto.
And even if
Ayal Baron has posted comments on this change.
Change subject: Remove unnecesary preparePaths.
..
Patch Set 1: Do not submit
I agree with Federico, this code is needed unless you find a different way to
make sure that no
Yaniv Kaul has posted comments on this change.
Change subject: bootstrap: m2crypto is no longer used
..
Patch Set 2:
From the code it looked like the bootstrap is used to install any VDSM version,
new or old. So even if the
Ayal Baron has posted comments on this change.
Change subject: Introducing the template activation leak.
..
Patch Set 4: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/863
To unsubscribe, visit
Ayal Baron has posted comments on this change.
Change subject: Related to BZ#784931 - Removing the unused useCache parameter.
..
Patch Set 1: Looks good to me, approved
(1 inline comment)
Douglas Schilling Landgraf has posted comments on this change.
Change subject: BZ#837443: removeVlan() drop/remove interface
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: BZ#837443: removeVlan() drop/remove interface
..
Patch Set 3: No score
--
To view, visit http://gerrit.ovirt.org/6090
To unsubscribe, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: BZ#837443: remove bridge before add VDSM bridge
..
Patch Set 4: Verified
--
To view, visit http://gerrit.ovirt.org/6016
To unsubscribe, visit
Igor Lvovsky has posted comments on this change.
Change subject: BZ#837443: removeVlan() drop/remove interface
..
Patch Set 5: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/6090
To
Igor Lvovsky has posted comments on this change.
Change subject: BZ#837443: remove bridge before add VDSM bridge
..
Patch Set 4: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/6016
To
Amador Pahim has posted comments on this change.
Change subject: Change source of CPU sockets/cores to /sys and add cpuThreads.
..
Patch Set 4: (8 inline comments)
Commit
Lee Yarwood has abandoned this change.
Change subject: Use more descriptive exceptions for blocksize errors.
..
Patch Set 1: Abandoned
--
To view, visit http://gerrit.ovirt.org/3688
To unsubscribe, visit
Lee Yarwood has uploaded a new change for review.
Change subject: BZ#839312 - Use cp to copy sparse files to ensure they remain
sparse.
..
BZ#839312 - Use cp to copy sparse files to ensure they remain sparse.
Previously all
Michal Skrivanek has posted comments on this change.
Change subject: Change source of CPU sockets/cores to /sys and add cpuThreads.
..
Patch Set 5: I would prefer that you didn't submit this
Hi,
actually, the new topology
Dan Kenigsberg has posted comments on this change.
Change subject: clean .pyc files generated in unit tests
..
Patch Set 3: I would prefer that you didn't submit this
why wouldn't
diff --git a/tests/run_tests_local.sh.in
Dan Kenigsberg has posted comments on this change.
Change subject: BZ#837443: removeVlan() drop/remove interface
..
Patch Set 5: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6090
To unsubscribe, visit
Alon Bar-Lev has abandoned this change.
Change subject: build: use consistent python path
..
Patch Set 2: Abandoned
Did this 2cnd stage only to see if can be done without modifying the code of
vdsm.
--
To view, visit
ShaoHe Feng has posted comments on this change.
Change subject: fix test error, NET_CONF_BACK_DIR is not in configNetwork module
..
Patch Set 1:
Igor, yes, it is same with Dan's patch
--
To view, visit
ShaoHe Feng has abandoned this change.
Change subject: fix test error, NET_CONF_BACK_DIR is not in configNetwork module
..
Patch Set 1: Abandoned
it is same with Dan's patch
--
To view, visit http://gerrit.ovirt.org/6131
To
Xu He Jie has posted comments on this change.
Change subject: iscsi: fix update discoverydb with wrong key
..
Patch Set 1:
Mark, yes, it dones't used by iscsiadm. But as the comment in the code, I guess
we prefer to keep this
Mark Wu has posted comments on this change.
Change subject: BZ#837443: remove bridge before add VDSM bridge
..
Patch Set 4: Looks good to me, but someone else must approve
(1 inline comment)
Zhou Zheng Sheng has posted comments on this change.
Change subject: Suppress generating .py{c,o} files when 'make check'
..
Patch Set 4:
The purpose of this patch is to avoid false positives in 'make check'.
We sometimes
Zhou Zheng Sheng has posted comments on this change.
Change subject: Suppress generating .py{c,o} files when 'make check'
..
Patch Set 4:
Sorry. I just look up the dictionary, by saying false positives I actually
mean false
Zhou Zheng Sheng has posted comments on this change.
Change subject: Suppress generating .py{c,o} files when 'make check'
..
Patch Set 5:
This message is the same as the one for patch set 4. Just looked up the
dictionary and
67 matches
Mail list logo
