Change in vdsm[master]: Unify the volume creation code in volume.create

2012-07-14 Thread abaron
Ayal Baron has posted comments on this change. Change subject: Unify the volume creation code in volume.create .. Patch Set 22: Looks good to me, but someone else must approve (3 inline comments) Please note inline comments

Change in vdsm[master]: BZ#832227: vdsm-reg.conf: change vdc_host_port

2012-07-14 Thread dougsland
Douglas Schilling Landgraf has posted comments on this change. Change subject: BZ#832227: vdsm-reg.conf: change vdc_host_port .. Patch Set 4: (1 inline comment) File

Change in vdsm[master]: register-to-engine: remove duplicate code

2012-07-14 Thread dougsland
Douglas Schilling Landgraf has uploaded a new change for review. Change subject: register-to-engine: remove duplicate code .. register-to-engine: remove duplicate code commit 9ee977d9e7edc688ae81db752041a05085f30cb2 moved

Change in vdsm[master]: engine.py: replace ping

2012-07-14 Thread dougsland
Douglas Schilling Landgraf has uploaded a new change for review. Change subject: engine.py: replace ping .. engine.py: replace ping Instead of use ping to reach oVirt Engine (which might be blocked) use http request via

Change in vdsm[master]: engine.py: replace ping

2012-07-14 Thread dougsland
Douglas Schilling Landgraf has posted comments on this change. Change subject: engine.py: replace ping .. Patch Set 1: Verified In RHEVM: iptables -F iptables -A -INPUT -p icmp --icmp-type echo-request -j REJECT Tried to

Change in vdsm[master]: BZ#832227: vdsm-reg.conf: change vdc_host_port

2012-07-14 Thread dougsland
Douglas Schilling Landgraf has posted comments on this change. Change subject: BZ#832227: vdsm-reg.conf: change vdc_host_port .. Patch Set 6: Verified -- To view, visit http://gerrit.ovirt.org/5367 To unsubscribe, visit

Change in vdsm[master]: Orthogonal storage repository conversion

2012-07-14 Thread abaron
Ayal Baron has posted comments on this change. Change subject: Orthogonal storage repository conversion .. Patch Set 33: I would prefer that you didn't submit this (4 inline comments) minor issues

Change in vdsm[master]: Add copyright information to betterPopenTests.py

2012-07-14 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Add copyright information to betterPopenTests.py .. Patch Set 1: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6239 To

Change in vdsm[master]: Add copyright information to betterPopenTests.py

2012-07-14 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: Add copyright information to betterPopenTests.py .. Add copyright information to betterPopenTests.py Change-Id:

Change in vdsm[master]: fix the netinfo module import problem

2012-07-14 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: fix the netinfo module import problem .. Patch Set 1: Looks good to me, approved thanks a lot for fixing this, Zhou Zheng Sheng. -- To view, visit

Change in vdsm[master]: fix the netinfo module import problem

2012-07-14 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: fix the netinfo module import problem .. fix the netinfo module import problem some files just do import netinfo, but it should be from vdsm import