Change in vdsm[master]: [WIP]Add text-based console support

2012-08-17 Thread zhshzhou
Zhou Zheng Sheng has posted comments on this change. Change subject: [WIP]Add text-based console support .. Patch Set 1: (1 inline comment) File vdsm/consoleServer.py Line

Change in vdsm[master]: Added xml option in gluster command execution.

2012-08-17 Thread barumuga
Bala.FA has posted comments on this change. Change subject: Added xml option in gluster command execution. .. Patch Set 1: (2 inline comments) File vdsm/gluster/cli.py Line

Change in vdsm[master]: Added glusterVolumeStatus verb

2012-08-17 Thread barumuga
Bala.FA has posted comments on this change. Change subject: Added glusterVolumeStatus verb .. Patch Set 3: (2 inline comments) File vdsm/gluster/cli.py Line 123:

Change in vdsm[master]: Add genisoimage to rpm dependencies

2012-08-17 Thread zhshzhou
Zhou Zheng Sheng has posted comments on this change. Change subject: Add genisoimage to rpm dependencies .. Patch Set 1: Verified Run through autobuild.sh. Then I yum localinstall the generated rpm in a fresh machine, then

Change in vdsm[master]: Use setattr instead of __dict__

2012-08-17 Thread zhshzhou
Zhou Zheng Sheng has posted comments on this change. Change subject: Use setattr instead of __dict__ .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/6870 To

Change in vdsm[master]: Fix a race existing in the singleton interface of clientIF

2012-08-17 Thread wudxw
Mark Wu has uploaded a new change for review. Change subject: Fix a race existing in the singleton interface of clientIF .. Fix a race existing in the singleton interface of clientIF There's a race in getInstance() between

Change in vdsm[master]: Fix a race existing in the singleton interface of clientIF

2012-08-17 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Fix a race existing in the singleton interface of clientIF .. Patch Set 1: Build Failed http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/489/ :

Change in vdsm[master]: Added glusterVolumeProfileStart verb

2012-08-17 Thread tjeyasin
Hello Bala.FA, Saggi Mizrahi, Dan Kenigsberg, I'd like you to do a code review. Please visit http://gerrit.ovirt.org/7285 to review the following change. Change subject: Added glusterVolumeProfileStart verb .. Added

Change in vdsm[master]: Added glusterVolumeProfileStart verb

2012-08-17 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Added glusterVolumeProfileStart verb .. Patch Set 1: Build Failed http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/490/ : ABORTED -- To view,

Change in vdsm[master]: Remove 'skipLibvirt' from NetworkOptions

2012-08-17 Thread wudxw
Mark Wu has uploaded a new change for review. Change subject: Remove 'skipLibvirt' from NetworkOptions .. Remove 'skipLibvirt' from NetworkOptions The option 'skipLibvirt' was removed in commit ccb07ae. So it should be removed

Change in vdsm[master]: Remove 'skipLibvirt' from NetworkOptions

2012-08-17 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Remove 'skipLibvirt' from NetworkOptions .. Patch Set 1: Build Failed http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/491/ : ABORTED -- To

Change in vdsm[master]: BZ#840294: Add sanlock packages to REQ_PACK list

2012-08-17 Thread dougsland
Douglas Schilling Landgraf has posted comments on this change. Change subject: BZ#840294: Add sanlock packages to REQ_PACK list .. Patch Set 2: (1 inline comment) File

Change in vdsm[master]: BZ#840294: Add sanlock packages to REQ_PACK list

2012-08-17 Thread dougsland
Douglas Schilling Landgraf has posted comments on this change. Change subject: BZ#840294: Add sanlock packages to REQ_PACK list .. Patch Set 3: Verified -- To view, visit http://gerrit.ovirt.org/7281 To unsubscribe, visit

Change in vdsm[master]: BZ829710 Get VMList with oop if necessary

2012-08-17 Thread abaron
Ayal Baron has posted comments on this change. Change subject: BZ829710 Get VMList with oop if necessary .. Patch Set 3: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6867 To unsubscribe, visit

Change in vdsm[master]: Added glusterVolumeProfileStart verb

2012-08-17 Thread barumuga
Bala.FA has posted comments on this change. Change subject: Added glusterVolumeProfileStart verb .. Patch Set 1: I would prefer that you didn't submit this (2 inline comments)

Change in vdsm[master]: Use setattr instead of __dict__

2012-08-17 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Use setattr instead of __dict__ .. Patch Set 1: Looks good to me, approved Indeed, fixing bad style. -- To view, visit http://gerrit.ovirt.org/6870 To

Change in vdsm[master]: Remove 'skipLibvirt' from NetworkOptions

2012-08-17 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Remove 'skipLibvirt' from NetworkOptions .. Patch Set 1: Looks good to me, approved Thanks for this cleanup! -- To view, visit http://gerrit.ovirt.org/7286 To

Change in vdsm[master]: Add genisoimage to rpm dependencies

2012-08-17 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Add genisoimage to rpm dependencies .. Patch Set 1: Looks good to me, approved Thanks. -- To view, visit http://gerrit.ovirt.org/7232 To unsubscribe, visit

Change in vdsm[master]: Add genisoimage to rpm dependencies

2012-08-17 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: Add genisoimage to rpm dependencies .. Add genisoimage to rpm dependencies vdsm/mkimage.py is using mkisofs, this command is provided by genisoimage.

Change in vdsm[master]: BZ#840294: Add sanlock packages to REQ_PACK list

2012-08-17 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: BZ#840294: Add sanlock packages to REQ_PACK list .. Patch Set 3: Looks good to me, approved Thanks! -- To view, visit http://gerrit.ovirt.org/7281 To

Change in vdsm[master]: BZ#840294: Add sanlock packages to REQ_PACK list

2012-08-17 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: BZ#840294: Add sanlock packages to REQ_PACK list .. BZ#840294: Add sanlock packages to REQ_PACK list Adding sanlock and sanlock-python to

Change in vdsm[master]: bootstrap: introduce bootstrap interface version

2012-08-17 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: bootstrap: introduce bootstrap interface version .. Patch Set 6: I would prefer that you didn't submit this indeed, data duplication make me feel

Change in vdsm[master]: bootstrap: send complete bootstrap from engine

2012-08-17 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: bootstrap: send complete bootstrap from engine .. Patch Set 13: I would prefer that you didn't submit this (3 inline comments) only minor comments.

Change in vdsm[master]: Revert BZ#842631 Use domain proxies instead of actual domai...

2012-08-17 Thread fsimonce
Federico Simoncelli has uploaded a new change for review. Change subject: Revert BZ#842631 Use domain proxies instead of actual domain references .. Revert BZ#842631 Use domain proxies instead of actual domain references This

Change in vdsm[master]: DomainMonitor should use use real domains (no proxy)

2012-08-17 Thread fsimonce
Federico Simoncelli has uploaded a new change for review. Change subject: DomainMonitor should use use real domains (no proxy) .. DomainMonitor should use use real domains (no proxy) In this patch: * produce the domain when

Change in vdsm[master]: Ship the version file with the tarballs

2012-08-17 Thread fsimonce
Federico Simoncelli has uploaded a new change for review. Change subject: Ship the version file with the tarballs .. Ship the version file with the tarballs Shipping the VERSION file allows running the autoreconf tool also from

Change in vdsm[master]: Set StoragePool.id to SPM_ID_FREE by default

2012-08-17 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Set StoragePool.id to SPM_ID_FREE by default .. Patch Set 2: Build Successful http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/493/ : SUCCESS --

Change in vdsm[master]: BZ#848843 Enable vdsm hooks on fedora

2012-08-17 Thread fsimonce
Federico Simoncelli has abandoned this change. Change subject: BZ#848843 Enable vdsm hooks on fedora .. Patch Set 1: Abandoned -- To view, visit http://gerrit.ovirt.org/7266 To unsubscribe, visit

Change in vdsm[master]: Revert BZ#842631 Use domain proxies instead of actual domai...

2012-08-17 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Revert BZ#842631 Use domain proxies instead of actual domain references .. Patch Set 1: Build Successful

Change in vdsm[master]: DomainMonitor should use use real domains (no proxy)

2012-08-17 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: DomainMonitor should use use real domains (no proxy) .. Patch Set 1: Build Successful http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/495/ :

Change in vdsm[master]: Ship the version file with the tarballs

2012-08-17 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Ship the version file with the tarballs .. Patch Set 1: Build Failed http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/496/ : FAILURE -- To view,

Change in vdsm[master]: Revert BZ#842631 Use domain proxies instead of actual domai...

2012-08-17 Thread abaron
Ayal Baron has posted comments on this change. Change subject: Revert BZ#842631 Use domain proxies instead of actual domain references .. Patch Set 1: (1 inline comment) Don't get me wrong, I'm all for this patch, but you

Change in vdsm[master]: tc: refine unsetPortMirroring

2012-08-17 Thread danken
Dan Kenigsberg has uploaded a new change for review. Change subject: tc: refine unsetPortMirroring .. tc: refine unsetPortMirroring unsetPortMirroring should not remove all reference of the mirrored bridge device. Instead,

Change in vdsm[master]: tc: list some information about filters

2012-08-17 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: tc: list some information about filters .. Patch Set 1: Build Successful http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/497/ : SUCCESS -- To

Change in vdsm[master]: tc: refine unsetPortMirroring

2012-08-17 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: tc: refine unsetPortMirroring .. Patch Set 1: Build Successful http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/498/ : SUCCESS -- To view, visit

Change in vdsm[master]: tc: rename qdisc_replace_prio()

2012-08-17 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: tc: rename qdisc_replace_prio() .. Patch Set 1: Build Successful http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/499/ : SUCCESS -- To view,

Change in vdsm[master]: Ship the version file with the tarballs

2012-08-17 Thread abaron
Ayal Baron has posted comments on this change. Change subject: Ship the version file with the tarballs .. Patch Set 1: Why is this dependent on the domain monitor patches? -- To view, visit http://gerrit.ovirt.org/7295 To

Change in vdsm[master]: DomainMonitor should use use real domains (no proxy)

2012-08-17 Thread abaron
Ayal Baron has posted comments on this change. Change subject: DomainMonitor should use use real domains (no proxy) .. Patch Set 1: (1 inline comment) Commit Message Line 3:

Change in vdsm[master]: Ship the version file with the tarballs

2012-08-17 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Ship the version file with the tarballs .. Patch Set 1: I would prefer that you didn't submit this (2 inline comments) thanks for attending to this packaging

Change in vdsm[master]: BZ#840594 Fix netinfo when libvirt bridge does not exist.

2012-08-17 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: BZ#840594 Fix netinfo when libvirt bridge does not exist. .. Patch Set 3: I would prefer that you didn't submit this (2 inline comments)

Change in vdsm[master]: bootstrap: introduce bootstrap interface version

2012-08-17 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: bootstrap: introduce bootstrap interface version .. Patch Set 7: Anything to make you happy :) -- To view, visit http://gerrit.ovirt.org/7092 To unsubscribe,

Change in vdsm[master]: bootstrap: introduce bootstrap interface version

2012-08-17 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: bootstrap: introduce bootstrap interface version .. Patch Set 7: Verified -- To view, visit http://gerrit.ovirt.org/7092 To unsubscribe, visit

Change in vdsm[master]: bootstrap: introduce bootstrap interface version

2012-08-17 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: bootstrap: introduce bootstrap interface version .. Patch Set 7: Build Successful http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/501/ : SUCCESS

Change in vdsm[master]: bootstrap: send complete bootstrap from engine

2012-08-17 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: bootstrap: send complete bootstrap from engine .. Patch Set 14: Minor changes for bootstrap interface handling. -- To view, visit http://gerrit.ovirt.org/6962

Change in vdsm[master]: bootstrap: send complete bootstrap from engine

2012-08-17 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: bootstrap: send complete bootstrap from engine .. Patch Set 14: Verified -- To view, visit http://gerrit.ovirt.org/6962 To unsubscribe, visit

Change in vdsm[master]: bootstrap: send complete bootstrap from engine

2012-08-17 Thread dougsland
Douglas Schilling Landgraf has posted comments on this change. Change subject: bootstrap: send complete bootstrap from engine .. Patch Set 13: (1 inline comment) File

Change in vdsm[master]: bootstrap: introduce bootstrap interface version

2012-08-17 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: bootstrap: introduce bootstrap interface version .. Patch Set 7: Looks good to me, approved not happy. just more comfortable. ;-) -- To view, visit

Change in vdsm[master]: bootstrap: introduce bootstrap interface version

2012-08-17 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: bootstrap: introduce bootstrap interface version .. bootstrap: introduce bootstrap interface version Bootstrap interface version is a method of