Zhou Zheng Sheng has posted comments on this change.
Change subject: generate initramfs on demand in VM creation test
..
Patch Set 1:
Dan Kenigsberg suggests me cache the generated initramfs. I am not sure where
to put the
Dan Kenigsberg has posted comments on this change.
Change subject: using blockStatsFlags to collect disk latency instead of qemu
cmd
..
Patch Set 7: I would prefer that you didn't submit this
(1 inline comment)
Thanks Royce,
ShaoHe Feng has uploaded a new change for review.
Change subject: move get-conf-item to vdsm-tool
..
move get-conf-item to vdsm-tool
many items in init scripts and spec file.
move the complexity from out of the init scripts and
Zhou Zheng Sheng has posted comments on this change.
Change subject: spec: declare mkimageTests' requirement of genisoimage
..
Patch Set 1: Verified
Run through autobuild.sh
Then I remove genisoimage from my system and
Dan Kenigsberg has posted comments on this change.
Change subject: spec: declare mkimageTests' requirement of genisoimage
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7674
To
Dan Kenigsberg has submitted this change and it was merged.
Change subject: spec: declare mkimageTests' requirement of genisoimage
..
spec: declare mkimageTests' requirement of genisoimage
Change-Id:
Dan Kenigsberg has posted comments on this change.
Change subject: configNetwork: _updateConfigValue: Add a new line char '\n' at
the end of the line
..
Patch Set 1: (1 inline comment)
ShaoHe Feng has posted comments on this change.
Change subject: move get-conf-item to vdsm-tool
..
Patch Set 1: (1 inline comment)
File vdsm-tool/vdsm_conf_item.py.in
Line
Zhou Zheng Sheng has posted comments on this change.
Change subject: move get-conf-item to vdsm-tool
..
Patch Set 1: (3 inline comments)
The idea is good.
I notice that the script dynamic creates many tools named
Royce Lv has uploaded a new change for review.
Change subject: Remove imageID in diskstats collect
..
Remove imageID in diskstats collect
imageID is only available for vdsm created images, direct lun and iso
stats can't be
Doron Fediuck has uploaded a new change for review.
Change subject: vdsm: Unifying engine and vdsm commit templates
..
vdsm: Unifying engine and vdsm commit templates
As agreed in ovirt's arch mailing-list[1], we'd like the
Dan Kenigsberg has posted comments on this change.
Change subject: using blockStatsFlags to collect disk latency instead of qemu
cmd
..
Patch Set 8: Looks good to me, approved
thanks!
--
To view, visit
Dan Kenigsberg has posted comments on this change.
Change subject: wait a little time before umount in mkFloppyFs
..
Patch Set 5: Looks good to me, but someone else must approve
that's an ugly hack for sure ;-)
let us give
Doron Fediuck has posted comments on this change.
Change subject: Introduce a new verb setBalloonTarget
..
Patch Set 9:
Any issues left with KB / KiB ?
--
To view, visit http://gerrit.ovirt.org/3669
To unsubscribe, visit
Doron Fediuck has posted comments on this change.
Change subject: Replace calling setSchedulerParameters() with filling its XML
description.
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm: Unifying engine and vdsm commit templates
..
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
I'd name the file simply
Doron Fediuck has posted comments on this change.
Change subject: add verb for vdsm to tuneCpu params
..
Patch Set 4:
Hi Royce,
any comments on my previous remark?
--
To view, visit http://gerrit.ovirt.org/7492
To
Yaniv Bronhaim has posted comments on this change.
Change subject: tests rpm: make non-local tests run
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/7570
To unsubscribe, visit
Yaniv Bronhaim has posted comments on this change.
Change subject: tests rpm: make non-local tests run
..
Patch Set 2: Looks good to me, but someone else must approve
we need to write wiki page about how to add ut and its temp
Dan Kenigsberg has posted comments on this change.
Change subject: Remove imageID in diskstats collect
..
Patch Set 1: I would prefer that you didn't submit this
But what if Engine somehow rely on this per-disk argument?
Doron Fediuck has posted comments on this change.
Change subject: vdsm: Unifying engine and vdsm commit templates
..
Patch Set 1: (1 inline comment)
File
Alon Bar-Lev has posted comments on this change.
Change subject: vdsm: Unifying engine and vdsm commit templates
..
Patch Set 2: (1 inline comment)
File commit-template.txt
Yaniv Bronhaim has posted comments on this change.
Change subject: add simple VM creation functional test
..
Patch Set 8: Fails
Both testStartSmallVM and testStartEmptyVM fail with the message:
AssertionError: 'Down' not found
Zhou Zheng Sheng has posted comments on this change.
Change subject: add simple VM creation functional test
..
Patch Set 8:
Thanks Yaniv Bronhaim, could you paste the related log messages in
/var/log/vdsm/vdsm.log? I guess
Zhou Zheng Sheng has posted comments on this change.
Change subject: add simple VM creation functional test
..
Patch Set 8:
And in this case, if we ps aux | grep qemu, you will see there is no qemu
process. Since the VM is
Antoni Segura Puimedon has posted comments on this change.
Change subject: Bug-Id: https://bugzilla.redhat.com/851839
..
Patch Set 2: (3 inline comments)
Commit Message
Line
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm: Unifying engine and vdsm commit templates
..
Patch Set 1: (1 inline comment)
File
Yaniv Bronhaim has posted comments on this change.
Change subject: Add local storage xmlrpc functional test
..
Patch Set 3: Verified
over rhel6.3
--
To view, visit http://gerrit.ovirt.org/5860
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: Unifying engine and vdsm commit templates
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/815/ : FAILURE
--
Federico Simoncelli has posted comments on this change.
Change subject: Asynchronous LVM bootstrap on vdsm start
..
Patch Set 1:
Correct Ayal, in fact I even thought to completely remove the bootstrap call.
Do you really
Yaniv Bronhaim has posted comments on this change.
Change subject: Add local storage xmlrpc functional test
..
Patch Set 3: I would prefer that you didn't submit this
(1 inline comment)
Federico Simoncelli has posted comments on this change.
Change subject: Upgrade a data domain on attachSD when required
..
Patch Set 4: Verified
--
To view, visit http://gerrit.ovirt.org/7444
To unsubscribe, visit
Royce Lv has posted comments on this change.
Change subject: using blockStatsFlags to collect disk latency instead of qemu
cmd
..
Patch Set 8: Verified
--
To view, visit http://gerrit.ovirt.org/4304
To unsubscribe, visit
Federico Simoncelli has posted comments on this change.
Change subject: Upgrade a data domain on attachSD when required
..
Patch Set 5: Verified
--
To view, visit http://gerrit.ovirt.org/7444
To unsubscribe, visit
Yaniv Bronhaim has posted comments on this change.
Change subject: add simple VM creation functional test
..
Patch Set 8:
This is what I get:
over rhel:
libvirtError: unknown OS type hvm
Thread-41::DEBUG::2012-09-03
Federico Simoncelli has posted comments on this change.
Change subject: Fix the check to convert block domains V0 to tag metadata
..
Patch Set 1: (2 inline comments)
File
Royce Lv has posted comments on this change.
Change subject: add verb for vdsm to tuneCpu params
..
Patch Set 4:
Doron,Thank you for your review, I just got my wiki account, I will update my
consideration immediately
--
To
Dan Kenigsberg has submitted this change and it was merged.
Change subject: using blockStatsFlags to collect disk latency instead of qemu
cmd
..
using blockStatsFlags to collect disk latency instead of qemu cmd
in
Meni Yakove has posted comments on this change.
Change subject: Define network filter on libvirt
..
Patch Set 5: Verified
vdsm-no-mac-spoofing.xml exist under /etc/libvirt/nwfilter/
VM start with filterref
Dan Kenigsberg has posted comments on this change.
Change subject: Upgrade a data domain on attachSD when required
..
Patch Set 5: Looks good to me, approved
copying Ayal's former score.
--
To view, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Upgrade a data domain on attachSD when required
..
Upgrade a data domain on attachSD when required
It is now possible to attach a storage domain with
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Remove imageID in diskstats collect
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/818/ : SUCCESS
--
To view,
oVirt Jenkins CI Server has posted comments on this change.
Change subject: move get-conf-item to vdsm-tool
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/819/ : SUCCESS
--
To view,
Deepak C Shetty has posted comments on this change.
Change subject: tests: Honour PYTHONPATH if set on the host
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/7648
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Define network filter on libvirt
..
Define network filter on libvirt
The patch defines custom network filter on libvirt in order to control
the VM
oVirt Jenkins CI Server has posted comments on this change.
Change subject: add simple VM creation functional test
..
Patch Set 8:
Build Successful
http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/821/ : SUCCESS
--
To
oVirt Jenkins CI Server has posted comments on this change.
Change subject: generate initramfs on demand in VM creation test
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/822/ : SUCCESS
Dan Kenigsberg has posted comments on this change.
Change subject: tests: Honour PYTHONPATH if set on the host
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7648
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: tests: Honour PYTHONPATH if set on the host
..
tests: Honour PYTHONPATH if set on the host
run_tests_local.sh doesn't honour PYTHONPATH if it was set.
Doron Fediuck has posted comments on this change.
Change subject: vdsm: Unifying engine and vdsm commit templates
..
Patch Set 2: (1 inline comment)
File commit-template.txt
Alon Bar-Lev has posted comments on this change.
Change subject: vdsm: Unifying engine and vdsm commit templates
..
Patch Set 2: (1 inline comment)
File commit-template.txt
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Fix the check to convert block domains V0 to tag metadata
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/824/
Doron Fediuck has posted comments on this change.
Change subject: vdsm: Unifying engine and vdsm commit templates
..
Patch Set 2: (1 inline comment)
File commit-template.txt
Dan Kenigsberg has posted comments on this change.
Change subject: Correct vdsClient's help for the verb getVmsInfo
..
Patch Set 3: I would prefer that you didn't submit this
Please relate to my comment about your commit
Alon Bar-Lev has posted comments on this change.
Change subject: vdsm: Unifying engine and vdsm commit templates
..
Patch Set 2: (1 inline comment)
File commit-template.txt
Rami Vaknin has posted comments on this change.
Change subject: Produce the domain in the domain monitor thread
..
Patch Set 5: Verified
The number of vgs calls haven't changed, however the connectStoragePool takes
only 13
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: Unifying engine and vdsm commit templates
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/826/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Correct vdsClient's help for the verb getVmsInfo
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/827/ : ABORTED
--
Doron Fediuck has posted comments on this change.
Change subject: vdsm: Unifying engine and vdsm commit templates
..
Patch Set 2: (1 inline comment)
File commit-template.txt
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Move load_needed_modules to vdsm-tool
..
Patch Set 7:
Build Successful
http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/829/ : SUCCESS
--
To
Mark Wu has uploaded a new change for review.
Change subject: Also remove NIC in delNetwork if no bonding configured.
..
Also remove NIC in delNetwork if no bonding configured.
The client needn't specifiy
Change-Id:
Mark Wu has uploaded a new change for review.
Change subject: Improve the validation of netmask and gateway
..
Improve the validation of netmask and gateway
Change-Id: I3c0a39f3f681a9e587f9118246e42a29e18d604b
Signed-off-by:
Mark Wu has abandoned this change.
Change subject: Also remove NIC in delNetwork if no bonding configured.
..
Patch Set 1: Abandoned
--
To view, visit http://gerrit.ovirt.org/7712
To unsubscribe, visit
Mark Wu has uploaded a new change for review.
Change subject: WIP: Add netcf support
..
WIP: Add netcf support
Change-Id: I343364c308654a1f992ee486a005f0ff99d73be8
Signed-off-by: Mark Wu wu...@linux.vnet.ibm.com
---
M
Mark Wu has uploaded a new change for review.
Change subject: WIP: refactor configNetwork
..
WIP: refactor configNetwork
Change-Id: I66710fdf8fd73beb06124f72ef9857df7393a602
Signed-off-by: Mark Wu wu...@linux.vnet.ibm.com
---
M
Zhou Zheng Sheng has posted comments on this change.
Change subject: add simple VM creation functional test
..
Patch Set 8:
Thanks Yaniv Bronhaim. This is because in the tests we ask vdsm to use KVM, but
the KVM module is not
Federico Simoncelli has posted comments on this change.
Change subject: BZ#844180: Change scsi scan to asynchronous
..
Patch Set 9: (1 inline comment)
File
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Produce the domain in the domain monitor thread
..
Patch Set 6:
Build Successful
http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/830/ : SUCCESS
Dan Kenigsberg has posted comments on this change.
Change subject: Asynchronous LVM bootstrap on vdsm start
..
Patch Set 1: (1 inline comment)
Commit Message
Line 7:
Igor Lvovsky has posted comments on this change.
Change subject: Asynchronous LVM bootstrap on vdsm start
..
Patch Set 1: (1 inline comment)
Commit Message
Line 7:
Laszlo Hornyak has uploaded a new change for review.
Change subject: report cpuUser and cpuSys separately
..
report cpuUser and cpuSys separately
Uses virDomainGetCPUStats to get the CPU information instead of info()
Laszlo Hornyak has abandoned this change.
Change subject: core: report cpuUser and cpuSys separately
..
Patch Set 1: Abandoned
--
To view, visit http://gerrit.ovirt.org/5793
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Improve the validation of netmask and gateway
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/833/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: WIP: refactor configNetwork
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/834/ : SUCCESS
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: WIP: Add netcf support
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/835/ : FAILURE
--
To view, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Asynchronous LVM bootstrap on vdsm start
..
Asynchronous LVM bootstrap on vdsm start
The lvm bootstrap might take a long time if one or more block
Igor Lvovsky has submitted this change and it was merged.
Change subject: Produce the domain in the domain monitor thread
..
Produce the domain in the domain monitor thread
This should reduce the number of vgs in
Igor Lvovsky has posted comments on this change.
Change subject: Produce the domain in the domain monitor thread
..
Patch Set 6: Verified; Looks good to me, approved
Restore Ayal's and Rami's ACKs
--
To view, visit
Alon Bar-Lev has uploaded a new change for review.
Change subject: bootstrap: eliminate extra new line at ~/.ssh/authorized_keys
..
bootstrap: eliminate extra new line at ~/.ssh/authorized_keys
In the past engine created ssh
oVirt Jenkins CI Server has posted comments on this change.
Change subject: report cpuUser and cpuSys separately
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/836/ : FAILURE
--
To view,
oVirt Jenkins CI Server has posted comments on this change.
Change subject: bootstrap: eliminate extra new line at ~/.ssh/authorized_keys
..
Patch Set 1:
Build Successful
Dan Kenigsberg has posted comments on this change.
Change subject: bootstrap: eliminate extra new line at ~/.ssh/authorized_keys
..
Patch Set 1: I would prefer that you didn't submit this
but who knows if your
Dan Kenigsberg has posted comments on this change.
Change subject: bootstrap: eliminate extra new line at ~/.ssh/authorized_keys
..
Patch Set 1:
btw, I'm repeating myself here: http://gerrit.ovirt.org/7688
--
To view, visit
Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: eliminate extra new line at ~/.ssh/authorized_keys
..
Patch Set 2:
now?
--
To view, visit http://gerrit.ovirt.org/7721
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: bootstrap: eliminate extra new line at ~/.ssh/authorized_keys
..
Patch Set 2:
Build Successful
Dan Kenigsberg has posted comments on this change.
Change subject: bootstrap: eliminate extra new line at ~/.ssh/authorized_keys
..
Patch Set 2: I would prefer that you didn't submit this
(1 inline comment)
Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: eliminate extra new line at ~/.ssh/authorized_keys
..
Patch Set 3:
ok, I did not know this was the reason... now?
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: bootstrap: eliminate extra new line at ~/.ssh/authorized_keys
..
Patch Set 3:
Build Successful
Mark Wu has posted comments on this change.
Change subject: report cpuUser and cpuSys separately
..
Patch Set 1: I would prefer that you didn't submit this
(4 inline comments)
Douglas Schilling Landgraf has posted comments on this change.
Change subject: add is_libvirtd_run method and improve comments.
..
Patch Set 2: (1 inline comment)
File
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Remove imageID in diskstats collect
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/840/ : SUCCESS
--
To view,
Mark Wu has posted comments on this change.
Change subject: [WIP] Add text-based console support
..
Patch Set 2: (15 inline comments)
Some small suggestions. I didn't do a full review on the consoleServer
implementation
Zhou Zheng Sheng has posted comments on this change.
Change subject: [WIP] Add text-based console support
..
Patch Set 2: (2 inline comments)
File vdsm/consoleServer.py
Line
Dan Kenigsberg has posted comments on this change.
Change subject: Remove imageID in diskstats collect
..
Patch Set 2: Looks good to me, but someone else must approve
the easy way is a valid way ;-)
--
To view, visit
94 matches
Mail list logo
