Yaniv Bronhaim has posted comments on this change.
Change subject: Move load_needed_modules to vdsm-tool
..
Patch Set 8: Verified; Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/7487
Dan Kenigsberg has posted comments on this change.
Change subject: Move load_needed_modules to vdsm-tool
..
Patch Set 8: Looks good to me, approved
Thanks for another vdsm-tool functionality!
--
To view, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Move load_needed_modules to vdsm-tool
..
Move load_needed_modules to vdsm-tool
Move load_needed_modules to vdsm-tool from vdsmd.init
Change-Id:
Mark Wu has posted comments on this change.
Change subject: Make vdsm/configNetwork.py PEP8 clean
..
Patch Set 3:
You give a lot of good suggestions on what the tool doesn't cover. I have fixed
it as you suggest. It makes the
Dan Kenigsberg has posted comments on this change.
Change subject: BZ#844180: Change scsi scan to asynchronous
..
Patch Set 13: I would prefer that you didn't submit this
(2 inline comments)
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm.spec: Adding hostname as Require
..
Patch Set 1: Looks good to me, approved
On Wed, Sep 05, 2012 at 05:39:24PM -0400, Douglas Landgraf wrote:
On
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vdsm.spec: Adding hostname as Require
..
vdsm.spec: Adding hostname as Require
vdsm-gencerts.sh requires hostname
Change-Id:
Antoni Segura Puimedon has posted comments on this change.
Change subject: Improve the validation of netmask and gateway
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit
Shireesh Anjal has posted comments on this change.
Change subject: Added gluster tag support in getAllTasks()
..
Patch Set 2: (1 inline comment)
File
Mark Wu has posted comments on this change.
Change subject: report cpuUser and cpuSys separately
..
Patch Set 1: (1 inline comment)
What's the benefit of this patch? To tell the cputime spent by qemu and guest
OS? Do users
Antoni Segura Puimedon has posted comments on this change.
Change subject: hook: Cisco VM-FEX support
..
Patch Set 2: I would prefer that you didn't submit this
(10 inline comments)
Not a final review yet, but some things to
Igor Lvovsky has uploaded a new change for review.
Change subject: Set right MTU when removing bridgeless networks
..
Set right MTU when removing bridgeless networks
Bug-Id: https://bugzilla.redhat.com/show_bug.cgi?id=854919
Igor Lvovsky has uploaded a new change for review.
Change subject: Change getVlansForNic to more general getVlansForIface
..
Change getVlansForNic to more general getVlansForIface
Change-Id:
Alon Bar-Lev has posted comments on this change.
Change subject: Trigger reboot automatically after upgrade
..
Patch Set 2:
Dan?
--
To view, visit http://gerrit.ovirt.org/7778
To unsubscribe, visit
Dan Kenigsberg has uploaded a new change for review.
Change subject: vdsmd: set nwfilter on ovirt-node
..
vdsmd: set nwfilter on ovirt-node
ovirt-node is shipped with .pyc only. Do not try running a missing
executable.
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsmd: set nwfilter on ovirt-node
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/7821
To
Dan Kenigsberg has posted comments on this change.
Change subject: bootstrap: perform reboot asynchronously
..
Patch Set 1: I would prefer that you didn't submit this
(2 inline comments)
(I'm not the python purist you make of
Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: perform reboot asynchronously
..
Patch Set 1: (2 inline comments)
Yes you are :)
File
Moti Asayag has posted comments on this change.
Change subject: vdsmd: set nwfilter on ovirt-node
..
Patch Set 1: Verified
verified on rhel6.3
--
To view, visit http://gerrit.ovirt.org/7821
To unsubscribe, visit
Saggi Mizrahi has posted comments on this change.
Change subject: schema: Rename Global class to Host
..
Patch Set 7: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7010
To unsubscribe, visit
Saggi Mizrahi has submitted this change and it was merged.
Change subject: schema: Rename Global class to Host
..
schema: Rename Global class to Host
The Host class is the root of the API. It will have functions to connect
Saggi Mizrahi has posted comments on this change.
Change subject: schema: Add class constructors to the schema
..
Patch Set 7: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7011
To unsubscribe,
Saggi Mizrahi has submitted this change and it was merged.
Change subject: schema: Add class constructors to the schema
..
schema: Add class constructors to the schema
All classes will accept parameters when they are
Saggi Mizrahi has posted comments on this change.
Change subject: schema: Add StorageDomainStatsMap map type
..
Patch Set 7: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7014
To unsubscribe,
Saggi Mizrahi has submitted this change and it was merged.
Change subject: schema: Add StorageDomainStatsMap map type
..
schema: Add StorageDomainStatsMap map type
API.getStorageRepoStats refers to an undefined mapping type.
Saggi Mizrahi has posted comments on this change.
Change subject: schema: Fixup command return values
..
Patch Set 7: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7017
To unsubscribe, visit
Saggi Mizrahi has submitted this change and it was merged.
Change subject: schema: Fixup command return values
..
schema: Fixup command return values
Commands return a single unnamed typed item. Fix the schema to reflect
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsmd: set nwfilter on ovirt-node
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/7821
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: vdsmd: set nwfilter on ovirt-node
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7821
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vdsmd: set nwfilter on ovirt-node
..
vdsmd: set nwfilter on ovirt-node
ovirt-node is shipped with .pyc only. Do not try running a missing
executable.
Dan Kenigsberg has posted comments on this change.
Change subject: Trigger reboot automatically after upgrade
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7778
To unsubscribe, visit
Igor Lvovsky has uploaded a new change for review.
Change subject: Continue support nicless bridge.
..
Continue support nicless bridge.
In general we can define bridge without connect it to any interface (nic/bond).
This
Igor Lvovsky has posted comments on this change.
Change subject: Continue support nicless bridge.
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/7831
To unsubscribe, visit http://gerrit.ovirt.org/settings
Igor Lvovsky has posted comments on this change.
Change subject: Continue support nicless bridge.
..
Patch Set 1:
Path all ruth tests
--
To view, visit http://gerrit.ovirt.org/7831
To unsubscribe, visit
Adam Litke has posted comments on this change.
Change subject: [WIP] vdsm API and libvdsm
..
Patch Set 1: (9 inline comments)
File vdsm_api/BindingJsonRpc.py
Line 18: import
Ayal Baron has posted comments on this change.
Change subject: BZ#844180: Change scsi scan to asynchronous
..
Patch Set 13: (1 inline comment)
File vdsm/storage/iscsi.py
Federico Simoncelli has uploaded a new change for review.
Change subject: DomainMonitor shouldn't releaseHostId if the domain is missing
..
DomainMonitor shouldn't releaseHostId if the domain is missing
In this patch:
* do not
Yaniv Bronhaim has posted comments on this change.
Change subject: make pep8 happy with config.py.in
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/7781
To
Yaniv Bronhaim has posted comments on this change.
Change subject: make pep8 happy with config.py.in
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/7781
To unsubscribe, visit
Adam Litke has uploaded a new change for review.
Change subject: build: Use correct equality operator for /bin/test
..
build: Use correct equality operator for /bin/test
According to the man page for 'test', the correct token
Dan Kenigsberg has posted comments on this change.
Change subject: build: Use correct equality operator for /bin/test
..
Patch Set 1: Looks good to me, approved
On my fedora
$ /usr/bin/test a == a echo yes
yes
works fine,
Dan Kenigsberg has posted comments on this change.
Change subject: make pep8 happy with config.py.in
..
Patch Set 1: Looks good to me, approved
Thanks, Yaniv!
--
To view, visit http://gerrit.ovirt.org/7781
To unsubscribe,
Dan Kenigsberg has submitted this change and it was merged.
Change subject: make pep8 happy with config.py.in
..
make pep8 happy with config.py.in
Change-Id: Idc172808b58512d9e154e1445d90c4f3019d82c0
Signed-off-by: Dan
Douglas Schilling Landgraf has posted comments on this change.
Change subject: engine.py: fix nodeCleanup() call
..
Patch Set 4: (1 inline comment)
File
Dan Kenigsberg has posted comments on this change.
Change subject: libvirtvm: Cast text to string when creating text node
..
Patch Set 1: (1 inline comment)
File
Dan Kenigsberg has posted comments on this change.
Change subject: engine.py: fix nodeCleanup() call
..
Patch Set 4: (1 inline comment)
File vdsm_reg/deployUtil.py.in
Line
Adam Litke has posted comments on this change.
Change subject: build: Use correct equality operator for /bin/test
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/7834
To unsubscribe, visit
Adam Litke has abandoned this change.
Change subject: schema: Introduce a Test object
..
Patch Set 6: Abandoned
No longer need to have a Test schema object.
--
To view, visit http://gerrit.ovirt.org/7018
To unsubscribe, visit
Adam Litke has uploaded a new change for review.
Change subject: schema: Change the format for specifying unions
..
schema: Change the format for specifying unions
Unions are regular types but with methods to 'cast' the
Adam Litke has uploaded a new change for review.
Change subject: schema: getStorageRepoStats returns StorageDomainVitalsMap
..
schema: getStorageRepoStats returns StorageDomainVitalsMap
The schema incorrectly had
Adam Litke has uploaded a new change for review.
Change subject: schema: New type VmParameters
..
schema: New type VmParameters
Although the format of the data passed via VM.create is very similar to a
VmDefinition, some of the
Dan Kenigsberg has posted comments on this change.
Change subject: Change getVlansForNic to more general getVlansForIface
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7810
To
Dan Kenigsberg has submitted this change and it was merged.
Change subject: build: Use correct equality operator for /bin/test
..
build: Use correct equality operator for /bin/test
According to the man page for 'test', the
Dan Kenigsberg has posted comments on this change.
Change subject: Set right MTU when removing bridgeless networks
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/7811
Dan Kenigsberg has posted comments on this change.
Change subject: Continue support nicless bridge.
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/7831
To unsubscribe,
Mark Wu has posted comments on this change.
Change subject: schema: Fix up VmDefinition Types
..
Patch Set 2: (1 inline comment)
File vdsm_api/vdsmapi-schema.json
Line 2346:
Zhou Zheng Sheng has posted comments on this change.
Change subject: Make vdsm/configNetwork.py PEP8 clean
..
Patch Set 3: Verified; Looks good to me, but someone else must approve
Run through autobuild.sh.
pydiff reports 10
57 matches
Mail list logo
