Change in vdsm[master]: Skip setting up network if no change is found.

2012-09-17 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: Skip setting up network if no change is found. .. Patch Set 1: I would prefer that you didn't submit this (4 inline comments) Just a couple of issues,

Change in vdsm[master]: Skip setting up network if no change is found.

2012-09-17 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: Skip setting up network if no change is found. .. Patch Set 1: To my previous review, I add that it might be good to have something in unit tests for

Change in vdsm[master]: BZ#856167 - Validate downloaded SSH public key

2012-09-17 Thread juan . hernandez
Juan Hernandez has uploaded a new change for review. Change subject: BZ#856167 - Validate downloaded SSH public key .. BZ#856167 - Validate downloaded SSH public key During registration the SSH public key of the engine is

Change in vdsm[master]: Add an option to create a watchdog device.

2012-09-17 Thread wudxw
Mark Wu has posted comments on this change. Change subject: Add an option to create a watchdog device. .. Patch Set 4: I would prefer that you didn't submit this (13 inline comments)

Change in vdsm[master]: BZ#856167 - Verify downloaded CA certificate

2012-09-17 Thread juan . hernandez
Juan Hernandez has uploaded a new change for review. Change subject: BZ#856167 - Verify downloaded CA certificate .. BZ#856167 - Verify downloaded CA certificate During installation the CA certificate of the engine is

Change in vdsm[master]: BZ#856167 - Parse correctly the management_server parameter

2012-09-17 Thread juan . hernandez
Juan Hernandez has uploaded a new change for review. Change subject: BZ#856167 - Parse correctly the management_server parameter .. BZ#856167 - Parse correctly the management_server parameter When doing automatic installations

Change in vdsm[master]: faqemu: remove the fake /dev/kvm after vdsmd stops

2012-09-17 Thread Ryan Harper
Ryan Harper has posted comments on this change. Change subject: faqemu: remove the fake /dev/kvm after vdsmd stops .. Patch Set 3: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/7885

Change in vdsm[master]: add uptime field to the getStats (getVdsStats in vdsClient...

2012-09-17 Thread Ryan Harper
Ryan Harper has posted comments on this change. Change subject: add uptime field to the getStats (getVdsStats in vdsClient) call .. Patch Set 2: Looks good to me, but someone else must approve -- To view, visit

Change in vdsm[master]: BZ#856167 - Verify downloaded CA certificate

2012-09-17 Thread dougsland
Douglas Schilling Landgraf has posted comments on this change. Change subject: BZ#856167 - Verify downloaded CA certificate .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit

Change in vdsm[master]: BZ#856167 - Parse correctly the management_server parameter

2012-09-17 Thread Ryan Harper
Ryan Harper has posted comments on this change. Change subject: BZ#856167 - Parse correctly the management_server parameter .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit

Change in vdsm[master]: BZ#856167 - Parse correctly the management_server parameter

2012-09-17 Thread dougsland
Douglas Schilling Landgraf has posted comments on this change. Change subject: BZ#856167 - Parse correctly the management_server parameter .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit

Change in vdsm[master]: BZ#856167 - Verify downloaded CA certificate

2012-09-17 Thread Ryan Harper
Ryan Harper has posted comments on this change. Change subject: BZ#856167 - Verify downloaded CA certificate .. Patch Set 1: I would prefer that you didn't submit this (1 inline comment)

Change in vdsm[master]: BZ#856167 - Verify downloaded CA certificate

2012-09-17 Thread juan . hernandez
Juan Hernandez has posted comments on this change. Change subject: BZ#856167 - Verify downloaded CA certificate .. Patch Set 1: (1 inline comment) File

Change in vdsm[master]: BZ#856167 - Verify downloaded CA certificate

2012-09-17 Thread juan . hernandez
Juan Hernandez has posted comments on this change. Change subject: BZ#856167 - Verify downloaded CA certificate .. Patch Set 2: Replaced mkstemp with NamedTemporaryFile. -- To view, visit http://gerrit.ovirt.org/8021 To

Change in vdsm[master]: add uptime field to the getStats (getVdsStats in vdsClient...

2012-09-17 Thread shuming
Shu Ming has posted comments on this change. Change subject: add uptime field to the getStats (getVdsStats in vdsClient) call .. Patch Set 2: I would prefer that you didn't submit this (1 inline comment)

Change in vdsm[master]: pep8ize vdsm/vdsm entry point

2012-09-17 Thread danken
Dan Kenigsberg has uploaded a new change for review. Change subject: pep8ize vdsm/vdsm entry point .. pep8ize vdsm/vdsm entry point Change-Id: Ia8c20b5dad7bf502e2862db14d6062ddc239ca3c Signed-off-by: Dan Kenigsberg

Change in vdsm[master]: removing cpuIdle

2012-09-17 Thread lhornyak
Laszlo Hornyak has posted comments on this change. Change subject: removing cpuIdle .. Patch Set 4: Verified -- To view, visit http://gerrit.ovirt.org/7892 To unsubscribe, visit http://gerrit.ovirt.org/settings

Change in vdsm[master]: BZ#856167 - Parse correctly the management_server parameter

2012-09-17 Thread juan . hernandez
Juan Hernandez has posted comments on this change. Change subject: BZ#856167 - Parse correctly the management_server parameter .. Patch Set 1: Verified With this change I see the following in /var/log/vdsm/vdsm-config after

Change in vdsm[master]: BZ#856167 - Verify downloaded CA certificate

2012-09-17 Thread dougsland
Douglas Schilling Landgraf has posted comments on this change. Change subject: BZ#856167 - Verify downloaded CA certificate .. Patch Set 2: Looks good to me, but someone else must approve -- To view, visit

Change in vdsm[master]: BZ#856167 - Validate downloaded SSH public key

2012-09-17 Thread Ryan Harper
Ryan Harper has posted comments on this change. Change subject: BZ#856167 - Validate downloaded SSH public key .. Patch Set 1: I would prefer that you didn't submit this (1 inline comment) Code looks fine, but I'd like to get

Change in vdsm[master]: BZ#856167 - Validate downloaded SSH public key

2012-09-17 Thread juan . hernandez
Juan Hernandez has posted comments on this change. Change subject: BZ#856167 - Validate downloaded SSH public key .. Patch Set 1: (1 inline comment) File

Change in vdsm[master]: BZ#856167 - Verify downloaded CA certificate

2012-09-17 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: BZ#856167 - Verify downloaded CA certificate .. Patch Set 2: (1 inline comment) File

Change in vdsm[master]: BZ#856167 - Validate downloaded SSH public key

2012-09-17 Thread juan . hernandez
Juan Hernandez has posted comments on this change. Change subject: BZ#856167 - Validate downloaded SSH public key .. Patch Set 1: (1 inline comment) File

Change in vdsm[master]: removing cpuIdle

2012-09-17 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: removing cpuIdle .. removing cpuIdle cpuIdle is not used by the engine, and it is wrong anyway Change-Id: I3308858f5c27c3dd193cd981c43721fa1cd023d9

Change in vdsm[master]: converting some more RH strings to oVirt

2012-09-17 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: converting some more RH strings to oVirt .. Patch Set 6: I would prefer that you didn't submit this (1 inline comment) minor comment about names.

Change in vdsm[master]: add and use hypervisor autodetection in bootstrap.

2012-09-17 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: add and use hypervisor autodetection in bootstrap. .. Patch Set 4: (1 inline comment) Commit Message Line

Change in vdsm[master]: Fix crash when libvirt refers to non-existing non-bridged in...

2012-09-17 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Fix crash when libvirt refers to non-existing non-bridged interfaces. .. Patch Set 2: Verified; Looks good to me, approved -- To view, visit

Change in vdsm[master]: Fix crash when libvirt refers to non-existing non-bridged in...

2012-09-17 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: Fix crash when libvirt refers to non-existing non-bridged interfaces. .. Fix crash when libvirt refers to non-existing non-bridged interfaces. This

Change in vdsm[master]: vdsm-upgrade: stop vdsm when complete upgrade

2012-09-17 Thread dougsland
Douglas Schilling Landgraf has posted comments on this change. Change subject: vdsm-upgrade: stop vdsm when complete upgrade .. Patch Set 1: (1 inline comment) File

Change in vdsm[master]: pep8ize vdsm/vdsm entry point

2012-09-17 Thread zhshzhou
Zhou Zheng Sheng has posted comments on this change. Change subject: pep8ize vdsm/vdsm entry point .. Patch Set 1: Verified (1 inline comment) Run through autobuild.sh. pydiff reports same changes, they are splitting big

Change in vdsm[master]: vdsm-upgrade: stop vdsm when complete upgrade

2012-09-17 Thread dougsland
Douglas Schilling Landgraf has posted comments on this change. Change subject: vdsm-upgrade: stop vdsm when complete upgrade .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/8029 To unsubscribe, visit

Change in vdsm[master]: pep8ize vdsm/vdsm entry point

2012-09-17 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: pep8ize vdsm/vdsm entry point .. Patch Set 1: Looks good to me, approved (1 inline comment) File

Change in vdsm[master]: pep8ize vdsm/vdsm entry point

2012-09-17 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: pep8ize vdsm/vdsm entry point .. pep8ize vdsm/vdsm entry point Change-Id: Ia8c20b5dad7bf502e2862db14d6062ddc239ca3c Signed-off-by: Dan Kenigsberg