Dan Kenigsberg has posted comments on this change.
Change subject: vdsm.spec.in: use locale LC_ALL
..
Patch Set 1: I would prefer that you didn't submit this
(2 inline comments)
textual comments only
Dan Kenigsberg has posted comments on this change.
Change subject: bootstrap: use yum API
..
Patch Set 1: (4 inline comments)
yeah, I must find the peace of mind to look deeper.
Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: use yum API
..
Patch Set 1: (4 inline comments)
File vds_bootstrap/MiniYum.py
Line 409:
Laszlo Hornyak has posted comments on this change.
Change subject: report cpuUser and cpuSys separately
..
Patch Set 2: (1 inline comment)
Commit Message
Line 5: CommitDate:
Antoni Segura Puimedon has posted comments on this change.
Change subject: Do not propagate the bridge bootproto to the underlying devices.
..
Patch Set 2: (1 inline comment)
Saggi Mizrahi has posted comments on this change.
Change subject: Properly propagate pool timeout in file handler
..
Patch Set 7: (1 inline comment)
File
Mark Wu has posted comments on this change.
Change subject: fix dataProgress of migration
..
Patch Set 4: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/7914
To unsubscribe, visit
Doron Fediuck has posted comments on this change.
Change subject: [WIP]add mem cgroup support to vdsm
..
Patch Set 1: I would prefer that you didn't submit this
(2 inline comments)
Royce,
Please see inline.
Also, the API is
Pradipta Banerjee has posted comments on this change.
Change subject: bootstrap: use yum API
..
Patch Set 1: (1 inline comment)
File vds_bootstrap/Makefile.am
Line 43:
Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: use yum API
..
Patch Set 1: (2 inline comments)
File vds_bootstrap/MiniYum.py
Line 443:
Pradipta Banerjee has posted comments on this change.
Change subject: bootstrap: use yum API
..
Patch Set 1: I would prefer that you didn't submit this
(2 inline comments)
Federico Simoncelli has posted comments on this change.
Change subject: Move the lastCheck computation in getRepoStats
..
Patch Set 1: (1 inline comment)
File
Deepak C Shetty has posted comments on this change.
Change subject: Move gluster/{cli.py, exception.py} to vdsm rpm
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/8033
To unsubscribe, visit
Saggi Mizrahi has uploaded a new change for review.
Change subject: Fix data pass with async execution
..
Fix data pass with async execution
Change-Id: Ibe496e74a24721ba00c596d36286bcdafdc20069
Signed-off-by: Saggi Mizrahi
Igor Lvovsky has posted comments on this change.
Change subject: Do not propagate top layer interfaces bootproto to the
underlying devices.
..
Patch Set 3: Looks good to me, approved
(1 inline comment)
Pradipta Banerjee has posted comments on this change.
Change subject: vdsm bootstrap changes for kvm on ppc64 support
..
Patch Set 7: (1 inline comment)
File
Yaniv Bronhaim has uploaded a new change for review.
Change subject: Adding new resourceFactory that only opens fd
..
Adding new resourceFactory that only opens fd
Avoiding activate every time we try to access lv and only open
Antoni Segura Puimedon has posted comments on this change.
Change subject: Do not propagate top layer interfaces bootproto to the
underlying devices.
..
Patch Set 3: (1 inline comment)
Deepak C Shetty has uploaded a new change for review.
Change subject: Introduce getMountPoint for NfsStorageDomain
..
Introduce getMountPoint for NfsStorageDomain
Move the code to generate the mount point into a seperate
Deepak C Shetty has posted comments on this change.
Change subject: Introduce getMountPoint for NfsStorageDomain
..
Patch Set 1:
@Dan,
As requested by you, i have split this change (from 6856) into a separate
patch.
--
To
Deepak C Shetty has posted comments on this change.
Change subject: Introduce getMountPoint for NfsStorageDomain
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/8085
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: Fix data pass with async execution
..
Patch Set 1: Looks good to me, but someone else must approve
yes, writing into stdout is dubious.
--
To view, visit
Yeela Kaplan has posted comments on this change.
Change subject: Fix data pass with async execution
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/8081
To unsubscribe,
Antoni Segura Puimedon has posted comments on this change.
Change subject: Do not propagate top layer interfaces bootproto to the
underlying devices.
..
Patch Set 3: Verified
Verified via vdsCli.
--
To view, visit
Saggi Mizrahi has posted comments on this change.
Change subject: Adding new resourceFactory that only opens fd
..
Patch Set 3: I would prefer that you didn't submit this
(3 inline comments)
Alon Bar-Lev has posted comments on this change.
Change subject: Validate downloaded CA certificate
..
Patch Set 5: Looks good to me, but someone else must approve
I still think that doing the write/move approach should have
Saggi Mizrahi has uploaded a new change for review.
Change subject: Add callback to the plethora of retry halting possibilities
..
Add callback to the plethora of retry halting possibilities
Change-Id:
Pradipta Banerjee has uploaded a new change for review.
Change subject: Add support for KVM on IBM POWER processor (ppc64)
..
Add support for KVM on IBM POWER processor (ppc64)
This patchset adds ppc64 arch support to the
Pradipta Banerjee has abandoned this change.
Change subject: vdsm bootstrap changes for kvm on ppc64 support
..
Patch Set 7: Abandoned
This patchset has been split into multiple patches as suggested by Dan. Hence
abandoning
Pradipta Banerjee has posted comments on this change.
Change subject: Add support for KVM on IBM POWER processor (ppc64)
..
Patch Set 1: Verified
compiled and tested cpu and virt capability detection on F17 ppc64 m/c
--
To
Ryan Harper has posted comments on this change.
Change subject: Add simple text-based console in vdsClient
..
Patch Set 1: I would prefer that you didn't submit this
(2 inline comments)
Ryan Harper has posted comments on this change.
Change subject: Validate downloaded CA certificate
..
Patch Set 5: I would prefer that you didn't submit this
(1 inline comment)
Ryan Harper has posted comments on this change.
Change subject: BZ#856167 - Validate downloaded SSH public key
..
Patch Set 4: I would prefer that you didn't submit this
(1 inline comment)
Code looks fine, just a minor nit to
Juan Hernandez has posted comments on this change.
Change subject: Validate downloaded CA certificate
..
Patch Set 5: (1 inline comment)
File vdsm_reg/deployUtil.py.in
Line
Juan Hernandez has uploaded a new change for review.
Change subject: Add input parameter to _logExec
..
Add input parameter to _logExec
This allows the use of _logExec when some text has to be provided in the
standard input of
Juan Hernandez has posted comments on this change.
Change subject: Validate downloaded CA certificate
..
Patch Set 6:
Separaed the changes to _logExec to a different patch.
--
To view, visit http://gerrit.ovirt.org/8021
To
Shu Ming has posted comments on this change.
Change subject: Move gluster/{cli.py, exception.py} to vdsm rpm
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/8033
To
Juan Hernandez has posted comments on this change.
Change subject: Validate downloaded SSH public key
..
Patch Set 5:
Fixed the issue with the docstrings and moved the bug reference to Bug-Id (I
have been asked to do this in
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm.spec.in: use locale LC_ALL=C
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/8068
To unsubscribe, visit
Shu Ming has posted comments on this change.
Change subject: Fix data pass with async execution
..
Patch Set 1: I would prefer that you didn't submit this
The patch subject is confusing to me. It tells me it fixes a problem
Ryan Harper has posted comments on this change.
Change subject: Add input parameter to _logExec
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/8095
To unsubscribe,
Ryan Harper has posted comments on this change.
Change subject: Validate downloaded CA certificate
..
Patch Set 6: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/8021
To unsubscribe,
Ryan Harper has posted comments on this change.
Change subject: Validate downloaded SSH public key
..
Patch Set 5: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/8018
To unsubscribe,
Antoni Segura Puimedon has uploaded a new change for review.
Change subject: Make vlan and bonding dhcp ifup to be asynchronous.
..
Make vlan and bonding dhcp ifup to be asynchronous.
Extends the asynchronous dhcp ifup beyond
Antoni Segura Puimedon has uploaded a new change for review.
Change subject: Generalize asynchronous ifupping of network interfaces.
..
Generalize asynchronous ifupping of network interfaces.
Make the already used asynchronous
Alon Bar-Lev has posted comments on this change.
Change subject: Add support for KVM on IBM POWER processor (ppc64)
..
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
Get rid of trailing
Dan Kenigsberg has posted comments on this change.
Change subject: Add support for KVM on IBM POWER processor (ppc64)
..
Patch Set 1: I would prefer that you didn't submit this
I'm afraid trailing whitespace is showstopper for
Dan Kenigsberg has posted comments on this change.
Change subject: Do not propagate top layer interfaces bootproto to the
underlying devices.
..
Patch Set 3: (1 inline comment)
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Do not propagate top layer interfaces bootproto to the
underlying devices.
..
Do not propagate top layer interfaces bootproto to the underlying
Dan Kenigsberg has posted comments on this change.
Change subject: Introduce getMountPoint for NfsStorageDomain
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/8085
To
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm.spec.in: use locale LC_ALL=C
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8068
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vdsm.spec.in: use locale LC_ALL=C
..
vdsm.spec.in: use locale LC_ALL=C
During VDSM instalation, we verify if SELinux booleans are
enabled with return
Dan Kenigsberg has posted comments on this change.
Change subject: Add input parameter to _logExec
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/8095
To unsubscribe,
Dan Kenigsberg has posted comments on this change.
Change subject: Move gluster/{cli.py, exception.py} to vdsm rpm
..
Patch Set 2: I would prefer that you didn't submit this
I'm marking this with -1 not because it is wrong,
Dan Kenigsberg has posted comments on this change.
Change subject: BZ#844180: Change scsi scan to asynchronous
..
Patch Set 16: (1 inline comment)
File vdsm/storage/iscsi.py
Douglas Schilling Landgraf has posted comments on this change.
Change subject: Add input parameter to _logExec
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/8095
To
Dan Kenigsberg has posted comments on this change.
Change subject: bootstrap: use yum API
..
Patch Set 1: (1 inline comment)
File vds_bootstrap/vds_bootstrap.py
Line 67:
Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: use yum API
..
Patch Set 3:
For some strange reasons I did not see some comments...
--
To view, visit http://gerrit.ovirt.org/8039
To unsubscribe,
Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: use yum API
..
Patch Set 1: (3 inline comments)
File vds_bootstrap/MiniYum.py
Line 409:
Ryan Harper has posted comments on this change.
Change subject: move get-conf-item/set-conf-item to vdsm-tool
..
Patch Set 2: I would prefer that you didn't submit this
(6 inline comments)
Ryan Harper has posted comments on this change.
Change subject: dump the core of a domain
..
Patch Set 2: I would prefer that you didn't submit this
If you're touching API.py, you need to also update
Ryan Harper has posted comments on this change.
Change subject: migrateStatus() progress report
..
Patch Set 6: I would prefer that you didn't submit this
(1 inline comment)
Yaniv Bronhaim has uploaded a new change for review.
Change subject: removing prepare from recoverExistVms
..
removing prepare from recoverExistVms
we don't need all prepare process after adding volumeFactory that holds
open fd
Greg Padgett has uploaded a new change for review.
Change subject: BZ#855729 - Default to NFSv3 if version not specified
..
BZ#855729 - Default to NFSv3 if version not specified
Unexpectedly switching to NFSv4 during e.g.
Ryan Harper has posted comments on this change.
Change subject: Add support for KVM on IBM POWER processor (ppc64)
..
Patch Set 1: I would prefer that you didn't submit this
(2 inline comments)
Greg Padgett has posted comments on this change.
Change subject: BZ#855729 - Default to NFSv3 if version not specified
..
Patch Set 1: I would prefer that you didn't submit this
--
To view, visit http://gerrit.ovirt.org/8110
Douglas Schilling Landgraf has posted comments on this change.
Change subject: Fix vdsm-reg service name
..
Patch Set 3: (2 inline comments)
Hi Fernando, IMO, you could split your patch. Also, fell free to add your name
into
Xu He Jie has posted comments on this change.
Change subject: Add simple text-based console in vdsClient
..
Patch Set 1: (2 inline comments)
Commit Message
Line 8:
Line 9:
Mark Wu has posted comments on this change.
Change subject: report cpuUser and cpuSys separately
..
Patch Set 3: I would prefer that you didn't submit this
(2 inline comments)
Greg Padgett has abandoned this change.
Change subject: BZ#855729 - Default to NFSv3 if version not specified
..
Patch Set 1: Abandoned
Patch behavior is wrong
--
To view, visit http://gerrit.ovirt.org/8110
To unsubscribe,
ShaoHe Feng has posted comments on this change.
Change subject: migrateStatus() progress report
..
Patch Set 6: I would prefer that you didn't submit this
(1 inline comment)
ShaoHe Feng has posted comments on this change.
Change subject: Add simple text-based console in vdsClient
..
Patch Set 1: (1 inline comment)
File vdsm_cli/vdsClient.py
Line
Deepak C Shetty has uploaded a new change for review.
Change subject: pep8ize vdsm/vdsm
..
pep8ize vdsm/vdsm
Makes vdsm/vdsm pep8 compliant
Change-Id: Ic8fd567366ed34b5b2f56fc968ca4769ab27b4ff
Signed-off-by: Deepak C Shetty
Deepak C Shetty has posted comments on this change.
Change subject: pep8ize vdsm/vdsm
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/8114
To unsubscribe, visit http://gerrit.ovirt.org/settings
Deepak C Shetty has uploaded a new change for review.
Change subject: Unify produceVolume
..
Unify produceVolume
Unify produceVolume function and make it use getVolumeClass
so that subclasses can override getVolumeClass to
Deepak C Shetty has posted comments on this change.
Change subject: Unify produceVolume
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/8115
To unsubscribe, visit http://gerrit.ovirt.org/settings
Xu He Jie has posted comments on this change.
Change subject: Add simple text-based console in vdsClient
..
Patch Set 1: (1 inline comment)
File vdsm_cli/vdsClient.py
Line
Mark Wu has posted comments on this change.
Change subject: Generalize asynchronous ifupping of network interfaces.
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/8097
Mark Wu has posted comments on this change.
Change subject: Make vlan and bonding dhcp ifup to be asynchronous.
..
Patch Set 1: I would prefer that you didn't submit this
Why not extend it to nic too? Besides that, it looks
Mark Wu has posted comments on this change.
Change subject: schema: make ConnectionRefArgs definition agree with the code
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit
80 matches
Mail list logo
