Mark Wu has posted comments on this change.
Change subject: Introduce a new verb setBalloonTarget
..
Patch Set 11: Verified
Fix a small pep8 issue reported by Hervé Leclerc in patch v11.
This patch was submit before the
Mark Wu has uploaded a new change for review.
Change subject: Enable balloon controller for MOM by default.
..
Enable balloon controller for MOM by default.
Since vdsm can support memory balloon tunning now, we should enable
Mark Wu has posted comments on this change.
Change subject: Enable balloon controller for MOM by default.
..
Patch Set 1:
The balloon support patch is in http://gerrit.ovirt.org/#/c/3669/
It's almost ready to merge.
--
To
ShaoHe Feng has posted comments on this change.
Change subject: Move gluster/{cli,exception,hostname,__init__}.py to vdsm rpm
..
Patch Set 3:
yes, you are right.
since you have move the files from vdsm-gluster rpm to vdsm
Mark Wu has posted comments on this change.
Change subject: engine.py: fix nodeCleanup() call
..
Patch Set 4:
Douglas,
I have two questions:
1. why do we try to avoid overriding the old cert. it seems related to
bz741856, but
Shireesh Anjal has posted comments on this change.
Change subject: glusterHostsList verb returns local hostname as IP address or
FQDN
..
Patch Set 5: Looks good to me, but someone else must approve
--
To view, visit
Peter V. Saveliev has posted comments on this change.
Change subject: BZ#855922, fix attribute error during migration
..
Patch Set 3: (1 inline comment)
Commit Message
Line
Yaniv Bronhaim has posted comments on this change.
Change subject: add is_libvirtd_run method and improve comments.
..
Patch Set 4: Verified
please check it, i think this patch makes the bash file a little bit more
readable
Dan Kenigsberg has posted comments on this change.
Change subject: bootstrap: use yum API
..
Patch Set 9: I would prefer that you didn't submit this
(9 inline comments)
Dan Kenigsberg has posted comments on this change.
Change subject: add is_libvirtd_run method and improve comments.
..
Patch Set 4: I would prefer that you didn't submit this
(1 inline comment)
Dan Kenigsberg has posted comments on this change.
Change subject: schema: Fixup command return values
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8191
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: schema: Fixup command return values
..
schema: Fixup command return values
There still one is not fixuped, so fix it.
Change-Id:
Laszlo Hornyak has posted comments on this change.
Change subject: report cpuUser and cpuSys separately (#800367)
..
Patch Set 5: (2 inline comments)
Commit Message
Line 5:
Dan Kenigsberg has posted comments on this change.
Change subject: report cpuUser and cpuSys separately (#800367)
..
Patch Set 5: (1 inline comment)
Commit Message
Line 5:
Mark Wu has posted comments on this change.
Change subject: Use 'yum clean expire-cache' instead of 'yum clean all'
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/8206
To unsubscribe, visit
Igor Lvovsky has posted comments on this change.
Change subject: Adding hooks support for NIC hotplug
..
Patch Set 3: Looks good to me, but someone else must approve
Itzik, I would glad to see the hook itself if it possible
Deepak C Shetty has posted comments on this change.
Change subject: Move gluster/{cli,exception,hostname,__init__}.py to vdsm rpm
..
Patch Set 4: Verified
--
To view, visit http://gerrit.ovirt.org/8033
To unsubscribe, visit
Laszlo Hornyak has posted comments on this change.
Change subject: report cpuUser and cpuSys separately (#800367)
..
Patch Set 5: (1 inline comment)
Commit Message
Line 5:
Saggi Mizrahi has uploaded a new change for review.
Change subject: Fix some pep8 errors
..
Fix some pep8 errors
Change-Id: I417f646b8fc1f242f3d5c91fdf0d7e79600552e9
Signed-off-by: Saggi Mizrahi smizr...@redhat.com
---
M
Ayal Baron has posted comments on this change.
Change subject: [WIP] Avoid prezeroing optimization in _createTargetImage
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit
Greg Padgett has uploaded a new change for review.
Change subject: storage: Default to NFSv3 if version not specified
..
storage: Default to NFSv3 if version not specified
Unexpectedly switching to NFSv4 during e.g. upgrades
Dan Kenigsberg has posted comments on this change.
Change subject: glusterHostsList verb returns local hostname as IP address or
FQDN
..
Patch Set 5: Looks good to me, approved
I do not want to delay this any further.
--
To
Dan Kenigsberg has submitted this change and it was merged.
Change subject: glusterHostsList verb returns local hostname as IP address or
FQDN
..
glusterHostsList verb returns local hostname as IP address or FQDN
The verb
Greg Padgett has posted comments on this change.
Change subject: storage: Default to NFSv3 if version not specified
..
Patch Set 1: Verified
Also see engine changes at http://gerrit.ovirt.org/8242
--
To view, visit
Dan Kenigsberg has posted comments on this change.
Change subject: Support for the new polkit rules
..
Patch Set 2: Looks good to me, approved
I'm trusting you guys!
--
To view, visit http://gerrit.ovirt.org/8213
To
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Support for the new polkit rules
..
Support for the new polkit rules
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=829884
Signed-off-by:
Federico Simoncelli has uploaded a new change for review.
Change subject: build: improve the gitignore Makefile check
..
build: improve the gitignore Makefile check
Change-Id: Ifc2315d39fa975089f152757bedf88ec1607b921
Dan Kenigsberg has posted comments on this change.
Change subject: Use 'yum clean expire-cache' instead of 'yum clean all'
..
Patch Set 1: Looks good to me, approved
seems reasonable to me.
--
To view, visit
Moti Asayag has uploaded a new change for review.
Change subject: vdsm: Use virsh to check if libvirt is up
..
vdsm: Use virsh to check if libvirt is up
The patch replaces libvirt socket file existence check with a check
using
Moti Asayag has posted comments on this change.
Change subject: vdsm: Use virsh to check if libvirt is up
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/8245
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm: Use virsh to check if libvirt is up
..
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm: Use virsh to check if libvirt is up
..
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
Igor Lvovsky has uploaded a new change for review.
Change subject: Read 'source' of NIC interface only if exists
..
Read 'source' of NIC interface only if exists
Change-Id: Idec5aef35298d93fd35d4f4a1933809c32ecce16
Alon Bar-Lev has posted comments on this change.
Change subject: Use 'yum clean expire-cache' instead of 'yum clean all'
..
Patch Set 2:
I don't like this is merged. At my environment there were scenarios that it was
not
Alon Bar-Lev has posted comments on this change.
Change subject: engine.py: fix nodeCleanup() call
..
Patch Set 4: (1 inline comment)
File vdsm_reg/deployUtil.py.in
Line
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm: Use virsh to check if libvirt is up
..
Patch Set 1: (1 inline comment)
File vdsm/vdsmd.init.in
Line
Dan Kenigsberg has posted comments on this change.
Change subject: Use 'yum clean expire-cache' instead of 'yum clean all'
..
Patch Set 2:
ouch. Alon, could you elaborate what was not enough? should we revert this
patch?
Alon Bar-Lev has posted comments on this change.
Change subject: Use 'yum clean expire-cache' instead of 'yum clean all'
..
Patch Set 2:
I don't know if we should revert.
I just changed the miniyum to do the same as this
Yaniv Bronhaim has posted comments on this change.
Change subject: Fix some pep8 errors
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/8237
To unsubscribe, visit
Yaniv Bronhaim has posted comments on this change.
Change subject: Fix problems with current implementation of forceIscsiRescan
..
Patch Set 4: Looks good to me, but someone else must approve
--
To view, visit
Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: use yum API
..
Patch Set 9: (8 inline comments)
File vds_bootstrap/miniyum.py
Line 348:
Moti Asayag has posted comments on this change.
Change subject: vdsm: Use virsh to check if libvirt is up
..
Patch Set 1: (2 inline comments)
File vdsm/vdsmd.init.in
Line
Moti Asayag has posted comments on this change.
Change subject: vdsm: Use virsh to check if libvirt is up
..
Patch Set 1: (1 inline comment)
File vdsm/vdsmd.init.in
Line
Dan Kenigsberg has posted comments on this change.
Change subject: bootstrap: use yum API
..
Patch Set 9: (3 inline comments)
File vds_bootstrap/miniyum.py
Line 446:
Federico Simoncelli has uploaded a new change for review.
Change subject: setup: configure selinux for sanlock on nfs
..
setup: configure selinux for sanlock on nfs
Signed-off-by: Federico Simoncelli fsimo...@redhat.com
Yeela Kaplan has uploaded a new change for review.
Change subject: Refresh storage in getDevicesVisibility using forceIScsiRescan
..
Refresh storage in getDevicesVisibility using forceIScsiRescan
Bug-Id:
Yeela Kaplan has posted comments on this change.
Change subject: Refresh storage in getDevicesVisibility using forceIScsiRescan
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/8256
To unsubscribe, visit
Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: use yum API
..
Patch Set 10: Verified
All should be done now... :)
--
To view, visit http://gerrit.ovirt.org/8039
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: Use 'yum clean expire-cache' instead of 'yum clean all'
..
Patch Set 2:
Alon, please use your -1s so that I do not miss a commit that should not go in.
--
To
Alon Bar-Lev has posted comments on this change.
Change subject: Use 'yum clean expire-cache' instead of 'yum clean all'
..
Patch Set 2:
Ok... I was discussing... I think that if you don't get +1 from parties you
should
Pradipta Banerjee has posted comments on this change.
Change subject: Add support for KVM on IBM POWER processor (ppc64)
..
Patch Set 4: Verified
Incorporated changes as suggested by Ryan
--
To view, visit
Dan Kenigsberg has posted comments on this change.
Change subject: bootstrap: use yum API
..
Patch Set 9: (1 inline comment)
File vds_bootstrap/vds_bootstrap.py
Line 126:
Dan Kenigsberg has posted comments on this change.
Change subject: bootstrap: use yum API
..
Patch Set 10: I would prefer that you didn't submit this
(1 inline comment)
I am happy with the current state of the patch, but I'm
Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: use yum API
..
Patch Set 9: (1 inline comment)
File vds_bootstrap/vds_bootstrap.py
Line 126:
Dan Kenigsberg has posted comments on this change.
Change subject: Read 'source' of NIC interface only if exists
..
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: use yum API
..
Patch Set 9: (1 inline comment)
File vds_bootstrap/vds_bootstrap.py
Line 126:
Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: use yum API
..
Patch Set 9: (1 inline comment)
File vds_bootstrap/vds_bootstrap.py
Line 126:
Adam Litke has posted comments on this change.
Change subject: Enable balloon controller for MOM by default.
..
Patch Set 1: Verified; Looks good to me, but someone else must approve
Looks good. This will not cause any harm
Dan Kenigsberg has posted comments on this change.
Change subject: Enable balloon controller for MOM by default.
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8222
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Enable balloon controller for MOM by default.
..
Enable balloon controller for MOM by default.
Since vdsm can support memory balloon tunning now, we
Dan Kenigsberg has posted comments on this change.
Change subject: Apply memoized to getos()
..
Patch Set 1: Looks good to me, approved
seems harmless to me, and avoids few disk accesses.
--
To view, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: setup: configure selinux for sanlock on nfs
..
Patch Set 1: I would prefer that you didn't submit this
-1 since I have a question: Should'n we add
Zhou Zheng Sheng has posted comments on this change.
Change subject: Fix some pep8 errors
..
Patch Set 2:
Would you add vdsm/storage/misc.py to PEP8_WHITELIST?
--
To view, visit http://gerrit.ovirt.org/8237
To unsubscribe,
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm: Use virsh to check if libvirt is up
..
Patch Set 2: Verified; Looks good to me, but someone else must approve
Alright guys, that's ok. From
Mark Wu has posted comments on this change.
Change subject: Apply memoized to getos()
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/8209
To unsubscribe, visit http://gerrit.ovirt.org/settings
Mark Wu has posted comments on this change.
Change subject: Fix duplicate emulated machines returned
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/8208
To unsubscribe, visit
Mark Wu has posted comments on this change.
Change subject: Fix duplicate emulated machines returned
..
Patch Set 1:
Without this patch, I got:
emulatedMachines = ['pc-0.15', 'pc-1.0', 'pc', 'pc-0.14', 'pc-0.13',
67 matches
Mail list logo
