Shu Ming has posted comments on this change.
Change subject: add a jsonrpcSeverClient for jsonRPC Server functional test
..
Patch Set 2: (4 inline comments)
Commit Message
Meni Yakove has posted comments on this change.
Change subject: net: drop nicSort
..
Patch Set 1: Verified
Test the following:
*. Create BOND on ovirtmgmt bridge.
*. Create BOND on ovirtmgmt bridge with wrong IP (check
Dan Kenigsberg has uploaded a new change for review.
Change subject: vdsd.service: softly require ntpd or chronyd
..
vdsd.service: softly require ntpd or chronyd
Fedora 18 ships with chronyd by default, which conflicts with
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsd.service: softly require ntpd or chronyd
..
Patch Set 1:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/869/ (1/3)
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsd.service: softly require ntpd or chronyd
..
Patch Set 1:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/12/ (3/3)
--
To
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsd.service: softly require ntpd or chronyd
..
Patch Set 1:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/904/ (2/3)
--
To view,
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsd.service: softly require ntpd or chronyd
..
Patch Set 1: Fails
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/869/ : SUCCESS
Dan Kenigsberg has posted comments on this change.
Change subject: net: drop nicSort
..
Patch Set 1: No score
thanks!
--
To view, visit http://gerrit.ovirt.org/10585
To unsubscribe, visit http://gerrit.ovirt.org/settings
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: drop nicSort
..
net: drop nicSort
nicSort was introduced so that vdsm calls ifup on bonded nics in the
same order that initscripts does it, in
Antoni Segura Puimedon has posted comments on this change.
Change subject: vdsd.service: softly require ntpd or chronyd
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit
Zhou Zheng Sheng has posted comments on this change.
Change subject: vdsd.service: softly require ntpd or chronyd
..
Patch Set 1: (1 inline comment)
Commit Message
Line 3:
Yaniv Bronhaim has uploaded a new change for review.
Change subject: Removing vdsm configuration when removing vdsm service
..
Removing vdsm configuration when removing vdsm service
Before we removed that section only over rhel
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Removing vdsm configuration when removing vdsm service
..
Patch Set 1:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/870/ (3/3)
--
To
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Removing vdsm configuration when removing vdsm service
..
Patch Set 1:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/13/ (2/3)
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Removing vdsm configuration when removing vdsm service
..
Patch Set 1:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/905/ (1/3)
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Removing vdsm configuration when removing vdsm service
..
Patch Set 1: Fails
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/870/ :
Yaniv Bronhaim has posted comments on this change.
Change subject: Removing vdsm configuration when removing vdsm service
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/11295
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm: free loop device when umounting floppy in mkimage.py
..
Patch Set 1: Verified; Looks good to me, approved
copy Jarod's verification.
--
To view, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vdsm: free loop device when umounting floppy in mkimage.py
..
vdsm: free loop device when umounting floppy in mkimage.py
After umounting floppy
Dan Kenigsberg has posted comments on this change.
Change subject: test CommandPath
..
Patch Set 1: Verified; Looks good to me, approved
thanks for the reviews.
--
To view, visit http://gerrit.ovirt.org/11165
To unsubscribe,
Dan Kenigsberg has submitted this change and it was merged.
Change subject: test CommandPath
..
test CommandPath
Change-Id: I0b53d5ce56551fea8c6ecf7801ca2de86334cf49
Signed-off-by: Dan Kenigsberg dan...@redhat.com
---
M
Alon Bar-Lev has posted comments on this change.
Change subject: Copy truncate vdsm-reg.log
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/11282
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Copy truncate vdsm-reg.log
..
Copy truncate vdsm-reg.log
When the vdsm-reg program doesn't stop (if it fails to contact the
engine, for example) it
Dan Kenigsberg has posted comments on this change.
Change subject: Copy truncate vdsm-reg.log
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11282
To unsubscribe, visit
Federico Simoncelli has posted comments on this change.
Change subject: upgrade: Catch MetaDataKeyNotFoundError when preparing
partially removed volumes.
..
Patch Set 1: I would prefer that you didn't submit this
(2 inline
oVirt Jenkins CI Server has posted comments on this change.
Change subject: upgrade: catch MetaDataKeyNotFoundError when preparing images
..
Patch Set 2:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/14/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: upgrade: catch MetaDataKeyNotFoundError when preparing images
..
Patch Set 2:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/871/ (3/3)
oVirt Jenkins CI Server has posted comments on this change.
Change subject: upgrade: catch MetaDataKeyNotFoundError when preparing images
..
Patch Set 2:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/906/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: upgrade: catch MetaDataKeyNotFoundError when preparing images
..
Patch Set 2: Fails
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/871/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: upgrade: catch MetaDataKeyNotFoundError when preparing images
..
Patch Set 3:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/15/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: upgrade: catch MetaDataKeyNotFoundError when preparing images
..
Patch Set 3:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/907/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: upgrade: catch MetaDataKeyNotFoundError when preparing images
..
Patch Set 3:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/872/ (1/3)
Deepak C Shetty has posted comments on this change.
Change subject: Support for GLUSTERFS_DOMAIN
..
Patch Set 14: (4 inline comments)
@dan,
pls see my comments and let me know if I have understood you correctly ?
oVirt Jenkins CI Server has posted comments on this change.
Change subject: upgrade: catch MetaDataKeyNotFoundError when preparing images
..
Patch Set 3: Fails
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/872/
Douglas Schilling Landgraf has posted comments on this change.
Change subject: Removing vdsm configuration when removing vdsm service
..
Patch Set 1:
I would support removing both vdsm conf styles, the new and old one, here an
Douglas Schilling Landgraf has posted comments on this change.
Change subject: spec: requires selinux-policy to avoid selinux failure on
access tls cert
..
Patch Set 2: Looks good to me, but someone else must approve
--
To
Douglas Schilling Landgraf has posted comments on this change.
Change subject: Avoid race condition with vdsm-reg during firstboot
..
Patch Set 1: I would prefer that you didn't submit this
as mburns said.
--
To view, visit
Federico Simoncelli has posted comments on this change.
Change subject: domain: remove race condition in extend
..
Patch Set 2: Verified
Verified: a block storage domain was successfully extended.
--
To view, visit
Yaniv Bronhaim has posted comments on this change.
Change subject: Removing vdsm configuration when removing vdsm service
..
Patch Set 1:
I know that part, and it uses that to rewrite the configuration when you
reconfigure
Douglas Schilling Landgraf has posted comments on this change.
Change subject: Removing vdsm configuration when removing vdsm service
..
Patch Set 1: Looks good to me, but someone else must approve
I was sharing that we could
Dan Kenigsberg has uploaded a new change for review.
Change subject: logUtils.funcName: work on partial methods
..
logUtils.funcName: work on partial methods
misc.Event.emit() fails when its callback is a partial(method, args)
oVirt Jenkins CI Server has posted comments on this change.
Change subject: logUtils.funcName: work on partial methods
..
Patch Set 1:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/16/ (1/3)
--
To view,
oVirt Jenkins CI Server has posted comments on this change.
Change subject: logUtils.funcName: work on partial methods
..
Patch Set 1:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/873/ (2/3)
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: logUtils.funcName: work on partial methods
..
Patch Set 1:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/908/ (3/3)
--
To view,
oVirt Jenkins CI Server has posted comments on this change.
Change subject: logUtils.funcName: work on partial methods
..
Patch Set 1: Fails
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/873/ : SUCCESS
Antoni Segura Puimedon has posted comments on this change.
Change subject: logUtils.funcName: work on partial methods
..
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
Maybe it's just me, but I get
Antoni Segura Puimedon has posted comments on this change.
Change subject: logUtils.funcName: work on partial methods
..
Patch Set 1:
Forgot to put a link to the place that shows why it should be 'func' instead of
'im_func'.
Antoni Segura Puimedon has posted comments on this change.
Change subject: vdsd.service: softly require ntpd or chronyd
..
Patch Set 1: (1 inline comment)
File
oVirt Jenkins CI Server has posted comments on this change.
Change subject: logUtils.funcName: work on partial methods
..
Patch Set 2:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/909/ (1/3)
--
To view,
oVirt Jenkins CI Server has posted comments on this change.
Change subject: logUtils.funcName: work on partial methods
..
Patch Set 2:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/874/ (2/3)
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: logUtils.funcName: work on partial methods
..
Patch Set 2:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/17/ (3/3)
--
To view,
oVirt Jenkins CI Server has posted comments on this change.
Change subject: logUtils.funcName: work on partial methods
..
Patch Set 2: Fails
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/874/ : SUCCESS
Antoni Segura Puimedon has posted comments on this change.
Change subject: logUtils.funcName: work on partial methods
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: forceVMstart: Initial commit
..
Patch Set 4:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/910/ (2/3)
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: forceVMstart: Initial commit
..
Patch Set 4:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/875/ (1/3)
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: forceVMstart: Initial commit
..
Patch Set 4:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/18/ (3/3)
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: forceVMstart: Initial commit
..
Patch Set 4: Fails; I would prefer that you didn't submit this
Build Failed
Allon Mureinik has posted comments on this change.
Change subject: misc: rename safelease to clusterlock
..
Patch Set 4: Looks good to me, but someone else must approve
(2 inline comments)
see annoying inline comment on
Allon Mureinik has posted comments on this change.
Change subject: domain: select the cluster lock using makeClusterLock
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: misc: rename safelease to clusterlock
..
Patch Set 5:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/911/ (1/3)
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: misc: rename safelease to clusterlock
..
Patch Set 5:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/876/ (3/3)
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: misc: rename safelease to clusterlock
..
Patch Set 5:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/19/ (2/3)
--
To view,
Federico Simoncelli has posted comments on this change.
Change subject: misc: rename safelease to clusterlock
..
Patch Set 5: Verified; Looks good to me, but someone else must approve
Minor change in Makefile.am. Verified
Federico Simoncelli has posted comments on this change.
Change subject: upgrade: catch MetaDataKeyNotFoundError when preparing images
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11281
ShaoHe Feng has posted comments on this change.
Change subject: add a jsonrpcSeverClient for jsonRPC Server functional test
..
Patch Set 2: (4 inline comments)
Commit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsd.service: softly require ntpd or chronyd
..
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
Antoni Segura Puimedon has uploaded a new change for review.
Change subject: Simplify ip address validation leveraging socket.
..
Simplify ip address validation leveraging socket.
Currently we have a ad-hoc validation of the
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Simplify ip address validation leveraging socket.
..
Patch Set 1:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/912/ (3/3)
--
To
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Simplify ip address validation leveraging socket.
..
Patch Set 1: Fails
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/877/ : SUCCESS
Adam Litke has uploaded a new change for review.
Change subject: Bridge: Fix the specification of the getAllTasks return value
..
Bridge: Fix the specification of the getAllTasks return value
Change-Id:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Bridge: Fix the specification of the getAllTasks return value
..
Patch Set 1:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/913/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Bridge: Fix the specification of the getAllTasks return value
..
Patch Set 1:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/21/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Bridge: Fix the specification of the getAllTasks return value
..
Patch Set 1:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/878/ (1/3)
Allon Mureinik has posted comments on this change.
Change subject: misc: rename safelease to clusterlock
..
Patch Set 5: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/10067
To
Adam Litke has posted comments on this change.
Change subject: Bridge: Fix the specification of the getAllTasks return value
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/11336
To unsubscribe, visit
ShaoHe Feng has posted comments on this change.
Change subject: Bridge: Fix the specification of the getAllTasks return value
..
Patch Set 1: Verified; Looks good to me, but someone else must approve
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Bridge: Fix the specification of the getAllTasks return value
..
Patch Set 1: Fails
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/878/
Adam Litke has posted comments on this change.
Change subject: Bridge: Fix the specification of the getAllTasks return value
..
Patch Set 1: Looks good to me, approved
Approving my own patch since it has independent
Adam Litke has posted comments on this change.
Change subject: Bridge: Fix the specification of the getAllTasks return value
..
Patch Set 1:
Jenkins build failure is noise related to pthreads on rhel
--
To view, visit
Yaniv Bronhaim has uploaded a new change for review.
Change subject: adding myself as an author
..
adding myself as an author
Change-Id: Ic41bc4ff3230dd51b8980b5b1dc5e731e2a61034
Signed-off-by: Yaniv Bronhaim
oVirt Jenkins CI Server has posted comments on this change.
Change subject: adding myself as an author
..
Patch Set 1:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/879/ (1/3)
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: adding myself as an author
..
Patch Set 1:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/22/ (2/3)
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: adding myself as an author
..
Patch Set 1:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/914/ (3/3)
--
To view, visit
Saggi Mizrahi has posted comments on this change.
Change subject: adding myself as an author
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11339
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: adding myself as an author
..
Patch Set 1: Fails
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/879/ : SUCCESS
Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: vdsm.spec: increase policycoreutils version for RHEL
..
vdsm.spec: increase policycoreutils version for RHEL
Due bz#893065 if selinux is disable
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm.spec: increase policycoreutils version for RHEL
..
Patch Set 1:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/915/ (3/3)
--
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm.spec: increase policycoreutils version for RHEL
..
Patch Set 1:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/23/ (1/3)
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm.spec: increase policycoreutils version for RHEL
..
Patch Set 1:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/880/ (2/3)
--
To
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm.spec: increase policycoreutils version for RHEL
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/11341
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm.spec: increase policycoreutils version for RHEL
..
Patch Set 1: Fails
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/880/ : SUCCESS
Dan Kenigsberg has posted comments on this change.
Change subject: adding myself as an author
..
Patch Set 1: I would prefer that you didn't submit this
welcome!
It's hard to notice, but this list is sorted by family name.
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Bridge: Fix the specification of the getAllTasks return value
..
Bridge: Fix the specification of the getAllTasks return value
Change-Id:
Dan Kenigsberg has posted comments on this change.
Change subject: Support for GLUSTERFS_DOMAIN
..
Patch Set 14: (2 inline comments)
File vdsm/storage/glusterVolume.py
Line
Dan Kenigsberg has posted comments on this change.
Change subject: spec: requires selinux-policy to avoid selinux failure on
access tls cert
..
Patch Set 2: Looks good to me, approved
--
To view, visit
Saggi Mizrahi has posted comments on this change.
Change subject: clusterlock: add the local locking implementation
..
Patch Set 3: I would prefer that you didn't submit this
(1 inline comment)
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsmd.service: require either ntpd or chronyd
..
Patch Set 2:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/916/ (2/3)
--
To
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsmd.service: require either ntpd or chronyd
..
Patch Set 2:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/881/ (1/3)
--
To view,
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsmd.service: require either ntpd or chronyd
..
Patch Set 2:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/24/ (3/3)
--
To
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsmd.service: require either ntpd or chronyd
..
Patch Set 2: Fails
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/881/ : SUCCESS
1 - 100 of 124 matches
Mail list logo
