Change in vdsm[master]: NetReload: netmodels for editBonding/removeBonding

oVirt Jenkins CI Server has posted comments on this change. Change subject: NetReload: netmodels for editBonding/removeBonding .. Patch Set 8: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2702/ : SUCCESS

Change in vdsm[master]: Separate libvirt network configuration from ifcfg

oVirt Jenkins CI Server has posted comments on this change. Change subject: Separate libvirt network configuration from ifcfg .. Patch Set 9: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2703/ : SUCCESS

Change in vdsm[master]: NetReload: netmodels for editBonding/removeBonding

Mark Wu has posted comments on this change. Change subject: NetReload: netmodels for editBonding/removeBonding .. Patch Set 8: Verified -- To view, visit http://gerrit.ovirt.org/15356 To unsubscribe, visit

Change in vdsm[master]: Separate libvirt network configuration from ifcfg

Mark Wu has posted comments on this change. Change subject: Separate libvirt network configuration from ifcfg .. Patch Set 9: Verified -- To view, visit http://gerrit.ovirt.org/15178 To unsubscribe, visit

Change in vdsm[master]: Separate libvirt network configuration from ifcfg

Antoni Segura Puimedon has posted comments on this change. Change subject: Separate libvirt network configuration from ifcfg .. Patch Set 9: Verified; Looks good to me, but someone else must approve r+1 cause it's just a

Change in vdsm[master]: NetReload: netmodels for editBonding/removeBonding

Antoni Segura Puimedon has posted comments on this change. Change subject: NetReload: netmodels for editBonding/removeBonding .. Patch Set 8: Verified; Looks good to me, but someone else must approve I like the further

Change in vdsm[master]: netmodles code cleanup

Antoni Segura Puimedon has uploaded a new change for review. Change subject: netmodles code cleanup .. netmodles code cleanup Removes unused parameters and variables. Change-Id: I7977d136c3ce08e97faf8e14c735f97eea6e2981

Change in vdsm[master]: iscsi: report hba sessions as fiber channel

Allon Mureinik has posted comments on this change. Change subject: iscsi: report hba sessions as fiber channel .. Patch Set 2: @Fede - who can verify this so we can move on? -- To view, visit http://gerrit.ovirt.org/15161 To

Change in vdsm[master]: netmodles code cleanup

oVirt Jenkins CI Server has posted comments on this change. Change subject: netmodles code cleanup .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2705/ : SUCCESS

Change in vdsm[master]: Added utility to ensure that files written to the file syste...

Giuseppe Vallarelli has posted comments on this change. Change subject: Added utility to ensure that files written to the file system happen atomically. .. Patch Set 4: I would prefer that you didn't submit this (1 inline

Change in vdsm[master]: Added utility to ensure that files written to the file syste...

Giuseppe Vallarelli has posted comments on this change. Change subject: Added utility to ensure that files written to the file system happen atomically. .. Patch Set 4: (1 inline comment)

Change in vdsm[master]: Make networking API endpoints match schema

oVirt Jenkins CI Server has posted comments on this change. Change subject: Make networking API endpoints match schema .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2706/ : SUCCESS

Change in vdsm[master]: Make networking API endpoints match schema

Giuseppe Vallarelli has posted comments on this change. Change subject: Make networking API endpoints match schema .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit

Change in vdsm[master]: Improve __prefetch logging.

Eduardo has uploaded a new change for review. Change subject: Improve __prefetch logging. .. Improve __prefetch logging. Related-To: https://bugzilla.redhat.com/show_bug.cgi?id=967296 Change-Id:

Change in vdsm[master]: Improve __prefetch logging.

oVirt Jenkins CI Server has posted comments on this change. Change subject: Improve __prefetch logging. .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2707/ : SUCCESS

Change in vdsm[master]: netmodles code cleanup

Giuseppe Vallarelli has posted comments on this change. Change subject: netmodles code cleanup .. Patch Set 2: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/15478 To unsubscribe,

Change in vdsm[master]: Added utility to ensure that files written to the file syste...

Antoni Segura Puimedon has posted comments on this change. Change subject: Added utility to ensure that files written to the file system happen atomically. .. Patch Set 4: (1 inline comment)

Change in vdsm[master]: Extend vdsm-tool: moving configure libvirt to external shell...

Yaniv Bronhaim has posted comments on this change. Change subject: Extend vdsm-tool: moving configure libvirt to external shell script .. Patch Set 6: (1 inline comment)

Change in vdsm[master]: Extend vdsm-tool: moving configure libvirt to external shell...

oVirt Jenkins CI Server has posted comments on this change. Change subject: Extend vdsm-tool: moving configure libvirt to external shell script .. Patch Set 7: Build Successful

Change in vdsm[master]: QoS feature: Adds bandwitdh elem to a network interface defi...

Dan Kenigsberg has posted comments on this change. Change subject: QoS feature: Adds bandwitdh elem to a network interface definition. .. Patch Set 1: (1 inline comment)

Change in vdsm[master]: WIP: Multiple Gateways Feature

oVirt Jenkins CI Server has posted comments on this change. Change subject: WIP: Multiple Gateways Feature .. Patch Set 10: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2709/ : SUCCESS

Change in vdsm[master]: Make IRS methods bypass API.py

Yaniv Bronhaim has posted comments on this change. Change subject: Make IRS methods bypass API.py .. Patch Set 7: (1 inline comment) File vdsm/BindingXMLRPC.py Line 513:

Change in vdsm[master]: Multiple Gateways: SourceRoute now uses a configurator

oVirt Jenkins CI Server has posted comments on this change. Change subject: Multiple Gateways: SourceRoute now uses a configurator .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2710/ :

Change in vdsm[master]: iproute2 binary wrapper

oVirt Jenkins CI Server has posted comments on this change. Change subject: iproute2 binary wrapper .. Patch Set 7: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2711/ : SUCCESS

Change in vdsm[master]: iproute2 binary wrapper

Mark Wu has posted comments on this change. Change subject: iproute2 binary wrapper .. Patch Set 7: (1 inline comment) File vdsm/ipwrapper.py Line 219: command += rule

Change in vdsm[master]: Move fencing logic out of API.py

Yaniv Bronhaim has posted comments on this change. Change subject: Move fencing logic out of API.py .. Patch Set 7: I would prefer that you didn't submit this (4 inline comments)

Change in vdsm[master]: misc: handle scientific notation in readspeed

Dan Kenigsberg has posted comments on this change. Change subject: misc: handle scientific notation in readspeed .. Patch Set 2: Verified; Looks good to me, approved Copy Sandro's verification (even though an rc check has been

Change in vdsm[master]: [WIP]export a priviledged vdsm startup for supervdsm server

Yaniv Bronhaim has posted comments on this change. Change subject: [WIP]export a priviledged vdsm startup for supervdsm server .. Patch Set 4: Not relevant any more due to http://gerrit.ovirt.org/#/c/11051/. Please abandon --

Change in vdsm[master]: misc: handle scientific notation in readspeed

Dan Kenigsberg has submitted this change and it was merged. Change subject: misc: handle scientific notation in readspeed .. misc: handle scientific notation in readspeed When the amount of bytes is low and the speed is high

Change in vdsm[master]: netmodles code cleanup

Giuseppe Vallarelli has posted comments on this change. Change subject: netmodles code cleanup .. Patch Set 2: No score Btw you got a typo in the commit msg title. -- To view, visit http://gerrit.ovirt.org/15478 To

Change in vdsm[master]: netmodles code cleanup

Antoni Segura Puimedon has posted comments on this change. Change subject: netmodles code cleanup .. Patch Set 2: :( -- To view, visit http://gerrit.ovirt.org/15478 To unsubscribe, visit http://gerrit.ovirt.org/settings

Change in vdsm[master]: netmodels code cleanup

oVirt Jenkins CI Server has posted comments on this change. Change subject: netmodels code cleanup .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2712/ : SUCCESS

Change in vdsm[master]: netmodels code cleanup

Giuseppe Vallarelli has posted comments on this change. Change subject: netmodels code cleanup .. Patch Set 3: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/15478 To unsubscribe,

Change in vdsm[master]: tests: Adding functional tests for networking

oVirt Jenkins CI Server has posted comments on this change. Change subject: tests: Adding functional tests for networking .. Patch Set 19: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2713/ : SUCCESS

Change in vdsm[master]: netmodels code cleanup

Mark Wu has posted comments on this change. Change subject: netmodels code cleanup .. Patch Set 3: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/15478 To unsubscribe, visit

Change in vdsm[master]: WIP: add dhcp support for iproute2 configurator

Mark Wu has uploaded a new change for review. Change subject: WIP: add dhcp support for iproute2 configurator .. WIP: add dhcp support for iproute2 configurator Change-Id: Iea88e8693e47fa51edb89c33344332c88c5c964d

Change in vdsm[master]: Add unit tests for iproute2 configurator

Mark Wu has abandoned this change. Change subject: Add unit tests for iproute2 configurator .. Patch Set 1: Abandoned -- To view, visit http://gerrit.ovirt.org/15302 To unsubscribe, visit http://gerrit.ovirt.org/settings

Change in vdsm[master]: Add iproute2 configurator

oVirt Jenkins CI Server has posted comments on this change. Change subject: Add iproute2 configurator .. Patch Set 2: Fails Build Failed http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2714/ : SUCCESS

Change in vdsm[master]: iproute2 binary wrapper

oVirt Jenkins CI Server has posted comments on this change. Change subject: iproute2 binary wrapper .. Patch Set 8: Fails Build Failed http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2715/ : SUCCESS

Change in vdsm[master]: WIP: add dhcp support for iproute2 configurator

oVirt Jenkins CI Server has posted comments on this change. Change subject: WIP: add dhcp support for iproute2 configurator .. Patch Set 1: Fails Build Failed http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2716/ : SUCCESS

Change in vdsm[master]: iproute2 binary wrapper

Mark Wu has posted comments on this change. Change subject: iproute2 binary wrapper .. Patch Set 8: (1 inline comment) File vdsm/ipwrapper.py Line 180: Line 181: return

Change in vdsm[master]: Add iproute2 configurator

Mark Wu has posted comments on this change. Change subject: Add iproute2 configurator .. Patch Set 2: Verified verified with the same test cases as ifcfg configurator. add bridged network over vlaned bond or nic add bridged

Change in vdsm[master]: WIP: add dhcp support for iproute2 configurator

Mark Wu has posted comments on this change. Change subject: WIP: add dhcp support for iproute2 configurator .. Patch Set 1: Anyone who has interest in this patch could take over it. I just send out this patch as a reference

Change in vdsm[master]: iproute2 binary wrapper

Giuseppe Vallarelli has posted comments on this change. Change subject: iproute2 binary wrapper .. Patch Set 8: I would prefer that you didn't submit this (7 inline comments)

Change in vdsm[master]: Make IRS methods bypass API.py

Deepak C Shetty has posted comments on this change. Change subject: Make IRS methods bypass API.py .. Patch Set 7: I agree with agl here... a better commit msg that clearly states the reason for this would be helpful and

Change in vdsm[master]: Multiple Gateways: SourceRoute now uses a configurator

Giuseppe Vallarelli has posted comments on this change. Change subject: Multiple Gateways: SourceRoute now uses a configurator .. Patch Set 4: I would prefer that you didn't submit this (4 inline comments) See comments.

Change in vdsm[master]: Multiple Gateways: SourceRoute now uses a configurator

Assaf Muller has posted comments on this change. Change subject: Multiple Gateways: SourceRoute now uses a configurator .. Patch Set 4: (4 inline comments) Replied to Guiseppe's review.

Change in vdsm[master]: WIP: Multiple Gateways Feature

Giuseppe Vallarelli has posted comments on this change. Change subject: WIP: Multiple Gateways Feature .. Patch Set 10: I would prefer that you didn't submit this (2 inline comments) Design can be further improved, by reading

Change in vdsm[master]: Multiple Gateways: SourceRoute now uses a configurator

Giuseppe Vallarelli has posted comments on this change. Change subject: Multiple Gateways: SourceRoute now uses a configurator .. Patch Set 4: (3 inline comments) File

Change in vdsm[master]: gluster: verbs for managing services

oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: verbs for managing services .. Patch Set 20: No score Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2717/ : SUCCESS

Change in vdsm[master]: WIP: Multiple Gateways Feature

Assaf Muller has posted comments on this change. Change subject: WIP: Multiple Gateways Feature .. Patch Set 10: (2 inline comments) Replied to Guiseppe's comments. Thanks for the review Guiseppe!

Change in vdsm[master]: iproute2 binary wrapper

Antoni Segura Puimedon has posted comments on this change. Change subject: iproute2 binary wrapper .. Patch Set 8: (1 inline comment) File vdsm/ipwrapper.py Line 162: