Change in vdsm[master]: vdsmd.init: Add init adapter

Zhou Zheng Sheng has posted comments on this change. Change subject: vdsmd.init: Add init adapter .. Patch Set 1: (19 inline comments) File vdsm/init/daemonAdapter Line 1:

Change in vdsm[master]: vdsmd.init: Add init adapter

Zhou Zheng Sheng has posted comments on this change. Change subject: vdsmd.init: Add init adapter .. Patch Set 1: (1 inline comment) File vdsm/init/daemonAdapter Line 1:

Change in vdsm[master]: QoS feature: Adds bandwitdh elem to a network interface defi...

oVirt Jenkins CI Server has posted comments on this change. Change subject: QoS feature: Adds bandwitdh elem to a network interface definition. .. Patch Set 5: Fails Build Failed

Change in vdsm[master]: QoS feature: Adds bandwitdh elem to a network interface defi...

oVirt Jenkins CI Server has posted comments on this change. Change subject: QoS feature: Adds bandwitdh elem to a network interface definition. .. Patch Set 5: No score Build Successful

Change in vdsm[master]: QoS feature: Adds bandwitdh elem to a network interface defi...

Giuseppe Vallarelli has posted comments on this change. Change subject: QoS feature: Adds bandwitdh elem to a network interface definition. .. Patch Set 5: Verified -- To view, visit http://gerrit.ovirt.org/15445 To

Change in vdsm[master]: vm: add the live diskSizeExtend method

Sergey Gotliv has posted comments on this change. Change subject: vm: add the live diskSizeExtend method .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/15614 To

Change in vdsm[master]: mom: add mom balloon functional tests for running vms

oVirt Jenkins CI Server has posted comments on this change. Change subject: mom: add mom balloon functional tests for running vms .. Patch Set 7: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2770/ : SUCCESS

Change in vdsm[master]: vdsmd.init: Add init adapter

Alon Bar-Lev has posted comments on this change. Change subject: vdsmd.init: Add init adapter .. Patch Set 1: (6 inline comments) Thanks!!! Few more questions... sorry for me bothering you.

Change in vdsm[master]: Extend vdsm-tool: moving configure libvirt to external shell...

Zhou Zheng Sheng has posted comments on this change. Change subject: Extend vdsm-tool: moving configure libvirt to external shell script .. Patch Set 10: I would prefer that you didn't submit this (6 inline comments) Some

Change in vdsm[master]: fix for after_vm_dehibernate hook not being called

Arik Hadas has uploaded a new change for review. Change subject: fix for after_vm_dehibernate hook not being called .. fix for after_vm_dehibernate hook not being called Due to what seems to be a copy-paste or typo problem, the

Change in vdsm[master]: fix for after_vm_dehibernate hook not being called

Arik Hadas has posted comments on this change. Change subject: fix for after_vm_dehibernate hook not being called .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/15656 To unsubscribe, visit

Change in vdsm[master]: fix for after_vm_dehibernate hook not being called

Michal Skrivanek has posted comments on this change. Change subject: fix for after_vm_dehibernate hook not being called .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit

Change in vdsm[master]: Added code coverage plugin

Yaniv Bronhaim has posted comments on this change. Change subject: Added code coverage plugin .. Patch Set 5: Dan, don't you prefer to have default entries for coverage in config.py.in? -- To view, visit

Change in vdsm[master]: fix for after_vm_dehibernate hook not being called

oVirt Jenkins CI Server has posted comments on this change. Change subject: fix for after_vm_dehibernate hook not being called .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2771/ : SUCCESS

Change in vdsm[master]: Extend vdsm-tool: moving configure libvirt to external shell...

oVirt Jenkins CI Server has posted comments on this change. Change subject: Extend vdsm-tool: moving configure libvirt to external shell script .. Patch Set 11: Build Successful

Change in vdsm[master]: fix for after_vm_dehibernate hook not being called

Dan Kenigsberg has submitted this change and it was merged. Change subject: fix for after_vm_dehibernate hook not being called .. fix for after_vm_dehibernate hook not being called Due to what seems to be a copy-paste or typo

Change in vdsm[master]: QoS feature: Adds bandwitdh elem to a network interface defi...

Dan Kenigsberg has posted comments on this change. Change subject: QoS feature: Adds bandwitdh elem to a network interface definition. .. Patch Set 5: Looks good to me, approved Thanks, taken. -- To view, visit

Change in vdsm[master]: QoS feature: Adds bandwitdh elem to a network interface defi...

Dan Kenigsberg has submitted this change and it was merged. Change subject: QoS feature: Adds bandwitdh elem to a network interface definition. .. QoS feature: Adds bandwitdh elem to a network interface definition.

Change in vdsm[master]: vdsm-tool: avoid service action redirections

Dan Kenigsberg has posted comments on this change. Change subject: vdsm-tool: avoid service action redirections .. Patch Set 5: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15099 To unsubscribe, visit

Change in vdsm[master]: vdsm-tool: avoid service action redirections

Dan Kenigsberg has submitted this change and it was merged. Change subject: vdsm-tool: avoid service action redirections .. vdsm-tool: avoid service action redirections Some smart init system will redirect actions to other

Change in vdsm[master]: vdsm-tool: extend service module to check existence of a s...

Dan Kenigsberg has submitted this change and it was merged. Change subject: vdsm-tool: extend service module to check existence of a service .. vdsm-tool: extend service module to check existence of a service Add a

Change in vdsm[master]: vdsm-tool: extend service module to check existence of a s...

Dan Kenigsberg has posted comments on this change. Change subject: vdsm-tool: extend service module to check existence of a service .. Patch Set 5: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15100

Change in vdsm[master]: vdsmd.init: ajust libvirt log file

Dan Kenigsberg has submitted this change and it was merged. Change subject: vdsmd.init: ajust libvirt log file .. vdsmd.init: ajust libvirt log file Nowadays VDSM configure libvirt daemon to log into /var/log/libvirtd.log.

Change in vdsm[master]: vdsmd.init: ajust libvirt log file

Dan Kenigsberg has posted comments on this change. Change subject: vdsmd.init: ajust libvirt log file .. Patch Set 1: Looks good to me, approved Thanks, Douglas. -- To view, visit http://gerrit.ovirt.org/14842 To

Change in vdsm[master]: RAM snapshots feature

Arik Hadas has posted comments on this change. Change subject: RAM snapshots feature .. Patch Set 6: modified the after/before_vm_dehibernate hooks to get parameters, and add 'backToSnapshot' parameter which is of boolean

Change in vdsm[master]: Added 3.2 to SupportedENGINES in dsaversion

Assaf Muller has uploaded a new change for review. Change subject: Added 3.2 to SupportedENGINES in dsaversion .. Added 3.2 to SupportedENGINES in dsaversion Change-Id: Ia3a0bd0edecd24a00edc0a5b07cad59d2c27bd7e Signed-off-by:

Change in vdsm[master]: Added 3.2 to SupportedENGINES in dsaversion

Assaf Muller has posted comments on this change. Change subject: Added 3.2 to SupportedENGINES in dsaversion .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/15663 To unsubscribe, visit

Change in vdsm[master]: Added 3.2 to SupportedENGINES in dsaversion

Dan Kenigsberg has posted comments on this change. Change subject: Added 3.2 to SupportedENGINES in dsaversion .. Patch Set 1: Looks good to me, approved I believe this is indeed required due to vdsm's recent version bump.

Change in vdsm[master]: NetReload: netmodels for editBonding/removeBonding

Antoni Segura Puimedon has posted comments on this change. Change subject: NetReload: netmodels for editBonding/removeBonding .. Patch Set 9: (1 inline comment) File

Change in vdsm[master]: RAM snapshots feature

oVirt Jenkins CI Server has posted comments on this change. Change subject: RAM snapshots feature .. Patch Set 6: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2773/ : SUCCESS

Change in vdsm[master]: tests: Adding functional tests for networking

Dan Kenigsberg has posted comments on this change. Change subject: tests: Adding functional tests for networking .. Patch Set 19: Fails; I would prefer that you didn't submit this (5 inline comments)

Change in vdsm[master]: Added 3.3 to SupportedENGINES in dsaversion

Amador Pahim has uploaded a new change for review. Change subject: Added 3.3 to SupportedENGINES in dsaversion .. Added 3.3 to SupportedENGINES in dsaversion Change-Id: I16b668f4d494c1c63fe89f8c54e5c13b94dc2911 Signed-off-by:

Change in vdsm[master]: Added 3.3 to SupportedENGINES in dsaversion

Douglas Schilling Landgraf has posted comments on this change. Change subject: Added 3.3 to SupportedENGINES in dsaversion .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit

Change in vdsm[master]: Added 3.3 to SupportedENGINES in dsaversion

Amador Pahim has posted comments on this change. Change subject: Added 3.3 to SupportedENGINES in dsaversion .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/15675 To unsubscribe, visit

Change in vdsm[master]: Added 3.3 to SupportedENGINES in dsaversion

Dan Kenigsberg has submitted this change and it was merged. Change subject: Added 3.3 to SupportedENGINES in dsaversion .. Added 3.3 to SupportedENGINES in dsaversion Change-Id: I16b668f4d494c1c63fe89f8c54e5c13b94dc2911

Change in vdsm[master]: introducing virtio-scsi support

Dan Kenigsberg has submitted this change and it was merged. Change subject: introducing virtio-scsi support .. introducing virtio-scsi support Drive class: * makeName - map 'scsi' to 'sd' * getXML: - added 'sgio' flag [1] -

Change in vdsm[master]: BZ#836161 - Remove code obsoleted by deleteImage() rewrite.

Allon Mureinik has posted comments on this change. Change subject: BZ#836161 - Remove code obsoleted by deleteImage() rewrite. .. Patch Set 14: Looks good to me, but someone else must approve -- To view, visit

Change in vdsm[master]: tests: Adding functional tests for networking

Giuseppe Vallarelli has posted comments on this change. Change subject: tests: Adding functional tests for networking .. Patch Set 19: (5 inline comments) Dan, thanks for the useful feedback I need to understand why that test

Change in vdsm[master]: clientIF: Check image alignment using virt-alignment-scan

Federico Simoncelli has posted comments on this change. Change subject: clientIF: Check image alignment using virt-alignment-scan .. Patch Set 11: 1. the verb is an HSM vm-related verb where Image has no meaning: hotplugDisk,

Change in vdsm[master]: Multiple Gateways: Use SourceRoute when adding/removing netw...

Assaf Muller has posted comments on this change. Change subject: Multiple Gateways: Use SourceRoute when adding/removing networks .. Patch Set 2: (1 inline comment) File

Change in vdsm[master]: iproute2 binary wrapper

oVirt Jenkins CI Server has posted comments on this change. Change subject: iproute2 binary wrapper .. Patch Set 10: Fails Build Failed http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2778/ : SUCCESS

Change in vdsm[master]: WIP: Multiple Gateways Feature

oVirt Jenkins CI Server has posted comments on this change. Change subject: WIP: Multiple Gateways Feature .. Patch Set 12: Fails Build Failed http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2776/ : SUCCESS

Change in vdsm[master]: Multiple Gateways: Use SourceRoute when adding/removing netw...

oVirt Jenkins CI Server has posted comments on this change. Change subject: Multiple Gateways: Use SourceRoute when adding/removing networks .. Patch Set 2: Fails Build Failed

Change in vdsm[master]: Added code coverage plugin

oVirt Jenkins CI Server has posted comments on this change. Change subject: Added code coverage plugin .. Patch Set 6: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2779/ : SUCCESS

Change in vdsm[master]: Added code coverage plugin

Dan Kenigsberg has posted comments on this change. Change subject: Added code coverage plugin .. Patch Set 6: I would prefer that you didn't submit this (2 inline comments)

Change in vdsm[master]: Added code coverage plugin

oVirt Jenkins CI Server has posted comments on this change. Change subject: Added code coverage plugin .. Patch Set 7: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2780/ : SUCCESS

Change in vdsm[master]: vdsmd.init: Add init adapter

Zhou Zheng Sheng has posted comments on this change. Change subject: vdsmd.init: Add init adapter .. Patch Set 1: (5 inline comments) File vdsm/init/daemonAdapter Line 38:

Change in vdsm[master]: Added code coverage plugin

Dan Kenigsberg has posted comments on this change. Change subject: Added code coverage plugin .. Patch Set 7: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15545 To unsubscribe, visit

Change in vdsm[master]: RAM snapshots feature

Dan Kenigsberg has posted comments on this change. Change subject: RAM snapshots feature .. Patch Set 6: I would prefer that you didn't submit this (3 inline comments) (A very partial review)

Change in vdsm[master]: volume: add the BLOCK_SIZE constant

Douglas Schilling Landgraf has posted comments on this change. Change subject: volume: add the BLOCK_SIZE constant .. Patch Set 2: Looks good to me, but someone else must approve -- To view, visit