Change in vdsm[master]: vm: add the transient disk support

2013-09-14 Thread fsimonce
Federico Simoncelli has posted comments on this change. Change subject: vm: add the transient disk support .. Patch Set 6: (2 comments) File vdsm/vm.py Line 1424:

Change in vdsm[master]: vm: small refactoring for _normalizeVdsmImg

2013-09-14 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: small refactoring for _normalizeVdsmImg .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4409/ : SUCCESS

Change in vdsm[master]: Modification in lockfile usage mechanism as part of sysv ini...

2013-09-14 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: Modification in lockfile usage mechanism as part of sysv init script .. Patch Set 14: -Verified (1 comment)

Change in vdsm[master]: Modification in lockfile usage mechanism as part of sysv ini...

2013-09-14 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Modification in lockfile usage mechanism as part of sysv init script .. Patch Set 15: Build Successful

Change in vdsm[master]: Handling errors in daemonAdapter

2013-09-14 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Handling errors in daemonAdapter .. Patch Set 11: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4411/ : SUCCESS

Change in vdsm[master]: Handling errors in daemonAdapter

2013-09-14 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: Handling errors in daemonAdapter .. Patch Set 11: (2 comments) File init/daemonAdapter Line 59: Line 60:

Change in vdsm[master]: Modification in lockfile usage mechanism as part of sysv ini...

2013-09-14 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: Modification in lockfile usage mechanism as part of sysv init script .. Patch Set 15: (1 comment) File

Change in vdsm[master]: lib: add rebase to qemuImg module

2013-09-14 Thread ykaplan
Yeela Kaplan has uploaded a new change for review. Change subject: lib: add rebase to qemuImg module .. lib: add rebase to qemuImg module Change-Id: I78e5584e59deaa5c302b1da67f5e3b840f6aa222 Signed-off-by: Yeela Kaplan

Change in vdsm[master]: Removing automatic restart of services in libvirt-reconfigure

2013-09-14 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Removing automatic restart of services in libvirt-reconfigure .. Patch Set 7: Build Successful

Change in vdsm[master]: Removing automatic restart of services in libvirt-reconfigure

2013-09-14 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: Removing automatic restart of services in libvirt-reconfigure .. Patch Set 7: (2 comments) File

Change in vdsm[master]: volume: Avoid prepare template by using unsafe qemu-img rebase

2013-09-14 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: volume: Avoid prepare template by using unsafe qemu-img rebase .. Patch Set 5: Build Successful

Change in vdsm[master]: lib: add rebase to qemuImg module

2013-09-14 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: lib: add rebase to qemuImg module .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4414/ : SUCCESS

Change in vdsm[master]: Handling errors in daemonAdapter

2013-09-14 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: Handling errors in daemonAdapter .. Patch Set 11: (1 comment) File init/daemonAdapter Line 63:

Change in vdsm[master]: net tests: more combinations mtu combinations

2013-09-14 Thread danken
Hello Mark Wu, I'd like you to do a code review. Please visit http://gerrit.ovirt.org/19230 to review the following change. Change subject: net tests: more combinations mtu combinations .. net tests: more combinations

Change in vdsm[master]: net tests: more combinations mtu combinations

2013-09-14 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: net tests: more combinations mtu combinations .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4416/ : SUCCESS

Change in vdsm[master]: netconf: Fix the mtu of bond/nic not being set for new network

2013-09-14 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: netconf: Fix the mtu of bond/nic not being set for new network .. Patch Set 3: Build Successful

Change in vdsm[master]: Packaging: Fix help string and usage for --disable-libvirt-s...

2013-09-14 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Packaging: Fix help string and usage for --disable-libvirt-sanlock .. Patch Set 4: Code-Review+2 I must admit that I do not care that much for the exact help

Change in vdsm[master]: Packaging: Fix help string and usage for --disable-libvirt-s...

2013-09-14 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: Packaging: Fix help string and usage for --disable-libvirt-sanlock .. Packaging: Fix help string and usage for --disable-libvirt-sanlock Help strings

Change in vdsm[master]: Packaging: Fix help string and usage for --disable-libvirt-s...

2013-09-14 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: Packaging: Fix help string and usage for --disable-libvirt-sanlock .. Patch Set 5: Alon, I assume that if this had been unacceptable to you, you would not have

Change in vdsm[master]: Packaging: VDSM v4.12.0 packaged on Ubuntu

2013-09-14 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Packaging: VDSM v4.12.0 packaged on Ubuntu .. Patch Set 6: Code-Review+1 I think that the vdsm tarball would be better if it includes a reference deb, to be

Change in vdsm[master]: Handling errors in daemonAdapter

2013-09-14 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Handling errors in daemonAdapter .. Patch Set 12: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4418/ : SUCCESS

Change in vdsm[master]: Modification in lockfile usage mechanism as part of sysv ini...

2013-09-14 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Modification in lockfile usage mechanism as part of sysv init script .. Patch Set 16: Build Successful

Change in vdsm[master]: Handling errors in daemonAdapter

2013-09-14 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: Handling errors in daemonAdapter .. Patch Set 12: (2 comments) File init/daemonAdapter Line 58:

Change in vdsm[master]: Modification in lockfile usage mechanism as part of sysv ini...

2013-09-14 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: Modification in lockfile usage mechanism as part of sysv init script .. Patch Set 16: (3 comments) File

Change in vdsm[master]: Handling errors in daemonAdapter

2013-09-14 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: Handling errors in daemonAdapter .. Patch Set 12: (1 comment) File init/daemonAdapter Line 62:

Change in vdsm[master]: Modification in lockfile usage mechanism as part of sysv ini...

2013-09-14 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Modification in lockfile usage mechanism as part of sysv init script .. Patch Set 17: Build Successful

Change in vdsm[master]: Handling errors in daemonAdapter

2013-09-14 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: Handling errors in daemonAdapter .. Patch Set 13: (1 comment) File init/daemonAdapter Line 101:

Change in vdsm[master]: Handling errors in daemonAdapter

2013-09-14 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Handling errors in daemonAdapter .. Patch Set 13: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4420/ : SUCCESS

Change in vdsm[master]: Modification in lockfile usage mechanism as part of sysv ini...

2013-09-14 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Modification in lockfile usage mechanism as part of sysv init script .. Patch Set 18: Build Successful

Change in vdsm[master]: Handling errors in daemonAdapter

2013-09-14 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: Handling errors in daemonAdapter .. Patch Set 13: (1 comment) File init/daemonAdapter Line 101:

Change in vdsm[master]: Handling errors in daemonAdapter

2013-09-14 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: Handling errors in daemonAdapter .. Patch Set 13: (1 comment) File init/daemonAdapter Line 101:

Change in vdsm[master]: Modification in lockfile usage mechanism as part of sysv ini...

2013-09-14 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: Modification in lockfile usage mechanism as part of sysv init script .. Patch Set 18: Code-Review+1 OK, looks OK, hope that also working :) -- To view, visit

Change in vdsm[master]: Modification in lockfile usage mechanism as part of sysv ini...

2013-09-14 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: Modification in lockfile usage mechanism as part of sysv init script .. Patch Set 18: Verified+1 Of course it is, I wouldn't submit without at least one run.

Change in vdsm[master]: Handling errors in daemonAdapter

2013-09-14 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: Handling errors in daemonAdapter .. Patch Set 14: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/18810 To unsubscribe, visit

Change in vdsm[master]: Modification in lockfile usage mechanism as part of sysv ini...

2013-09-14 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: Modification in lockfile usage mechanism as part of sysv init script .. Patch Set 19: Code-Review+1 Please avoid rebase if not required... -- To view, visit

Change in vdsm[master]: Handling errors in daemonAdapter

2013-09-14 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: Handling errors in daemonAdapter .. Patch Set 14: Verified+1 -- To view, visit http://gerrit.ovirt.org/18810 To unsubscribe, visit

Change in vdsm[master]: Modification in lockfile usage mechanism as part of sysv ini...

2013-09-14 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: Modification in lockfile usage mechanism as part of sysv init script .. Patch Set 19: Verified+1 -- To view, visit http://gerrit.ovirt.org/18875 To

Change in vdsm[master]: Handling errors in daemonAdapter

2013-09-14 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Handling errors in daemonAdapter .. Patch Set 14: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4423/ : SUCCESS

Change in vdsm[master]: Modification in lockfile usage mechanism as part of sysv ini...

2013-09-14 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Modification in lockfile usage mechanism as part of sysv init script .. Patch Set 19: Build Successful

Change in vdsm[master]: Removing automatic restart of services in libvirt-reconfigure

2013-09-14 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: Removing automatic restart of services in libvirt-reconfigure .. Patch Set 7: (1 comment) File

Change in vdsm[master]: Handling errors in daemonAdapter

2013-09-14 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Handling errors in daemonAdapter .. Patch Set 14: Code-Review-1 (2 comments) minor question, -1 for visibility.

Change in vdsm[master]: Handling errors in daemonAdapter

2013-09-14 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: Handling errors in daemonAdapter .. Patch Set 14: (1 comment) File init/daemonAdapter Line 57:

Change in vdsm[master]: Handling errors in daemonAdapter

2013-09-14 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: Handling errors in daemonAdapter .. Patch Set 15: (1 comment) File init/daemonAdapter Line 56:

Change in vdsm[master]: Removing automatic restart of services in libvirt-reconfigure

2013-09-14 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: Removing automatic restart of services in libvirt-reconfigure .. Patch Set 7: (1 comment) File

Change in vdsm[master]: Handling errors in daemonAdapter

2013-09-14 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: Handling errors in daemonAdapter .. Patch Set 14: (1 comment) File init/daemonAdapter Line 57:

Change in vdsm[master]: Handling errors in daemonAdapter

2013-09-14 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Handling errors in daemonAdapter .. Patch Set 15: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4424/ : SUCCESS

Change in vdsm[master]: Handling errors in daemonAdapter

2013-09-14 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: Handling errors in daemonAdapter .. Patch Set 15: (1 comment) File init/daemonAdapter Line 56:

Change in vdsm[master]: Handling errors in daemonAdapter

2013-09-14 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: Handling errors in daemonAdapter .. Patch Set 14: (1 comment) File init/daemonAdapter Line 57:

Change in vdsm[master]: Handling errors in daemonAdapter

2013-09-14 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: Handling errors in daemonAdapter .. Patch Set 15: (1 comment) File init/daemonAdapter Line 56:

Change in vdsm[master]: Removing automatic restart of services in libvirt-reconfigure

2013-09-14 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: Removing automatic restart of services in libvirt-reconfigure .. Patch Set 7: (1 comment) File

Change in vdsm[master]: Removing automatic restart of services in libvirt-reconfigure

2013-09-14 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: Removing automatic restart of services in libvirt-reconfigure .. Patch Set 7: (1 comment) File

Change in vdsm[master]: Handling errors in daemonAdapter

2013-09-14 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: Handling errors in daemonAdapter .. Patch Set 15: (1 comment) File init/daemonAdapter Line 56:

Change in vdsm[master]: Handling errors in daemonAdapter

2013-09-14 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: Handling errors in daemonAdapter .. Patch Set 15: (1 comment) File init/daemonAdapter Line 56:

Change in vdsm[master]: Removing automatic restart of services in libvirt-reconfigure

2013-09-14 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: Removing automatic restart of services in libvirt-reconfigure .. Patch Set 7: (1 comment) File

Change in vdsm[master]: Removing automatic restart of services in libvirt-reconfigure

2013-09-14 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: Removing automatic restart of services in libvirt-reconfigure .. Patch Set 8: (2 comments) File

Change in vdsm[master]: Removing automatic restart of services in libvirt-reconfigure

2013-09-14 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Removing automatic restart of services in libvirt-reconfigure .. Patch Set 8: Build Successful

Change in vdsm[master]: Handling errors in daemonAdapter

2013-09-14 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: Handling errors in daemonAdapter .. Patch Set 15: (1 comment) File init/daemonAdapter Line 56:

Change in vdsm[master]: Handling errors in daemonAdapter

2013-09-14 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: Handling errors in daemonAdapter .. Patch Set 16: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/18810 To unsubscribe, visit

Change in vdsm[master]: Handling errors in daemonAdapter

2013-09-14 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Handling errors in daemonAdapter .. Patch Set 16: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4426/ : SUCCESS

Change in vdsm[master]: Handling errors in daemonAdapter

2013-09-14 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: Handling errors in daemonAdapter .. Patch Set 16: (1 comment) File init/daemonAdapter Line 29: Line 30:

Change in vdsm[master]: Handling errors in daemonAdapter

2013-09-14 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: Handling errors in daemonAdapter .. Patch Set 16: (1 comment) File init/daemonAdapter Line 29: Line 30:

Change in vdsm[master]: Removing automatic restart of services in libvirt-reconfigure

2013-09-14 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Removing automatic restart of services in libvirt-reconfigure .. Patch Set 9: Build Successful

Change in vdsm[master]: Refactor StoragePool.getPoolParams()

2013-09-14 Thread ewarszaw
Eduardo has uploaded a new change for review. Change subject: Refactor StoragePool.getPoolParams() .. Refactor StoragePool.getPoolParams() Change-Id: Ibbeaaaf67a39f3ca8b27252fc631a91f266d1adc Signed-off-by: Eduardo

Change in vdsm[master]: Refactor StoragePool.getPoolParams()

2013-09-14 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Refactor StoragePool.getPoolParams() .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4428/ : SUCCESS